23 May, 2007
1 commit
-
The UCC_GETH Kconfig option in drivers/net/Kconfig had a line to select the
UCC_FAST option is arch/powerpc/sysdev/qe_lib/Kconfig, which is only used
on PowerPC builds. On other architectures, this would generated a warning.
The fix is to have UCC_FAST depend on UCC_GETH.Signed-off-by: Timur Tabi
Signed-off-by: Andrew Morton
Signed-off-by: Kumar Gala
22 May, 2007
2 commits
-
The spin_unlock_irq() invocation in lance_start_xmit() has no matching
locking request. The call is already protected by netif_tx_lock, so
remove the statement.Signed-off-by: Maciej W. Rozycki
Signed-off-by: Jeff Garzik -
Herbert Xu wrote:
"netif_poll_enable can only be called if you've previously called
netif_poll_disable. Otherwise a poll might already be in action
and you may get a crash like this."Removing the call to netif_poll_enable in e1000_open should fix this issue,
the only other call to netif_poll_enable is in e1000_up() which is only
reached after a device reset or resume.Bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=8455
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240339Tested by Doug Chapman
Signed-off-by: Auke Kok
Acked-by: Herbert Xu
Signed-off-by: Jeff Garzik
19 May, 2007
1 commit
-
Don't overrun fname[] array when decoding device flags.
This was spotted by the Coverity checker (CID 1642).
Signed-off-by: Roland Dreier
18 May, 2007
14 commits
-
pci_enable_msi failure is a normal event so we should not print any error.
Going over the code I spotted a missing pci_disable_msi() leak when irq
allocation fails. The whole code also needed a cleanup, so I combined the
two different calls to pci_request_irq into a single call making this
look a lot better. All #ifdef CONFIG_PCI_MSI's have been removed.Compile tested with both CONFIG_PCI_MSI enabled and disabled.
Signed-off-by: Auke Kok
Cc: H. Peter Anvin
Signed-off-by: Jeff Garzik -
pci_enable_msi calls can fail for normal operational reasons. Driver
should not print an error message in that case. Fix a leak that leaves
msi enabled if pci_request_irq fails. We can remove CONFIG_PCI_MSI
ifdefs alltogetherSigned-off-by: Auke Kok
Signed-off-by: Jeff Garzik -
NetXen: Fix for driver on System-p
This patch will fix a ping issue on system-pSigned-off by: Milan Bag
Signed-off by: Adhiraj Joshi
Signed-by: Mithlesh ThukralSigned-off-by: Jeff Garzik
-
Spidernet was the driver I original did all the node-aware netdevice
allocation for, but after a year it still hasn't hit mainline.Signed-off-by: Christoph Hellwig
Signed-off-by: Linas Vepstas
Signed-off-by: Jeff Garzik -
The hardware must not see that is given ownership of a buffer until it is
completely written, and when the driver receives ownership of a buffer,
it must ensure that any other reads to the buffer reflect its final
state. Thus, I/O barriers are added where required.Without this patch, I have observed GCC reordering the setting of
bdp->length and bdp->status in gfar_new_skb. Hardware reordering
was also theoretically possible.Signed-off-by: Scott Wood
Signed-off-by: Jeff Garzik -
Fix link speed detection change.
Thanks to Stefan Roese for finding this bug.CC: Stefan Roese
Signed-off-by: Eugene Surovegin
Signed-off-by: Jeff Garzik -
Original patch is from Jeff Haran with my minor style
fixes. His comments follow:The first problem was in the function that configures the PHY for
autonegotiation, genmii_setup_aneg(). The original code does a
read/modify/write of the autonegotiation advertizement register (reg 4),
followed by a read/modify/write of the control register (reg 0). While
the original code follows the proper procedure as per reading the IEEE
specs, what I found is that on at least one PHY model (National DP83843)
the read of the control register comes back with the soft reset bit set
(bit 15). Because of the read/modify/write operation, this causes the
write to write a 1 back to the reset bit, which initiates a software
reset of the PHY. This software reset causes the PHY to return to its
power up state which advertizes all modes of operation, thus negating
the write to the autoneg advertizement register. The modification is to
spin reading the control register until the soft reset bit is clear
before doing the modify/write.
The second problem was in the function that configures the PHY for
forced operation, genmii_setup_forced(). The original code initiates a
software reset operation via a write of a 1 to bit 15 of the control
register (reg 0), but then proceeds to do a second write to that same
register without waiting until that reset bit is cleared by the PHY
itself (which according to the IEEE specs indicates that the PHY reset
is complete). This is a violation of how one is supposed to use this
software reset feature of these PHYs and I believe was the cause of
mysterious, difficult to reproduce link failures that we've observed on
some of our systems that use this driver. The fix is to modify the
function so that it spins waiting for the reset bit to clear after doing
the soft reset and before doing the subsequent write.Signed-off-by: Jeff Haran
CC: Benjamin Herrenschmidt
Signed-off-by: Eugene Surovegin
Signed-off-by: Jeff Garzik -
Fix "Section mismatch" warnings
Signed-off-by: Eugene Surovegin
Signed-off-by: Jeff Garzik -
Do some memory barrier changes for safety/perfomance:
Don't need read after update to index, mmiowb() followed by read at end
of irq is sufficient.Signed-off-by: Stephn Hemminger
Signed-off-by: Jeff Garzik -
This workaround was added to deal with NAPI core and how
it affected dual port shared polling. It turned out not to
be necessary. Stopping device 0 only doesn't stop NAPI from
working completely after that.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Make sure that if we ever get a MIB counter overflow interrupt (normally
masked off), that the IRQ is cleared.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
When driver can't allocate receive buffer it drops incoming
packet. Keep a counter.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Align the PHY setup of the sky2 driver with the vendor sk98lin (10.0.4.3)
driver. The PHY register settings are mostly black magic, even with access
to the documentation it isn't clear what the right values are. The changes
are mostly comments, the code change only affects the Yukon FE (100 mbit only)
version.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
The problems with Gigabyte motherboards are system configuration dependent.
Since it works fine for some users, it doesn't make sense to deprive
them.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
16 May, 2007
8 commits
-
Signed-off-by: Al Viro
Acked-by: Jeff Garzik
Acked-by: Roland Dreier
Signed-off-by: Linus Torvalds -
It was agreed that phy-connection-type was a better name for
the interface-type property, so this patch renames it.Also, the max-speed property name was determined too generic,
and is therefore eliminated in favour of phy-connection-type
derivation logic.includes corrections to copyright text.
Signed-off-by: Kim Phillips
Signed-off-by: Jeff Garzik -
Looks like the new version of this patch has been overlooked,
so I'm resending it.It just adapts the driver to the new IRQ API
according to what Russell has pointed out.drivers/net/smc911x.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)Signed-off-by: Vitaly Wool
Signed-off-by: Jeff Garzik -
Turns out we have an old version of firmware that stores the mac address
in 'mac-address' as a string instead of a byte array. All versions that
use local-mac-address should have it as byte array, so no need to do
string parsing for that case.Signed-off-by: Olof Johansson
Signed-off-by: Jeff Garzik -
This caused some very interesting behaviour depending on what happened to
be built at the same time. Add terminating empty entry to the list of IDs.Signed-off-by: Olof Johansson
Signed-off-by: Jeff Garzik -
Interrupt ack fixes
Fix the packet count resets at interrupt time, using the cacheable
packet count status to set number of processed/received packets, since
the ack count is the cumulative number of packets processed, and not
incremental.Signed-off-by: Olof Johansson
Signed-off-by: Jeff Garzik -
Some shift values were obviously wrong. Fix them to correspond with
the masks.Signed-off-by: Olof Johansson
Signed-off-by: Jeff Garzik -
* 'for-linus' of master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband:
IPoIB/cm: Optimize stale connection detection
IB/mthca: Set cleaned CQEs back to HW ownership when cleaning CQ
IB/mthca: Fix posting >255 recv WRs for Tavor
RDMA/cma: Add check to validate that cm_id is bound to a device
RDMA/cma: Fix synchronization with device removal in cma_iw_handler
RDMA/cma: Simplify device removal handling code
IB/ehca: Disable scaling code by default, bump version number
IB/ehca: Beautify sysfs attribute code and fix compiler warnings
IB/ehca: Remove _irqsave, move #ifdef
IB/ehca: Fix AQP0/1 QP number
IB/ehca: Correctly set GRH mask bit in ehca_modify_qp()
IB/ehca: Serialize hypervisor calls in ehca_register_mr()
IB/ipath: Shadow the gpio_mask register
IB/mlx4: Fix uninitialized spinlock for 32-bit archs
mlx4_core: Remove unused doorbell_lock
net: Trivial MLX4_DEBUG dependency fix.
13 May, 2007
3 commits
-
struct mlx4_priv.doorbell_lock is never used, so delete it.
Signed-off-by: Roland Dreier
-
CONFIG_MLX4_DEBUG works out to a def_bool y for those that have
CONFIG_EMBEDDED set. Make it depend on MLX4_CORE.Signed-off-by: Paul Mundt
Signed-off-by: Roland Dreier -
* 'for-linus' of master.kernel.org:/home/rmk/linux-2.6-arm: (30 commits)
[ARM] Use new get_irqnr_preamble
[ARM] Ensure machine class menu is sorted alphabetically
[ARM] 4333/2: KS8695: Micrel Development board
[ARM] 4332/2: KS8695: Serial driver
[ARM] 4331/3: Support for Micrel/Kendin KS8695 processor
[ARM] 4371/1: AT91: Support for Atmel AT91SAM9RL-EK development board
[ARM] 4372/1: Define byte sizes in asm-arm/sizes.h
[ARM] 4370/3: AT91: Support for Atmel AT91SAM9RL processors.
[ARM] Update mach-types
[ARM] export symbol csum_partial_copy_from_user
[ARM] iop13xx: msi support
[ARM] stacktrace fix
[ARM] Spinlock initializer cleanup
[ARM] remove useless config option GENERIC_BUST_SPINLOCK
[ARM] 4303/3: base kernel support for TI DaVinci
[ARM] 4369/1: AT91: Fix circular dependency in header files
[ARM] 4368/1: S3C24xx: build fix
[ARM] 4364/1: AT91: LEDS on AT91SAM9261-EK
[ARM] Fix iop32x/iop33x build
[ARM] EBSA110: fix build errors caused by missing "const"
...
12 May, 2007
11 commits
-
* 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc: (23 commits)
[POWERPC] Add arch/powerpc support for the Motorola PrPMC2800
[POWERPC] Add bootwrapper support for Motorola PrPMC2800 platform
[POWERPC] Add DTS file for the Motorola PrPMC2800 platform
[POWERPC] Check cache coherency of kernel vs firmware
[POWERPC] Add Marvell mv64x60 PCI bridge support
[POWERPC] Create Marvell mv64x60 I2C platform_data
[POWERPC] Create Marvell mv64x60 ethernet platform_data
[POWERPC] Create Marvell mv64x60 MPSC (serial) platform_data
[POWERPC] Add interrupt support for Marvell mv64x60 chips
[POWERPC] Add bootwrapper support for Marvell/mv64x60 I2C
[POWERPC] Add bootwrapper support for Marvell MPSC
[POWERPC] Add bootwrapper support for Marvell/mv64x60 hostbridge
[POWERPC] Add Makefile rules to wrap dts file in zImage
[POWERPC] Spelling fixes: arch/ppc/
[POWERPC] U-boot passes the initrd as start/end, not start/size.
[POWERPC] PS3: Update ps3_defconfig
[POWERPC] PS3: Fix request_irq warning
[POWERPC] Don't complain if size-cells == 0 in prom_parse()
[POWERPC] Simplify smp_space_timers
[POWERPC] Trivial ps3 warning fixes
... -
This patch creates platform_device entries for the Marvell mv64x60
ethernet controller ports, based on information contained in the
device tree.This driver (like the other mv64x60 drivers) are unusual in that it
works on both the MIPS and PowerPC architectures. Because of that,
the drivers do not support the normal PowerPC of_platform_bus_type.
They support platform_bus_type instead.Signed-off-by: Dale Farnsworth
Acked-by: Arnd Bergmann
Signed-off-by: Paul Mackerras -
…e/wireless-2.6 into upstream
-
Distinguish between the Davicom DM9161A PHY and the DM9161E.
Signed-off-by: Kim Phillips
Signed-off-by: Jeff Garzik -
Use DMI to add a blacklist of broken boards (so far only one).
Hopefully, the problems will be solved later, and the the whole
blacklist can disappear.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
The driver is not ready to support 88e8071 chip.
If this chip is present, system will hang on boot.So remove it from PCI device id's for now.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
If device is not fails during module startup (like unsupported chip
version) then driver would crash dereferencing a null pointer, on shutdown
or suspend/resume.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
If the device is fails during module startup for some reason like
unsupported chip version then the driver would crash dereferencing a
null pointer, on shutdown or suspend/resume.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Cc: Jeff Garzik
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik -
drivers/net/netxen/netxen_nic_main.c: In function 'netxen_nic_open':
drivers/net/netxen/netxen_nic_main.c:738: warning: 'deprecated_irq_flag' is deprecated (declared at include/linux/interrupt.h:66)
drivers/net/netxen/netxen_nic_main.c:738: warning: 'deprecated_irq_flag' is deprecated (declared at include/linux/interrupt.h:66)Cc: Jeff Garzik
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik -
Change Kconfig objects from "menu, config" into "menuconfig" so
that the user can disable the whole feature without having to
enter the menu first.Signed-off-by: Jan Engelhardt
Cc: Jeff Garzik
Cc: Krzysztof Halasa
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik
