Eric Lee / smarc-fsl-linux-kernel

20 Jun, 2020

1 commit

  • 4b61d3e8d   net: qos offload add flow status with dropped count ... Browse Code »

    This patch adds a drop frames counter to tc flower offloading.
    Reporting h/w dropped frames is necessary for some actions.
    Some actions like police action and the coming introduced stream gate
    action would produce dropped frames which is necessary for user. Status
    update shows how many filtered packets increasing and how many dropped
    in those packets.

    v2: Changes
    - Update commit comments suggest by Jiri Pirko.

    Signed-off-by: Po Liu
    Reviewed-by: Simon Horman
    Reviewed-by: Vlad Buslov
    Signed-off-by: David S. Miller

    Po Liu
     

31 Mar, 2020

1 commit

  • 93a129eb8   net: sched: expose HW stats types per action used by drivers ... Browse Code »

    It may be up to the driver (in case ANY HW stats is passed) to select
    which type of HW stats he is going to use. Add an infrastructure to
    expose this information to user.

    $ tc filter add dev enp3s0np1 ingress proto ip handle 1 pref 1 flower dst_ip 192.168.1.1 action drop
    $ tc -s filter show dev enp3s0np1 ingress
    filter protocol ip pref 1 flower chain 0
    filter protocol ip pref 1 flower chain 0 handle 0x1
    eth_type ipv4
    dst_ip 192.168.1.1
    in_hw in_hw_count 2
    action order 1: gact action drop
    random type none pass val 0
    index 1 ref 1 bind 1 installed 10 sec used 10 sec
    Action statistics:
    Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
    backlog 0b 0p requeues 0
    used_hw_stats immediate <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

    Signed-off-by: Jiri Pirko
    Signed-off-by: David S. Miller

    Jiri Pirko
     

18 Feb, 2020

1 commit

14 Feb, 2020

1 commit

  • 1afa3cc90   net/sched: matchall: add missing validation of TCA_MATCHALL_FLAGS ... Browse Code »

    unlike other classifiers that can be offloaded (i.e. users can set flags
    like 'skip_hw' and 'skip_sw'), 'cls_matchall' doesn't validate the size
    of netlink attribute 'TCA_MATCHALL_FLAGS' provided by user: add a proper
    entry to mall_policy.

    Fixes: b87f7936a932 ("net/sched: Add match-all classifier hw offloading.")
    Signed-off-by: Davide Caratti
    Acked-by: Jiri Pirko
    Signed-off-by: David S. Miller

    Davide Caratti
     

27 Jan, 2020

1 commit

  • 2e24cd755   net_sched: fix ops->bind_class() implementations ... Browse Code »

    The current implementations of ops->bind_class() are merely
    searching for classid and updating class in the struct tcf_result,
    without invoking either of cl_ops->bind_tcf() or
    cl_ops->unbind_tcf(). This breaks the design of them as qdisc's
    like cbq use them to count filters too. This is why syzbot triggered
    the warning in cbq_destroy_class().

    In order to fix this, we have to call cl_ops->bind_tcf() and
    cl_ops->unbind_tcf() like the filter binding path. This patch does
    so by refactoring out two helper functions __tcf_bind_filter()
    and __tcf_unbind_filter(), which are lockless and accept a Qdisc
    pointer, then teaching each implementation to call them correctly.

    Note, we merely pass the Qdisc pointer as an opaque pointer to
    each filter, they only need to pass it down to the helper
    functions without understanding it at all.

    Fixes: 07d79fc7d94e ("net_sched: add reverse binding for tc class")
    Reported-and-tested-by: syzbot+0a0596220218fcb603a8@syzkaller.appspotmail.com
    Reported-and-tested-by: syzbot+63bdb6006961d8c917c6@syzkaller.appspotmail.com
    Cc: Jamal Hadi Salim
    Cc: Jiri Pirko
    Signed-off-by: Cong Wang
    Signed-off-by: David S. Miller

    Cong Wang
     

31 Aug, 2019

1 commit

  • f2b795ea0   net: sched: cls_matchall: cleanup flow_action before deallocating ... Browse Code »

    Recent rtnl lock removal patch changed flow_action infra to require proper
    cleanup besides simple memory deallocation. However, matchall classifier
    was not updated to call tc_cleanup_flow_action(). Add proper cleanup to
    mall_replace_hw_filter() and mall_reoffload().

    Fixes: 5a6ff4b13d59 ("net: sched: take reference to action dev before calling offloads")
    Reported-by: Ido Schimmel
    Tested-by: Ido Schimmel
    Signed-off-by: Vlad Buslov
    Signed-off-by: David S. Miller

    Vlad Buslov
     

27 Aug, 2019

2 commits

  • 9838b20a7   net: sched: take rtnl lock in tc_setup_flow_action() ... Browse Code »

    In order to allow using new flow_action infrastructure from unlocked
    classifiers, modify tc_setup_flow_action() to accept new 'rtnl_held'
    argument. Take rtnl lock before accessing tc_action data. This is necessary
    to protect from concurrent action replace.

    Signed-off-by: Vlad Buslov
    Acked-by: Jiri Pirko
    Signed-off-by: David S. Miller

    Vlad Buslov
     
  • 401192113   net: sched: refactor block offloads counter usage ... Browse Code »

    Without rtnl lock protection filters can no longer safely manage block
    offloads counter themselves. Refactor cls API to protect block offloadcnt
    with tcf_block->cb_lock that is already used to protect driver callback
    list and nooffloaddevcnt counter. The counter can be modified by concurrent
    tasks by new functions that execute block callbacks (which is safe with
    previous patch that changed its type to atomic_t), however, block
    bind/unbind code that checks the counter value takes cb_lock in write mode
    to exclude any concurrent modifications. This approach prevents race
    conditions between bind/unbind and callback execution code but allows for
    concurrency for tc rule update path.

    Move block offload counter, filter in hardware counter and filter flags
    management from classifiers into cls hardware offloads API. Make functions
    tcf_block_offload_{inc|dec}() and tc_cls_offload_cnt_update() to be cls API
    private. Implement following new cls API to be used instead:

    tc_setup_cb_add() - non-destructive filter add. If filter that wasn't
    already in hardware is successfully offloaded, increment block offloads
    counter, set filter in hardware counter and flag. On failure, previously
    offloaded filter is considered to be intact and offloads counter is not
    decremented.

    tc_setup_cb_replace() - destructive filter replace. Release existing
    filter block offload counter and reset its in hardware counter and flag.
    Set new filter in hardware counter and flag. On failure, previously
    offloaded filter is considered to be destroyed and offload counter is
    decremented.

    tc_setup_cb_destroy() - filter destroy. Unconditionally decrement block
    offloads counter.

    tc_setup_cb_reoffload() - reoffload filter to single cb. Execute cb() and
    call tc_cls_offload_cnt_update() if cb() didn't return an error.

    Refactor all offload-capable classifiers to atomically offload filters to
    hardware, change block offload counter, and set filter in hardware counter
    and flag by means of the new cls API functions.

    Signed-off-by: Vlad Buslov
    Acked-by: Jiri Pirko
    Signed-off-by: David S. Miller

    Vlad Buslov
     

20 Jul, 2019

1 commit

18 Jun, 2019

1 commit

  • f517f2716   net: sched: cls_matchall: allow to delete filter ... Browse Code »

    Currently user is unable to delete the filter. See following example:
    $ tc filter add dev ens16np1 ingress pref 1 handle 1 matchall action drop
    $ tc filter show dev ens16np1 ingress
    filter protocol all pref 1 matchall chain 0
    filter protocol all pref 1 matchall chain 0 handle 0x1
    in_hw
    action order 1: gact action drop
    random type none pass val 0
    index 1 ref 1 bind 1

    $ tc filter del dev ens16np1 ingress pref 1 handle 1 matchall action drop
    RTNETLINK answers: Operation not supported

    Implement tcf_proto_ops->delete() op and allow user to delete the filter.

    Reported-by: Eli Cohen
    Signed-off-by: Jiri Pirko
    Signed-off-by: David S. Miller

    Jiri Pirko
     

31 May, 2019

1 commit

  • 2874c5fd2   treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152 ... Browse Code »

    Based on 1 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license as published by
    the free software foundation either version 2 of the license or at
    your option any later version

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-or-later

    has been chosen to replace the boilerplate/reference in 3029 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Allison Randal
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190527070032.746973796@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

09 May, 2019

1 commit

  • 5f0583683   net/sched: avoid double free on matchall reoffload ... Browse Code »

    Avoid freeing cls_mall.rule twice when failing to setup flow_action
    offload used in the hardware intermediate representation. This is
    achieved by returning 0 when the setup fails but the skip software
    flag has not been set.

    Fixes: f00cbf196814 ("net/sched: use the hardware intermediate representation for matchall")
    Reported-by: Dan Carpenter
    Signed-off-by: Pieter Jansen van Vuuren
    Reviewed-by: Jakub Kicinski
    Signed-off-by: David S. Miller

    Pieter Jansen van Vuuren
     

08 May, 2019

2 commits

06 May, 2019

4 commits

04 May, 2019

1 commit

  • 25426043e   cls_matchall: avoid panic when receiving a packet before filter set ... Browse Code »

    When a matchall classifier is added, there is a small time interval in
    which tp->root is NULL. If we receive a packet in this small time slice
    a NULL pointer dereference will happen, leading to a kernel panic:

    # tc qdisc replace dev eth0 ingress
    # tc filter add dev eth0 parent ffff: matchall action gact drop
    Unable to handle kernel NULL pointer dereference at virtual address 0000000000000034
    Mem abort info:
    ESR = 0x96000005
    Exception class = DABT (current EL), IL = 32 bits
    SET = 0, FnV = 0
    EA = 0, S1PTW = 0
    Data abort info:
    ISV = 0, ISS = 0x00000005
    CM = 0, WnR = 0
    user pgtable: 4k pages, 39-bit VAs, pgdp = 00000000a623d530
    [0000000000000034] pgd=0000000000000000, pud=0000000000000000
    Internal error: Oops: 96000005 [#1] SMP
    Modules linked in: cls_matchall sch_ingress nls_iso8859_1 nls_cp437 vfat fat m25p80 spi_nor mtd xhci_plat_hcd xhci_hcd phy_generic sfp mdio_i2c usbcore i2c_mv64xxx marvell10g mvpp2 usb_common spi_orion mvmdio i2c_core sbsa_gwdt phylink ip_tables x_tables autofs4
    Process ksoftirqd/0 (pid: 9, stack limit = 0x0000000009de7d62)
    CPU: 0 PID: 9 Comm: ksoftirqd/0 Not tainted 5.1.0-rc6 #21
    Hardware name: Marvell 8040 MACCHIATOBin Double-shot (DT)
    pstate: 40000005 (nZcv daif -PAN -UAO)
    pc : mall_classify+0x28/0x78 [cls_matchall]
    lr : tcf_classify+0x78/0x138
    sp : ffffff80109db9d0
    x29: ffffff80109db9d0 x28: ffffffc426058800
    x27: 0000000000000000 x26: ffffffc425b0dd00
    x25: 0000000020000000 x24: 0000000000000000
    x23: ffffff80109dbac0 x22: 0000000000000001
    x21: ffffffc428ab5100 x20: ffffffc425b0dd00
    x19: ffffff80109dbac0 x18: 0000000000000000
    x17: 0000000000000000 x16: 0000000000000000
    x15: 0000000000000000 x14: 0000000000000000
    x13: ffffffbf108ad288 x12: dead000000000200
    x11: 00000000f0000000 x10: 0000000000000001
    x9 : ffffffbf1089a220 x8 : 0000000000000001
    x7 : ffffffbebffaa950 x6 : 0000000000000000
    x5 : 000000442d6ba000 x4 : 0000000000000000
    x3 : ffffff8008735ad8 x2 : ffffff80109dbac0
    x1 : ffffffc425b0dd00 x0 : ffffff8010592078
    Call trace:
    mall_classify+0x28/0x78 [cls_matchall]
    tcf_classify+0x78/0x138
    __netif_receive_skb_core+0x29c/0xa20
    __netif_receive_skb_one_core+0x34/0x60
    __netif_receive_skb+0x28/0x78
    netif_receive_skb_internal+0x2c/0xc0
    napi_gro_receive+0x1a0/0x1d8
    mvpp2_poll+0x928/0xb18 [mvpp2]
    net_rx_action+0x108/0x378
    __do_softirq+0x128/0x320
    run_ksoftirqd+0x44/0x60
    smpboot_thread_fn+0x168/0x1b0
    kthread+0x12c/0x130
    ret_from_fork+0x10/0x1c
    Code: aa0203f3 aa1e03e0 d503201f f9400684 (b9403480)
    ---[ end trace fc71e2ef7b8ab5a5 ]---
    Kernel panic - not syncing: Fatal exception in interrupt
    SMP: stopping secondary CPUs
    Kernel Offset: disabled
    CPU features: 0x002,00002000
    Memory Limit: none
    Rebooting in 1 seconds..

    Fix this by adding a NULL check in mall_classify().

    Fixes: ed76f5edccc9 ("net: sched: protect filter_chain list with filter_chain_lock mutex")
    Signed-off-by: Matteo Croce
    Acked-by: Cong Wang
    Signed-off-by: David S. Miller

    Matteo Croce
     

28 Apr, 2019

2 commits

  • 8cb081746   netlink: make validation more configurable for future strictness ... Browse Code »

    We currently have two levels of strict validation:

    1) liberal (default)
    - undefined (type >= max) & NLA_UNSPEC attributes accepted
    - attribute length >= expected accepted
    - garbage at end of message accepted
    2) strict (opt-in)
    - NLA_UNSPEC attributes accepted
    - attribute length >= expected accepted

    Split out parsing strictness into four different options:
    * TRAILING - check that there's no trailing data after parsing
    attributes (in message or nested)
    * MAXTYPE - reject attrs > max known type
    * UNSPEC - reject attributes with NLA_UNSPEC policy entries
    * STRICT_ATTRS - strictly validate attribute size

    The default for future things should be *everything*.
    The current *_strict() is a combination of TRAILING and MAXTYPE,
    and is renamed to _deprecated_strict().
    The current regular parsing has none of this, and is renamed to
    *_parse_deprecated().

    Additionally it allows us to selectively set one of the new flags
    even on old policies. Notably, the UNSPEC flag could be useful in
    this case, since it can be arranged (by filling in the policy) to
    not be an incompatible userspace ABI change, but would then going
    forward prevent forgetting attribute entries. Similar can apply
    to the POLICY flag.

    We end up with the following renames:
    * nla_parse -> nla_parse_deprecated
    * nla_parse_strict -> nla_parse_deprecated_strict
    * nlmsg_parse -> nlmsg_parse_deprecated
    * nlmsg_parse_strict -> nlmsg_parse_deprecated_strict
    * nla_parse_nested -> nla_parse_nested_deprecated
    * nla_validate_nested -> nla_validate_nested_deprecated

    Using spatch, of course:
    @@
    expression TB, MAX, HEAD, LEN, POL, EXT;
    @@
    -nla_parse(TB, MAX, HEAD, LEN, POL, EXT)
    +nla_parse_deprecated(TB, MAX, HEAD, LEN, POL, EXT)

    @@
    expression NLH, HDRLEN, TB, MAX, POL, EXT;
    @@
    -nlmsg_parse(NLH, HDRLEN, TB, MAX, POL, EXT)
    +nlmsg_parse_deprecated(NLH, HDRLEN, TB, MAX, POL, EXT)

    @@
    expression NLH, HDRLEN, TB, MAX, POL, EXT;
    @@
    -nlmsg_parse_strict(NLH, HDRLEN, TB, MAX, POL, EXT)
    +nlmsg_parse_deprecated_strict(NLH, HDRLEN, TB, MAX, POL, EXT)

    @@
    expression TB, MAX, NLA, POL, EXT;
    @@
    -nla_parse_nested(TB, MAX, NLA, POL, EXT)
    +nla_parse_nested_deprecated(TB, MAX, NLA, POL, EXT)

    @@
    expression START, MAX, POL, EXT;
    @@
    -nla_validate_nested(START, MAX, POL, EXT)
    +nla_validate_nested_deprecated(START, MAX, POL, EXT)

    @@
    expression NLH, HDRLEN, MAX, POL, EXT;
    @@
    -nlmsg_validate(NLH, HDRLEN, MAX, POL, EXT)
    +nlmsg_validate_deprecated(NLH, HDRLEN, MAX, POL, EXT)

    For this patch, don't actually add the strict, non-renamed versions
    yet so that it breaks compile if I get it wrong.

    Also, while at it, make nla_validate and nla_parse go down to a
    common __nla_validate_parse() function to avoid code duplication.

    Ultimately, this allows us to have very strict validation for every
    new caller of nla_parse()/nlmsg_parse() etc as re-introduced in the
    next patch, while existing things will continue to work as is.

    In effect then, this adds fully strict validation for any new command.

    Signed-off-by: Johannes Berg
    Signed-off-by: David S. Miller

    Johannes Berg
     
  • ae0be8de9   netlink: make nla_nest_start() add NLA_F_NESTED flag ... Browse Code »

    Even if the NLA_F_NESTED flag was introduced more than 11 years ago, most
    netlink based interfaces (including recently added ones) are still not
    setting it in kernel generated messages. Without the flag, message parsers
    not aware of attribute semantics (e.g. wireshark dissector or libmnl's
    mnl_nlmsg_fprintf()) cannot recognize nested attributes and won't display
    the structure of their contents.

    Unfortunately we cannot just add the flag everywhere as there may be
    userspace applications which check nlattr::nla_type directly rather than
    through a helper masking out the flags. Therefore the patch renames
    nla_nest_start() to nla_nest_start_noflag() and introduces nla_nest_start()
    as a wrapper adding NLA_F_NESTED. The calls which add NLA_F_NESTED manually
    are rewritten to use nla_nest_start().

    Except for changes in include/net/netlink.h, the patch was generated using
    this semantic patch:

    @@ expression E1, E2; @@
    -nla_nest_start(E1, E2)
    +nla_nest_start_noflag(E1, E2)

    @@ expression E1, E2; @@
    -nla_nest_start_noflag(E1, E2 | NLA_F_NESTED)
    +nla_nest_start(E1, E2)

    Signed-off-by: Michal Kubecek
    Acked-by: Jiri Pirko
    Acked-by: David Ahern
    Signed-off-by: David S. Miller

    Michal Kubecek
     

02 Apr, 2019

1 commit

  • 0db6f8bef   net/sched: fix ->get helper of the matchall cls ... Browse Code »

    It returned always NULL, thus it was never possible to get the filter.

    Example:
    $ ip link add foo type dummy
    $ ip link add bar type dummy
    $ tc qdisc add dev foo clsact
    $ tc filter add dev foo protocol all pref 1 ingress handle 1234 \
    matchall action mirred ingress mirror dev bar

    Before the patch:
    $ tc filter get dev foo protocol all pref 1 ingress handle 1234 matchall
    Error: Specified filter handle not found.
    We have an error talking to the kernel

    After:
    $ tc filter get dev foo protocol all pref 1 ingress handle 1234 matchall
    filter ingress protocol all pref 1 matchall chain 0 handle 0x4d2
    not_in_hw
    action order 1: mirred (Ingress Mirror to device bar) pipe
    index 1 ref 1 bind 1

    CC: Yotam Gigi
    CC: Jiri Pirko
    Fixes: fd62d9f5c575 ("net/sched: matchall: Fix configuration race")
    Signed-off-by: Nicolas Dichtel
    Signed-off-by: David S. Miller

    Nicolas Dichtel
     

23 Feb, 2019

1 commit

  • 14215108a   net_sched: initialize net pointer inside tcf_exts_init() ... Browse Code »

    For tcindex filter, it is too late to initialize the
    net pointer in tcf_exts_validate(), as tcf_exts_get_net()
    requires a non-NULL net pointer. We can just move its
    initialization into tcf_exts_init(), which just requires
    an additional parameter.

    This makes the code in tcindex_alloc_perfect_hash()
    prettier.

    Cc: Jamal Hadi Salim
    Cc: Jiri Pirko
    Signed-off-by: Cong Wang
    Signed-off-by: David S. Miller

    Cong Wang
     

18 Feb, 2019

1 commit

  • d66022cd1   net: sched: matchall: verify that filter is not NULL in mall_walk() ... Browse Code »

    Check that filter is not NULL before passing it to tcf_walker->fn()
    callback. This can happen when mall_change() failed to offload filter to
    hardware.

    Fixes: ed76f5edccc9 ("net: sched: protect filter_chain list with filter_chain_lock mutex")
    Reported-by: Ido Schimmel
    Tested-by: Ido Schimmel
    Signed-off-by: Vlad Buslov
    Signed-off-by: David S. Miller

    Vlad Buslov
     

13 Feb, 2019

2 commits

  • 12db03b65   net: sched: extend proto ops to support unlocked classifiers ... Browse Code »

    Add 'rtnl_held' flag to tcf proto change, delete, destroy, dump, walk
    functions to track rtnl lock status. Extend users of these function in cls
    API to propagate rtnl lock status to them. This allows classifiers to
    obtain rtnl lock when necessary and to pass rtnl lock status to extensions
    and driver offload callbacks.

    Add flags field to tcf proto ops. Add flag value to indicate that
    classifier doesn't require rtnl lock.

    Signed-off-by: Vlad Buslov
    Acked-by: Jiri Pirko
    Signed-off-by: David S. Miller

    Vlad Buslov
     
  • ec6743a10   net: sched: track rtnl lock status when validating extensions ... Browse Code »

    Actions API is already updated to not rely on rtnl lock for
    synchronization. However, it need to be provided with rtnl status when
    called from classifiers API in order to be able to correctly release the
    lock when loading kernel module.

    Extend extension validation function with 'rtnl_held' flag which is passed
    to actions API. Add new 'rtnl_held' parameter to tcf_exts_validate() in cls
    API. No classifier is currently updated to support unlocked execution, so
    pass hardcoded 'true' flag parameter value.

    Signed-off-by: Vlad Buslov
    Acked-by: Jiri Pirko
    Signed-off-by: David S. Miller

    Vlad Buslov
     

19 Jan, 2019

1 commit

  • f88c19aab   net_sched: add hit counter for matchall ... Browse Code »

    Although matchall always matches packets, however, it still
    relies on a protocol match first. So it is still useful to have
    such a counter for matchall. Of course, unlike u32, every time
    we hit a matchall filter, it is always a success, so we don't
    have to distinguish them.

    Sample output:

    filter protocol 802.1Q pref 100 matchall chain 0
    filter protocol 802.1Q pref 100 matchall chain 0 handle 0x1
    not_in_hw (rule hit 10)
    action order 1: vlan pop continue
    index 1 ref 1 bind 1 installed 40 sec used 1 sec
    Action statistics:
    Sent 836 bytes 10 pkt (dropped 0, overlimits 0 requeues 0)
    backlog 0b 0p requeues 0

    Reported-by: Martin Olsson
    Cc: Jamal Hadi Salim
    Cc: Jiri Pirko
    Signed-off-by: Cong Wang
    Signed-off-by: David S. Miller

    Cong Wang
     

15 Dec, 2018

1 commit

  • aeb3fecde   net_sched: fold tcf_block_cb_call() into tc_setup_cb_call() ... Browse Code »

    After commit 69bd48404f25 ("net/sched: Remove egdev mechanism"),
    tc_setup_cb_call() is nearly identical to tcf_block_cb_call(),
    so we can just fold tcf_block_cb_call() into tc_setup_cb_call()
    and remove its unused parameter 'exts'.

    Fixes: 69bd48404f25 ("net/sched: Remove egdev mechanism")
    Cc: Oz Shlomo
    Cc: Jiri Pirko
    Signed-off-by: Cong Wang
    Acked-by: Jiri Pirko
    Acked-by: Oz Shlomo
    Signed-off-by: David S. Miller

    Cong Wang
     

17 Aug, 2018

1 commit

  • a51c76b4d   cls_matchall: fix tcf_unbind_filter missing ... Browse Code »

    Fix tcf_unbind_filter missing in cls_matchall as this will trigger
    WARN_ON() in cbq_destroy_class().

    Fixes: fd62d9f5c575f ("net/sched: matchall: Fix configuration race")
    Reported-by: Li Shuang
    Signed-off-by: Hangbin Liu
    Acked-by: Cong Wang
    Signed-off-by: David S. Miller

    Hangbin Liu
     

26 Jun, 2018

1 commit

  • 0efd1b3a1   net: sched: cls_matchall: implement offload tcf_proto_op ... Browse Code »

    Add the reoffload tcf_proto_op in matchall to generate an offload message
    for each filter in the given tcf_proto. Call the specified callback with
    this new offload message. The function only returns an error if the
    callback rejects adding a 'hardware only' rule.

    Ensure matchall flags correctly report if the rule is in hw by keeping a
    reference counter for the number of instances of the rule offloaded. Only
    update the flag when this counter changes from or to 0.

    Signed-off-by: John Hurley
    Signed-off-by: Jakub Kicinski
    Acked-by: Jiri Pirko
    Signed-off-by: David S. Miller

    John Hurley
     

25 May, 2018

1 commit

  • aaa908ffb   net_sched: switch to rcu_work ... Browse Code »

    Commit 05f0fe6b74db ("RCU, workqueue: Implement rcu_work") introduces
    new API's for dispatching work in a RCU callback. Now we can just
    switch to the new API's for tc filters. This could get rid of a lot
    of code.

    Cc: Tejun Heo
    Cc: "Paul E. McKenney"
    Cc: Jamal Hadi Salim
    Signed-off-by: Cong Wang
    Signed-off-by: David S. Miller

    Cong Wang
     

25 Jan, 2018

4 commits

23 Jan, 2018

2 commits

  • 8f0b425a7   net: sched: add extack support for offload via tc_cls_common_offload ... Browse Code »

    Add extack support for hardware offload of classifiers. In order
    to achieve this, a pointer to a struct netlink_ext_ack is added to the
    struct tc_cls_common_offload that is passed to the callback for setting
    up the classifier. Function tc_cls_common_offload_init() is updated to
    support initialization of this new attribute.

    Signed-off-by: Quentin Monnet
    Reviewed-by: Jakub Kicinski
    Signed-off-by: David S. Miller

    Quentin Monnet
     
  • 027981405   net: sched: cls_matchall: propagate extack support for filter offload ... Browse Code »

    Propagate the extack pointer from the `->change()` classifier operation
    to the function used for filter replacement in cls_matchall. This makes
    it possible to use netlink extack messages in the future at replacement
    time for this filter, although it is not used at this point.

    Signed-off-by: Quentin Monnet
    Reviewed-by: Jakub Kicinski
    Signed-off-by: David S. Miller

    Quentin Monnet
     

20 Jan, 2018

3 commits