26 Apr, 2018

1 commit

• a6a25002e   tcp_nv: fix potential integer overflow in tcpnv_acked ... Browse Code »

  [ Upstream commit e4823fbd229bfbba368b40cdadb8f4eeb20604cc ]

  Add suffix ULL to constant 80000 in order to avoid a potential integer
  overflow and give the compiler complete information about the proper
  arithmetic to use. Notice that this constant is used in a context that
  expects an expression of type u64.

  The current cast to u64 effectively applies to the whole expression
  as an argument of type u64 to be passed to div64_u64, but it does
  not prevent it from being evaluated using 32-bit arithmetic instead
  of 64-bit arithmetic.

  Also, once the expression is properly evaluated using 64-bit arithmentic,
  there is no need for the parentheses and the external cast to u64.

  Addresses-Coverity-ID: 1357588 ("Unintentional integer overflow")
  Signed-off-by: Gustavo A. R. Silva
  Signed-off-by: David S. Miller
  Signed-off-by: Sasha Levin
  Signed-off-by: Greg Kroah-Hartman

  Gustavo A. R. Silva

  2018-04-26 17:02:13 +0800  

02 Nov, 2017

1 commit

• 4eebff27c   tcp_nv: fix division by zero in tcpnv_acked() ... Browse Code »

  Average RTT could become zero. This happened in real life at least twice.
  This patch treats zero as 1us.

  Signed-off-by: Konstantin Khlebnikov
  Acked-by: Lawrence Brakmo
  Signed-off-by: David S. Miller

  Konstantin Khlebnikov

  2017-11-02 15:16:27 +0800  

07 Aug, 2017

1 commit

• f1722a1be   tcp: consolidate congestion control undo functions ... Browse Code »

  Most TCP congestion controls are using identical logic to undo
  cwnd except BBR. This patch consolidates these similar functions
  to the one used currently by Reno and others.

  Suggested-by: Neal Cardwell
  Signed-off-by: Yuchung Cheng
  Signed-off-by: Neal Cardwell
  Signed-off-by: David S. Miller

  Yuchung Cheng

  2017-08-07 12:25:10 +0800  

22 May, 2017

1 commit

• c718c6d66   tcpnv: do not export local function ... Browse Code »

  The TCP New Vegas congestion control was exporting an internal
  function tcpnv_get_info which is not used by any other in tree
  kernel code. Make it static.

  Signed-off-by: Stephen Hemminger
  Signed-off-by: David S. Miller

  stephen hemminger

  2017-05-22 01:42:36 +0800  

11 Jun, 2016

1 commit

• 699fafafa   tcp: add NV congestion control ... Browse Code »

  TCP-NV (New Vegas) is a major update to TCP-Vegas.
  An earlier version of NV was presented at 2010's LPC.
  It is a delayed based congestion avoidance for the
  data center. This version has been tested within a
  10G rack where the HW RTTs are 20-50us and with
  1 to 400 flows.

  A description of TCP-NV, including implementation
  details as well as experimental results, can be found at:
  http://www.brakmo.org/networking/tcp-nv/TCPNV.html

  Signed-off-by: Lawrence Brakmo
  Signed-off-by: David S. Miller

  Lawrence Brakmo

  2016-06-11 14:07:49 +0800