07 Jan, 2011

1 commit

  • Mux data is passed by pointers to mux.c from the SoC specific
    mux file, these variables dont really need to be global scope.

    This fixes the following sparse warnings:
    arch/arm/mach-omap2/mux44xx.c:547:29: warning: symbol 'omap4_core_cbl_ball' was not declared. Should it be static?
    arch/arm/mach-omap2/mux44xx.c:1265:29: warning: symbol 'omap4_core_cbs_ball' was not declared. Should it be static?
    arch/arm/mach-omap2/mux44xx.c:1549:29: warning: symbol 'omap4_wkup_cbl_cbs_ball' was not declared. Should it be static?

    Signed-off-by: Nishanth Menon
    Signed-off-by: Tony Lindgren

    Nishanth Menon
     

17 Nov, 2010

2 commits

  • Removed mux: and added the __func__ macro to make debugging
    easier.

    Signed-off-by: Dan Murphy
    Signed-off-by: Benoit Cousson
    Cc: Tony Lindgren

    Dan Murphy
     
  • Starting on OMAP4, the pin mux configuration is located in two
    different partitions of the control module (CODE_PAD and WKUP_PAD).
    The first one is inside the core power domain whereas the second
    one is inside the wakeup.
    - Add the capability to add any number of partition during board init
    time depending of Soc partitioning.
    - Add some init flags as well in order to avoid explicit Soc version
    check inside the mux core code.
    - Add a comment with mux0 mode on top of omap_mux/board/
    if the current mux mode is not the default one.

    Thanks to Tony Lindgren for the following improvements:
    - Add omap_mux_get for getting the partition data so platform level
    device code can use it.
    - Fix the rx51 board code to use the new API.
    - Do not store the partition for each mux entry. Look up the partition
    for debugfs instead.

    Thanks to Dan Murphy for testing on OMAP4 and reporting
    a couple of bugs.
    Thanks to Anand Gadiyar for testing on OMAP3 zoom and
    bug report.

    Signed-off-by: Benoit Cousson
    Signed-off-by: Tony Lindgren
    Tested-by: Murphy Dan
    Cc: Paul Walmsley
    Cc: Kevin Hilman
    Cc: Santosh Shilimkar
    Cc: Anand Gadiyar

    Benoit Cousson
     

09 Oct, 2010

1 commit

  • This patch fixes sparse warnings due to non declaration of
    static structures and variables.

    Sparse warning logs fixed:
    arch/arm/mach-omap2/control.c:88:6: warning: symbol 'omap3_secure_ram_storage' was not declared. Should it be static?
    n
    arch/arm/mach-omap2/timer-gp.c:50:22: warning: symbol 'gptimer_wakeup' was not declared. Should it be static?
    arch/arm/mach-omap2/timer-gp.c:240:18: warning: symbol 'omap_timer' was not declared. Should it be static?
    arch/arm/mach-omap2/prcm.c:121:24: warning: symbol 'prcm_context' was not declared. Should it be static?
    arch/arm/mach-omap2/mux2420.c:510:29: warning: symbol 'omap2420_pop_ball' was not declared. Should it be static?
    arch/arm/mach-omap2/mux2430.c:589:29: warning: symbol 'omap2430_pop_ball' was not declared. Should it be static?
    arch/arm/mach-omap2/mux34xx.c:934:28: warning: symbol 'omap3_cus_subset' was not declared. Should it be static?
    arch/arm/mach-omap2/mux34xx.c:1080:29: warning: symbol 'omap3_cus_ball' was not declared. Should it be static?
    arch/arm/mach-omap2/mux34xx.c:1272:28: warning: symbol 'omap3_cbb_subset' was not declared. Should it be static?
    arch/arm/mach-omap2/mux34xx.c:1393:29: warning: symbol 'omap3_cbb_ball' was not declared. Should it be static?
    arch/arm/mach-omap2/mux34xx.c:1603:28: warning: symbol 'omap36xx_cbp_subset' was not declared. Should it be static?
    arch/arm/mach-omap2/mux34xx.c:1821:29: warning: symbol 'omap36xx_cbp_ball' was not declared. Should it be static?
    arch/arm/mach-omap2/pm-debug.c:165:15: warning: symbol 'pm_dbg_dir' was not declared. Should it be static?
    arch/arm/mach-omap2/board-omap3evm.c:587:30: warning: symbol 'ads7846_config' was not declared. Should it be static?
    arch/arm/mach-omap2/board-omap3evm.c:606:23: warning: symbol 'omap3evm_spi_board_info' was not declared. Should it be static?
    arch/arm/mach-omap2/board-rx51-sdram.c:46:25: warning: symbol 'rx51_sdrc_params' was not declared. Should it be static?
    arch/arm/mach-omap2/board-rx51-sdram.c:211:25: warning: symbol 'rx51_get_sdram_timings' was not declared. Should it be static?
    arch/arm/mach-omap2/board-omap3touchbook.c:64:15: warning: symbol 'touchbook_revision' was not declared. Should it be static?
    arch/arm/mach-omap2/board-am3517evm.c:350:24: warning: symbol 'am3517_evm_dss_device' was not declared. Should it be static?
    arch/arm/mach-omap2/board-omap3stalker.c:567:23: warning: symbol 'omap3stalker_spi_board_info' was not declared. Should it be static?

    Signed-off-by: Manjunath Kondaiah G
    Cc: linux-arm-kernel@lists.infradead.org
    Cc: Nishanth Menon
    Signed-off-by: Tony Lindgren

    Manjunath Kondaiah G
     

05 Jul, 2010

1 commit


05 May, 2010

1 commit


04 Feb, 2010

1 commit

  • 3630 has more mux signals than 34xx. The additional pins
    exist in omap36xx_cbp_subset, but are not initialized
    as the superset is missing these offsets. This causes
    the following errors during the boot:

    mux: Unknown entry offset 0x236
    mux: Unknown entry offset 0x22e
    mux: Unknown entry offset 0x1ec
    mux: Unknown entry offset 0x1ee
    mux: Unknown entry offset 0x1f4
    mux: Unknown entry offset 0x1f6
    mux: Unknown entry offset 0x1f8
    mux: Unknown entry offset 0x1fa
    mux: Unknown entry offset 0x1fc
    mux: Unknown entry offset 0x22a
    mux: Unknown entry offset 0x226
    mux: Unknown entry offset 0x230
    mux: Unknown entry offset 0x22c
    mux: Unknown entry offset 0x228

    Fix this by adding the missing offsets to omap3 superset.
    Note that additionally the uninitialized pins need to be
    skipped on 34xx.

    Based on an earlier patch by Allen Pais .

    Reported-by: Allen Pais
    Signed-off-by: Allen Pais
    Signed-off-by: Tony Lindgren

    Tony Lindgren
     

12 Dec, 2009

2 commits