Eric Lee / smarc-fsl-linux-kernel

17 Apr, 2011

1 commit

31 Mar, 2011

3 commits

  • c031235b3   atm/solos-pci: Don't flap VCs when carrier state changes ... Browse Code »

    Don't flap VCs when carrier state changes; higher-level protocols
    can detect loss of connectivity and act accordingly. This is more
    consistent with how other network interfaces work.

    We no longer use release_vccs() so we can delete it.

    release_vccs() was duplicated from net/atm/common.c; make the
    corresponding function exported, since other code duplicates it
    and could leverage it if it were public.

    Signed-off-by: Philip A. Prindeville
    Signed-off-by: David S. Miller

    Philip A. Prindeville
     
  • 18b429e74   atm/solos-pci: Don't include frame pseudo-header on transmit hex-dump ... Browse Code »

    Omit pkt_hdr preamble when dumping transmitted packet as hex-dump;
    we can pull this up because the frame has already been sent, and
    dumping it is the last thing we do with it before freeing it.

    Also include the size, vpi, and vci in the debug as is done on
    receive.

    Use "port" consistently instead of "device" intermittently.

    Signed-off-by: Philip Prindeville
    Signed-off-by: David S. Miller

    Philip A. Prindeville
     
  • 1e19e6585   atm/solos-pci: Use VPI.VCI notation uniformly. ... Browse Code »

    Use VPI.VCI notation consistently throughout the module. This is the
    one remaining place where the VCI is used before the VPI in any output.

    Signed-off-by: Philip Prindeville
    Signed-off-by: David S. Miller

    Philip A. Prindeville
     

14 Feb, 2011

1 commit

  • da1ab3e23   ATM, Solos PCI ADSL2+: Don't deref NULL pointer if net_ratelimit() and alloc_skb() interact badly. ... Browse Code »

    If alloc_skb() fails to allocate memory and returns NULL then we want to
    return -ENOMEM from drivers/atm/solos-pci.c::popen() regardless of the
    value of net_ratelimit(). The way the code is today, we may not return if
    net_ratelimit() returns 0, then we'll proceed to pass a NULL pointer to
    skb_put() which will blow up in our face.
    This patch ensures that we always return -ENOMEM on alloc_skb() failure
    and only let the dev_warn() be controlled by the value of net_ratelimit().

    Signed-off-by: Jesper Juhl
    Signed-off-by: David S. Miller

    Jesper Juhl
     

11 Dec, 2010

1 commit

  • d9ca676bc   atm: correct sysfs 'device' link creation and parent relationships ... Browse Code »

    The ATM subsystem was incorrectly creating the 'device' link for ATM
    nodes in sysfs. This led to incorrect device/parent relationships
    exposed by sysfs and udev. Instead of rolling the 'device' link by hand
    in the generic ATM code, pass each ATM driver's bus device down to the
    sysfs code and let sysfs do this stuff correctly.

    Signed-off-by: Dan Williams
    Signed-off-by: David S. Miller

    Dan Williams
     

09 Nov, 2010

1 commit

12 Oct, 2010

1 commit

  • f1ee89d5b   ATM: solos-pci, remove use after free ... Browse Code »

    Stanse found we do in console_show:
    kfree_skb(skb);
    return skb->len;
    which is not good. Fix that by remembering the len and use it in the
    function instead.

    Signed-off-by: Jiri Slaby
    Cc: Chas Williams
    Acked-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Jiri Slaby
     

08 Aug, 2010

1 commit

  • 1f6ea6e51   solos-pci: Fix race condition in tasklet RX handling ... Browse Code »

    We were seeing faults in the solos-pci receive tasklet when packets
    arrived for a VCC which was currently being closed:

    [18842.727906] EIP: [] br2684_push+0x19/0x234 [br2684] SS:ESP 0068:dfb89d14

    [18845.090712] [] ? do_page_fault+0x0/0x2e1
    [18845.120042] [] ? br2684_push+0x19/0x234 [br2684]
    [18845.153530] [] solos_bh+0x28b/0x7c8 [solos_pci]
    [18845.186488] [] ? solos_irq+0x2d/0x51 [solos_pci]
    [18845.219960] [] ? handle_irq+0x3b/0x48
    [18845.247732] [] ? irq_exit+0x34/0x57
    [18845.274437] [] tasklet_action+0x42/0x69
    [18845.303247] [] __do_softirq+0x8e/0x129
    [18845.331540] [] do_softirq+0x25/0x2a
    [18845.358274] [] _local_bh_enable_ip+0x5e/0x6a
    [18845.389677] [] local_bh_enable+0xb/0xe
    [18845.417944] [] ppp_unregister_channel+0x32/0xbb [ppp_generic]
    [18845.458193] [] pppox_unbind_sock+0x18/0x1f [pppox]

    This patch uses an RCU-inspired approach to fix it. In the RX tasklet's
    find_vcc() function we first refuse to use a VCC which already has the
    ATM_VF_READY bit cleared. And in the VCC close function, we synchronise
    with the tasklet to ensure that it can't still be using the VCC before
    we continue and allow the VCC to be destroyed.

    Signed-off-by: David Woodhouse
    Tested-by: Nathan Williams
    Cc: stable@kernel.org
    Signed-off-by: David S. Miller

    David Woodhouse
     

09 Jul, 2010

1 commit

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

18 Nov, 2009

1 commit

  • 7adcdb4c1   drivers/atm/solos-pci.c: fix warning/bug, clean up code ... Browse Code »

    drivers/atm/solos-pci.c: In function 'flash_upgrade':
    drivers/atm/solos-pci.c:528: warning: 'fw_name' may be used uninitialized in this function

    Cc: Chas Williams
    Cc: David Woodhouse
    Cc: Nathan Williams
    Cc: David S. Miller
    Signed-off-by: Andrew Morton
    Acked-By: David Woodhouse
    Signed-off-by: David S. Miller

    Andrew Morton
     

11 Nov, 2009

1 commit

23 Sep, 2009

1 commit

28 Jul, 2009

1 commit

  • 6cf5767c7   drivers/atm: Correct redundant test ... Browse Code »

    str has already been tested. It seems that this test should be on the
    recently returned value snr.

    A simplified version of the semantic match that finds this problem is as
    follows: (http://www.emn.fr/x-info/coccinelle/)

    //
    @r exists@
    local idexpression x;
    expression E;
    @@

    if (x == NULL || ...) { ... when forall
    return ...; }
    ... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\)
    (
    *x == NULL
    |
    *x != NULL
    )
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: David S. Miller

    Julia Lawall
     

14 Apr, 2009

1 commit

  • e930438c4   Replace all DMA_nBIT_MASK macro with DMA_BIT_MASK(n) ... Browse Code »

    This is the second go through of the old DMA_nBIT_MASK macro,and there're not
    so many of them left,so I put them into one patch.I hope this is the last round.
    After this the definition of the old DMA_nBIT_MASK macro could be removed.

    Signed-off-by: Yang Hongyang
    Cc: Russell King
    Cc: Tony Lindgren
    Cc: "David S. Miller"
    Cc: James Bottomley
    Cc: Greg KH
    Cc: Takashi Iwai
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Yang Hongyang
     

25 Mar, 2009

2 commits

22 Mar, 2009

1 commit

17 Mar, 2009

3 commits

09 Feb, 2009

1 commit

  • bc111d570   drivers/atm: introduce missing kfree ... Browse Code »

    Error handling code following a kmalloc should free the allocated data.

    The semantic match that finds the problem is as follows:
    (http://www.emn.fr/x-info/coccinelle/)

    //
    @r exists@
    local idexpression x;
    statement S;
    expression E;
    identifier f,l;
    position p1,p2;
    expression *ptr != NULL;
    @@

    (
    if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...)) == NULL) S
    |
    x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
    ...
    if (x == NULL) S
    )
    }
    x->f = E
    ...>
    (
    return \(0\|\|ptr\);
    |
    return@p2 ...;
    )

    @script:python@
    p1 << r.p1;
    p2 << r.p2;
    @@

    print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: David S. Miller

    Julia Lawall
     

30 Jan, 2009

5 commits

29 Jan, 2009

8 commits

28 Jan, 2009

4 commits