13 Jan, 2012

1 commit

• 90ab5ee94   module_param: make bool parameters really bool (drivers & misc) ... Browse Code »

  86

  module_param(bool) used to counter-intuitively take an int. In
  fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
  trick.

  It's time to remove the int/unsigned int option. For this version
  it'll simply give a warning, but it'll break next kernel version.

  Acked-by: Mauro Carvalho Chehab
  Signed-off-by: Rusty Russell

  Rusty Russell

  2012-01-13 07:02:20 +0800  

05 Aug, 2011

1 commit

• 00b15628b   HID: prodikeys: kfree() NULL pointer cleanup ... Browse Code »

  No need for freeing pm in case when it's not allocated.

  Reported-by: Julia Lawall
  Signed-off-by: Bojan Prtvar
  Signed-off-by: Jiri Kosina

  Bojan Prtvar

  2011-08-05 05:51:29 +0800  

21 Jul, 2011

2 commits

• d6b8f5819   HID: prodikeys: remove a redundant forward declaration of struct pcmidi_snd ... Browse Code »

  Signed-off-by: Axel Lin
  Signed-off-by: Jiri Kosina

  Axel Lin

  2011-07-21 19:59:08 +0800  
• f4c79818a   HID: prodikeys: make needlessly global symbols static ... Browse Code »

  The following symbols are not referenced outside this file so
  there's no need for it to be in the global name space.

  pcmidi_sustained_note_release
  init_sustain_timers
  stop_sustain_timers
  pcmidi_handle_report
  pcmidi_setup_extra_keys
  pcmidi_snd_initialise
  pcmidi_snd_terminate

  Make them static.

  Signed-off-by: Axel Lin
  Signed-off-by: Jiri Kosina

  Axel Lin

  2011-07-21 19:58:53 +0800  

10 Dec, 2010

1 commit

• 4291ee305   HID: Add and use hid_<level>: dev_<level> equivalents ... Browse Code »

  Neaten current uses of dev_ by adding and using
  hid specific hid_ macros.

  Convert existing uses of dev_ uses to hid_.
  Convert hid-pidff printk uses to hid_.

  Remove err_hid and use hid_err instead.

  Add missing newlines to logging messages where necessary.
  Coalesce format strings.

  Add and use pr_fmt(fmt) KBUILD_MODNAME ": " fmt

  Other miscellaneous changes:

  Add const struct hid_device * argument to hid-core functions
  extract() and implement() so hid_ can be used by them.
  Fix bad indentation in hid-core hid_input_field function
  that calls extract() function above.

  Signed-off-by: Joe Perches
  Signed-off-by: Jiri Kosina

  Joe Perches

  2010-12-10 22:10:38 +0800  

18 Nov, 2010

1 commit

• c311598b2   HID: prodikeys: make sysfs permissions more strict ... Browse Code »

  It's not really dangerous in this driver, but it's against general
  practice and worth fixing.

  Proper place for handling this correctly is udev.

  Reported-by: Linus Torvalds
  Signed-off-by: Jiri Kosina

  Jiri Kosina

  2010-11-18 23:30:34 +0800  

10 Aug, 2010

1 commit

• 73e4008dd   HID: allow resizing and replacing report descriptors ... Browse Code »

  Update hid_driver's report_fixup prototype to allow changing report
  descriptor size and/or returning completely different report descriptor.
  Update existing usage accordingly.

  This is to give more freedom in descriptor fixup and to allow having a whole
  fixed descriptor in the code for the sake of readability.

  Signed-off-by: Nikolai Kondrashov
  Signed-off-by: Jiri Kosina

  Nikolai Kondrashov

  2010-08-10 01:52:42 +0800  

12 May, 2010

1 commit

• 3a370ca1d   HID: Prodikeys PC-MIDI HID Driver ... Browse Code »

  A specialised HID driver for the Creative Prodikeys PC-MIDI USB Keyboard.

  The Prodikeys PC-MIDI is a multifunction keyboard comprising a qwerty keyboard,
  multimedia keys and a touch sensitive musical keyboard.

  The specialised HID driver adds full support for the musical keyboard and extra
  multimedia keys which are not currently handled by the default HID driver.

  The specialised HID driver interfaces with ALSA, and presents the midi keyboard
  as a rawmidi device. Sustain duration, octave shifting and the midi output
  channel can be read/written form userspace via sysfs.

  Signed-off-by: Don Prince
  ALSA parts:
  Acked-by: Clemens Ladisch
  Signed-off-by: Jiri Kosina

  Don Prince

  2010-05-12 21:18:59 +0800