13 Jan, 2012
1 commit
-
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.Acked-by: Mauro Carvalho Chehab
Signed-off-by: Rusty Russell
06 Jan, 2012
1 commit
-
replaced strict_strtol with kstrtol and
replaced strict_strtuol with kstrtuolThis satisfies checkpatch -f
Compile tested only: no warnings or errors givenSigned-off-by: Frans Meulenbroeks
Signed-off-by: Guenter Roeck
13 Jan, 2011
1 commit
-
The code triggers a false warning with older versions of gcc:
w83795.c: In function 'w83795_update_device':
w83795.c:475: warning: 'lsb' may be used uninitialized in this functionI admit that the code is a little tricky, but I see no way to write it
differently without hurting performance. So let's just silent the
warning with a needless initialization.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck
16 Nov, 2010
7 commits
-
On the W83795ADG, there's a single pin for BEEP and OVT#, so you
can't have both. Check the configuration and don't create beep
attributes when BEEP pin is not available.The W83795G has a dedicated BEEP pin so the functionality is always
available there.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck -
When asked to clear the intrusion alarm, do so immediately. We have to
invalidate the cache to make sure the new status will be read. But we
also have to read from the status register once to clear the pending
alarm, as writing to CLR_CHS surprising won't clear it automatically.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck -
We can't read the intrusion state from the real-time alarm registers
as we do for all other alarm flags, because real-time alarm bits don't
stick (by definition) and the intrusion state has to stick until
explicitly cleared (otherwise it has little value.)So we have to use the interrupt status register instead, which is read
from the same address but with a configuration bit flipped in another
register.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck -
Don't expose raw register values to user-space. Decode and encode
temperature channels selected as temperature sources as needed.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck -
Temperature sources are not correlated directly with temperature
channels. A look-up table is required to find out which temperature
sources can be used depending on which temperature channels (both
analog and digital) are enabled.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck -
Expose fan control method (DC vs. PWM) using the standard sysfs
attributes. I've made it read-only as the board should be wired for
a given mode, the BIOS should have set up the chip for this mode, and
you shouldn't have to change it. But it would be easy enough to make
it changeable if someone comes up with a use case.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck -
There were two bugs:
* Speed cruise mode was improperly reported for all fans but fan1.
* Fan control method (PWM vs. DC) was mixed with the control mode.
It will be added back as a separate attribute, as per the standard
sysfs interface.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck
29 Oct, 2010
30 commits
-
Follow the standard attribute naming for the chassis intrusion
feature. I couldn't test the beeping (my board apparently doesn't do
that) but the alarm works fine.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck -
The fan control feature of the w83795 driver is insufficiently
reviewed and tested for public consumption at this time, so make it
optional and disabled by default. We will change the default when
review and testing is deemed sufficient. Ultimately the option will
go away.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck -
I've made so many changes to the w83795 driver that it's only fair to
list myself as a co-author. I'll also maintain the driver for some
time. There's more work needed on the driver for sure.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck -
Cleanups suggested by Guenter Roeck, falling into 4 categories:
* Swapping test orders, because if (var == CONSTANT) is much easier to
read than if (CONSTANT == var).
* Simplifying comparisons with 0.
* Dropping unneeded masks.
* Dropping unneeded parentheses and curly braces.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck -
Wrong index caused the wrong register value to be read, resulting in
random LSB for voltage limits.Signed-off-by: Jean Delvare
-
When we don't need the client pointer, calling dev_get_drvdata() is
more efficient that calling to_i2c_client() and then
i2c_get_clientdata().Signed-off-by: Jean Delvare
-
Wait until we need the pwm config register values, instead of
pre-reading them. This saves over 1 second on modprobe on my test
system.Obviously this time is added when first accessing pwm config
attributes, however not everybody will use them, so it seems unfair
to slow down driver loading (and thus boot) for an optional feature.Signed-off-by: Jean Delvare
-
Wait until we need the limit register values, instead of pre-reading
them. This saves 544 ms on modprobe on my test system. Obviously this
time is added when first running "sensors" or any other monitoring
application, but I think it is better than slowing down the boot.Signed-off-by: Jean Delvare
-
Move initial register reads out of probe, to dedicated functions.
This makes the code clearer, and will be needed if we want to delay
calling these functions until they are needed, or want to call them
periodically.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck -
Pack similar register reads using for loops.
Signed-off-by: Jean Delvare
-
Cascaded conditionals are inefficient. Reorder the fields so that
PWM register addresses can be computed more efficiently.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck -
There is no point in reading registers during initialization if we
will refresh the values in the update function later. This is only
slowing down the driver loading with no benefit, stop doing it.
This change saves 480 ms on driver load on my test system.Signed-off-by: Jean Delvare
-
All 3 temperature sensor type sysfs functions (show_temp_mode,
store_temp_mode and show_dts_mode) can be simplified. We don't
create these files when the correponding input isn't in temperature
monitoring mode, so there is no point in handling that case.
Likewise, we don't allow changing inputs from temperature to voltage,
so the code handling this case is dead and can be removed.Signed-off-by: Jean Delvare
-
Consistently use ARRAY_SIZE() to control for loops.
Signed-off-by: Jean Delvare
-
Get rid of REST_VLT_BEGIN and REST_VLT_END, they don't make the code
more readable.Signed-off-by: Jean Delvare
-
x % 1 is obviously wrong, as it always evaluates to 0. You want
x % 2, or x & 1, for parity checking.Signed-off-by: Jean Delvare
-
VRLSB_SHIFT is a non-sense, the actual shift depends on the sensor
type (fans need 4, other sensors need 6). Get rid of it to prevent
any confusion. Also get rid of the useless masking, the meaningful
bits are always the MSb so there's nothing to mask out after
shifting.Signed-off-by: Jean Delvare
-
Shorten driver load time by avoiding duplicate register access during
initialization. This saves 112 ms on modprobe on my test system.Signed-off-by: Jean Delvare
-
Handle beep_enable just like all other beep bits. It doesn't need
anything special, so let's avoid redundant code. This also saves a
duplicate register read at initialization time.Signed-off-by: Jean Delvare
-
On systems with PECI, report PECI agent Tbase temperature values.
This is informative only.Signed-off-by: Jean Delvare
-
The temperature registers hold regular 2's complement values, no need
to add any arithmetics.Signed-off-by: Jean Delvare
-
Follow the standard for temperature limit attribute naming, so that
libsensors will pick the values.Signed-off-by: Jean Delvare
-
The PWM duty cycle frequenty attributes are improperly named
(fanN_div instead of pwmN_div) and contain raw values instead of
actual frequencies. Rename them and fix their contents.Also improve the logic when the user asks for a new frequency, to
always pick the closest supported frequency. The algorithm could
certainly be optimized, but the operation is infrequent enough that
I don't think it's worth the effort.Signed-off-by: Jean Delvare
-
The W83795G can be configured to set the in0, in1 and/or in2 voltage
limits dynamically based on VID input pins. Switch the respective
sysfs attributes to read-only.Signed-off-by: Jean Delvare
-
Misplaced parentheses caused the wrong register value to be read,
resulting in random LSB for fan speed values and limits.Signed-off-by: Jean Delvare
-
* The data structure is zalloc'd, so no need to set individual fields
to 0 explicitly.
* Refactor the handling of pins that can be used for either
temperature or voltage monitoring.
* Misc other clean-ups.Signed-off-by: Jean Delvare
-
Gain bit set means 1x gain and cleared means 8x gain, not the other
way around.Signed-off-by: Jean Delvare
-
This saves an SMBus write if monitoring was already enabled.
Signed-off-by: Jean Delvare
-
Attribute structures can be made const. Same for the I2C address
list.Signed-off-by: Jean Delvare
-
Only create fan[1-8]_target files when the fan in question can be
controlled (PWM output is present.) Also name these files according
to the standard.Signed-off-by: Jean Delvare