Eric Lee / smarc-fsl-linux-kernel

10 Jan, 2012

4 commits

21 Sep, 2011

1 commit

11 Sep, 2011

3 commits

  • 0612b9ddc   mtd: rename MTD_OOB_* to MTD_OPS_* ... Browse Code »

    These modes are not necessarily for OOB only. Particularly, MTD_OOB_RAW
    affected operations on in-band page data as well. To clarify these
    options and to emphasize that their effect is applied per-operation, we
    change the primary prefix to MTD_OPS_.

    Signed-off-by: Brian Norris
    Signed-off-by: Artem Bityutskiy

    Brian Norris
     
  • 289c05222   mtd: replace DEBUG() with pr_debug() ... Browse Code »

    Start moving away from the MTD_DEBUG_LEVEL messages. The dynamic
    debugging feature is a generic kernel feature that provides more
    flexibility.

    (See Documentation/dynamic-debug-howto.txt)

    Also fix some punctuation, indentation, and capitalization that went
    along with the affected lines.

    Signed-off-by: Brian Norris
    Signed-off-by: Artem Bityutskiy

    Brian Norris
     
  • 0870066d7   mtd: remove printk's for [kv][mz]alloc failures ... Browse Code »

    When a memory allocation fails, the kernel will print out a backtrace
    automatically. These print statements are unnecessary.

    Signed-off-by: Brian Norris
    Signed-off-by: Artem Bityutskiy

    Brian Norris
     

09 Aug, 2010

1 commit

27 Feb, 2010

1 commit

  • 048d87199   mtd: blktrans: Hotplug fixes ... Browse Code »

    * Add locking where it was missing.

    * Don't do a get_mtd_device in blktrans_open because it would lead to a
    deadlock; instead do that in add_mtd_blktrans_dev.

    * Only free the mtd_blktrans_dev structure when the last user exits.

    * Flush request queue on device removal.

    * Track users, and call tr->release in del_mtd_blktrans_dev
    Due to that ->open and release aren't called more that once.

    Now it is safe to call del_mtd_blktrans_dev while the device is still in use.

    Signed-off-by: Maxim Levitsky
    Signed-off-by: David Woodhouse

    Maxim Levitsky
     

03 Sep, 2009

2 commits

  • 16f05c2b6   mtd: nftl: fix offset alignments ... Browse Code »

    Arithmetic conversion in the mask computation makes the upper word
    of the second argument passed down to mtd->read_oob(), be always 0
    (assuming 'offs' being a 64-bit signed long long type, and
    'mtd->writesize' being a 32-bit unsigned int type).

    This patch applies over the other one adding masking in nftl_write,
    "nftl: write support is broken".

    Signed-off-by: Dimitri Gorokhovik
    Cc: Tim Gardner
    Cc: Scott James Remnant
    Signed-off-by: David Woodhouse

    Dimitri Gorokhovik
     
  • 4149ed1aa   mtd: nftl: write support is broken ... Browse Code »

    Write support is broken in NFTL. Fix it.

    Signed-off-by:
    Cc: Tim Gardner
    Cc: Scott James Remnant
    Signed-off-by: Andrew Morton
    Signed-off-by: David Woodhouse

    Dimitri Gorokhovik
     

27 Jun, 2009

1 commit

  • 70ec3bb8e   mtd: Use BLOCK_NIL consistently in NFTL/INFTL ... Browse Code »

    Use BLOCK_NIL consistently rather than sometimes 0xffff and sometimes
    BLOCK_NIL.

    The semantic patch that finds this issue is below
    (http://www.emn.fr/x-info/coccinelle/). On the other hand, the changes
    were made by hand, in part because drivers/mtd/inftlcore.c contains dead
    code that causes spatch to ignore a relevant function. Specifically, the
    function INFTL_findwriteunit contains a do-while loop, but always takes a
    return that leaves the loop on the first iteration.

    //
    @r exists@
    identifier f,C;
    @@

    f(...) { ... return C; }

    @s@
    identifier r.C;
    expression E;
    @@

    @@
    identifier r.f,r.C,I;
    expression s.E;
    @@

    f(...) {

    }

    //

    Signed-off-by: Julia Lawall
    Signed-off-by: David Woodhouse

    Julia Lawall
     

21 Mar, 2009

1 commit

20 Mar, 2009

1 commit

  • 7ed8c7d44   [MTD] we don't need no misc devices ... Browse Code »

    Remove from various drivers which don't actually use
    any of its contents. There are still a number of these left in
    arch-specific bits of the tree.

    (Found by diffing results of "grep -rl" for linux/miscdevice.h and for
    misc_register, examining the differences, and verifying removals with a
    build test.)

    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: David Woodhouse

    David Brownell
     

10 Dec, 2008

1 commit

  • 69423d99f   [MTD] update internal API to support 64-bit device size ... Browse Code »

    MTD internal API presently uses 32-bit values to represent
    device size. This patch updates them to 64-bits but leaves
    the external API unchanged. Extending the external API
    is a separate issue for several reasons. First, no one
    needs it at the moment. Secondly, whether the implementation
    is done with IOCTLs, sysfs or both is still debated. Thirdly
    external API changes require the internal API to be accepted
    first.

    Note that although the MTD API will be able to support 64-bit
    device sizes, existing drivers do not and are not required
    to do so, although NAND base has been updated.

    In general, changing from 32-bit to 64-bit values cause little
    or no changes to the majority of the code with the following
    exceptions:
    - printk message formats
    - division and modulus of 64-bit values
    - NAND base support
    - 32-bit local variables used by mtdpart and mtdconcat
    - naughtily assuming one structure maps to another
    in MEMERASE ioctl

    Signed-off-by: Adrian Hunter
    Signed-off-by: Artem Bityutskiy
    Signed-off-by: David Woodhouse

    Adrian Hunter
     

05 Jun, 2008

1 commit

  • 59018b6d2   MTD/JFFS2: remove CVS keywords ... Browse Code »

    Once upon a time, the MTD repository was using CVS.

    This patch therefore removes all usages of the no longer updated CVS
    keywords from the MTD code.

    This also includes code that printed them to the user.

    Signed-off-by: Adrian Bunk
    Signed-off-by: David Woodhouse

    Adrian Bunk
     

03 May, 2007

1 commit

  • 6473d160b   PCI: Cleanup the includes of <linux/pci.h> ... Browse Code »

    I noticed that many source files include while they do
    not appear to need it. Here is an attempt to clean it all up.

    In order to find all possibly affected files, I searched for all
    files including but without any other occurence of "pci"
    or "PCI". I removed the include statement from all of these, then I
    compiled an allmodconfig kernel on both i386 and x86_64 and fixed the
    false positives manually.

    My tests covered 66% of the affected files, so there could be false
    positives remaining. Untested files are:

    arch/alpha/kernel/err_common.c
    arch/alpha/kernel/err_ev6.c
    arch/alpha/kernel/err_ev7.c
    arch/ia64/sn/kernel/huberror.c
    arch/ia64/sn/kernel/xpnet.c
    arch/m68knommu/kernel/dma.c
    arch/mips/lib/iomap.c
    arch/powerpc/platforms/pseries/ras.c
    arch/ppc/8260_io/enet.c
    arch/ppc/8260_io/fcc_enet.c
    arch/ppc/8xx_io/enet.c
    arch/ppc/syslib/ppc4xx_sgdma.c
    arch/sh64/mach-cayman/iomap.c
    arch/xtensa/kernel/xtensa_ksyms.c
    arch/xtensa/platform-iss/setup.c
    drivers/i2c/busses/i2c-at91.c
    drivers/i2c/busses/i2c-mpc.c
    drivers/media/video/saa711x.c
    drivers/misc/hdpuftrs/hdpu_cpustate.c
    drivers/misc/hdpuftrs/hdpu_nexus.c
    drivers/net/au1000_eth.c
    drivers/net/fec_8xx/fec_main.c
    drivers/net/fec_8xx/fec_mii.c
    drivers/net/fs_enet/fs_enet-main.c
    drivers/net/fs_enet/mac-fcc.c
    drivers/net/fs_enet/mac-fec.c
    drivers/net/fs_enet/mac-scc.c
    drivers/net/fs_enet/mii-bitbang.c
    drivers/net/fs_enet/mii-fec.c
    drivers/net/ibm_emac/ibm_emac_core.c
    drivers/net/lasi_82596.c
    drivers/parisc/hppb.c
    drivers/sbus/sbus.c
    drivers/video/g364fb.c
    drivers/video/platinumfb.c
    drivers/video/stifb.c
    drivers/video/valkyriefb.c
    include/asm-arm/arch-ixp4xx/dma.h
    sound/oss/au1550_ac97.c

    I would welcome test reports for these files. I am fine with removing
    the untested files from the patch if the general opinion is that these
    changes aren't safe. The tested part would still be nice to have.

    Note that this patch depends on another header fixup patch I submitted
    to LKML yesterday:
    [PATCH] scatterlist.h needs types.h
    http://lkml.org/lkml/2007/3/01/141

    Signed-off-by: Jean Delvare
    Cc: Badari Pulavarty
    Signed-off-by: Greg Kroah-Hartman

    Jean Delvare
     

15 Feb, 2007

1 commit

  • cd354f1ae   [PATCH] remove many unneeded #includes of sched.h ... Browse Code »

    After Al Viro (finally) succeeded in removing the sched.h #include in module.h
    recently, it makes sense again to remove other superfluous sched.h includes.
    There are quite a lot of files which include it but don't actually need
    anything defined in there. Presumably these includes were once needed for
    macros that used to live in sched.h, but moved to other header files in the
    course of cleaning it up.

    To ease the pain, this time I did not fiddle with any header files and only
    removed #includes from .c-files, which tend to cause less trouble.

    Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
    arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
    allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
    configs in arch/arm/configs on arm. I also checked that no new warnings were
    introduced by the patch (actually, some warnings are removed that were emitted
    by unnecessarily included header files).

    Signed-off-by: Tim Schmielau
    Acked-by: Russell King
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tim Schmielau
     

29 Nov, 2006

3 commits

  • 95b93a0cd   [MTD] replace kmalloc+memset with kzalloc ... Browse Code »

    Signed-off-by: Yan Burman
    Signed-off-by: David Woodhouse

    Burman Yan
     
  • 7014568ba   [MTD] [NAND] remove len/ooblen confusion. ... Browse Code »

    As was discussed between Ricard Wanderlöf, David Woodhouse, Artem
    Bityutskiy and me, the current API for reading/writing OOB is confusing.

    The thing that introduces confusion is the need to specify ops.len
    together with ops.ooblen for reads/writes that concern only OOB not data
    area. So, ops.len is overloaded: when ops.datbuf != NULL it serves to
    specify the length of the data read, and when ops.datbuf == NULL, it
    serves to specify the full OOB read length.

    The patch inlined below is the slightly updated version of the previous
    patch serving the same purpose, but with the new Artem's comments taken
    into account.

    Artem, BTW, thanks a lot for your valuable input!

    Signed-off-by: Vitaly Wool
    Signed-off-by: David Woodhouse

    Vitaly Wool
     
  • 191876729   [MTD] Allow variable block sizes in mtd_blkdevs ... Browse Code »

    Currently, mtd_blkdevs enforces a block size of 512, even if the drivers
    can seemingly request a different size. This patch fixes mtd_blkdevs so
    block sizes other than 512 work correctly.

    Signed-off-by: Richard Purdie
    Signed-off-by: David Woodhouse

    Richard Purdie
     

02 Oct, 2006

1 commit

  • 553a80120   [MTD] fix nftl_write warning ... Browse Code »

    Building 2.6.18-mm2 issues the following warning if CONFIG_NFTL_RW is not set:

    CC [M] drivers/mtd/nftlcore.o
    drivers/mtd/nftlcore.c:183: warning: 'nftl_write' defined but not used
    The following patch only compiles nftl_write if CONFIG_NFTL_RW is set.

    Signed-off-by: Frederik Deweerdt
    Signed-off-by: Andrew Morton
    Signed-off-by: David Woodhouse

    Frederik Deweerdt
     

01 Jul, 2006

1 commit

29 May, 2006

3 commits

  • 9a1fcdfd4   [MTD] NAND Signal that a bitflip was corrected by ECC ... Browse Code »

    Return -EUCLEAN on read when a bitflip was detected and corrected, so the
    clients can react and eventually copy the affected block to a spare one.
    Make all in kernel users aware of the change.

    Signed-off-by: Thomas Gleixner

    Thomas Gleixner
     
  • 8593fbc68   [MTD] Rework the out of band handling completely ... Browse Code »
    43

    Hopefully the last iteration on this!

    The handling of out of band data on NAND was accompanied by tons of fruitless
    discussions and halfarsed patches to make it work for a particular
    problem. Sufficiently annoyed by I all those "I know it better" mails and the
    resonable amount of discarded "it solves my problem" patches, I finally decided
    to go for the big rework. After removing the _ecc variants of mtd read/write
    functions the solution to satisfy the various requirements was to refactor the
    read/write _oob functions in mtd.

    The major change is that read/write_oob now takes a pointer to an operation
    descriptor structure "struct mtd_oob_ops".instead of having a function with at
    least seven arguments.

    read/write_oob which should probably renamed to a more descriptive name, can do
    the following tasks:

    - read/write out of band data
    - read/write data content and out of band data
    - read/write raw data content and out of band data (ecc disabled)

    struct mtd_oob_ops has a mode field, which determines the oob handling mode.

    Aside of the MTD_OOB_RAW mode, which is intended to be especially for
    diagnostic purposes and some internal functions e.g. bad block table creation,
    the other two modes are for mtd clients:

    MTD_OOB_PLACE puts/gets the given oob data exactly to/from the place which is
    described by the ooboffs and ooblen fields of the mtd_oob_ops strcuture. It's
    up to the caller to make sure that the byte positions are not used by the ECC
    placement algorithms.

    MTD_OOB_AUTO puts/gets the given oob data automaticaly to/from the places in
    the out of band area which are described by the oobfree tuples in the ecclayout
    data structre which is associated to the devicee.

    The decision whether data plus oob or oob only handling is done depends on the
    setting of the datbuf member of the data structure. When datbuf == NULL then
    the internal read/write_oob functions are selected, otherwise the read/write
    data routines are invoked.

    Tested on a few platforms with all variants. Please be aware of possible
    regressions for your particular device / application scenario

    Disclaimer: Any whining will be ignored from those who just contributed "hot
    air blurb" and never sat down to tackle the underlying problem of the mess in
    the NAND driver grown over time and the big chunk of work to fix up the
    existing users. The problem was not the holiness of the existing MTD
    interfaces. The problems was the lack of time to go for the big overhaul. It's
    easy to add more mess to the existing one, but it takes alot of effort to go
    for a real solution.

    Improvements and bugfixes are welcome!

    Signed-off-by: Thomas Gleixner

    Thomas Gleixner
     
  • f4a43cfce   [MTD] Remove silly MTD_WRITE/READ macros ... Browse Code »

    Most of those macros are unused and the used ones just obfuscate
    the code. Remove them and fixup all users.

    Signed-off-by: Thomas Gleixner

    Thomas Gleixner
     

23 May, 2006

1 commit

08 Nov, 2005

1 commit

07 Nov, 2005

2 commits

17 Apr, 2005

1 commit

  • 1da177e4c   Linux-2.6.12-rc2 ... Browse Code »

    Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds