30 Nov, 2011
2 commits
-
There are two potential integer overflows in private_ioctl() if
userspace passes in a large sList.uItem / sNodeList.uItem. The
subsequent call to kmalloc() would allocate a small buffer, leading
to a memory corruption.Reported-by: Dan Rosenberg
Signed-off-by: Xi Wang
Signed-off-by: Greg Kroah-Hartman -
Removed the function iwctl_giwnwid, that just return a error code.
Changes v1 to v2:
Removed same functions of vt6655 and vt6656.Signed-off-by: Marcos Paulo de Souza
Signed-off-by: Greg Kroah-Hartman
26 Oct, 2011
1 commit
-
* 'staging-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: (1519 commits)
staging: et131x: Remove redundant check and return statement
staging: et131x: Mainly whitespace changes to appease checkpatch
staging: et131x: Remove last of the forward declarations
staging: et131x: Remove even more forward declarations
staging: et131x: Remove yet more forward declarations
staging: et131x: Remove more forward declarations
staging: et131x: Remove forward declaration of et131x_adapter_setup
staging: et131x: Remove some forward declarations
staging: et131x: Remove unused rx_ring.recv_packet_pool
staging: et131x: Remove call to find pci pm capability
staging: et131x: Remove redundant et131x_reset_recv() call
staging: et131x: Remove unused rx_ring.recv_buffer_pool
Staging: bcm: Fix three initialization errors in InterfaceDld.c
Staging: bcm: Fix coding style issues in InterfaceDld.c
staging:iio:dac: Add AD5360 driver
staging:iio:trigger:bfin-timer: Fix compile error
Staging: vt6655: add some range checks before memcpy()
Staging: vt6655: whitespace fixes to iotcl.c
Staging: vt6656: add some range checks before memcpy()
Staging: vt6656: whitespace cleanups in ioctl.c
...Fix up conflicts in:
- drivers/{Kconfig,Makefile}, drivers/staging/{Kconfig,Makefile}:
vg driver movement
- drivers/staging/brcm80211/brcmfmac/{dhd_linux.c,mac80211_if.c}:
driver removal vs now stale changes
- drivers/staging/rtl8192e/r8192E_core.c:
driver removal vs now stale changes
- drivers/staging/et131x/et131*:
driver consolidation into one file, tried to do fixups
23 Oct, 2011
2 commits
-
There were no range checks in the original code so the user could
write past the end of the array.Signed-off-by: Dan Carpenter
Signed-off-by: Greg Kroah-Hartman -
The indents didn't line up at all in the original code. I also fixed
a bunch of other white issues as I went along. I changed the comment
style and removed some commented out code.Signed-off-by: Dan Carpenter
Signed-off-by: Greg Kroah-Hartman
20 Oct, 2011
1 commit
-
The original code left it up to the user to decide how much data to
copy, but that doesn't work with a fixed size array.Signed-off-by: Dan Carpenter
Signed-off-by: Greg Kroah-Hartman
27 Sep, 2011
1 commit
-
Smatch has a new check for Rosenberg type information leaks where
structs are copied to the user with uninitialized stack data in them.In this path, the .uLinkRate member doesn't get initialized so I've
set it to zero.Signed-off-by: Dan Carpenter
Signed-off-by: Greg Kroah-Hartman
24 Aug, 2011
2 commits
-
Signed-off-by: Andy Shevchenko
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Toon Schoenmakers
Signed-off-by: Greg Kroah-Hartman
18 Aug, 2011
1 commit
-
replace it by ndo_set_rx_mode
Signed-off-by: Jiri Pirko
Signed-off-by: David S. Miller
07 May, 2011
1 commit
-
If staging:vt6655 is built without CONFIG_DM being defined, there are large
numbers of warnings of the following form due to use of #if instead of #ifdef:In file included from drivers/staging/vt6655/upc.h:32,
from drivers/staging/vt6655/mac.h:39,
from drivers/staging/vt6655/wroute.c:34:
drivers/staging/vt6655/device.h:399:5: warning: "CONFIG_PM" is not definedSigned-off-by: Larry Finger
Signed-off-by: Greg Kroah-Hartman
26 Apr, 2011
3 commits
-
Done via perl script:
$ cat remove_semi_switch.pl
my $match_balanced_parentheses = qr/(\((?:[^\(\)]++|(?-1))*\))/;
my $match_balanced_braces = qr/(\{(?:[^\{\}]++|(?-1))*\})/;foreach my $file (@ARGV) {
my $f;
my $text;
my $oldtext;next if ((-d $file));
open($f, '
Signed-off-by: Greg Kroah-Hartman -
Done via perl script:
$ cat remove_semi_for.pl
my $match_balanced_parentheses = qr/(\((?:[^\(\)]++|(?-1))*\))/;
my $match_balanced_braces = qr/(\{(?:[^\{\}]++|(?-1))*\})/;foreach my $file (@ARGV) {
my $f;
my $text;
my $oldtext;next if ((-d $file));
open($f, '
Signed-off-by: Greg Kroah-Hartman -
Done via perl script:
$ cat remove_semi_if.pl
my $match_balanced_parentheses = qr/(\((?:[^\(\)]++|(?-1))*\))/;
my $match_balanced_braces = qr/(\{(?:[^\{\}]++|(?-1))*\})/;foreach my $file (@ARGV) {
my $f;
my $text;
my $oldtext;next if ((-d $file));
open($f, '
Signed-off-by: Greg Kroah-Hartman
08 Apr, 2011
1 commit
-
* 'staging-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6: (28 commits)
staging: usbip: bugfix for isochronous packets and optimization
staging: usbip: bugfix add number of packets for isochronous frames
staging: usbip: bugfixes related to kthread conversion
staging: usbip: fix shutdown problems.
staging: hv: Fix GARP not sent after Quick Migration
staging: IIO: IMU: ADIS16400: Avoid using printk facility directly
staging: IIO: IMU: ADIS16400: Fix product ID check, skip embedded revision number
staging: IIO: IMU: ADIS16400: Make sure only enabled scan_elements are pushed into the ring
staging: IIO: IMU: ADIS16400: Fix addresses of GYRO and ACCEL calibration offset
staging: IIO: IMU: ADIS16400: Add delay after self test
staging: IIO: IMU: ADIS16400: Fix up SPI messages cs_change behavior
staging/rtl81*: build as loadable modules only
staging: brcm80211: removed 'is_amsdu causing toss' log spam
staging: brcm80211: fix for 'Short CCK' log spam
staging: brcm80211: fix for 'AC_BE txop..' logs spammed problem
staging: memrar: remove driver from tree
staging: sep: remove last memrar remnants
staging: fix hv_mouse build, needs delay.h
staging: fix olpc_dcon build errors
staging: sm7xx: fixed defines
...Fix up trivial conflict in drivers/staging/memrar/memrar_handler.c
(deleted vs trivial spelling fixes)
05 Apr, 2011
1 commit
-
It causes lots of linking errors when both of these modules are built into the
kernel directly due to their global symbol mess.Reported-by: Linus Torvalds
Signed-off-by: Greg Kroah-Hartman
31 Mar, 2011
1 commit
-
Fixes generated by 'codespell' and manually reviewed.
Signed-off-by: Lucas De Marchi
15 Mar, 2011
1 commit
-
This patch was generated by the following semantic patch:
//
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
//Signed-off-by: Ilia Mirkin
Signed-off-by: Greg Kroah-Hartman
01 Mar, 2011
1 commit
-
The patch below removes an extra "l" in the word.
Signed-off-by: Justin P. Mattock
Signed-off-by: Greg Kroah-Hartman
22 Jan, 2011
1 commit
-
This patch fixes the sparse warnings
"obsolete struct initializer, use C99 syntax" in vt6655/device_main.c
by converting the struct to C99 syntaxKernelVersion: linux-next-20110110
Signed-off-by: Peter Huewe
Signed-off-by: Greg Kroah-Hartman
17 Nov, 2010
1 commit
-
Signed-off-by: Joe Perches
Signed-off-by: Greg Kroah-Hartman
29 Oct, 2010
1 commit
-
This merges the staging-next tree to Linus's tree and resolves
some conflicts that were present due to changes in other trees that were
affected by files here.Signed-off-by: Greg Kroah-Hartman
06 Oct, 2010
1 commit
-
Changed to use the proper ccflags-y option
Signed-off-by: Tracey Dent
Acked-by: Sam Ravnborg
Signed-off-by: Greg Kroah-Hartman
21 Sep, 2010
3 commits
-
Signed-off-by: Charles Clément
Signed-off-by: Greg Kroah-Hartman -
"param->u.wpa_associate.wpa_ie_len" comes from the user. We should
check it so that the copy_from_user() doesn't overflow the buffer.Also further down in the function, we assume that if
"param->u.wpa_associate.wpa_ie_len" is set then "abyWPAIE[0]" is
initialized. To make that work, I changed the test here to say that if
"wpa_ie_len" is set then "wpa_ie" has to be a valid pointer or we return
-EINVAL.Oddly, we only use the first element of the abyWPAIE[] array. So I
suspect there may be some other issues in this function.Signed-off-by: Dan Carpenter
Cc: stable
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Andy Shevchenko
Signed-off-by: Greg Kroah-Hartman
17 Sep, 2010
2 commits
-
Signed-off-by: Charles Clément
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Andy Shevchenko
Signed-off-by: Greg Kroah-Hartman
01 Sep, 2010
2 commits
-
An error code is stored in a variable, but 0 is returned instead. Use the
variable instead of 0.The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)//
@r@
local idexpression x;
constant C;
@@if (...) { ...
x = -C
... when != x
(
return ;
|
return NULL;
|
return;
|
* return ...;
)
}
//Signed-off-by: Julia Lawall
Signed-off-by: Greg Kroah-Hartman -
IRQ and resource[] may not have correct values until
after PCI hotplug setup occurs at pci_enable_device() time.The semantic match that finds this problem is as follows:
//
@@
identifier x;
identifier request ~= "pci_request.*|pci_resource.*";
@@(
* x->irq
|
* x->resource
|
* request(x, ...)
)
...
*pci_enable_device(x)
//Signed-off-by: Kulikov Vasiliy
Signed-off-by: Greg Kroah-Hartman
03 Aug, 2010
3 commits
-
Signed-off-by: Charles Clément
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Charles Clément
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Charles Clément
Signed-off-by: Greg Kroah-Hartman
09 Jul, 2010
2 commits
-
Use for_each_pci_dev() to simplify the code.
Signed-off-by: Kulikov Vasiliy
Signed-off-by: Greg Kroah-Hartman -
A broadcast address is also a multicast address so simplify test cases where
possible.As suggested by Joe Perches.
Signed-off-by: Charles Clément
Signed-off-by: Greg Kroah-Hartman
26 Jun, 2010
2 commits
-
As suggested by Jiri Slaby.
Signed-off-by: Charles Clément
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Charles Clément
Signed-off-by: Greg Kroah-Hartman
25 Jun, 2010
3 commits
-
Replace all occurrences with unsigned char type.
Signed-off-by: Charles Clément
Signed-off-by: Greg Kroah-Hartman -
Replace all occurrences with unsigned short type.
Signed-off-by: Charles Clément
Signed-off-by: Greg Kroah-Hartman -
Replace all occurrences with unsigned long type, except for pointer fields that
should be u32 in packed structures and 8-byte-aligned 8 byte long structure
QWORD.Thanks to Jiri Slaby for pointing out that simply replacing by unsigned long is
wrong on x86-64 arch.Signed-off-by: Charles Clément
Signed-off-by: Greg Kroah-Hartman