27 Apr, 2016
1 commit
-
It has a DRIVER_MODESET check to sure make it's not creating havoc
for drm drivers. Make that clear in the name too.v2: Move misplaced hunk, spotted by 0day and Thierry.
Cc: Thierry Reding
Reviewed-by: Chris Wilson
Acked-by: Alex Deucher
Signed-off-by: Daniel Vetter
Link: http://patchwork.freedesktop.org/patch/msgid/1461691808-12414-2-git-send-email-daniel.vetter@ffwll.ch
30 Sep, 2015
2 commits
-
They're only used in the drm ioctl table, and there they're excluded
when AGP support is disabled. So this is just dead code ripe for
removal.Reviewed-by: David Herrmann
Signed-off-by: Daniel Vetter -
We already express the drm/agp depencies correctly in Kconfig, so we
can rip this remnant from the shared drm core days.Aside: Pretty much all the #ifdefs in radeon/nouveau could be killed
if ttm would provide dummy functions. I'm not going to volunteer for
that though.v2: Use IS_ENABLED(CONFIG_AGP) as suggested by Ville
v3: Polish from Ville's review.
Cc: Ville Syrjälä
Reviewed-by: Ville Syrjälä
Reviewed-by: Christian König (v2)
Reviewed-by: David Herrmann
Signed-off-by: Daniel Vetter
10 Sep, 2014
3 commits
-
Including headers somewhere else but at the top is ugly, deprecated and
was used in early days only to speed up compile-times. Those days are
over. Make headers independent and then move the inclusions to the top.Signed-off-by: David Herrmann
Reviewed-by: Thierry Reding
Signed-off-by: Dave Airlie -
With drm_memory.h gone, there is no header left that uses __OS_HAS_AGP.
Move it into drm_agpsupport.h (which is itself included from drmP.h) to
hide it harder from public eyes.Signed-off-by: David Herrmann
Signed-off-by: Dave Airlie -
Move drm_agp_head to drm_agpsupport.h and drm_agp_mem into drm_legacy.h.
Unfortunately, drivers still heavily access drm_agp_head so we cannot
move it to drm_legacy.h. However, at least it's no longer visible in
drmP.h now (it's directly included from it, though).Signed-off-by: David Herrmann
Reviewed-by: Thierry Reding
Signed-off-by: Dave Airlie
18 Dec, 2013
3 commits
-
The header provides dummy functions and
fallbacks, so no need for screaming macros.Signed-off-by: Daniel Vetter
Signed-off-by: Dave Airlie -
Wrapping a kfree is pointless.
v2: Add a comment to the kerneldoc for drm_agp_init to explain where
the kfree happens as requested by David. Note that for modeset drivers
agp cleanup is fairly complicated anyway: The drm_agp_clear is a noop
and drivers must call drm_agp_release on their own. Which they all
seem to do properly.Cc: David Herrmann
Reviewed-by: David Herrmann
Signed-off-by: Daniel Vetter
Signed-off-by: Dave Airlie -
Most place actually want to just check for dev->agp (most do, but a
few don't so this fixes a few potential NULL derefs). The only
exception is the agp init code which should check for the AGP driver
feature flag.Signed-off-by: Daniel Vetter
Signed-off-by: Dave Airlie
09 Aug, 2013
1 commit
-
We currently rely on gcc dead-code elimination so the drm_agp_* helpers
are not called if drm_core_has_AGP() is false. That's ugly as hell so
provide "static inline" dummies for the case that AGP is disabled.Fixes a build-regression introduced by:
commit 28ec711cd427f8b61f73712a43b8100ba8ca933b
Author: David Herrmann
Date: Sat Jul 27 16:37:00 2013 +0200drm/agp: move AGP cleanup paths to drm_agpsupport.c
v2: switch #ifdef -> #if (spotted by Stephen)
Cc: Laurent Pinchart
Cc: Daniel Vetter
Tested-by: Stephen Warren
Signed-off-by: David Herrmann
Signed-off-by: Dave Airlie