30 Dec, 2020

2 commits

  • commit 20f1431160c6b590cdc269a846fc5a448abf5b98 upstream.

    Write buffers use a kmalloc()'ed buffer, they can leak
    up to seven bytes of kernel memory to flash if writes are not
    aligned.
    So use ubifs_pad() to fill these gaps with padding bytes.
    This was never a problem while scanning because the scanner logic
    manually aligns node lengths and skips over these gaps.

    Cc:
    Fixes: 1e51764a3c2ac05a2 ("UBIFS: add new flash file system")
    Signed-off-by: Richard Weinberger
    Reviewed-by: Zhihao Cheng
    Signed-off-by: Richard Weinberger
    Signed-off-by: Greg Kroah-Hartman

    Richard Weinberger
     
  • [ Upstream commit 3cded66330591cfd2554a3fd5edca8859ea365a2 ]

    Fix to return PTR_ERR() error code from the error handling case where
    ubifs_hash_get_desc() failed instead of 0 in ubifs_init_authentication(),
    as done elsewhere in this function.

    Fixes: 49525e5eecca5 ("ubifs: Add helper functions for authentication support")
    Signed-off-by: Wang ShaoBo
    Reviewed-by: Sascha Hauer
    Signed-off-by: Richard Weinberger
    Signed-off-by: Sasha Levin

    Wang ShaoBo
     

26 Dec, 2020

1 commit

  • commit 76786a0f083473de31678bdb259a3d4167cf756d upstream.

    As described in "fscrypt: add fscrypt_is_nokey_name()", it's possible to
    create a duplicate filename in an encrypted directory by creating a file
    concurrently with adding the directory's encryption key.

    Fix this bug on ubifs by rejecting no-key dentries in ubifs_create(),
    ubifs_mkdir(), ubifs_mknod(), and ubifs_symlink().

    Note that ubifs doesn't actually report the duplicate filenames from
    readdir, but rather it seems to replace the original dentry with a new
    one (which is still wrong, just a different effect from ext4).

    On ubifs, this fixes xfstest generic/595 as well as the new xfstest I
    wrote specifically for this bug.

    Fixes: f4f61d2cc6d8 ("ubifs: Implement encrypted filenames")
    Cc: stable@vger.kernel.org
    Link: https://lore.kernel.org/r/20201118075609.120337-5-ebiggers@kernel.org
    Signed-off-by: Eric Biggers
    Signed-off-by: Greg Kroah-Hartman

    Eric Biggers
     

19 Oct, 2020

2 commits

  • Pull more ubi and ubifs updates from Richard Weinberger:
    "UBI:
    - Correctly use kthread_should_stop in ubi worker

    UBIFS:
    - Fixes for memory leaks while iterating directory entries
    - Fix for a user triggerable error message
    - Fix for a space accounting bug in authenticated mode"

    * tag 'for-linus-5.10-rc1-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs:
    ubifs: journal: Make sure to not dirty twice for auth nodes
    ubifs: setflags: Don't show error message when vfs_ioc_setflags_prepare() fails
    ubifs: ubifs_jnl_change_xattr: Remove assertion 'nlink > 0' for host inode
    ubi: check kthread_should_stop() after the setting of task state
    ubifs: dent: Fix some potential memory leaks while iterating entries
    ubifs: xattr: Fix some potential memory leaks while iterating entries

    Linus Torvalds
     
  • Pull ubifs updates from Richard Weinberger:

    - Kernel-doc fixes

    - Fixes for memory leaks in authentication option parsing

    * tag 'for-linus-5.10-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs:
    ubifs: mount_ubifs: Release authentication resource in error handling path
    ubifs: Don't parse authentication mount options in remount process
    ubifs: Fix a memleak after dumping authentication mount options
    ubifs: Fix some kernel-doc warnings in tnc.c
    ubifs: Fix some kernel-doc warnings in replay.c
    ubifs: Fix some kernel-doc warnings in gc.c
    ubifs: Fix 'hash' kernel-doc warning in auth.c

    Linus Torvalds
     

14 Oct, 2020

1 commit

  • Pull block updates from Jens Axboe:

    - Series of merge handling cleanups (Baolin, Christoph)

    - Series of blk-throttle fixes and cleanups (Baolin)

    - Series cleaning up BDI, seperating the block device from the
    backing_dev_info (Christoph)

    - Removal of bdget() as a generic API (Christoph)

    - Removal of blkdev_get() as a generic API (Christoph)

    - Cleanup of is-partition checks (Christoph)

    - Series reworking disk revalidation (Christoph)

    - Series cleaning up bio flags (Christoph)

    - bio crypt fixes (Eric)

    - IO stats inflight tweak (Gabriel)

    - blk-mq tags fixes (Hannes)

    - Buffer invalidation fixes (Jan)

    - Allow soft limits for zone append (Johannes)

    - Shared tag set improvements (John, Kashyap)

    - Allow IOPRIO_CLASS_RT for CAP_SYS_NICE (Khazhismel)

    - DM no-wait support (Mike, Konstantin)

    - Request allocation improvements (Ming)

    - Allow md/dm/bcache to use IO stat helpers (Song)

    - Series improving blk-iocost (Tejun)

    - Various cleanups (Geert, Damien, Danny, Julia, Tetsuo, Tian, Wang,
    Xianting, Yang, Yufen, yangerkun)

    * tag 'block-5.10-2020-10-12' of git://git.kernel.dk/linux-block: (191 commits)
    block: fix uapi blkzoned.h comments
    blk-mq: move cancel of hctx->run_work to the front of blk_exit_queue
    blk-mq: get rid of the dead flush handle code path
    block: get rid of unnecessary local variable
    block: fix comment and add lockdep assert
    blk-mq: use helper function to test hw stopped
    block: use helper function to test queue register
    block: remove redundant mq check
    block: invoke blk_mq_exit_sched no matter whether have .exit_sched
    percpu_ref: don't refer to ref->data if it isn't allocated
    block: ratelimit handle_bad_sector() message
    blk-throttle: Re-use the throtl_set_slice_end()
    blk-throttle: Open code __throtl_de/enqueue_tg()
    blk-throttle: Move service tree validation out of the throtl_rb_first()
    blk-throttle: Move the list operation after list validation
    blk-throttle: Fix IO hang for a corner case
    blk-throttle: Avoid tracking latency if low limit is invalid
    blk-throttle: Avoid getting the current time if tg->last_finish_time is 0
    blk-throttle: Remove a meaningless parameter for throtl_downgrade_state()
    block: Remove redundant 'return' statement
    ...

    Linus Torvalds
     

12 Oct, 2020

3 commits


29 Sep, 2020

1 commit

  • When removing the last reference of an inode the size of an auth node
    is already part of write_len. So we must not call ubifs_add_auth_dirt().
    Call it only when needed.

    Cc:
    Cc: Sascha Hauer
    Cc: Kristof Havasi
    Fixes: 6a98bc4614de ("ubifs: Add authentication nodes to journal")
    Reported-and-tested-by: Kristof Havasi
    Reviewed-by: Sascha Hauer
    Signed-off-by: Richard Weinberger

    Richard Weinberger
     

25 Sep, 2020

1 commit

  • Set up a readahead size by default, as very few users have a good
    reason to change it. This means code, ecryptfs, and orangefs now
    set up the values while they were previously missing it, while ubifs,
    mtd and vboxsf manually set it to 0 to avoid readahead.

    Signed-off-by: Christoph Hellwig
    Reviewed-by: Jan Kara
    Acked-by: David Sterba [btrfs]
    Acked-by: Richard Weinberger [ubifs, mtd]
    Signed-off-by: Jens Axboe

    Christoph Hellwig
     

22 Sep, 2020

1 commit

  • Convert ubifs to use the new functions fscrypt_prepare_new_inode() and
    fscrypt_set_context().

    Unlike ext4 and f2fs, this doesn't appear to fix any deadlock bug. But
    it does shorten the code slightly and get all filesystems using the same
    helper functions, so that fscrypt_inherit_context() can be removed.

    It also fixes an incorrect error code where ubifs returned EPERM instead
    of the expected ENOKEY.

    Link: https://lore.kernel.org/r/20200917041136.178600-6-ebiggers@kernel.org
    Signed-off-by: Eric Biggers

    Eric Biggers
     

18 Sep, 2020

8 commits

  • Fixes the following W=1 kernel build warning(s):

    fs/ubifs/tnc.c:3479: warning: Excess function parameter 'inum' description in 'dbg_check_inode_size'
    fs/ubifs/tnc.c:366: warning: Excess function parameter 'node' description in 'lnc_free'

    @inum in 'dbg_check_inode_size' should be @inode, fix it.
    @node in 'lnc_free' is not in use, Remove it.

    Reported-by: Hulk Robot
    Signed-off-by: Wang Hai
    Signed-off-by: Richard Weinberger

    Wang Hai
     
  • Fixes the following W=1 kernel build warning(s):

    fs/ubifs/replay.c:942: warning: Excess function parameter 'ref_lnum' description in 'validate_ref'
    fs/ubifs/replay.c:942: warning: Excess function parameter 'ref_offs' description in 'validate_ref'

    They're not in use. Remove them.

    Reported-by: Hulk Robot
    Signed-off-by: Wang Hai
    Signed-off-by: Richard Weinberger

    Wang Hai
     
  • Fixes the following W=1 kernel build warning(s):

    fs/ubifs/gc.c:70: warning: Excess function parameter 'buf' description in 'switch_gc_head'
    fs/ubifs/gc.c:70: warning: Excess function parameter 'len' description in 'switch_gc_head'
    fs/ubifs/gc.c:70: warning: Excess function parameter 'lnum' description in 'switch_gc_head'
    fs/ubifs/gc.c:70: warning: Excess function parameter 'offs' description in 'switch_gc_head'

    They're not in use. Remove them.

    Reported-by: Hulk Robot
    Signed-off-by: Wang Hai
    Signed-off-by: Richard Weinberger

    Wang Hai
     
  • Fixes the following W=1 kernel build warning(s):

    fs/ubifs/auth.c:66: warning: Excess function parameter 'hash' description in 'ubifs_prepare_auth_node'

    Rename hash to inhash.

    Reported-by: Hulk Robot
    Signed-off-by: Wang Hai
    Signed-off-by: Richard Weinberger

    Wang Hai
     
  • Following process will trigger ubifs_err:
    1. useradd -m freg (Under root)
    2. cd /home/freg && mkdir mp (Under freg)
    3. mount -t ubifs /dev/ubi0_0 /home/freg/mp (Under root)
    4. cd /home/freg && echo 123 > mp/a (Under root)
    5. cd mp && chown freg a && chgrp freg a && chmod 777 a (Under root)
    6. chattr +i a (Under freg)

    UBIFS error (ubi0:0 pid 1723): ubifs_ioctl [ubifs]: can't modify inode
    65 attributes
    chattr: Operation not permitted while setting flags on a

    This is not an UBIFS problem, it was caused by task priviliage checking
    on file operations. Remove error message printing from kernel just like
    other filesystems (eg. ext4), since we already have enough information
    from userspace tools.

    Signed-off-by: Zhihao Cheng
    Signed-off-by: Richard Weinberger

    Zhihao Cheng
     
  • Changing xattr of a temp file will trigger following assertion failed
    and make ubifs turn into readonly filesystem:
    ubifs_assert_failed [ubifs]: UBIFS assert failed: host->i_nlink > 0,
    in fs/ubifs/journal.c:1801

    Reproducer:
    1. fd = open(__O_TMPFILE)
    2. fsetxattr(fd, key, value2, XATTR_CREATE)
    3. fsetxattr(fd, key, value2, XATTR_REPLACE)

    Fix this by removing assertion 'nlink > 0' for host inode.

    Reported-by: Chengsong Ke
    Signed-off-by: Zhihao Cheng
    Signed-off-by: Richard Weinberger

    Zhihao Cheng
     
  • Fix some potential memory leaks in error handling branches while
    iterating dent entries. For example, function dbg_check_dir()
    forgets to free pdent if it exists.

    Signed-off-by: Zhihao Cheng
    Cc:
    Fixes: 1e51764a3c2ac05a2 ("UBIFS: add new flash file system")
    Signed-off-by: Richard Weinberger

    Zhihao Cheng
     
  • Fix some potential memory leaks in error handling branches while
    iterating xattr entries. For example, function ubifs_tnc_remove_ino()
    forgets to free pxent if it exists. Similar problems also exist in
    ubifs_purge_xattrs(), ubifs_add_orphan() and ubifs_jnl_write_inode().

    Signed-off-by: Zhihao Cheng
    Cc:
    Fixes: 1e51764a3c2ac05a2 ("UBIFS: add new flash file system")
    Signed-off-by: Richard Weinberger

    Zhihao Cheng
     

08 Sep, 2020

1 commit


24 Aug, 2020

1 commit

  • Replace the existing /* fall through */ comments and its variants with
    the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
    fall-through markings when it is the case.

    [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

    Signed-off-by: Gustavo A. R. Silva

    Gustavo A. R. Silva
     

11 Aug, 2020

1 commit

  • Pull JFFS2, UBI and UBIFS updates from Richard Weinberger:
    "JFFS2:
    - Fix for a corner case while mounting
    - Fix for an use-after-free issue

    UBI:
    - Fix for a memory load while attaching
    - Don't produce an anchor PEB with fastmap being disabled

    UBIFS:
    - Fix for orphan inode logic
    - Spelling fixes
    - New mount option to specify filesystem version"

    * tag 'for-linus-5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs:
    jffs2: fix UAF problem
    jffs2: fix jffs2 mounting failure
    ubifs: Fix wrong orphan node deletion in ubifs_jnl_update|rename
    ubi: fastmap: Free fastmap next anchor peb during detach
    ubi: fastmap: Don't produce the initial next anchor PEB when fastmap is disabled
    ubifs: misc.h: delete a duplicated word
    ubifs: add option to specify version for new file systems

    Linus Torvalds
     

03 Aug, 2020

3 commits

  • There a wrong orphan node deleting in error handling path in
    ubifs_jnl_update() and ubifs_jnl_rename(), which may cause
    following error msg:

    UBIFS error (ubi0:0 pid 1522): ubifs_delete_orphan [ubifs]:
    missing orphan ino 65

    Fix this by checking whether the node has been operated for
    adding to orphan list before being deleted,

    Signed-off-by: Zhihao Cheng
    Fixes: 823838a486888cf484e ("ubifs: Add hashes to the tree node cache")
    Signed-off-by: Richard Weinberger

    Zhihao Cheng
     
  • Drop the repeated word "as" in a comment.

    Signed-off-by: Randy Dunlap
    Cc: Richard Weinberger
    Cc: linux-mtd@lists.infradead.org
    Signed-off-by: Richard Weinberger

    Randy Dunlap
     
  • Instead of creating ubifs file systems with UBIFS_FORMAT_VERSION
    by default, add a module parameter ubifs.default_version to allow
    the user to specify the desired version. Valid values are 4 to
    UBIFS_FORMAT_VERSION (currently 5).

    This way, one can for example create a file system with version 4
    on kernel 4.19 which can still be mounted rw when downgrading to
    kernel 4.9.

    Signed-off-by: Martin Kaistra
    Signed-off-by: Richard Weinberger

    Martin Kaistra
     

17 Jul, 2020

1 commit

  • Using uninitialized_var() is dangerous as it papers over real bugs[1]
    (or can in the future), and suppresses unrelated compiler warnings
    (e.g. "unused variable"). If the compiler thinks it is uninitialized,
    either simply initialize the variable or make compiler changes.

    In preparation for removing[2] the[3] macro[4], remove all remaining
    needless uses with the following script:

    git grep '\buninitialized_var\b' | cut -d: -f1 | sort -u | \
    xargs perl -pi -e \
    's/\buninitialized_var\(([^\)]+)\)/\1/g;
    s:\s*/\* (GCC be quiet|to make compiler happy) \*/$::g;'

    drivers/video/fbdev/riva/riva_hw.c was manually tweaked to avoid
    pathological white-space.

    No outstanding warnings were found building allmodconfig with GCC 9.3.0
    for x86_64, i386, arm64, arm, powerpc, powerpc64le, s390x, mips, sparc64,
    alpha, and m68k.

    [1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/
    [2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/
    [3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/
    [4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/

    Reviewed-by: Leon Romanovsky # drivers/infiniband and mlx4/mlx5
    Acked-by: Jason Gunthorpe # IB
    Acked-by: Kalle Valo # wireless drivers
    Reviewed-by: Chao Yu # erofs
    Signed-off-by: Kees Cook

    Kees Cook
     

03 Jun, 2020

1 commit

  • The pgprot argument to __vmalloc is always PAGE_KERNEL now, so remove it.

    Signed-off-by: Christoph Hellwig
    Signed-off-by: Andrew Morton
    Reviewed-by: Michael Kelley [hyperv]
    Acked-by: Gao Xiang [erofs]
    Acked-by: Peter Zijlstra (Intel)
    Acked-by: Wei Liu
    Cc: Christian Borntraeger
    Cc: Christophe Leroy
    Cc: Daniel Vetter
    Cc: David Airlie
    Cc: Greg Kroah-Hartman
    Cc: Haiyang Zhang
    Cc: Johannes Weiner
    Cc: "K. Y. Srinivasan"
    Cc: Laura Abbott
    Cc: Mark Rutland
    Cc: Minchan Kim
    Cc: Nitin Gupta
    Cc: Robin Murphy
    Cc: Sakari Ailus
    Cc: Stephen Hemminger
    Cc: Sumit Semwal
    Cc: Benjamin Herrenschmidt
    Cc: Catalin Marinas
    Cc: Heiko Carstens
    Cc: Paul Mackerras
    Cc: Vasily Gorbik
    Cc: Will Deacon
    Link: http://lkml.kernel.org/r/20200414131348.444715-22-hch@lst.de
    Signed-off-by: Linus Torvalds

    Christoph Hellwig
     

02 Jun, 2020

1 commit

  • Pull crypto updates from Herbert Xu:
    "API:
    - Introduce crypto_shash_tfm_digest() and use it wherever possible.
    - Fix use-after-free and race in crypto_spawn_alg.
    - Add support for parallel and batch requests to crypto_engine.

    Algorithms:
    - Update jitter RNG for SP800-90B compliance.
    - Always use jitter RNG as seed in drbg.

    Drivers:
    - Add Arm CryptoCell driver cctrng.
    - Add support for SEV-ES to the PSP driver in ccp"

    * 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6: (114 commits)
    crypto: hisilicon - fix driver compatibility issue with different versions of devices
    crypto: engine - do not requeue in case of fatal error
    crypto: cavium/nitrox - Fix a typo in a comment
    crypto: hisilicon/qm - change debugfs file name from qm_regs to regs
    crypto: hisilicon/qm - add DebugFS for xQC and xQE dump
    crypto: hisilicon/zip - add debugfs for Hisilicon ZIP
    crypto: hisilicon/hpre - add debugfs for Hisilicon HPRE
    crypto: hisilicon/sec2 - add debugfs for Hisilicon SEC
    crypto: hisilicon/qm - add debugfs to the QM state machine
    crypto: hisilicon/qm - add debugfs for QM
    crypto: stm32/crc32 - protect from concurrent accesses
    crypto: stm32/crc32 - don't sleep in runtime pm
    crypto: stm32/crc32 - fix multi-instance
    crypto: stm32/crc32 - fix run-time self test issue.
    crypto: stm32/crc32 - fix ext4 chksum BUG_ON()
    crypto: hisilicon/zip - Use temporary sqe when doing work
    crypto: hisilicon - add device error report through abnormal irq
    crypto: hisilicon - remove codes of directly report device errors through MSI
    crypto: hisilicon - QM memory management optimization
    crypto: hisilicon - unify initial value assignment into QM
    ...

    Linus Torvalds
     

18 May, 2020

1 commit

  • crypto_shash_descsize() returns the size of the shash_desc context
    needed to compute the hash, not the size of the hash itself.

    crypto_shash_digestsize() would be correct, or alternatively using
    c->hash_len and c->hmac_desc_len which already store the correct values.
    But actually it's simpler to just use stack arrays, so do that instead.

    Fixes: 49525e5eecca ("ubifs: Add helper functions for authentication support")
    Fixes: da8ef65f9573 ("ubifs: Authenticate replayed journal")
    Cc: # v4.20+
    Cc: Sascha Hauer
    Signed-off-by: Eric Biggers
    Acked-by: Sascha Hauer
    Signed-off-by: Richard Weinberger

    Eric Biggers
     

08 May, 2020

1 commit

  • Instead of manually allocating a 'struct shash_desc' on the stack and
    calling crypto_shash_digest(), switch to using the new helper function
    crypto_shash_tfm_digest() which does this for us.

    Cc: linux-mtd@lists.infradead.org
    Signed-off-by: Eric Biggers
    Signed-off-by: Herbert Xu

    Eric Biggers
     

10 Apr, 2020

1 commit

  • When "ubifs: introduce UBIFS_ATIME_SUPPORT to ubifs" introduced atime
    support to ubifs, it also added lazytime support. As far as I can tell
    the lazytime support is terminally broken, as it causes
    mark_inode_dirty_sync to be called from __writeback_single_inode, which
    will then trigger the locking assert in ubifs_dirty_inode. Just remove
    the broken lazytime support for now, it can be added back later,
    especially as some infrastructure changes should make that easier soon.

    Fixes: 8c1c5f263833 ("ubifs: introduce UBIFS_ATIME_SUPPORT to ubifs")
    Signed-off-by: Christoph Hellwig
    Signed-off-by: Richard Weinberger

    Christoph Hellwig
     

08 Apr, 2020

1 commit

  • Pull UBI and UBIFS updates from Richard Weinberger:

    - Fix for memory leaks around UBIFS orphan handling

    - Fix for memory leaks around UBI fastmap

    - Remove zero-length array from ubi-media.h

    - Fix for TNC lookup in UBIFS orphan code

    * tag 'for-linus-5.7-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs:
    ubi: ubi-media.h: Replace zero-length array with flexible-array member
    ubifs: Fix out-of-bounds memory access caused by abnormal value of node_len
    ubi: fastmap: Only produce the initial anchor PEB when fastmap is used
    ubi: fastmap: Free unused fastmap anchor peb during detach
    ubifs: ubifs_add_orphan: Fix a memory leak bug
    ubifs: ubifs_jnl_write_inode: Fix a memory leak bug
    ubifs: Fix ubifs_tnc_lookup() usage in do_kill_orphans()

    Linus Torvalds
     

31 Mar, 2020

4 commits

  • In “ubifs_check_node”, when the value of "node_len" is abnormal,
    the code will goto label of "out_len" for execution. Then, in the
    following "ubifs_dump_node", if inode type is "UBIFS_DATA_NODE",
    in "print_hex_dump", an out-of-bounds access may occur due to the
    wrong "ch->len".

    Therefore, when the value of "node_len" is abnormal, data length
    should to be adjusted to a reasonable safe range. At this time,
    structured data is not credible, so dump the corrupted data directly
    for analysis.

    Signed-off-by: Liu Song
    Signed-off-by: Richard Weinberger

    Liu Song
     
  • Memory leak occurs when files with extended attributes are added to
    orphan list.

    Signed-off-by: Zhihao Cheng
    Fixes: 988bec41318f3fa897e2f8 ("ubifs: orphan: Handle xattrs like files")
    Signed-off-by: Richard Weinberger

    Zhihao Cheng
     
  • When inodes with extended attributes are evicted, xent is not freed in one
    exit branch.

    Signed-off-by: Zhihao Cheng
    Fixes: 9ca2d732644484488db3112 ("ubifs: Limit number of xattrs per inode")
    Signed-off-by: Richard Weinberger

    Zhihao Cheng
     
  • Orphans are allowed to point to deleted inodes.
    So -ENOENT is not a fatal error.

    Reported-by: Кочетков Максим
    Reported-and-tested-by: "Christian Berger"
    Tested-by: Karl Olsen
    Tested-by: Jef Driesen
    Fixes: ee1438ce5dc4 ("ubifs: Check link count of inodes when killing orphans.")
    Signed-off-by: Richard Weinberger

    Richard Weinberger
     

20 Mar, 2020

1 commit


05 Feb, 2020

1 commit

  • Pull vfs timestamp updates from Al Viro:
    "More 64bit timestamp work"

    * 'imm.timestamp' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
    kernfs: don't bother with timestamp truncation
    fs: Do not overload update_time
    fs: Delete timespec64_trunc()
    fs: ubifs: Eliminate timespec64_trunc() usage
    fs: ceph: Delete timespec64_trunc() usage
    fs: cifs: Delete usage of timespec64_trunc
    fs: fat: Eliminate timespec64_trunc() usage
    utimes: Clamp the timestamps in notify_change()

    Linus Torvalds
     

31 Jan, 2020

1 commit

  • Pull UBI/UBIFS updates from Miquel Raynal:
    "This pull request contains mostly fixes for UBI and UBIFS:

    UBI:
    - Fixes for memory leaks in error paths
    - Fix for an logic error in a fastmap selfcheck

    UBIFS:
    - Fix for FS_IOC_SETFLAGS related to fscrypt flag
    - Support for FS_ENCRYPT_FL
    - Fix for a dead lock in bulk-read mode"

    Sent on behalf of Richard Weinberger who is traveling.

    * tag 'upstream-5.6-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs:
    ubi: Fix an error pointer dereference in error handling code
    ubifs: Fix memory leak from c->sup_node
    ubifs: Fix ino_t format warnings in orphan_delete()
    ubifs: Fix deadlock in concurrent bulk-read and writepage
    ubifs: Fix wrong memory allocation
    ubi: Free the normal volumes in error paths of ubi_attach_mtd_dev()
    ubi: Check the presence of volume before call ubi_fastmap_destroy_checkmap()
    ubifs: Add support for FS_ENCRYPT_FL
    ubifs: Fix FS_IOC_SETFLAGS unexpectedly clearing encrypt flag
    ubi: wl: Remove set but not used variable 'prev_e'
    ubi: fastmap: Fix inverted logic in seen selfcheck

    Linus Torvalds