03 Sep, 2008
5 commits
-
* git://git.kernel.org/pub/scm/linux/kernel/git/bart/ide-2.6:
ide/Kconfig: mark ide-scsi as deprecated
ide-disk: remove stale init_idedisk_capacity() documentation
palm_bk3710: improve IDE registration
ide: fix hwif_to_node()
IDE: palm_bk3710: fix compile warning for unused variable
IDE: compile fix for sff_dma_ops -
Mark ide-scsi as deprecated and remove stale/bogus documentation.
Signed-off-by: Bartlomiej Zolnierkiewicz
-
Acked-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz -
* fix device tree ... don't forget to set the parent device
* let init/exit code be removed where practical
Signed-off-by: David Brownell
[bart: splitted it from bigger DaVinci patch, s/hw.parent/hw.dev/]
Signed-off-by: Bartlomiej Zolnierkiewicz -
Signed-off-by: Kevin Hilman
Signed-off-by: Bartlomiej Zolnierkiewicz
29 Aug, 2008
1 commit
-
This patch remove blk_register_filter and blk_unregister_filter in
gendisk, and adds them to sd.c, sr.c. and ide-cd.cThe commit abf5439370491dd6fbb4fe1a7939680d2a9bc9d4 moved cmdfilter
from gendisk to request_queue. It turned out that in some subsystems
multiple gendisks share a single request_queue. So we get:Using physmap partition information
Creating 3 MTD partitions on "physmap-flash":
0x00000000-0x01c00000 : "User FS"
0x01c00000-0x01c40000 : "booter"
kobject (8511c410): tried to init an initialized object, something is seriously wrong.
Call Trace:
[] dump_stack+0x8/0x34
[] kobject_init+0x50/0xcc
[] kobject_init_and_add+0x24/0x58
[] blk_register_filter+0x4c/0x64
[] add_disk+0x78/0xe0
[] add_mtd_blktrans_dev+0x254/0x278
[] blktrans_notify_add+0x40/0x78
[] add_mtd_device+0xd0/0x150
[] add_mtd_partitions+0x568/0x5d8
[] physmap_flash_probe+0x2ac/0x334
[] driver_probe_device+0x12c/0x244
[] __driver_attach+0x4c/0x84
[] bus_for_each_dev+0x58/0xac
[] bus_add_driver+0xc4/0x24c
[] driver_register+0xcc/0x184
[] _stext+0x60/0x1bcIn the long term, we need to fix such subsystems but we need a quick
fix now. This patch add the command filter support to only sd and sr
though it might be useful for other SG_IO users (such as cciss).Signed-off-by: FUJITA Tomonori
Reported-by: Manuel Lauss
Signed-off-by: Jens Axboe
19 Aug, 2008
3 commits
-
There can be more than one sgiioc4 card in the system so print
also PCI device name on resource allocation failure (so we know
which one is the problematic one).Reported-by: Jeremy Higdon
Signed-off-by: Bartlomiej Zolnierkiewicz -
Change ide-cd to use the new bcd2bin/bin2bcd functions instead of the
obsolete BCD2BIN/BIN2BCD macros.Signed-off-by: Adrian Bunk
Acked-by: Borislav Petkov
Signed-off-by: Andrew Morton
Signed-off-by: Bartlomiej Zolnierkiewicz -
This patch adds missing __devexit_p's.
Reported-by: Russell King
Signed-off-by: Adrian Bunk
Signed-off-by: Bartlomiej Zolnierkiewicz
07 Aug, 2008
3 commits
-
This just leaves include/asm-arm/plat-* to deal with.
Signed-off-by: Russell King
-
There are 43 includes of asm/mach-types.h by files that don't
reference anything from that file. Remove these unnecessary
includes.Signed-off-by: Russell King
06 Aug, 2008
8 commits
-
Now that we have warm-plug support ->cable_detect method no longer
can be be marked __devinit.Signed-off-by: Bartlomiej Zolnierkiewicz
-
Now that we have warm-plug support ->quirkproc method no longer
can be be marked __devinit.Signed-off-by: Bartlomiej Zolnierkiewicz
-
Based on sparse comments in OpenFirmware code
(no Cx5510/Cx5520 datasheet here).This fixes 2.6.26 regression reported by TAKADA
and caused by addition of warm-plug support.Tested-by: TAKADA Yoshihito
Signed-off-by: Bartlomiej Zolnierkiewicz -
Aesthetic regards aside, commit e8e7b9eb11c34ee18bde8b7011af41938d1ad667
still leaves a bug in the error message, because it uses the unconverted
big-endian value for printk.Fix this by using a local variable in machine byte order. The result is
correct, more readable, and also produces slightly shorter code on i386.Signed-off-by: Petr Tesarik
Cc: Jens Axboe
Cc: Jan Kara
Cc: Andrew Morton
Cc:
Acked-by: Borislav Petkov
[bart: __u32 -> u32]
Signed-off-by: Bartlomiej Zolnierkiewicz -
The benefits of a user settable CONFIG_IDE_MAX_HWIFS have become pretty
tiny and are no longer considered worth the trouble of an own option.Simply always #define MAX_HWIFS to 10.
Signed-off-by: Adrian Bunk
Signed-off-by: Bartlomiej Zolnierkiewicz -
On Monday 28 July 2008, Benjamin Herrenschmidt wrote:
[...]
> Vector: 300 (Data Access) at [c58b7b80]
> pc: c014f264: elv_may_queue+0x10/0x44
> lr: c0152750: get_request+0x2c/0x2c0
> sp: c58b7c30
> msr: 1032
> dar: c
> dsisr: 40000000
> current = 0xc58aaae0
> pid = 854, comm = media-bay
> enter ? for help
> mon> t
> [c58b7c40] c0152750 get_request+0x2c/0x2c0
> [c58b7c70] c0152a08 get_request_wait+0x24/0xec
> [c58b7cc0] c0225674 ide_cd_queue_pc+0x58/0x1a0
> [c58b7d40] c022672c ide_cdrom_packet+0x9c/0xdc
> [c58b7d70] c0261810 cdrom_get_disc_info+0x60/0xd0
> [c58b7dc0] c026208c cdrom_mrw_exit+0x1c/0x11c
> [c58b7e30] c0260f7c unregister_cdrom+0x84/0xe8
> [c58b7e50] c022395c ide_cd_release+0x80/0x84
> [c58b7e70] c0163650 kref_put+0x54/0x6c
> [c58b7e80] c0223884 ide_cd_put+0x40/0x5c
> [c58b7ea0] c0211100 generic_ide_remove+0x28/0x3c
> [c58b7eb0] c01e9d34 __device_release_driver+0x78/0xb4
> [c58b7ec0] c01e9e44 device_release_driver+0x28/0x44
> [c58b7ee0] c01e8f7c bus_remove_device+0xac/0xd8
> [c58b7f00] c01e7424 device_del+0x104/0x198
> [c58b7f20] c01e74d0 device_unregister+0x18/0x30
> [c58b7f40] c02121c4 __ide_port_unregister_devices+0x6c/0x88
> [c58b7f60] c0212398 ide_port_unregister_devices+0x38/0x80
> [c58b7f80] c0208ca4 media_bay_step+0x1cc/0x5c0
> [c58b7fb0] c0209124 media_bay_task+0x8c/0xcc
> [c58b7fd0] c00485c0 kthread+0x48/0x84
> [c58b7ff0] c0011b20 kernel_thread+0x44/0x60The guilty commit turned out to be 08da591e14cf87247ec09b17c350235157a92fc3
("ide: add ide_device_{get,put}() helpers"). ide_device_put() is called
before kref_put() in ide_cd_put() so IDE device is already gone by the time
ide_cd_release() is reached.Fix it by calling ide_device_get() before kref_get() and ide_device_put()
after kref_put() in all affected device drivers.v2:
Brown paper bag time. In v1 cd->drive was referenced after dropping last
reference on cd object (which could result in OOPS in ide_device_put() as
reported/debugged by Mariusz Kozlowski). Fix it by caching cd->drive in
the local variable (fix other device drivers too).Reported-by: Benjamin Herrenschmidt
Reported-by: Mariusz Kozlowski
Cc: FUJITA Tomonori
Cc: Borislav Petkov
Tested-by: Mariusz Kozlowski
Tested-by: Benjamin Herrenschmidt
Signed-off-by: Bartlomiej Zolnierkiewicz -
Fix byte-swapping for id->words161_175[], id->words206_254[]
and id->words206_254[].Luckily all words previously left in little-endian byte-order
are marked as reserved so this fix shouldn't affect user-space
applications.Signed-off-by: Bartlomiej Zolnierkiewicz
-
id->tDMA is of 'unsigned char' type so endianness is already
correct and calling le16_to_cpu() is wrong.Signed-off-by: Bartlomiej Zolnierkiewicz
30 Jul, 2008
1 commit
-
The current ide-pmac calls media_bay_set_ide_infos() with an
uninitialized "hwif" argument. The proper fix is to split the
allocation of the hwif from its registration in order to properly
setup the mediabay informations before registration.Acked-by: Bartlomiej Zolnierkiewicz
Signed-off-by: Benjamin Herrenschmidt
25 Jul, 2008
19 commits
-
While at it:
- fixup printk() messages in save_match() and hwif_init().
Signed-off-by: Bartlomiej Zolnierkiewicz
-
IDE probing code used to skip devices attached to EATA SCSI HBA
in ATA emulating mode but because of warm-plug support port I/O
resources are no longer freed if no devices are detected on a port
and the decision about the driver to use is left up to the user.Remove no longer valid EATA SCSI HBA quirk from do_identify().
Noticed-by: Alan Cox
Signed-off-by: Bartlomiej Zolnierkiewicz -
Signed-off-by: Bartlomiej Zolnierkiewicz
-
It is already done by task_no_data_intr() and there is no reason
not to do it in other TASKFILE_NO_DATA data phase handlers.Signed-off-by: Bartlomiej Zolnierkiewicz
-
Remove the ancient version history. Git does a better job.
From: Jan Evert van Grootheest
Signed-off-by: Bartlomiej Zolnierkiewicz -
Update email address.
From: Jan Evert van Grootheest
Signed-off-by: Bartlomiej Zolnierkiewicz -
cdrom_read_capacity() will blindly return the capacity from the device
without sanity-checking it. This later causes code in fs/buffer.c to
oops.Fix this by checking that the device is telling us sensible things.
From: Jens Axboe
Cc: Michael Buesch
Cc: Jan Kara
Cc: Arnd Bergmann
Cc:
Cc: Borislav Petkov
Signed-off-by: Andrew Morton
[bart: print device name instead of driver name]
Signed-off-by: Bartlomiej Zolnierkiewicz
[harvey: blocklen is a big-endian value]
Signed-off-by: Harvey Harrison
Signed-off-by: Bartlomiej Zolnierkiewicz -
"gayle: reserve memory resources at once" patch temporary removed
freeing of resources on failure (to ease convertion to ide_host_add()
interface). This patch fixes it.Thanks to Geert for noticing the issue.
Noticed-by: Geert Uytterhoeven
Signed-off-by: Bartlomiej Zolnierkiewicz -
This controller supports UltraDMA up to mode 5 but it should be clocked with
at least twice the data strobe frequency, so enable mode 5 for 100+ MHz IDECLK.While at it, start passing the correct device to clk_get() -- it worked anyway
but WTF? :-/Signed-off-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz -
Signed-off-by: Harvey Harrison
Signed-off-by: Bartlomiej Zolnierkiewicz -
If this is actually unaligned the access of speed/max_speed above
is already broken and needs a get_unaligned. Otherwise it is
aligned and they can be removed.Signed-off-by: Harvey Harrison
Cc: Borislav Petkov
Signed-off-by: Bartlomiej Zolnierkiewicz -
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz
-
Prefix messages from IDE PCI host drivers by driver name instead of marketed
chipset name (it is still possible to exactly identify the particular chipset
basing on driver messages).As a bonus this provides nice code savings for some drivers:
text data bss dec hex filename
3826 112 8 3946 f6a drivers/ide/pci/amd74xx.o.before
2786 112 8 2906 b5a drivers/ide/pci/amd74xx.o.after
764 108 0 872 368 drivers/ide/pci/cs5520.o.before
680 108 0 788 314 drivers/ide/pci/cs5520.o.after
1680 112 4 1796 704 drivers/ide/pci/generic.o.before
1155 112 4 1271 4f7 drivers/ide/pci/generic.o.after
7128 792 0 7920 1ef0 drivers/ide/pci/hpt366.o.before
6984 792 0 7776 1e60 drivers/ide/pci/hpt366.o.after
2800 148 0 2948 b84 drivers/ide/pci/pdc202xx_new.o.before
2523 148 0 2671 a6f drivers/ide/pci/pdc202xx_new.o.after
2831 148 0 2979 ba3 drivers/ide/pci/pdc202xx_old.o.before
2683 148 0 2831 b0f drivers/ide/pci/pdc202xx_old.o.after
3776 112 4 3892 f34 drivers/ide/pci/piix.o.before
2804 112 4 2920 b68 drivers/ide/pci/piix.o.after
4693 116 0 4809 12c9 drivers/ide/pci/siimage.o.before
4600 116 0 4716 126c drivers/ide/pci/siimage.o.afterSigned-off-by: Bartlomiej Zolnierkiewicz
-
While at it:
* it821x_chipsets[] -> it821x_chipset.
* Fix it821x_chipset's name field (as it is used for IT8211/8212).
Signed-off-by: Bartlomiej Zolnierkiewicz
-
While at it:
* it8213_chipsets[] -> it8213_chipset.
Signed-off-by: Bartlomiej Zolnierkiewicz
-
While at it:
* Apply small fixes to messages (s/dma/DMA/, remove trailing '.', etc).
* Fix printk() call in ide_setup_pci_baseregs() to use KERN_INFO.
* Move printk() call from ide_pci_clear_simplex() to the caller.
* Cleanup do_ide_setup_pci_device() a bit.
* amd74xx.c: remove superfluous PCI device revision information.
* hpt366.c: fix two printk() calls in ->init_chipset to use KERN_INFO.
* pdc202xx_new.c: fix printk() call in ->init_chipset to use KERN_INFO.
* pdc202xx_old.c: fix driver message in pdc202xx_init_one().
* via82cxxx.c: fix driver warning message in via_init_one().
Signed-off-by: Bartlomiej Zolnierkiewicz
-
Replace ide_default_{io_base,irq}() inlines by legacy_{bases,irqs}[].
v2:
Add missing zero-ing of hws[] (caught during testing by Borislav Petkov).v3:
Fix zero-oing of hws[] for _real_ this time.There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz
-
Cc: Benjamin Herrenschmidt
Signed-off-by: Bartlomiej Zolnierkiewicz -
Move ide_probe_legacy() call to ide_generic_init() so it fails
early if necessary and returns the proper error value (nowadays
ide_default_io_base() is used only by ide-generic).Cc: Ralf Baechle
Signed-off-by: Bartlomiej Zolnierkiewicz
