Eric Lee / smarc-fsl-linux-kernel

16 Oct, 2007

2 commits

11 Oct, 2007

1 commit

  • 587117414   [NETFILTER]: bridge: remove broken netfilter binary sysctls ... Browse Code »

    The netfilter sysctls in the bridging code don't set strategy routines:

    sysctl table check failed: /net/bridge/bridge-nf-call-arptables .3.10.1 Missing strategy
    sysctl table check failed: /net/bridge/bridge-nf-call-iptables .3.10.2 Missing strategy
    sysctl table check failed: /net/bridge/bridge-nf-call-ip6tables .3.10.3 Missing strategy
    sysctl table check failed: /net/bridge/bridge-nf-filter-vlan-tagged .3.10.4 Missing strategy
    sysctl table check failed: /net/bridge/bridge-nf-filter-pppoe-tagged .3.10.5 Missing strategy

    These binary sysctls can't work. The binary sysctl numbers of
    other netfilter sysctls with this problem are being removed. These
    need to go as well.

    Signed-off-by: Joseph Fannin
    Acked-by: "Eric W. Biederman"
    Signed-off-by: Patrick McHardy
    Signed-off-by: David S. Miller

    Joseph Fannin
     

17 Sep, 2007

1 commit

  • d9cc20484   [NET] skbuff: Add skb_cow_head ... Browse Code »

    This patch adds an optimised version of skb_cow that avoids the copy if
    the header can be modified even if the rest of the payload is cloned.

    This can be used in encapsulating paths where we only need to modify the
    header. As it is, this can be used in PPPOE and bridging.

    Signed-off-by: Herbert Xu
    Signed-off-by: David S. Miller

    Herbert Xu
     

27 Aug, 2007

1 commit

  • e7c243c92   [VLAN/BRIDGE]: Fix "skb_pull_rcsum - Fatal exception in interrupt" ... Browse Code »

    I tried to preserve bridging code as it was before, but logic is quite
    strange - I think we should free skb on error, since it is already
    unshared and thus will just leak.

    Herbert Xu states:

    > + if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL)
    > + goto out;

    If this happens it'll be a double-free on skb since we'll
    return NF_DROP which makes the caller free it too.

    We could return NF_STOLEN to prevent that but I'm not sure
    whether that's correct netfilter semantics. Patrick, could
    you please make a call on this?

    Patrick McHardy states:

    NF_STOLEN should work fine here.

    Signed-off-by: Evgeniy Polyakov
    Signed-off-by: David S. Miller

    Evgeniy Polyakov
     

03 May, 2007

1 commit

26 Apr, 2007

9 commits

23 Mar, 2007

1 commit

  • b6f99a211   [NET]: fix up misplaced inlines. ... Browse Code »

    Turning up the warnings on gcc makes it emit warnings
    about the placement of 'inline' in function declarations.
    Here's everything that was under net/

    Signed-off-by: Dave Jones
    Signed-off-by: David S. Miller

    Dave Jones
     

15 Feb, 2007

1 commit

  • 0b4d41471   [PATCH] sysctl: remove insert_at_head from register_sysctl ... Browse Code »

    The semantic effect of insert_at_head is that it would allow new registered
    sysctl entries to override existing sysctl entries of the same name. Which is
    pain for caching and the proc interface never implemented.

    I have done an audit and discovered that none of the current users of
    register_sysctl care as (excpet for directories) they do not register
    duplicate sysctl entries.

    So this patch simply removes the support for overriding existing entries in
    the sys_sysctl interface since no one uses it or cares and it makes future
    enhancments harder.

    Signed-off-by: Eric W. Biederman
    Acked-by: Ralf Baechle
    Acked-by: Martin Schwidefsky
    Cc: Russell King
    Cc: David Howells
    Cc: "Luck, Tony"
    Cc: Ralf Baechle
    Cc: Paul Mackerras
    Cc: Martin Schwidefsky
    Cc: Andi Kleen
    Cc: Jens Axboe
    Cc: Corey Minyard
    Cc: Neil Brown
    Cc: "John W. Linville"
    Cc: James Bottomley
    Cc: Jan Kara
    Cc: Trond Myklebust
    Cc: Mark Fasheh
    Cc: David Chinner
    Cc: "David S. Miller"
    Cc: Patrick McHardy
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Eric W. Biederman
     

11 Feb, 2007

1 commit

09 Feb, 2007

1 commit

14 Dec, 2006

1 commit

07 Dec, 2006

1 commit

  • f216f082b   [NETFILTER]: bridge netfilter: deal with martians correctly ... Browse Code »

    The attached patch resolves an issue where a IP DNATed packet with a
    martian source is forwarded while it's better to drop it. It also
    resolves messages complaining about ip forwarding being disabled while
    it's actually enabled. Thanks to lepton for
    reporting this problem.

    This is probably a candidate for the -stable release.

    Signed-off-by: Bart De Schuymer
    Signed-off-by: Patrick McHardy
    Signed-off-by: David S. Miller

    Bart De Schuymer
     

03 Dec, 2006

2 commits

23 Sep, 2006

3 commits

25 Jul, 2006

1 commit

09 Jul, 2006

1 commit

  • 89114afd4   [NET] gso: Add skb_is_gso ... Browse Code »

    This patch adds the wrapper function skb_is_gso which can be used instead
    of directly testing skb_shinfo(skb)->gso_size. This makes things a little
    nicer and allows us to change the primary key for indicating whether an skb
    is GSO (if we ever want to do that).

    Signed-off-by: Herbert Xu
    Signed-off-by: David S. Miller

    Herbert Xu
     

23 Jun, 2006

1 commit

  • 7967168ce   [NET]: Merge TSO/UFO fields in sk_buff ... Browse Code »

    Having separate fields in sk_buff for TSO/UFO (tso_size/ufo_size) is not
    going to scale if we add any more segmentation methods (e.g., DCCP). So
    let's merge them.

    They were used to tell the protocol of a packet. This function has been
    subsumed by the new gso_type field. This is essentially a set of netdev
    feature bits (shifted by 16 bits) that are required to process a specific
    skb. As such it's easy to tell whether a given device can process a GSO
    skb: you just have to and the gso_type field and the netdev's features
    field.

    I've made gso_type a conjunction. The idea is that you have a base type
    (e.g., SKB_GSO_TCPV4) that can be modified further to support new features.
    For example, if we add a hardware TSO type that supports ECN, they would
    declare NETIF_F_TSO | NETIF_F_TSO_ECN. All TSO packets with CWR set would
    have a gso_type of SKB_GSO_TCPV4 | SKB_GSO_TCPV4_ECN while all other TSO
    packets would be SKB_GSO_TCPV4. This means that only the CWR packets need
    to be emulated in software.

    Signed-off-by: Herbert Xu
    Signed-off-by: David S. Miller

    Herbert Xu
     

18 Jun, 2006

1 commit

  • b38dfee3d   [NET]: skb_trim audit ... Browse Code »

    I found a few more spots where pskb_trim_rcsum could be used but were not.
    This patch changes them to use it.

    Also, sk_filter can get paged skb data. Therefore we must use pskb_trim
    instead of skb_trim.

    Signed-off-by: Herbert Xu
    Signed-off-by: David S. Miller

    Herbert Xu
     

10 Apr, 2006

1 commit

21 Mar, 2006

6 commits

24 Feb, 2006

1 commit

  • 42cf93cd4   [NETFILTER]: Fix bridge netfilter related in xfrm_lookup ... Browse Code »

    The bridge-netfilter code attaches a fake dst_entry with dst->ops == NULL
    to purely bridged packets. When these packets are SNATed and a policy
    lookup is done, xfrm_lookup crashes because it tries to dereference
    dst->ops.

    Change xfrm_lookup not to dereference dst->ops before checking for the
    DST_NOXFRM flag and set this flag in the fake dst_entry.

    Signed-off-by: Patrick McHardy
    Signed-off-by: David S. Miller

    Patrick McHardy
     

14 Feb, 2006

1 commit

13 Feb, 2006

1 commit