07 Jul, 2018

2 commits

  • Checking whether output of commands matches the ver_linux pattern in
    the version function is original shell implementation legacy code. When
    the original implementation failed to locate a particular utility,
    it generated error output along the lines of:

    ver_linux:line number: command not found.

    The awk implementation, does not contain the name of the script within the
    body of the error message returned by the subshell when a given utility
    fails to be located. The error message returned is along the lines of:

    sh: name of utility: command not found

    Safeguarding against the ver_linux pattern being found in the output
    being parsed may thus be safely omitted.

    Signed-off-by: Alexander Kapshuk
    Signed-off-by: Greg Kroah-Hartman

    Alexander Kapshuk
     
  • Currently, input coming from /proc/self/maps is split into fields without
    checking whether or not it matches libc.so. This is not efficient.
    All text processing should only be performed on lines of input that
    match libc.so.

    Signed-off-by: Alexander Kapshuk
    Signed-off-by: Greg Kroah-Hartman

    Alexander Kapshuk
     

14 May, 2018

2 commits

  • Running 'test -r' on an awk variable name whose value is an empty
    string results in test being run with no arguments, and causes system()
    to return 0, which indicates success when used to test values returned
    by function calls. This results in code within the if blocks being run
    when it should not be.
    Instead of testing if a file is accessible and readable via calls to
    system("test -r " file), rely on the value returned by getline to perform
    this kind of testing. Getline returns -1 on error, with the code within
    the while loops not being run.

    Signed-off-by: Alexander Kapshuk
    Signed-off-by: Greg Kroah-Hartman

    Alexander Kapshuk
     
  • Remove stderr redirection to stdout from all the parameters to the
    version() function, and put it with the body of the version() function
    instead.
    This improves code readability.

    Signed-off-by: Alexander Kapshuk
    Signed-off-by: Greg Kroah-Hartman

    Alexander Kapshuk
     

02 Nov, 2017

1 commit

  • Many source files in the tree are missing licensing information, which
    makes it harder for compliance tools to determine the correct license.

    By default all files without license information are under the default
    license of the kernel, which is GPL version 2.

    Update the files which contain no license information with the 'GPL-2.0'
    SPDX license identifier. The SPDX identifier is a legally binding
    shorthand, which can be used instead of the full boiler plate text.

    This patch is based on work done by Thomas Gleixner and Kate Stewart and
    Philippe Ombredanne.

    How this work was done:

    Patches were generated and checked against linux-4.14-rc6 for a subset of
    the use cases:
    - file had no licensing information it it.
    - file was a */uapi/* one with no licensing information in it,
    - file was a */uapi/* one with existing licensing information,

    Further patches will be generated in subsequent months to fix up cases
    where non-standard license headers were used, and references to license
    had to be inferred by heuristics based on keywords.

    The analysis to determine which SPDX License Identifier to be applied to
    a file was done in a spreadsheet of side by side results from of the
    output of two independent scanners (ScanCode & Windriver) producing SPDX
    tag:value files created by Philippe Ombredanne. Philippe prepared the
    base worksheet, and did an initial spot review of a few 1000 files.

    The 4.13 kernel was the starting point of the analysis with 60,537 files
    assessed. Kate Stewart did a file by file comparison of the scanner
    results in the spreadsheet to determine which SPDX license identifier(s)
    to be applied to the file. She confirmed any determination that was not
    immediately clear with lawyers working with the Linux Foundation.

    Criteria used to select files for SPDX license identifier tagging was:
    - Files considered eligible had to be source code files.
    - Make and config files were included as candidates if they contained >5
    lines of source
    - File already had some variant of a license header in it (even if
    Reviewed-by: Philippe Ombredanne
    Reviewed-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

09 Apr, 2017

1 commit

  • Most Linux distributions contain awk in /usr/bin by default,
    not in /bin. This script's suggested use is for creating version
    information for bug reporting.

    This has been tested on a number of different distributions,
    including Fedora, Ubuntu, OpenSUSE, Debian, Centos, Arch Linuxi,
    and Poky!

    Signed-off-by: Saul Wold
    Reviewed-by: Alexander Kapshuk
    Reviewed-by: Mark Gross
    Signed-off-by: Greg Kroah-Hartman

    Saul Wold
     

31 Aug, 2016

2 commits


08 Feb, 2016

1 commit


18 Oct, 2015

22 commits


10 Jun, 2009

1 commit

  • The '-e' option to echo and brace expansion are not guaranteed to be supported
    by a POSIX-compliant /bin/sh (e.g. dash)

    Signed-off-by: dann frazier
    Signed-off-by: Andrew Morton
    Signed-off-by: Sam Ravnborg

    dann frazier
     

01 Aug, 2008

1 commit

  • It would have saved both a bug submitter and me a few hours if
    scripts/ver_linux had picked the same gcc as the build.

    Since I can't see any reason why it fiddles with PATH at all this patch
    therefore removes the PATH setting.

    Signed-off-by: Adrian Bunk
    Signed-off-by: Sam Ravnborg

    Adrian Bunk
     

26 May, 2008

1 commit

  • These magic greps and hacks in ver_linux to get the gcc version always break after some gcc releases.

    Since now gcc >4.3 allows compiling with '--with-pkgversion' ( which can be everything 'My Cool Gcc' or something )
    ver_linux will report random junk for these.

    Simply use 'gcc -dumpversion' to get the gcc version which should always work.

    Signed-off-by: Gabriel C
    Signed-off-by: Andrew Morton
    Signed-off-by: Sam Ravnborg

    Gabriel C
     

13 Oct, 2007

2 commits

  • Currently scripts/ver_linux prints "Binutils" or other random
    information for the version number in the "binutils" output line
    on some distributions. This patch corrects that.

    When I initially submitted a patch to correct that, I was not aware
    that the output from "ld -v" could differ as much as it turned out
    it can, so my original fix turned out to not cover all bases.
    This patch works correctly with all the different "ld -v" output
    that people posted in replys to my first patch, so it should be a
    clear win over what we have currently.

    Signed-off-by: Jesper Juhl
    Signed-off-by: Sam Ravnborg

    Jesper Juhl
     
  • Fix ver_linux glibc version printing (for real this time)

    Alexey Dobriyan reported that commit
    4a645d5ea65baaa5736bcb566673bf4a351b2ad8
    broke ver_linux when glibc has a 3 digit
    version number, and proposed a patch.
    Al Viro then suggested a simpler way to
    solve the problem which I've then simply
    put into patch form.

    Signed-off-by: Alexey Dobriyan
    Signed-off-by: Al Viro
    Signed-off-by: Jesper Juhl
    Signed-off-by: Sam Ravnborg

    Jesper Juhl
     

26 Jul, 2007

1 commit


08 Dec, 2006

1 commit

  • scripts/ver_linux needed some minor clean-ups, as follows:
    1) Add reporting of actual oprofile release
    2) Add reporting of actual wireless-tools release
    3) Add reporting of actual pcmciautils release

    Signed-off-by: Valdis Kletnieks
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Valdis Kletnieks
     

05 Apr, 2006

1 commit


08 Sep, 2005

1 commit