11 Mar, 2012
5 commits
-
This queue is used for sleeping in kernel and it have to be per-net since we
don't want to wake any other waiters except in out network nemespace.
BTW, move wq to per-net data is easy. But some way to handle upcall timeouts
have to be provided. On message destroy in case of timeout, tasks, waiting for
message to be delivered, should be awakened. Thus, some data required to
located the right wait queue. Chosen solution replaces rpc_pipe_msg object with
new introduced bl_pipe_msg object, containing rpc_pipe_msg and proper wq.Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust -
This global variable is used for blocklayout downcall and thus can be corrupted
if case of existence of multiple networks namespaces.Signed-off-by: Stanislav Kinsbursky
Signed-off-by: Trond Myklebust -
The radix tree is only being used to compile lists of reqs needing commit.
It is simpler to just put the reqs directly into a list.Signed-off-by: Fred Isaman
Signed-off-by: Trond Myklebust -
The last real use of this tag was removed by
commit 7f2f12d963 NFS: Simplify nfs_wb_page()Signed-off-by: Fred Isaman
Signed-off-by: Trond Myklebust -
When the NFSv4.0 server tells us that it can no-longer talk to us
on the callback channel, we should attempt a new SETCLIENTID in
order to re-transmit the callback channel information.Note that as long as we do not change the boot verifier, this is
a safe procedure; the server is required to keep our state.Also move the function nfs_handle_cb_pathdown to fs/nfs/nfs4state.c,
and change the name in order to mark it as being specific to NFSv4.0.Signed-off-by: Trond Myklebust
09 Mar, 2012
3 commits
-
Ensure that we select delegation stateids first, then
lock stateids and then open stateids.Signed-off-by: Trond Myklebust
-
The server will just return an NFS4ERR_OPENMODE anyway.
Signed-off-by: Trond Myklebust
-
The error handler nfs4_state parameter is never NULL in the pNFS case as
the open_context must carry an nfs_state.Signed-off-by: Andy Adamson
Signed-off-by: Trond Myklebust
08 Mar, 2012
2 commits
-
If a setattr() fails because of an NFS4ERR_OPENMODE error, it is
probably due to us holding a read delegation. Ensure that the
recovery routines return that delegation in this case.Reported-by: Miklos Szeredi
Signed-off-by: Trond Myklebust
Cc: stable@vger.kernel.org -
Otherwise we can end up with sequence id problems if the client reuses
the owner_id before the server has processed the release_lockownerSigned-off-by: Trond Myklebust
07 Mar, 2012
3 commits
-
Handle DS READ and WRITE stateid errors by recovering the stateid on the MDS.
NFS4ERR_OLD_STATEID is ignored as the client always sends a
state sequenceid of zero for DS READ and WRITE stateids.Signed-off-by: Andy Adamson
Signed-off-by: Trond Myklebust -
Print the filehandle crc in two debug messages
Signed-off-by: Weston Andros Adamson
Signed-off-by: Trond Myklebust -
Match wireshark's CRC-32 hash for easier debugging
Signed-off-by: Weston Andros Adamson
Signed-off-by: Trond Myklebust
06 Mar, 2012
19 commits
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Clean up due to code review.
The nfs4_verifier's data field is not guaranteed to be u32-aligned.
Casting an array of chars to a u32 * is considered generally
hazardous.Fix this by using a __be32 array to generate a verifier's contents,
and then byte-copy the contents into the verifier field. The contents
of a verifier, for all intents and purposes, are opaque bytes. Only
local code that generates a verifier need know the actual content and
format. Everyone else compares the full byte array for exact
equality.Also, sizeof(nfs4_verifer) is the size of the in-core verifier data
structure, but NFS4_VERIFIER_SIZE is the number of octets in an XDR'd
verifier. The two are not interchangeable, even if they happen to
have the same value.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Replace the union with the common struct stateid4 as defined in both
RFC3530 and RFC5661. This makes it easier to access the sequence id,
which will again make implementing support for parallel OPEN calls
easier.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
It is really a function for selecting the correct stateid to use in a
read or write situation.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
The current version of encode_stateid really only applies to open stateids.
You can't use it for locks, delegations or layouts.Signed-off-by: Trond Myklebust
-
Change the name to reflect what we're really doing: testing two
stateids for whether or not they match according the the rules in
RFC3530 and RFC5661.
Move the code from callback_proc.c to nfs4proc.cSigned-off-by: Trond Myklebust
-
nfs41_validate_delegation_stateid is broken if we supply a stateid with
a non-zero sequence id. Instead of trying to match the sequence id,
the function assumes that we always want to error. While this is
true for a delegation callback, it is not true in general.Also fix a typo in nfs4_callback_recall.
Reported-by: Andy Adamson
Signed-off-by: Trond Myklebust -
If we know that the delegation stateid is bad or revoked, we need to
remove that delegation as soon as possible, and then mark all the
stateids that relied on that delegation for recovery. We cannot use
the delegation as part of the recovery process.Also note that NFSv4.1 uses a different error code (NFS4ERR_DELEG_REVOKED)
to indicate that the delegation was revoked.Finally, ensure that setlk() and setattr() can both recover safely from
a revoked delegation.Signed-off-by: Trond Myklebust
Cc: stable@vger.kernel.org -
The check for 'fh == NULL' needs to come _before_ we dereference
fh.Reported-by: Dan Carpenter
Signed-off-by: Trond Myklebust -
The attempt to display the implementation ID needs to be conditional on
whether or not CONFIG_NFS_V4_1 is definedReported-by: Bryan Schumaker
Signed-off-by: Trond Myklebust -
When compiled without NFS v4 configured these function won't be defined
and the compiler will yell.Signed-off-by: Bryan Schumaker
Signed-off-by: Trond Myklebust
04 Mar, 2012
1 commit
-
Conflicts:
fs/nfs/nfs4proc.cBack-merge of the upstream kernel in order to fix a conflict with the
slotid type conversion and implementation id patches...
03 Mar, 2012
7 commits
-
Get rid of
encode_compound: tag=
when XDR debugging is enabled. The current Linux client never sets
compound tags.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
The fh_expire_type file attribute is a filesystem wide attribute that
consists of flags that indicate what characteristics file handles
on this FSID have.Our client doesn't support volatile file handles. It should find
out early (say, at mount time) whether the server is going to play
shenanighans with file handles during a migration.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
The Linux NFS client must distinguish between referral events (which
it currently supports) and migration events (which it does not yet
support).In both types of events, an fs_locations array is returned. But upper
layers, not the XDR layer, should make the distinction between a
referral and a migration. There really isn't a way for an XDR decoder
function to distinguish the two, in general.Slightly adjust the FATTR flags returned by decode_fs_locations()
to set NFS_ATTR_FATTR_V4_LOCATIONS only if a non-empty locations
array was returned from the server. Then have logic in nfs4proc.c
distinguish whether the locations array is for a referral or
something else.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
Clean up: pass just the clientid4 to encode_renew(). This enables it
to be used by callers who might not have an full nfs_client.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
For debugging, introduce a simplistic function to print NFS file
handles on the system console. The main function is hooked into the
dprintk debugging facility, but you can directly call the helper,
_nfs_display_fhandle(), if you want to print a handle unconditionally.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
For NFSv4 mounts, the clientaddr= mount option has always been
required. Now we have rpc_localaddr() in the kernel, which was
modeled after the same logic in the mount.nfs command that constructs
the clientaddr= mount option. If user space doesn't provide a
clientaddr= mount option, the kernel can now construct its own.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
NFSv4.0 clients must send endpoint information for their callback
service to NFSv4.0 servers during their first contact with a server.
Traditionally on Linux, user space provides the callback endpoint IP
address via the "clientaddr=" mount option.During an NFSv4 migration event, it is possible that an FSID may be
migrated to a destination server that is accessible via a different
source IP address than the source server was. The client must update
callback endpoint information on the destination server so that it can
maintain leases and allow delegation.Without a new "clientaddr=" option from user space, however, the
kernel itself must construct an appropriate IP address for the
callback update. Provide an API in the RPC client for upper layer
RPC consumers to acquire a source address for a remote.The mechanism used by the mount.nfs command is copied: set up a
connected UDP socket to the designated remote, then scrape the source
address off the socket. We are careful to select the correct network
namespace when setting up the temporary UDP socket.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust