20 Aug, 2011
3 commits
-
The label outnodev is only used when kzalloc has not yet taken place or has
failed, so there is no need for the call for kfree under this label.A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)//
@@
identifier x;
expression E1!=0,E2,E3,E4;
statement S;
iterator I;
@@(
if (...) { ... when != kfree(x)
when != x = E3
when != E3 = x
* return ...;
}
... when != x = E2
when != I(...,x,...) S
if (...) { ... when != x = E4
kfree(x); ... return ...; }
)
//Signed-off-by: Julia Lawall
Signed-off-by: Takashi Iwai -
snd_hda_get_conn_index() returns a negative value while the current code
stores it in an unsigned int. It must be stored in a signed integer.Reported-by: Jesper Juhl
Signed-off-by: Takashi Iwai -
Currently HD-audio driver shows the all error ELD byte as an error
in the kernel message. This is annoying when the video driver doesn't
set the correct ELD from the beginning. e.g. radeon sends a zero-byte
data, but we still check ELD with the fixed 128 byte as a workaround
for some broken devices, it spews 128-times errors.For avoiding this, the driver aborts reading when the first byte is
invalid. In such a case, the whole data is certainly invalid.Signed-off-by: Takashi Iwai
19 Aug, 2011
1 commit
-
The recent fix for testing dB range at the mixer creation time seems
to cause regressions in some devices. In such devices, reading the dB
info at probing time gives an error, thus both dBmin and dBmax are still
zero, and TLV flag isn't set although the later read of dB info succeeds.This patch adds a workaround for such a case by assuming that the later
read will succeed. In future, a similar test should be performed in a
case where a wrong dB range is seen even in the later read.Signed-off-by: Takashi Iwai
Cc:
18 Aug, 2011
1 commit
-
The new parser may use "PCM" volume, but it was missing the vmaster
slave list, thus "Master" volume didn't control it.Reference: https://bugzilla.kernel.org/show_bug.cgi?id=41342
Signed-off-by: Takashi Iwai
16 Aug, 2011
1 commit
-
Fix the duplicated creation of capture-mixer elements for some static
ALC268 configurations. The capture mixers must be put to cap_mixer field
instead of mixers array.Signed-off-by: Takashi Iwai
15 Aug, 2011
2 commits
-
BugLink: https://bugs.launchpad.net/bugs/826081
The original reporter needs 'Headphone Jack Sense' enabled to have
audible audio, so add his PCI SSID to the whitelist.Reported-and-tested-by: Muhammad Khurram Khan
Cc:
Signed-off-by: Daniel T Chen
Signed-off-by: Takashi Iwai -
The snd_usb_caiaq driver currently assumes that output urbs are serviced
in time and doesn't track when and whether they are given back by the
USB core. That usually works fine, but due to temporary limitations of
the XHCI stack, we faced that urbs were submitted more than once with
this approach.As it's no good practice to fire and forget urbs anyway, this patch
introduces a proper bit mask to track which requests have been submitted
and given back.That alone however doesn't make the driver work in case the host
controller is broken and doesn't give back urbs at all, and the output
stream will stop once all pre-allocated output urbs are consumed. But
it does prevent crashes of the controller stack in such cases.See http://bugzilla.kernel.org/show_bug.cgi?id=40702 for more details.
Signed-off-by: Daniel Mack
Reported-and-tested-by: Matej Laitl
Cc: Sarah Sharp
Cc: stable@kernel.org
Signed-off-by: Takashi Iwai
13 Aug, 2011
2 commits
-
sound/soc/codecs/wm8750.c:784:2: warning: missing braces around initializer
sound/soc/codecs/wm8750.c:784:2: warning: (near initialization for ‘wm8750_spi_ids[2].name’)It's because struct spi_device_id.name is a char array, not a pointer,
while the driver initializes explicitly with 0.Signed-off-by: Takashi Iwai
12 Aug, 2011
2 commits
-
My gmail account got disabled and I'm not going to reopen it.
Signed-off-by: Jarkko Nikula
Acked-by: Liam Girdwood
Signed-off-by: Mark Brown -
I2S in Exynos4 and S5PC110(S5PV210) has a internal dma.
It can be used low power audio mode and 2nd channel transfer.
This patch can support idma.[Reapplied after dependencies propagated through in 3.1-rc1. --broonie]
Signed-off-by: Sangbeom Kim
Acked-by: Jassi Brar
Acked-by: Liam Girdwood
Acked-by: Jassi Brar
Signed-off-by: Mark Brown
11 Aug, 2011
3 commits
-
Signed-off-by: Mark Brown
Reported-by: Stephen Rothwell -
This error would have no effect on current silicon revisions, the fall
through case has the same behaviour.Signed-off-by: Mark Brown
Acked-by: Liam Girdwood -
This fixes faulty outbount packets in case the inbound packets
received from the hardware are fragmented and contain bogus input
iso frames. The bug has been there for ages, but for some strange
reasons, it was only triggered by newer machines in 64bit mode.Signed-off-by: Daniel Mack
Reported-and-tested-by: William Light
Reported-by: Pedro Ribeiro
Cc: stable@kernel.org
Signed-off-by: Takashi Iwai
10 Aug, 2011
4 commits
-
snd_azf3328_dbgcallenter is called at the very beginning of the function,
so it could be useful to call snd_azf3328_dbgcallleave at all exit points.Signed-off-by: Julia Lawall
Signed-off-by: Takashi Iwai -
In commit 45eebda7, it add new function stac_vrefout_set, but it
is only used in code between CONFIG_SND_HDA_POWER_SAVE macro, so
add the macro to avoid such warning:sound/pci/hda/patch_sigmatel.c:676:12: warning: 'stac_vrefout_set' defined but not used
Signed-off-by: Wang Shaoyan
Signed-off-by: Takashi Iwai -
Signed-off-by: Kazutomo Yoshii
Signed-off-by: Takashi Iwai -
Signed-off-by: Mark Brown
Reported-by: Stephen Rothwell
09 Aug, 2011
6 commits
-
Signed-off-by: Mark Brown
Acked-by: Liam Girdwood -
As we had no id_table only the driver name would be matched against
meaning that WM8987 devices wouldn't be bound.Signed-off-by: Mark Brown
Acked-by: Liam Girdwood -
The I2C address is misformatted and would never match.
Signed-off-by: Mark Brown
Acked-by: Liam Girdwood
Cc: stable@kernel.org -
Without this, request_irq on subsequent device initialization fails, and
the codec cannot be used.Signed-off-by: Stephen Warren
Acked-by: Liam Girdwood
Signed-off-by: Mark Brown -
Two issues were preventing module snd-soc-tegra-wm8903.ko from being
removed and re-inserted:a) The speaker-enable GPIO is hosted by the WM8903 chip. This GPIO must
be freed before snd_soc_unregister_card() is called, because that
triggers wm8903.c:wm8903_remove(), which calls gpiochip_remove(), which
then fails if any of the GPIOs are in use. To solve this, free all GPIOs
first, so the code doesn't care where they come from.b) We need to call snd_soc_jack_free_gpios() to match the call to
snd_soc_jack_add_gpios() during initialization. Without this, the
call to snd_soc_jack_add_gpios() fails during any subsequent modprobe
and initialization, since the GPIO and IRQ are already registered. In
turn, this causes the headphone state not to be monitored, so the
headphone is assumed not to be plugged in, and the audio path to it is
never enabled.Signed-off-by: Stephen Warren
Cc: stable@kernel.org
Signed-off-by: Mark Brown -
Not all PCM devices have all sub-streams. Specifically, the SPDIF driver
only supports playback and hence has no capture substream. Check whether
a substream exists before dereferencing it, when de-allocating DMA
buffers in tegra_pcm_deallocate_dma_buffer.Signed-off-by: Stephen Warren
Acked-by: Liam Girdwood
Signed-off-by: Mark Brown
Cc: stable@kernel.org
08 Aug, 2011
8 commits
-
sound/oss/pss.c: In function 'configure_nonsound_components':
sound/oss/pss.c:676: warning: 'check_region' is deprecated (declared at include/linux/ioport.h:201)Signed-off-by: Wang Shaoyan
Signed-off-by: Takashi Iwai -
Just to be sure.
Signed-off-by: Takashi Iwai
-
A slave-timer instance has no timer reference, and this results in
NULL-dereference at stopping the timer, typically called at closing
the device.Reference: https://bugzilla.kernel.org/show_bug.cgi?id=40682
Cc:
Signed-off-by: Takashi Iwai -
…oonie/sound-2.6 into fix/asoc
-
This closes the small race between a status being read in response to an
interrupt and clearing the interrupt, meaning that if the status changes
between those periods we might not get a reassertion of the interrupt.Signed-off-by: Mark Brown
-
For marketing reasons the part will be called WM8996. In order to avoid
user confusion rename the driver to reflect this.Signed-off-by: Mark Brown
Acked-by: Kukjin Kim
Acked-by: Liam Girdwood
07 Aug, 2011
2 commits
-
CONFIG_SND_TEA575X is enabled by RADIO_SF16FMR2, but the latter one is
no PCI device. Since tea575x-tuner itself is independent from the board
bus type, the config should be moved out of SND_PCI dependency.Reported-by: Randy Dunlap
Acked-by: Randy Dunlap
Signed-off-by: Takashi Iwai -
Use kzalloc rather than kmalloc followed by memset with 0
This considers some simple cases that are common and easy to validate
Note in particular that there are no ...s in the rule, so all of the
matched code has to be contiguousThe semantic patch that makes this output is available
in scripts/coccinelle/api/alloc/kzalloc-simple.cocci.More information about semantic patching is available at
http://coccinelle.lip6.fr/Signed-off-by: Thomas Meyer
Signed-off-by: Takashi Iwai
06 Aug, 2011
2 commits
-
Signed-off-by: Daniel Mack
Reported-by: Renato
Cc: stable@kernel.org
Signed-off-by: Takashi Iwai -
Purely cosmetic, but fixes the following build warning.
CC [M] sound/usb/quirks.o
sound/usb/quirks.c: In function ‘snd_usb_apply_boot_quirk’:
sound/usb/quirks.c:429:6: warning: ‘err’ may be used uninitialized in this function [-Wuninitialized]Signed-off-by: Daniel Mack
Signed-off-by: Takashi Iwai
05 Aug, 2011
3 commits
-
sound/pci/hda/patch_via.c:2087: warning: 'dac' may be used uninitialized in this function
Signed-off-by: Wang Shaoyan
Signed-off-by: Takashi Iwai -
Put the exception checks for io_type switch() for possible mistakes in
future. Also this shuts up annoying compile warnings.Signed-off-by: Takashi Iwai
-
Signed-off-by: Miller Puckette
Signed-off-by: Takashi Iwai
