11 Aug, 2016

5 commits

  • Some of node threshold depends on number of managed pages in the node.
    When memory is going on/offline, it can be changed and we need to adjust
    them.

    Add recalculation to appropriate places and clean-up related functions
    for better maintenance.

    Link: http://lkml.kernel.org/r/1470724248-26780-2-git-send-email-iamjoonsoo.kim@lge.com
    Signed-off-by: Joonsoo Kim
    Acked-by: Mel Gorman
    Cc: Vlastimil Babka
    Cc: Johannes Weiner
    Cc: Minchan Kim
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joonsoo Kim
     
  • Before resetting min_unmapped_pages, we need to initialize
    min_unmapped_pages rather than min_slab_pages.

    Fixes: a5f5f91da6 (mm: convert zone_reclaim to node_reclaim)
    Link: http://lkml.kernel.org/r/1470724248-26780-1-git-send-email-iamjoonsoo.kim@lge.com
    Signed-off-by: Joonsoo Kim
    Acked-by: Mel Gorman
    Cc: Vlastimil Babka
    Cc: Johannes Weiner
    Cc: Minchan Kim
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joonsoo Kim
     
  • The newly introduced shmem_huge_enabled() function has two definitions,
    but neither of them is visible if CONFIG_SYSFS is disabled, leading to a
    build error:

    mm/khugepaged.o: In function `khugepaged':
    khugepaged.c:(.text.khugepaged+0x3ca): undefined reference to `shmem_huge_enabled'

    This changes the #ifdef guards around the definition to match those that
    are used in the header file.

    Fixes: e496cf3d7821 ("thp: introduce CONFIG_TRANSPARENT_HUGE_PAGECACHE")
    Link: http://lkml.kernel.org/r/20160809123638.1357593-1-arnd@arndb.de
    Signed-off-by: Arnd Bergmann
    Acked-by: Kirill A. Shutemov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arnd Bergmann
     
  • Revert commit 51d5d12b8f3d ("ARM: keystone: dts: add psci command
    definition"), which was inadvertently added twice.

    Cc: Russell King - ARM Linux
    Cc: Vitaly Andrianov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     
  • Original patch: https://lkml.org/lkml/2016/8/4/32

    If riocm_ch_alloc() fails then we end up dereferencing the error
    pointer.

    The problem is that we're not unwinding in the reverse order from how we
    allocate things so it gets confusing. I've changed this around so now
    "ch" is NULL when we are done with it after we call riocm_put_channel().
    That way we can check if it's NULL and avoid calling riocm_put_channel()
    on it twice.

    I renamed err_nodev to err_put_new_ch so that it better reflects what
    the goto does.

    Then because we had flipping things around, it means we don't neeed to
    initialize the pointers to NULL and we can remove an if statement and
    pull things in an indent level.

    Link: http://lkml.kernel.org/r/20160805152406.20713-1-alexandre.bounine@idt.com
    Signed-off-by: Dan Carpenter
    Signed-off-by: Alexandre Bounine
    Cc: Matt Porter
    Cc: Andre van Herk
    Cc: Barry Wood
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Dan Carpenter
     

10 Aug, 2016

7 commits

  • This reverts commit 874f9c7da9a4acbc1b9e12ca722579fb50e4d142.

    Geert Uytterhoeven reports:
    "This change seems to have an (unintendent?) side-effect.

    Before, pr_*() calls without a trailing newline characters would be
    printed with a newline character appended, both on the console and in
    the output of the dmesg command.

    After this commit, no new line character is appended, and the output
    of the next pr_*() call of the same type may be appended, like in:

    - Truncating RAM at 0x0000000040000000-0x00000000c0000000 to -0x0000000070000000
    - Ignoring RAM at 0x0000000200000000-0x0000000240000000 (!CONFIG_HIGHMEM)
    + Truncating RAM at 0x0000000040000000-0x00000000c0000000 to -0x0000000070000000Ignoring RAM at 0x0000000200000000-0x0000000240000000 (!CONFIG_HIGHMEM)"

    Joe Perches says:
    "No, that is not intentional.

    The newline handling code inside vprintk_emit is a bit involved and
    for now I suggest a revert until this has all the same behavior as
    earlier"

    Reported-by: Geert Uytterhoeven
    Requested-by: Joe Perches
    Cc: Andrew Morton
    Signed-off-by: Linus Torvalds

    Linus Torvalds
     
  • Pull tracing fix from Steven Rostedt:
    "Fix tick_stop tracepoint symbols for user export.

    Luiz Capitulino noticed that the tick_stop tracepoint wasn't being
    parsed properly by the tracing user space tools.

    This was due to the TRACE_DEFINE_ENUM() being set to a define, when it
    should have been set to the enum itself. The define was of the MASK
    that used the BIT to shift. The BIT was the enum and by adding that,
    everything gets converted nicely. The MASK is still kept just in case
    it gets converted to an enum in the future"

    * tag 'trace-v4.8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace:
    tracing: Fix tick_stop tracepoint symbols for user export

    Linus Torvalds
     
  • …inux/kernel/git/kees/linux

    Pull gcc plugin improvements from Kees Cook:
    "Several fixes/improvements for the gcc plugin infrastructure:

    - fix a problem with gcc plugins interfering with cc-option tests.

    - abort more gracefully when gcc plugin headers or compiler support
    is missing.

    - improve the gcc plugin rule generation to be more dynamic, pass
    arguments, and build from subdirectories"

    * tag 'gcc-plugin-infrastructure-v4.8-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux:
    gcc-plugins: Add support for plugin subdirectories
    gcc-plugins: Automate make rule generation
    gcc-plugins: Add support for passing plugin arguments
    gcc-plugins: abort builds cleanly when not supported
    kbuild: no gcc-plugins during cc-option tests

    Linus Torvalds
     
  • …linux-platform-drivers-x86

    Pull x86 platform driver update from Darren Hart:
    "dell-wmi: ignore battery remove/insert event"

    * tag 'platform-drivers-x86-v4.8-3' of git://git.infradead.org/users/dvhart/linux-platform-drivers-x86:
    dell-wmi: Ignore WMI event 0xe00e

    Linus Torvalds
     
  • Pull drm fixes from Dave Airlie:
    "This contains a bunch of amdgpu fixes, and some i915 regression fixes.

    It also contains some fixes for an older regression with some EDID
    changes and some 6bpc panels.

    Then there are the lockdep, cirrus and rcar-du regression fixes from
    this window"

    * tag 'drm-fixes-for-4.8-rc2' of git://people.freedesktop.org/~airlied/linux:
    drm/cirrus: Fix NULL pointer dereference when registering the fbdev
    drm/edid: Set 8 bpc color depth for displays with "DFP 1.x compliant TMDS".
    drm/i915/dp: Revert "drm/i915/dp: fall back to 18 bpp when sink capability is unknown"
    drm/edid: Add 6 bpc quirk for display AEO model 0.
    drm: Paper over locking inversion after registration rework
    drm: rcar-du: Link HDMI encoder with bridge
    drm/ttm: Wait for a BO to become idle before unbinding it from GTT
    drm/i915/fbdev: Check for the framebuffer before use
    drm/amdgpu: update golden setting of polaris10
    drm/amdgpu: update golden setting of stoney
    drm/amdgpu: update golden setting of polaris11
    drm/amdgpu: update golden setting of carrizo
    drm/amdgpu: update golden setting of iceland
    drm/amd/amdgpu: change pptable output format from ASCII to binary
    drm/amdgpu/ci: add mullins to default case for smc ucode
    drm/amdgpu/gmc7: add missing mullins case
    drm/i915: Never fully mask the the EI up rps interrupt on SNB/IVB
    drm/i915: Wait up to 3ms for the pcu to ack the cdclk change request on SKL

    Linus Torvalds
     
  • Commit b195d5e2bffd ("ipr: Wait to do async scan until scsi host is
    initialized") fixed async scan for ipr, but broke sync scan for ipr.

    This fixes sync scan back up.

    Signed-off-by: Brian King
    Reported-and-tested-by: Michael Ellerman
    Signed-off-by: Linus Torvalds

    Brian King
     
  • To distinguish non-slab pages charged to kmemcg we mark them PageKmemcg,
    which sets page->_mapcount to -512. Currently, we set/clear PageKmemcg
    in __alloc_pages_nodemask()/free_pages_prepare() for any page allocated
    with __GFP_ACCOUNT, including those that aren't actually charged to any
    cgroup, i.e. allocated from the root cgroup context. To avoid overhead
    in case cgroups are not used, we only do that if memcg_kmem_enabled() is
    true. The latter is set iff there are kmem-enabled memory cgroups
    (online or offline). The root cgroup is not considered kmem-enabled.

    As a result, if a page is allocated with __GFP_ACCOUNT for the root
    cgroup when there are kmem-enabled memory cgroups and is freed after all
    kmem-enabled memory cgroups were removed, e.g.

    # no memory cgroups has been created yet, create one
    mkdir /sys/fs/cgroup/memory/test
    # run something allocating pages with __GFP_ACCOUNT, e.g.
    # a program using pipe
    dmesg | tail
    # remove the memory cgroup
    rmdir /sys/fs/cgroup/memory/test

    we'll get bad page state bug complaining about page->_mapcount != -1:

    BUG: Bad page state in process swapper/0 pfn:1fd945c
    page:ffffea007f651700 count:0 mapcount:-511 mapping: (null) index:0x0
    flags: 0x1000000000000000()

    To avoid that, let's mark with PageKmemcg only those pages that are
    actually charged to and hence pin a non-root memory cgroup.

    Fixes: 4949148ad433 ("mm: charge/uncharge kmemcg from generic page allocator paths")
    Reported-and-tested-by: Eric Dumazet
    Signed-off-by: Vladimir Davydov
    Signed-off-by: Linus Torvalds

    Vladimir Davydov
     

09 Aug, 2016

16 commits

  • The symbols used in the tick_stop tracepoint were not being converted
    properly into integers in the trace_stop format file. Instead we had this:

    print fmt: "success=%d dependency=%s", REC->success,
    __print_symbolic(REC->dependency, { 0, "NONE" },
    { (1 << TICK_DEP_BIT_POSIX_TIMER), "POSIX_TIMER" },
    { (1 << TICK_DEP_BIT_PERF_EVENTS), "PERF_EVENTS" },
    { (1 << TICK_DEP_BIT_SCHED), "SCHED" },
    { (1 << TICK_DEP_BIT_CLOCK_UNSTABLE), "CLOCK_UNSTABLE" })

    User space tools have no idea how to parse "TICK_DEP_BIT_SCHED" or the other
    symbols used to do the bit shifting. The reason is that the conversion was
    done with using the TICK_DEP_MASK_* symbols which are just macros that
    convert to the BIT shift itself (with the exception of NONE, which was
    converted properly, because it doesn't use bits, and is defined as zero).

    The TICK_DEP_BIT_* needs to be denoted by TRACE_DEFINE_ENUM() in order to
    have this properly converted for user space tools to parse this event.

    Cc: stable@vger.kernel.org
    Cc: Frederic Weisbecker
    Fixes: e6e6cc22e067 ("nohz: Use enum code for tick stop failure tracing message")
    Reported-by: Luiz Capitulino
    Tested-by: Luiz Capitulino
    Signed-off-by: Steven Rostedt

    Steven Rostedt (Red Hat)
     
  • cirrus_modeset_init() is initializing/registering the emulated fbdev
    and, since commit c61b93fe51b1 ("drm/atomic: Fix remaining places where
    !funcs->best_encoder is valid"), DRM internals can access/test some of
    the fields in mode_config->funcs as part of the fbdev registration
    process.
    Make sure dev->mode_config.funcs is properly set to avoid dereferencing
    a NULL pointer.

    Reported-by: Mike Marshall
    Reported-by: Eric W. Biederman
    Signed-off-by: Boris Brezillon
    Fixes: c61b93fe51b1 ("drm/atomic: Fix remaining places where !funcs->best_encoder is valid")
    Signed-off-by: Dave Airlie

    Boris Brezillon
     
  • This adds support for building more complex gcc plugins that live in a
    subdirectory instead of just in a single source file.

    Reported-by: PaX Team
    Signed-off-by: Emese Revfy
    [kees: clarified commit message]
    Signed-off-by: Kees Cook

    Emese Revfy
     
  • There's no reason to repeat the same names in the Makefile when the .so
    files have already been listed. The .o list can be generated from them.

    Reported-by: PaX Team
    Signed-off-by: Emese Revfy
    [kees: clarified commit message]
    Signed-off-by: Kees Cook

    Emese Revfy
     
  • The latent_entropy plugin needs to pass arguments, so this adds the
    support.

    Signed-off-by: Emese Revfy
    Signed-off-by: Kees Cook

    Emese Revfy
     
  • When the compiler doesn't support gcc plugins (either due to missing
    headers or too old a version), report the problem and abort the build
    instead of emitting a warning and letting the build founder with arcane
    compiler errors.

    Signed-off-by: Kees Cook

    Kees Cook
     
  • The gcc-plugins arguments should not be included when performing
    cc-option tests.

    Steps to reproduce:
    1) make mrproper
    2) make defconfig
    3) enable GCC_PLUGINS, GCC_PLUGIN_CYC_COMPLEXITY
    4) enable FUNCTION_TRACER (it will select other options as well)
    5) make && make modules

    Build errors:
    MODPOST 18 modules
    ERROR: "__fentry__" [net/netfilter/xt_nat.ko] undefined!
    ERROR: "__fentry__" [net/netfilter/xt_mark.ko] undefined!
    ERROR: "__fentry__" [net/netfilter/xt_addrtype.ko] undefined!
    ERROR: "__fentry__" [net/netfilter/xt_LOG.ko] undefined!
    ERROR: "__fentry__" [net/netfilter/nf_nat_sip.ko] undefined!
    ERROR: "__fentry__" [net/netfilter/nf_nat_irc.ko] undefined!
    ERROR: "__fentry__" [net/netfilter/nf_nat_ftp.ko] undefined!
    ERROR: "__fentry__" [net/netfilter/nf_nat.ko] undefined!

    Reported-by: Laura Abbott
    Signed-off-by: Emese Revfy
    [kees: renamed variable, clarified commit message]
    Signed-off-by: Kees Cook

    Emese Revfy
     
  • According to E-EDID spec 1.3, table 3.9, a digital video sink with the
    "DFP 1.x compliant TMDS" bit set is "signal compatible with VESA DFP 1.x
    TMDS CRGB, 1 pixel / clock, up to 8 bits / color MSB aligned".

    For such displays, the DFP spec 1.0, section 3.10 "EDID support" says:

    "If the DFP monitor only supports EDID 1.X (1.1, 1.2, etc.)
    without extensions, the host will make the following assumptions:

    1. 24-bit MSB-aligned RGB TFT
    2. DE polarity is active high
    3. H and V syncs are active high
    4. Established CRT timings will be used
    5. Dithering will not be enabled on the host"

    So if we don't know the bit depth of the display from additional
    colorimetry info we should assume 8 bpc / 24 bpp by default.

    This patch adds info->bpc = 8 assignement for that case.

    Signed-off-by: Mario Kleiner
    Cc: Jani Nikula
    Cc: Ville Syrjälä
    Cc: Daniel Vetter
    Signed-off-by: Dave Airlie

    Mario Kleiner
     
  • This reverts commit 013dd9e03872
    ("drm/i915/dp: fall back to 18 bpp when sink capability is unknown")

    This commit introduced a regression into stable kernels,
    as it reduces output color depth to 6 bpc for any video
    sink connected to a Displayport connector if that sink
    doesn't report a specific color depth via EDID, or if
    our EDID parser doesn't actually recognize the proper
    bpc from EDID.

    Affected are active DisplayPort->VGA converters and
    active DisplayPort->DVI converters. Both should be
    able to handle 8 bpc, but are degraded to 6 bpc with
    this patch.

    The reverted commit was meant to fix
    Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=105331

    A followup patch implements a fix for that specific bug,
    which is caused by a faulty EDID of the affected DP panel
    by adding a new EDID quirk for that panel.

    DP 18 bpp fallback handling and other improvements to
    DP sink bpc detection will be handled for future
    kernels in a separate series of patches.

    Please backport to stable.

    Signed-off-by: Mario Kleiner
    Acked-by: Jani Nikula
    Cc: stable@vger.kernel.org
    Cc: Ville Syrjälä
    Cc: Daniel Vetter
    Signed-off-by: Dave Airlie

    Mario Kleiner
     
  • Bugzilla https://bugzilla.kernel.org/show_bug.cgi?id=105331
    reports that the "AEO model 0" display is driven with 8 bpc
    without dithering by default, which looks bad because that
    panel is apparently a 6 bpc DP panel with faulty EDID.

    A fix for this was made by commit 013dd9e03872
    ("drm/i915/dp: fall back to 18 bpp when sink capability is unknown").

    That commit triggers new regressions in precision for DP->DVI and
    DP->VGA displays. A patch is out to revert that commit, but it will
    revert video output for the AEO model 0 panel to 8 bpc without
    dithering.

    The EDID 1.3 of that panel, as decoded from the xrandr output
    attached to that bugzilla bug report, is somewhat faulty, and beyond
    other problems also sets the "DFP 1.x compliant TMDS" bit, which
    according to DFP spec means to drive the panel with 8 bpc and
    no dithering in absence of other colorimetry information.

    Try to make the original bug reporter happy despite the
    faulty EDID by adding a quirk to mark that panel as 6 bpc,
    so 6 bpc output with dithering creates a nice picture.

    Tested by injecting the edid from the fdo bug into a DP connector
    via drm_kms_helper.edid_firmware and verifying the 6 bpc + dithering
    is selected.

    This patch should be backported to stable.

    Signed-off-by: Mario Kleiner
    Cc: stable@vger.kernel.org
    Cc: Jani Nikula
    Cc: Ville Syrjälä
    Cc: Daniel Vetter
    Signed-off-by: Dave Airlie

    Mario Kleiner
     
  • Pull lkdtm update from Kees Cook:
    "Fix rebuild problem with LKDTM's rodata test"

    [ This, and the usercopy branch, both came in before the merge window
    closed, but ended up in my 'need to look more' queue and thus got
    merged only after rc1 was out ]

    * tag 'lkdtm-v4.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux:
    lkdtm: Fix targets for objcopy usage
    lkdtm: fix false positive warning from -Wmaybe-uninitialized

    Linus Torvalds
     
  • Pull usercopy protection from Kees Cook:
    "Tbhis implements HARDENED_USERCOPY verification of copy_to_user and
    copy_from_user bounds checking for most architectures on SLAB and
    SLUB"

    * tag 'usercopy-v4.8' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux:
    mm: SLUB hardened usercopy support
    mm: SLAB hardened usercopy support
    s390/uaccess: Enable hardened usercopy
    sparc/uaccess: Enable hardened usercopy
    powerpc/uaccess: Enable hardened usercopy
    ia64/uaccess: Enable hardened usercopy
    arm64/uaccess: Enable hardened usercopy
    ARM: uaccess: Enable hardened usercopy
    x86/uaccess: Enable hardened usercopy
    mm: Hardened usercopy
    mm: Implement stack frame object validation
    mm: Add is_migrate_cma_page

    Linus Torvalds
     
  • When I initially added the unsafe_[get|put]_user() helpers in commit
    5b24a7a2aa20 ("Add 'unsafe' user access functions for batched
    accesses"), I made the mistake of modeling the interface on our
    traditional __[get|put]_user() functions, which return zero on success,
    or -EFAULT on failure.

    That interface is fairly easy to use, but it's actually fairly nasty for
    good code generation, since it essentially forces the caller to check
    the error value for each access.

    In particular, since the error handling is already internally
    implemented with an exception handler, and we already use "asm goto" for
    various other things, we could fairly easily make the error cases just
    jump directly to an error label instead, and avoid the need for explicit
    checking after each operation.

    So switch the interface to pass in an error label, rather than checking
    the error value in the caller. Best do it now before we start growing
    more users (the signal handling code in particular would be a good place
    to use the new interface).

    So rather than

    if (unsafe_get_user(x, ptr))
    ... handle error ..

    the interface is now

    unsafe_get_user(x, ptr, label);

    where an error during the user mode fetch will now just cause a jump to
    'label' in the caller.

    Right now the actual _implementation_ of this all still ends up being a
    "if (err) goto label", and does not take advantage of any exception
    label tricks, but for "unsafe_put_user()" in particular it should be
    fairly straightforward to convert to using the exception table model.

    Note that "unsafe_get_user()" is much harder to convert to a clever
    exception table model, because current versions of gcc do not allow the
    use of "asm goto" (for the exception) with output values (for the actual
    value to be fetched). But that is hopefully not a limitation in the
    long term.

    [ Also note that it might be a good idea to switch unsafe_get_user() to
    actually _return_ the value it fetches from user space, but this
    commit only changes the error handling semantics ]

    Signed-off-by: Linus Torvalds

    Linus Torvalds
     
  • In commit 874f9c7da9a4 ("printk: create pr_ functions"), new
    pr_level defines were added to printk.c.

    These new defines are guarded by an #ifdef CONFIG_PRINTK - however,
    there is already a surrounding #ifdef CONFIG_PRINTK starting a lot
    earlier in line 249 which means the newly introduced #ifdef is
    unnecessary.

    Let's remove it to avoid confusion.

    Signed-off-by: Andreas Ziegler
    Cc: Joe Perches
    Cc: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andreas Ziegler
     
  • WMI event 0xe00e is received when battery was removed or inserted.

    Signed-off-by: Pali Rohár
    Signed-off-by: Darren Hart

    Pali Rohár
     
  • The caller expects %rdi to remain intact, push+pop it make that happen.

    Fixes the following kind of explosions on my core2duo machine when
    trying to reboot or shut down:

    general protection fault: 0000 [#1] PREEMPT SMP
    Modules linked in: i915 i2c_algo_bit drm_kms_helper cfbfillrect syscopyarea cfbimgblt sysfillrect sysimgblt fb_sys_fops cfbcopyarea drm netconsole configfs binfmt_misc iTCO_wdt psmouse pcspkr snd_hda_codec_idt e100 coretemp hwmon snd_hda_codec_generic i2c_i801 mii i2c_smbus lpc_ich mfd_core snd_hda_intel uhci_hcd snd_hda_codec snd_hwdep snd_hda_core ehci_pci 8250 ehci_hcd snd_pcm 8250_base usbcore evdev serial_core usb_common parport_pc parport snd_timer snd soundcore
    CPU: 0 PID: 3070 Comm: reboot Not tainted 4.8.0-rc1-perf-dirty #69
    Hardware name: /D946GZIS, BIOS TS94610J.86A.0087.2007.1107.1049 11/07/2007
    task: ffff88012a0b4080 task.stack: ffff880123850000
    RIP: 0010:[] [] x86_perf_event_update+0x52/0xc0
    RSP: 0018:ffff880123853b60 EFLAGS: 00010087
    RAX: 0000000000000001 RBX: ffff88012fc0a3c0 RCX: 000000000000001e
    RDX: 0000000000000000 RSI: 0000000040000000 RDI: ffff88012b014800
    RBP: ffff880123853b88 R08: ffffffffffffffff R09: 0000000000000000
    R10: ffffea0004a012c0 R11: ffffea0004acedc0 R12: ffffffff80000001
    R13: ffff88012b0149c0 R14: ffff88012b014800 R15: 0000000000000018
    FS: 00007f8b155cd700(0000) GS:ffff88012fc00000(0000) knlGS:0000000000000000
    CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
    CR2: 00007f8b155f5000 CR3: 000000012a2d7000 CR4: 00000000000006f0
    Stack:
    ffff88012fc0a3c0 ffff88012b014800 0000000000000004 0000000000000001
    ffff88012fc1b750 ffff880123853bb0 ffffffff81003d59 ffff88012b014800
    ffff88012fc0a3c0 ffff88012b014800 ffff880123853bd8 ffffffff81003e13
    Call Trace:
    [] x86_pmu_stop+0x59/0xd0
    [] x86_pmu_del+0x43/0x140
    [] event_sched_out.isra.105+0xbd/0x260
    [] __perf_remove_from_context+0x2d/0xb0
    [] __perf_event_exit_context+0x4d/0x70
    [] generic_exec_single+0xb6/0x140
    [] ? __perf_remove_from_context+0xb0/0xb0
    [] ? __perf_remove_from_context+0xb0/0xb0
    [] smp_call_function_single+0xdf/0x140
    [] perf_event_exit_cpu_context+0x87/0xc0
    [] perf_reboot+0x13/0x40
    [] notifier_call_chain+0x4a/0x70
    [] __blocking_notifier_call_chain+0x47/0x60
    [] blocking_notifier_call_chain+0x16/0x20
    [] kernel_restart_prepare+0x1d/0x40
    [] kernel_restart+0x12/0x60
    [] SYSC_reboot+0xf6/0x1b0
    [] ? mntput_no_expire+0x2c/0x1b0
    [] ? mntput+0x24/0x40
    [] ? __fput+0x16c/0x1e0
    [] ? ____fput+0xe/0x10
    [] ? task_work_run+0x83/0xa0
    [] ? exit_to_usermode_loop+0x53/0xc0
    [] ? trace_hardirqs_on_thunk+0x1a/0x1c
    [] SyS_reboot+0xe/0x10
    [] entry_SYSCALL_64_fastpath+0x18/0xa3
    Code: 7c 4c 8d af c0 01 00 00 49 89 fe eb 10 48 09 c2 4c 89 e0 49 0f b1 55 00 4c 39 e0 74 35 4d 8b a6 c0 01 00 00 41 8b 8e 60 01 00 00 33 8b 35 6e 02 8c 00 48 c1 e2 20 85 f6 7e d2 48 89 d3 89 cf
    RIP [] x86_perf_event_update+0x52/0xc0
    RSP
    ---[ end trace 7ec95181faf211be ]---
    note: reboot[3070] exited with preempt_count 2

    Cc: Borislav Petkov
    Cc: H. Peter Anvin
    Cc: Andy Lutomirski
    Cc: Brian Gerst
    Cc: Denys Vlasenko
    Cc: Peter Zijlstra
    Cc: Thomas Gleixner
    Cc: Ingo Molnar
    Fixes: f5967101e9de ("x86/hweight: Get rid of the special calling convention")
    Signed-off-by: Ville Syrjälä
    Signed-off-by: Linus Torvalds

    Ville Syrjälä
     

08 Aug, 2016

11 commits

  • A few fixes for amdgpu and ttm for 4.8
    - fix a ttm regression caused by the new pipelining code
    - fixes for mullins on amdgpu
    - updated golden settings for amdgpu

    * 'drm-next-4.8' of git://people.freedesktop.org/~agd5f/linux:
    drm/ttm: Wait for a BO to become idle before unbinding it from GTT
    drm/amdgpu: update golden setting of polaris10
    drm/amdgpu: update golden setting of stoney
    drm/amdgpu: update golden setting of polaris11
    drm/amdgpu: update golden setting of carrizo
    drm/amdgpu: update golden setting of iceland
    drm/amd/amdgpu: change pptable output format from ASCII to binary
    drm/amdgpu/ci: add mullins to default case for smc ucode
    drm/amdgpu/gmc7: add missing mullins case

    Dave Airlie
     
  • 3 intel fixes.

    * tag 'drm-intel-next-fixes-2016-08-05' of git://anongit.freedesktop.org/drm-intel:
    drm/i915/fbdev: Check for the framebuffer before use
    drm/i915: Never fully mask the the EI up rps interrupt on SNB/IVB
    drm/i915: Wait up to 3ms for the pcu to ack the cdclk change request on SKL

    Dave Airlie
     
  • drm_connector_register_all requires a few too many locks because our
    connector_list locking is busted. Add another FIXME+hack to work
    around this. This should address the below lockdep splat:

    ======================================================
    [ INFO: possible circular locking dependency detected ]
    4.7.0-rc5+ #524 Tainted: G O
    -------------------------------------------------------
    kworker/u8:0/6 is trying to acquire lock:
    (&dev->mode_config.mutex){+.+.+.}, at: [] drm_modeset_lock_all+0x40/0x120

    but task is already holding lock:
    ((fb_notifier_list).rwsem){++++.+}, at: [] __blocking_notifier_call_chain+0x35/0x70

    which lock already depends on the new lock.

    the existing dependency chain (in reverse order) is:

    -> #1 ((fb_notifier_list).rwsem){++++.+}:
    [] lock_acquire+0xb1/0x200
    [] down_write+0x44/0x80
    [] blocking_notifier_chain_register+0x21/0xb0
    [] fb_register_client+0x18/0x20
    [] backlight_device_register+0x136/0x260
    [] intel_backlight_device_register+0xa2/0x160 [i915]
    [] intel_connector_register+0xe/0x10 [i915]
    [] intel_dp_connector_register+0x1b/0x80 [i915]
    [] drm_connector_register+0x4a/0x80
    [] drm_connector_register_all+0x64/0xf0
    [] drm_modeset_register_all+0x174/0x1c0
    [] drm_dev_register+0xc2/0xd0
    [] i915_driver_load+0x1547/0x2200 [i915]
    [] i915_pci_probe+0x4f/0x70 [i915]
    [] local_pci_probe+0x45/0xa0
    [] pci_device_probe+0xdb/0x130
    [] driver_probe_device+0x223/0x440
    [] __driver_attach+0xd5/0x100
    [] bus_for_each_dev+0x66/0xa0
    [] driver_attach+0x1e/0x20
    [] bus_add_driver+0x1ee/0x280
    [] driver_register+0x60/0xe0
    [] __pci_register_driver+0x60/0x70
    [] i915_init+0x5b/0x62 [i915]
    [] do_one_initcall+0x3d/0x150
    [] do_init_module+0x5f/0x1d9
    [] load_module+0x20e6/0x27e0
    [] SYSC_finit_module+0xc3/0xf0
    [] SyS_finit_module+0xe/0x10
    [] entry_SYSCALL_64_fastpath+0x1c/0xac

    -> #0 (&dev->mode_config.mutex){+.+.+.}:
    [] __lock_acquire+0x10fc/0x1260
    [] lock_acquire+0xb1/0x200
    [] mutex_lock_nested+0x67/0x3c0
    [] drm_modeset_lock_all+0x40/0x120
    [] drm_fb_helper_restore_fbdev_mode_unlocked+0x2b/0x80
    [] drm_fb_helper_set_par+0x2d/0x50
    [] intel_fbdev_set_par+0x1a/0x60 [i915]
    [] fbcon_init+0x586/0x610
    [] visual_init+0xca/0x130
    [] do_bind_con_driver+0x1c1/0x3a0
    [] do_take_over_console+0x116/0x180
    [] do_fbcon_takeover+0x57/0xb0
    [] fbcon_event_notify+0x658/0x750
    [] notifier_call_chain+0x3e/0xb0
    [] __blocking_notifier_call_chain+0x4d/0x70
    [] blocking_notifier_call_chain+0x16/0x20
    [] fb_notifier_call_chain+0x1b/0x20
    [] register_framebuffer+0x251/0x330
    [] drm_fb_helper_initial_config+0x25f/0x3f0
    [] intel_fbdev_initial_config+0x18/0x30 [i915]
    [] async_run_entry_fn+0x48/0x150
    [] process_one_work+0x1e7/0x750
    [] worker_thread+0x4b/0x4f0
    [] kthread+0xef/0x110
    [] ret_from_fork+0x1f/0x40

    other info that might help us debug this:

    Possible unsafe locking scenario:

    CPU0 CPU1
    ---- ----
    lock((fb_notifier_list).rwsem);
    lock(&dev->mode_config.mutex);
    lock((fb_notifier_list).rwsem);
    lock(&dev->mode_config.mutex);

    *** DEADLOCK ***

    6 locks held by kworker/u8:0/6:
    #0: ("events_unbound"){.+.+.+}, at: [] process_one_work+0x169/0x750
    #1: ((&entry->work)){+.+.+.}, at: [] process_one_work+0x169/0x750
    #2: (registration_lock){+.+.+.}, at: [] register_framebuffer+0x27/0x330
    #3: (console_lock){+.+.+.}, at: [] register_framebuffer+0x26e/0x330
    #4: (&fb_info->lock){+.+.+.}, at: [] lock_fb_info+0x1d/0x40
    #5: ((fb_notifier_list).rwsem){++++.+}, at: [] __blocking_notifier_call_chain+0x35/0x70

    stack backtrace:
    CPU: 2 PID: 6 Comm: kworker/u8:0 Tainted: G O 4.7.0-rc5+ #524
    Hardware name: Intel Corp. Broxton P/NOTEBOOK, BIOS APLKRVPA.X64.0138.B33.1606250842 06/25/2016
    Workqueue: events_unbound async_run_entry_fn
    0000000000000000 ffff8800758577f0 ffffffff814507a5 ffffffff828b9900
    ffffffff828b9900 ffff880075857830 ffffffff810dc6fa ffff880075857880
    ffff88007584d688 0000000000000005 0000000000000006 ffff88007584d6b0
    Call Trace:
    [] dump_stack+0x67/0x92
    [] print_circular_bug+0x1aa/0x200
    [] __lock_acquire+0x10fc/0x1260
    [] lock_acquire+0xb1/0x200
    [] ? drm_modeset_lock_all+0x40/0x120
    [] ? drm_modeset_lock_all+0x40/0x120
    [] mutex_lock_nested+0x67/0x3c0
    [] ? drm_modeset_lock_all+0x40/0x120
    [] ? rcu_read_lock_sched_held+0x7f/0x90
    [] ? kmem_cache_alloc_trace+0x248/0x2b0
    [] ? drm_modeset_lock_all+0x25/0x120
    [] drm_modeset_lock_all+0x40/0x120
    [] drm_fb_helper_restore_fbdev_mode_unlocked+0x2b/0x80
    [] drm_fb_helper_set_par+0x2d/0x50
    [] intel_fbdev_set_par+0x1a/0x60 [i915]
    [] fbcon_init+0x586/0x610
    [] visual_init+0xca/0x130
    [] do_bind_con_driver+0x1c1/0x3a0
    [] do_take_over_console+0x116/0x180
    [] do_fbcon_takeover+0x57/0xb0
    [] fbcon_event_notify+0x658/0x750
    [] notifier_call_chain+0x3e/0xb0
    [] __blocking_notifier_call_chain+0x4d/0x70
    [] blocking_notifier_call_chain+0x16/0x20
    [] fb_notifier_call_chain+0x1b/0x20
    [] register_framebuffer+0x251/0x330
    [] ? vga_switcheroo_client_fb_set+0x5d/0x70
    [] drm_fb_helper_initial_config+0x25f/0x3f0
    [] intel_fbdev_initial_config+0x18/0x30 [i915]
    [] async_run_entry_fn+0x48/0x150
    [] process_one_work+0x1e7/0x750
    [] ? process_one_work+0x169/0x750
    [] worker_thread+0x4b/0x4f0
    [] ? process_one_work+0x750/0x750
    [] kthread+0xef/0x110
    [] ret_from_fork+0x1f/0x40
    [] ? kthread_stop+0x2e0/0x2e0

    v2: Rebase onto the right branch (hand-editing patches ftw) and add more
    reporters.

    Reported-by: Imre Deak
    Cc: Imre Deak
    Cc: Chris Wilson
    Acked-by: Chris Wilson
    Reported-by: Jiri Kosina
    Cc: Jiri Kosina
    Signed-off-by: Daniel Vetter
    Signed-off-by: Dave Airlie

    Daniel Vetter
     
  • The conversion of the rcar-du driver from the I2C slave encoder to the
    DRM bridge API left the HDMI encoder's bridge pointer NULL, preventing
    the bridge from being handled automatically by the DRM core. Fix it.

    Fixes: 1d926114d8f4 ("drm: rcar-du: Remove i2c slave encoder interface for hdmi encoder")
    Signed-off-by: Laurent Pinchart
    Signed-off-by: Dave Airlie

    Laurent Pinchart
     
  • Linus Torvalds
     
  • Pull more block fixes from Jens Axboe:
    "As mentioned in the pull the other day, a few more fixes for this
    round, all related to the bio op changes in this series.

    Two fixes, and then a cleanup, renaming bio->bi_rw to bio->bi_opf. I
    wanted to do that change right after or right before -rc1, so that
    risk of conflict was reduced. I just rebased the series on top of
    current master, and no new ->bi_rw usage has snuck in"

    * 'for-linus' of git://git.kernel.dk/linux-block:
    block: rename bio bi_rw to bi_opf
    target: iblock_execute_sync_cache() should use bio_set_op_attrs()
    mm: make __swap_writepage() use bio_set_op_attrs()
    block/mm: make bdev_ops->rw_page() take a bool for read/write

    Linus Torvalds
     
  • Pull drm zpos property support from Dave Airlie:
    "This tree was waiting on some media stuff I hadn't had time to get a
    stable branchpoint off, so I just waited until it was all in your tree
    first.

    It's been around a bit on the list and shouldn't affect anything
    outside adding the generic API and moving some ARM drivers to using
    it"

    * tag 'drm-for-v4.8-zpos' of git://people.freedesktop.org/~airlied/linux:
    drm: rcar: use generic code for managing zpos plane property
    drm/exynos: use generic code for managing zpos plane property
    drm: sti: use generic zpos for plane
    drm: add generic zpos property

    Linus Torvalds
     
  • Since commit 63a4cc24867d, bio->bi_rw contains flags in the lower
    portion and the op code in the higher portions. This means that
    old code that relies on manually setting bi_rw is most likely
    going to be broken. Instead of letting that brokeness linger,
    rename the member, to force old and out-of-tree code to break
    at compile time instead of at runtime.

    No intended functional changes in this commit.

    Signed-off-by: Jens Axboe

    Jens Axboe
     
  • The original commit missed this function, it needs to mark it a
    write flush.

    Cc: Mike Christie
    Fixes: e742fc32fcb4 ("target: use bio op accessors")
    Signed-off-by: Jens Axboe

    Jens Axboe
     
  • Cleaner than manipulating bio->bi_rw flags directly.

    Signed-off-by: Jens Axboe

    Jens Axboe
     
  • Commit abf545484d31 changed it from an 'rw' flags type to the
    newer ops based interface, but now we're effectively leaking
    some bdev internals to the rest of the kernel. Since we only
    care about whether it's a read or a write at that level, just
    pass in a bool 'is_write' parameter instead.

    Then we can also move op_is_write() and friends back under
    CONFIG_BLOCK protection.

    Reviewed-by: Mike Christie
    Signed-off-by: Jens Axboe

    Jens Axboe
     

07 Aug, 2016

1 commit

  • Pull documentation fixes from Jonathan Corbet:
    "Three fixes for the docs build, including removing an annoying warning
    on 'make help' if sphinx isn't present"

    * tag 'doc-4.8-fixes' of git://git.lwn.net/linux:
    DocBook: use DOCBOOKS="" to ignore DocBooks instead of IGNORE_DOCBOOKS=1
    Documenation: update cgroup's document path
    Documentation/sphinx: do not warn about missing tools in 'make help'

    Linus Torvalds