Eric Lee / smarc-fsl-linux-kernel

07 Sep, 2010

1 commit

20 May, 2010

1 commit

10 May, 2010

1 commit

13 Apr, 2010

3 commits

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

14 Dec, 2009

1 commit

  • 0d64b568f   ALSA: sound/isa/gus: Correct code taking the size of a pointer ... Browse Code »

    sizeof(share_id) is just the size of the pointer. On the other hand,
    block->share_id is an array, so its size seems more appropriate.

    A simplified version of the semantic patch that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    //
    @@
    expression *x;
    expression f;
    type T;
    @@

    *f(...,(T)x,...)
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: Takashi Iwai

    Julia Lawall
     

19 Jul, 2009

1 commit

  • fcb2954b9   ALSA: sound/isa: convert nested spin_lock_irqsave to spin_lock ... Browse Code »

    If spin_lock_irqsave is called twice in a row with the same second
    argument, the interrupt state at the point of the second call overwrites
    the value saved by the first call. Indeed, the second call does not need
    to save the interrupt state, so it is changed to a simple spin_lock.

    The semantic match that finds this problem is as follows:
    (http://www.emn.fr/x-info/coccinelle/)

    //
    @@
    expression lock1,lock2;
    expression flags;
    @@

    *spin_lock_irqsave(lock1,flags)
    ... when != flags
    *spin_lock_irqsave(lock2,flags)
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: Takashi Iwai

    Julia Lawall
     

04 Jun, 2009

1 commit

17 Feb, 2009

1 commit

05 Feb, 2009

1 commit

29 Jan, 2009

1 commit

12 Jan, 2009

2 commits

03 Nov, 2008

1 commit

13 Aug, 2008

1 commit

06 Aug, 2008

2 commits

01 Feb, 2008

3 commits

  • 9004acc70   [ALSA] Remove sound/driver.h ... Browse Code »

    This header file exists only for some hacks to adapt alsa-driver
    tree. It's useless for building in the kernel. Let's move a few
    lines in it to sound/core.h and remove it.
    With this patch, sound/driver.h isn't removed but has just a single
    compile warning to include it. This should be really killed in
    future.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     
  • 109c53f84   [ALSA] sound/isa: kill pnp_resource_change ... Browse Code »

    This removes the pnp_resource_change use from the ALSA ISAPnP drivers. In
    2.4 these were useful in providing an easy path to setting the resources,
    but in 2.6 they retain function as a layering violation only.
    This makes for a nice cleanup (-550 lines) of ALSA but moreover, ALSA is the
    only remaining user of pnp_init_resource_table(), pnp_resource_change() and
    pnp_manual_config_dev() (and, in fact, of 'struct pnp_resource_table') in
    the tree outide of drivers/pnp itself meaning it makes for more cleanup
    potential inside the PnP layer.
    Thomas Renninger acked their removal from that side, you did from the ALSA
    side (CC list just copied from that thread).
    Against current alsa-kernel HG. Many more potential cleanups in there, but
    this _only_ removes the pnp_resource_change code. Compile tested against
    current alsa-kernel HG and compile- and use-tested against 2.6.23.x (few
    offsets).
    Cc: Thomas Renninger

    Signed-off-by: Rene Herman
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Rene Herman
     
  • e5723b41a   [ALSA] Remove sequencer instrument layer ... Browse Code »

    Remove sequencer instrument layer from the tree.
    This mechanism hasn't been used much with the actual devices. The only
    reasonable user was OPL3 loader, and now it was rewritten to use hwdep
    instead. So, let's remove the rest of rotten codes.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     

16 Oct, 2007

3 commits

  • c2cbdbb15   [ALSA] fix bootup crash in snd_gus_interrupt() ... Browse Code »

    when simulating a storm of fake GUS interrupts (without actually owning
    this venerable piece of ISA hardware) the driver falls over (crashes) in
    two ways:
    1) spinlocks being initialized too late:
    INFO: trying to register non-static key.
    the code is fine but needs lockdep annotation.
    turning off the locking correctness validator.
    [] show_trace_log_lvl+0x1a/0x30
    [] show_trace+0x12/0x20
    [] dump_stack+0x16/0x20
    [] __lock_acquire+0xcfb/0x1030
    [] lock_acquire+0x60/0x80
    [] _spin_lock_irqsave+0x38/0x50
    [] snd_gf1_i_look8+0x22/0x60
    [] snd_gus_interrupt+0x13e/0x270
    [] handle_IRQ_event+0x28/0x60
    [] handle_fasteoi_irq+0x71/0xe0
    [] do_IRQ+0x48/0xa0
    [] common_interrupt+0x2e/0x40
    [] register_handler_proc+0x92/0xf0
    [] setup_irq+0xe2/0x190
    [] request_irq+0xb4/0xd0
    [] snd_gus_create+0x124/0x3c0
    [] snd_gusclassic_probe+0x2a7/0x4b0
    [] isa_bus_probe+0x1f/0x30
    [] driver_probe_device+0x84/0x190
    [] __device_attach+0x8/0x10
    [] bus_for_each_drv+0x53/0x80
    [] device_attach+0x8b/0x90
    [] bus_attach_device+0x48/0x80
    [] device_add+0x45d/0x5a0
    [] device_register+0x12/0x20
    [] isa_register_driver+0xb3/0x140
    [] alsa_card_gusclassic_init+0x12/0x20
    [] kernel_init+0x133/0x310
    [] kernel_thread_helper+0x7/0x10
    =======================
    2) callback functions not being filled in yet:
    BUG: unable to handle kernel NULL pointer dereference at virtual address 00000000
    printing eip:
    00000000
    *pde = 00000000
    Oops: 0000 [#1]
    SMP DEBUG_PAGEALLOC
    CPU: 0
    EIP: 0060:[] Not tainted VLI
    EFLAGS: 00010002 (2.6.23 #37)
    EIP is at 0x0
    eax: 7fe94000 ebx: 7fe94000 ecx: 00000000 edx: 00000226
    esi: 00000000 edi: 00000005 ebp: 7ff87c28 esp: 7ff87bf4
    ds: 007b es: 007b fs: 00d8 gs: 0000 ss: 0068
    Process swapper (pid: 1, ti=7ff86000 task=7ff84000 task.ti=7ff86000)
    Stack: 40590683 408424a9 408db87c 00000029 40787406 00000064 00000046 ff000000
    000000ff 00000001 7faefaf0 00000000 00000005 7ff87c40 401548e8 00000000
    40a52000 7faefaf0 00000005 7ff87c58 40155cc1 40a52030 00000005 00000000
    Call Trace:
    [] show_trace_log_lvl+0x1a/0x30
    [] show_stack_log_lvl+0xab/0xd0
    [] show_registers+0x1cc/0x2d0
    [] die+0x116/0x240
    [] do_page_fault+0x18b/0x670
    [] error_code+0x72/0x80
    [] handle_IRQ_event+0x28/0x60
    [] handle_fasteoi_irq+0x71/0xe0
    [] do_IRQ+0x48/0xa0
    [] common_interrupt+0x2e/0x40
    [] proc_create+0x3e/0x120
    [] proc_mkdir_mode+0x23/0x50
    [] proc_mkdir+0xf/0x20
    [] register_handler_proc+0xd4/0xf0
    [] setup_irq+0xe2/0x190
    [] request_irq+0xb4/0xd0
    [] snd_gus_create+0x124/0x3c0
    [] snd_gusclassic_probe+0x2a7/0x4b0
    [] isa_bus_probe+0x1f/0x30
    [] driver_probe_device+0x84/0x190
    [] __device_attach+0x8/0x10
    [] bus_for_each_drv+0x53/0x80
    [] device_attach+0x8b/0x90
    [] bus_attach_device+0x48/0x80
    [] device_add+0x45d/0x5a0
    [] device_register+0x12/0x20
    [] isa_register_driver+0xb3/0x140
    [] alsa_card_gusclassic_init+0x12/0x20
    [] kernel_init+0x133/0x310
    [] kernel_thread_helper+0x7/0x10
    =======================
    Code: Bad EIP value.
    EIP: [] 0x0 SS:ESP 0068:7ff87bf4
    Kernel panic - not syncing: Fatal exception in interrupt
    with these things fixed, i get the expected 'no such hardware' result
    from the driver initialization:
    Calling initcall 0x40aa3dc0: alsa_card_gusclassic_init+0x0/0x20()
    ALSA sound/isa/gus/gusclassic.c:136: [0x220] check 1 failed - 0xff
    initcall 0x40aa3dc0: alsa_card_gusclassic_init+0x0/0x20() returned 0.
    initcall 0x40aa3dc0 ran for 133 msecs:
    alsa_card_gusclassic_init+0x0/0x20()

    Signed-off-by: Ingo Molnar
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Ingo Molnar
     
  • c1017a4cd   [ALSA] Changed Jaroslav Kysela's e-mail from perex@suse.cz to perex@perex.cz ... Browse Code »

    Signed-off-by: Jaroslav Kysela

    Jaroslav Kysela
     
  • a5ce88909   [ALSA] Clean up with common snd_ctl_boolean_*_info callbacks ... Browse Code »

    Clean up codes using the new common snd_ctl_boolean_*_info() callbacks.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     

16 May, 2007

1 commit

11 May, 2007

5 commits

14 Feb, 2007

1 commit

  • 788c60433   [ALSA] Fix __devinit and __devexit issues with sound drivers ... Browse Code »

    Fix __devinit and __devexit issues with sound drivers.
    Resolves MODPOST warnings similar to:
    WARNING: sound/drivers/snd-dummy.o - Section mismatch: reference to .init.text:snd_dummy_probe from .data.rel.local between 'snd_dummy_driver' (at offset 0x0) and 'snd_dummy_controls'
    WARNING: sound/drivers/snd-mtpav.o - Section mismatch: reference to .init.text:snd_mtpav_probe from .data.rel.local between 'snd_mtpav_driver' (at offset 0x0) and 'snd_mtpav_input'
    WARNING: sound/drivers/snd-virmidi.o - Section mismatch: reference to .init.text:snd_virmidi_probe from .data.rel.local after 'snd_virmidi_driver' (at offset 0x0)

    Signed-off-by: Prarit Bhargava
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Prarit Bhargava
     

09 Feb, 2007

1 commit

20 Dec, 2006

1 commit

22 Oct, 2006

1 commit

07 Oct, 2006

1 commit

  • c7bec5aba   Various drivers' irq handlers: kill dead code, needless casts ... Browse Code »

    - Eliminate casts to/from void*

    - Eliminate checks for conditions that never occur. These typically
    fall into two classes:

    1) Checking for 'dev_id == NULL', then it is never called with
    NULL as an argument.

    2) Checking for invalid irq number, when the only caller (the
    system) guarantees the irq handler is called with the proper
    'irq' number argument.

    Signed-off-by: Jeff Garzik

    Jeff Garzik
     

05 Oct, 2006

1 commit

  • 7d12e780e   IRQ: Maintain regs pointer globally rather than passing to IRQ handlers ... Browse Code »

    Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

23 Sep, 2006

1 commit

13 Jul, 2006

1 commit

03 Jul, 2006

1 commit