01 Sep, 2009
1 commit
-
In a couple of cases collapse some extra code like:
int retval = NETDEV_TX_OK;
...
return retval;
into
return NETDEV_TX_OK;Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller
20 Jul, 2009
1 commit
-
rain_maker@root-forum.org wrote:
> Hello cesar,
>
> In a recent thread in a german linux forum, a user reported his PIC
> NIC not being recognized by the kernel.
>
> Fortunately he provided enough information and I was able to help him
> and get the device working with the sc92031 driver.
>
> The device ID is [1088:2031] (Vendor is called "Microcomputer Systems
> (M) Son"), here is the respective thread in "ubuntuusers.de"
>
> http://forum.ubuntuusers.de/topic/lankarte-unter-xubuntu-wird-nicht-erkannt/
>
> (Although you might not speak german, the code provided will show
> you, that the device is actually working with your driver).
>
> It would be nice, if you include this new device ID to the
> sc92031-driver.
>
> Regards,
>
> Axel Köllhofer (aka Rain_Maker)Cc: rain_maker@root-forum.org
Signed-off-by: Cesar Eduardo Barros
Signed-off-by: David S. Miller
07 Apr, 2009
1 commit
-
Replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32)
Signed-off-by: Yang Hongyang
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
22 Jan, 2009
5 commits
-
Signed-off-by: Cesar Eduardo Barros
Signed-off-by: David S. Miller -
Instead of making up a name for the device ids, put them directly in the
device id table. Also move the vendor id to pci_ids.h.Signed-off-by: Cesar Eduardo Barros
Signed-off-by: David S. Miller -
SC92031_DESCRIPTION is only used in one place.
Signed-off-by: Cesar Eduardo Barros
Signed-off-by: David S. Miller -
The version string makes no sense anymore, since this driver is only
maintained within the kernel.Signed-off-by: Cesar Eduardo Barros
Signed-off-by: David S. Miller -
The banner currently printed when loading the module is mostly useless.
Replace it with a more informative one, printed after probing the device.
Output format copied from 8139cp/8139too.
Signed-off-by: Cesar Eduardo Barros
Signed-off-by: David S. Miller
11 Jan, 2009
1 commit
-
Many drivers lost the ability to set ethernet address accidently
during the net_device_ops conversion.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller
22 Nov, 2008
1 commit
-
Convert this driver to net_device_ops. Compile tested only.
Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller
04 Nov, 2008
1 commit
-
The generic packet receive code takes care of setting
netdev->last_rx when necessary, for the sake of the
bonding ARP monitor.Drivers need not do it any more.
Some cases had to be skipped over because the drivers
were making use of the ->last_rx value themselves.Signed-off-by: David S. Miller
31 May, 2008
1 commit
-
Commit 5a0a92e67b5009a71e011658da04fb92dad8961f mentions len < ETH_ZLEN
is true for ARP packets. This obviously is not unlikely.Signed-off-by: Cesar Eduardo Barros
Signed-off-by: Jeff Garzik
22 May, 2008
1 commit
-
IPv4 would work with this driver only with static arp table entries,
the patch reverts a padto introduced incommit 26a17b7bbb36a8552d531bc1ad08472fb5aa3007
sc92031: start transmit return value bugfixThe padto does not work because the driver code evaluates `len' later on and
there are cases where skb->len is not updated accordingly.This was observed with ARP frames (skb->len = 42 bytes, !skb_cloned(),
skb_tailroom = 84 bytes). Then in skb_pad(), the first condition is true, where
skb->len is not updated. As a consequence, the driver uses 42 bytes instead of
the 60 bytes, and the ARP frame never makes it onto the wire.Signed-off-by: Gerrit Renker
Signed-off-by: Jeff Garzik
17 Apr, 2008
3 commits
-
Use netdev_alloc_skb since it handles any NUMA node memory localtion issues
and sets skb->dev. Since device driver was not setting skb->dev, I bet
filter rules based on device would not work.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Any negative return value from start_xmit is interpreted as NETDEV_TX_LOCK
which is not what this driver wants. It should return 0 (NETDEV_TX_OK)
when it consumes a packet.Also, use skb_padto() as the generic way to pad small frames.
Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik -
Statistics structure is available for use in net_device structure.
Compile tested only.Signed-off-by: Stephen Hemminger
Signed-off-by: Jeff Garzik
12 Apr, 2008
1 commit
-
Add missing sysfs device association. Compile tested only -ENOHW.
Addresses http://bugzilla.kernel.org/show_bug.cgi?id=10380
Signed-off-by: Stephen Hemminger
Cc: Cesar Eduardo Barros
Cc:
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik
11 Oct, 2007
2 commits
-
These have been superceded by the new ->get_sset_count() hook.
Signed-off-by: Jeff Garzik
Signed-off-by: David S. Miller -
For the operations
get-tx-csum
get-sg
get-tso
get-ufo
the default ethtool_op_xxx behavior is fine for all drivers, so we
permit op==NULL to imply the default behavior.This provides a more uniform behavior across all drivers, eliminating
ethtool(8) "ioctl not supported" errors on older drivers that had
not been updated for the latest sub-ioctls.The ethtool_op_xxx() functions are left exported, in case anyone
wishes to call them directly from a driver-private implementation --
a not-uncommon case. Should an ethtool_op_xxx() helper remain unused
for a while, except by net/core/ethtool.c, we can un-export it at a
later date.[ Resolved conflicts with set/get value ethtool patch... -DaveM ]
Signed-off-by: Jeff Garzik
Signed-off-by: David S. Miller
01 Aug, 2007
1 commit
-
All drivers implement ethtool get_perm_addr the same way -- by calling
the generic function. So we can inline the generic function into the
caller and avoid going through the drivers.Signed-off-by: Matthew Wilcox
Signed-off-by: David S. Miller
26 Apr, 2007
1 commit
-
One less thing for drivers writers to worry about.
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller
10 Apr, 2007
1 commit
-
The spin_lock calls made in dev->open and dev->close must disable
BH since open/close are made in process context. Conversely, the
call in dev->hard_start_xmit does not need to disable BH since it
is already executing with BH disabled.Signed-off-by: Herbert Xu
Signed-off-by: David S. Miller
15 Feb, 2007
1 commit
-
The obsolete SA_xxx interrupt flags have been used despite the scheduled
removal. Fixup the remaining users in -mm.Signed-off-by: Thomas Gleixner
Acked-by: Ingo Molnar
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
06 Feb, 2007
1 commit
-
This is a driver for the Silan SC92031/Rsltek 8139D NIC chip.
This chip is found on at least one counterfeit Encore ENL832-TX-RENT NIC
[1], which came with a mini-CD with the 2.4 driver. A slightly older
version of the driver was found at [2]. The main difference between them
is that the newer one has a small bugfix in the RX path, a lot of
gratuitous renaming of functions, all the printable strings changed to show
as a "Rsltek 8139D" [sic], and a PCI ID of 8139 instead of 2031. The
driver on this patch is a rewrite of the vendor drivers (based mostly on
the older one).Changes from the previous patch sent to netdev:
- Use MMIO instead of PIO
- Changed TX bounce buffers allocation
- Use skb_copy_and_csum_dev
- Several small bug fixes
- Tested for more than just a few minutes each time[1] See http://www.encore-usa.com/faq.php under ENL832-TX-RENT for more
information
[2] Look for SL_LINUX.ZIP (which is really a .tar.gz) at
http://broadbandforum.in/dataone_Intex_LAN_cardlinux-t4207-s15.html
[3] To compile on 2.6.17, simply add back the last argument to the
interrupt handler in two places, and copy the boolean declarations
from 2.6.19[akpm@osdl.org: build fixes]
Signed-off-by: Cesar Eduardo Barros
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik