02 Nov, 2017

1 commit

  • Many source files in the tree are missing licensing information, which
    makes it harder for compliance tools to determine the correct license.

    By default all files without license information are under the default
    license of the kernel, which is GPL version 2.

    Update the files which contain no license information with the 'GPL-2.0'
    SPDX license identifier. The SPDX identifier is a legally binding
    shorthand, which can be used instead of the full boiler plate text.

    This patch is based on work done by Thomas Gleixner and Kate Stewart and
    Philippe Ombredanne.

    How this work was done:

    Patches were generated and checked against linux-4.14-rc6 for a subset of
    the use cases:
    - file had no licensing information it it.
    - file was a */uapi/* one with no licensing information in it,
    - file was a */uapi/* one with existing licensing information,

    Further patches will be generated in subsequent months to fix up cases
    where non-standard license headers were used, and references to license
    had to be inferred by heuristics based on keywords.

    The analysis to determine which SPDX License Identifier to be applied to
    a file was done in a spreadsheet of side by side results from of the
    output of two independent scanners (ScanCode & Windriver) producing SPDX
    tag:value files created by Philippe Ombredanne. Philippe prepared the
    base worksheet, and did an initial spot review of a few 1000 files.

    The 4.13 kernel was the starting point of the analysis with 60,537 files
    assessed. Kate Stewart did a file by file comparison of the scanner
    results in the spreadsheet to determine which SPDX license identifier(s)
    to be applied to the file. She confirmed any determination that was not
    immediately clear with lawyers working with the Linux Foundation.

    Criteria used to select files for SPDX license identifier tagging was:
    - Files considered eligible had to be source code files.
    - Make and config files were included as candidates if they contained >5
    lines of source
    - File already had some variant of a license header in it (even if
    Reviewed-by: Philippe Ombredanne
    Reviewed-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

22 Aug, 2017

1 commit


03 Aug, 2017

2 commits


24 Aug, 2016

1 commit

  • If devm_add_action() fails we are explicitly calling the cleanup to free
    the resources allocated. Lets use the helper devm_add_action_or_reset()
    and return directly in case of error, as we know that the cleanup function
    has been already called by the helper if there was any error.

    Signed-off-by: Sudip Mukherjee
    Reviewed-by: Heiko Stuebner
    Signed-off-by: Herbert Xu

    Sudip Mukherjee
     

28 Feb, 2016

1 commit


04 Dec, 2015

1 commit

  • Lockdep warns about a possible deadlock resulting from the use of regular
    spin_locks:

    =================================
    [ INFO: inconsistent lock state ]
    4.4.0-rc2+ #2724 Not tainted
    ---------------------------------
    inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage.
    ksoftirqd/0/3 [HC0[0]:SC1[1]:HE1:SE0] takes:
    (&(&crypto_info->lock)->rlock){+.?...}, at: [] rk_crypto_tasklet_cb+0x24/0xb4 [rk_crypto]
    {SOFTIRQ-ON-W} state was registered at:
    [] lock_acquire+0x178/0x218
    [] _raw_spin_lock+0x54/0x64
    [] rk_handle_req+0x7c/0xbc [rk_crypto]
    [] rk_des_ecb_encrypt+0x2c/0x30 [rk_crypto]
    [] rk_aes_ecb_encrypt+0x18/0x1c [rk_crypto]
    [] skcipher_encrypt_ablkcipher+0x64/0x68
    [] __test_skcipher+0x2a8/0x8dc
    [] test_skcipher+0x38/0xc4
    [] alg_test_skcipher+0x90/0xb0
    [] alg_test+0x1e8/0x280
    [] cryptomgr_test+0x34/0x54
    [] kthread+0xf4/0x10c
    [] ret_from_fork+0x14/0x24
    irq event stamp: 10672
    hardirqs last enabled at (10672): [] tasklet_action+0x48/0x104
    hardirqs last disabled at (10671): [] tasklet_action+0x20/0x104
    softirqs last enabled at (10658): [] __do_softirq+0x358/0x49c
    softirqs last disabled at (10669): [] run_ksoftirqd+0x40/0x80

    other info that might help us debug this:
    Possible unsafe locking scenario:

    CPU0
    ----
    lock(&(&crypto_info->lock)->rlock);

    lock(&(&crypto_info->lock)->rlock);

    *** DEADLOCK ***

    Fix this by moving to irq-disabling spinlocks.

    Signed-off-by: Heiko Stuebner
    Signed-off-by: Herbert Xu

    Heiko Stuebner
     

27 Nov, 2015

1 commit

  • Crypto driver support:
    ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_ede)
    You can alloc tags above in your case.

    And other algorithms and platforms will be added later on.

    Signed-off-by: Zain Wang
    Tested-by: Heiko Stuebner
    Signed-off-by: Herbert Xu

    Zain Wang