20 Aug, 2013
4 commits
-
Use devm_*() functions to make cleanup paths simpler.
Signed-off-by: Jingoo Han
Signed-off-by: Lee Jones -
Use devm_*() functions to make cleanup paths simpler.
Signed-off-by: Jingoo Han
Signed-off-by: Lee Jones -
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by: Jingoo Han
Signed-off-by: Lee Jones -
Include in order to fix the following errors.
drivers/mfd/pm8921-core.c:209:16: error: expected declaration specifiers or '...' before string constant
drivers/mfd/pm8921-core.c:210:20: error: expected declaration specifiers or '...' before string constant
drivers/mfd/pm8921-core.c:211:16: error: expected declaration specifiers or '...' before string constant
drivers/mfd/pm8921-core.c:212:14: error: expected declaration specifiers or '...' before string constantSigned-off-by: Jingoo Han
Signed-off-by: Lee Jones
15 Aug, 2013
14 commits
-
The reg_cache variable should be updated with current
steps in the reg_se register. Then the mask should
apply and clear the register. Previously, the reg_cache
can be an old redundant value that isn't updated.Signed-off-by: Zubair Lutfullah
Signed-off-by: Lee Jones -
The child device intends to perform DMA operations then it needs a dma
mask and params set. This patches copies them from the parent device.Signed-off-by: Benedikt Spranger
Signed-off-by: Holger Dengler
Signed-off-by: Lee Jones -
There is no need to use a per CPU workqueue to poll, especially with the
5s delay used, so allow the scheduler to use any CPU.Signed-off-by: Mark Brown
Signed-off-by: Lee Jones -
This patch adds DMI system IDs for the new Kontron modules COMe-bHL6 and
COMe-cTH6 to the Kontron PLD driver.Acked-by: Kevin Strasser
Signed-off-by: Michael Brunner
Signed-off-by: Lee Jones -
Hook up "pm_power_off" to palmas power off routine if there is DT
property "ti,system-power-controller" defined, so platform which is
powered by this regulator can be powered off properly.Acked-by: Nishanth Menon
Signed-off-by: Mallikarjun Kasoju
Signed-off-by: Bill Huang
Signed-off-by: Lee Jones -
This patch adds clock to list of mfd cells for s2mps11 and DT documentation
for clock part.Reviewed-by: Mike Turquette
Signed-off-by: Yadwinder Singh Brar
Signed-off-by: Lee Jones -
FX_CTRL2 is a volatile register and should be marked as such, this patch
does so.Signed-off-by: Charles Keepax
Signed-off-by: Lee Jones -
Signed-off-by: Charles Keepax
Signed-off-by: Lee Jones -
The mic detect level registers are used from common code to configure
the button detection code. Add these registers to the defaults list and
mark them as readable for wm5110.Signed-off-by: Charles Keepax
Signed-off-by: Lee Jones -
The FLL gains are present on all devices and controlled from common code
shared between them. This patch adds these registers into defaults list
for wm5110 and marks them as readable.Reported-by: D.J. Barrow
Signed-off-by: Charles Keepax
Signed-off-by: Lee Jones -
Reg_cache variable is used to lock step enable register
from being accessed and written by both TSC and ADC
at the same time.
However, it isn't updated anywhere in the code at all.If both TSC and ADC are used, eventually 1FFFF is always
written enabling all 16 steps uselessly causing a mess.Patch fixes it by correcting the locks and updates the
variable by reading the step enable registerSigned-off-by: Zubair Lutfullah
Signed-off-by: Lee Jones -
If we disable DCVDD before we mark the cache as cache only, we might
attempt to write to the chip whilst it is powered down and lose a write.Signed-off-by: Charles Keepax
Signed-off-by: Lee Jones -
Add CONFIG_PM_SLEEP to suspend/resume functions to fix the build
warnings when CONFIG_PM_SLEEP is not selected. This is because
sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used
when the CONFIG_PM_SLEEP is enabled.drivers/mfd/ab8500-gpadc.c:891:12: warning: 'ab8500_gpadc_suspend' defined but not used [-Wunused-function]
drivers/mfd/ab8500-gpadc.c:903:12: warning: 'ab8500_gpadc_resume' defined but not used [-Wunused-function]Acked-by: Linus Walleij
Signed-off-by: Jingoo Han
Signed-off-by: Lee Jones -
Add CONFIG_PM_RUNTIME to runtime_suspend/runtime_resume functions
to fix the build warnings when CONFIG_PM_RUNTIME is not selected.
This is because runtime PM callbacks defined by SET_RUNTIME_PM_OPS
are only used when the CONFIG_PM_RUNTIME is enabled.drivers/mfd/ab8500-gpadc.c:870:12: warning: 'ab8500_gpadc_runtime_suspend' defined but not used [-Wunused-function]
drivers/mfd/ab8500-gpadc.c:878:12: warning: 'ab8500_gpadc_runtime_resume' defined but not used [-Wunused-function]Acked-by: Linus Walleij
Signed-off-by: Jingoo Han
Signed-off-by: Lee Jones
07 Aug, 2013
2 commits
-
Add CONFIG_PM_SLEEP to suspend/resume functions to fix the build
warnings when CONFIG_PM_SLEEP is not selected. This is because
sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used
when the CONFIG_PM_SLEEP is enabled.drivers/mfd/ucb1x00-core.c:672:12: warning: 'ucb1x00_suspend' defined but not used [-Wunused-function]
drivers/mfd/ucb1x00-core.c:704:12: warning: 'ucb1x00_resume' defined but not used [-Wunused-function]Signed-off-by: Jingoo Han
Signed-off-by: Lee Jones -
'mmc_callback_data' and 'vtg' are pointers.
Fix the following sparse warning:
drivers/mfd/menelaus.c:445:43: warning: Using plain integer as NULL pointer
drivers/mfd/menelaus.c:469:20: warning: Using plain integer as NULL pointerSigned-off-by: Jingoo Han
Signed-off-by: Lee Jones
01 Aug, 2013
3 commits
-
twl4030_power_configure_scripts(), twl4030_power_configure_resources(),
twl4030_power_probe() are used only in this file.Fix the following sparse warnings:
drivers/mfd/twl4030-power.c:496:5: warning: symbol 'twl4030_power_configure_scripts' was not declared. Should it be static?
drivers/mfd/twl4030-power.c:512:5: warning: symbol 'twl4030_power_configure_resources' was not declared. Should it be static?
drivers/mfd/twl4030-power.c:556:5: warning: symbol 'twl4030_power_probe' was not declared. Should it be static?Signed-off-by: Jingoo Han
Signed-off-by: Lee Jones -
'lpc_chipset_info' is used only in this file.
Fix the following sparse warning:
drivers/mfd/lpc_ich.c:216:21: warning: symbol 'lpc_chipset_info' was not declared. Should it be static?
Signed-off-by: Jingoo Han
Signed-off-by: Lee Jones -
Casting (void *) data of max8997_pmic_dt_match is necessary,
because variable 'data' of struct 'of_device_id' is defined as
'const void *data'. Thus, pointer should be used instead of value.Signed-off-by: Jingoo Han
Signed-off-by: Lee Jones
31 Jul, 2013
17 commits
-
It is only called from this file so there is no need for it to be in the
global namespace and cause sparse to warn.Signed-off-by: Mark Brown
Signed-off-by: Lee Jones -
Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly.Signed-off-by: Jingoo Han
Signed-off-by: Lee Jones -
Since the conversion to the regmap API setting bits per word will lead to
data corruption since the regmap API already configures the bits per word
appropriately.Signed-off-by: Mark Brown
Signed-off-by: Lee Jones -
Fixes this compilation error:
linux/include/linux/mfd/ucb1x00.h:137:17: error: field 'dev' has incomplete typeSigned-off-by: Andrea Adami
Signed-off-by: Lee Jones
Signed-off-by: Samuel Ortiz -
Fixes this compilation error:
linux/include/linux/mfd/mcp.h:22:16: error: field 'attached_device' has incomplete type
linux/include/linux/mfd/mcp.h:48:23: error: field 'drv' has incomplete typeSigned-off-by: Andrea Adami
Signed-off-by: Lee Jones
Signed-off-by: Samuel Ortiz -
AFE Pen Ctrl and TouchScreen transistors enabling is not
required when only ADC mode is being used, so check for availability of
TSC driver before accessing control register.Signed-off-by: Patil, Rachna
Acked-by: Vaibhav Hiremath
Signed-off-by: Zubair Lutfullah
Signed-off-by: Lee Jones
Signed-off-by: Samuel Ortiz -
ADC is ideally expected to work at a frequency of 3MHz.
The present code had a check, which returned error if the frequency
went below the threshold value. But since AM335x supports various
working frequencies, this check is not required.
Now the code just uses the internal ADC clock divider to set the ADC
frequency w.r.t the sys clock.Signed-off-by: Patil, Rachna
Signed-off-by: Zubair Lutfullah
Signed-off-by: Lee Jones
Signed-off-by: Samuel Ortiz -
Since enabling VMID takes a runtime PM reference there is no need to
suppress suspend when doing a runtime suspend. Similarly the digital
inputs and outputs are DAPM widgets and therefore the ASoC core will
be holding a reference for them.This used to be required when integration with system suspend was being
bodged.Signed-off-by: Mark Brown
Signed-off-by: Lee Jones
Signed-off-by: Samuel Ortiz -
The jack detection code holds runtime PM references when required so
there is no need for suspend to do any checks.Signed-off-by: Mark Brown
Signed-off-by: Lee Jones
Signed-off-by: Samuel Ortiz -
The Kconfig prompt for WM8997 says "Support for..." while the other MFD
Kconfigs (including the adjacent ones for other Arizona devices) just
list the device name which sticks out like a sore thumb when doing
configuration.Signed-off-by: Mark Brown
Signed-off-by: Lee Jones
Signed-off-by: Samuel Ortiz -
Since these are fixed rate clocks which are registered with common clock
framework so remove these from list of regulators which were unnecessarily
incrementing the count(S2MPS11_REGULATOR_MAX) of regulators.Signed-off-by: Yadwinder Singh Brar
Signed-off-by: Lee Jones
Signed-off-by: Samuel Ortiz -
During a move to use managed resources, the .remove function all was
deemed superfluous which subsequently led to its deletion. As there are
no remaining users of the stored 'base' address we only have to use it
locally during probe.Signed-off-by: Alexander Shiyan
Signed-off-by: Lee Jones
Signed-off-by: Samuel Ortiz -
The err: label is not needed we can just return instead of the jump there.
Signed-off-by: Peter Ujfalusi
Signed-off-by: Lee Jones
Signed-off-by: Samuel Ortiz -
To comply with coding style.
Signed-off-by: Peter Ujfalusi
Signed-off-by: Lee Jones
Signed-off-by: Samuel Ortiz -
TWL6040 is used only with OMAP4/5 SoCs and they can only boot in in DT mode.
The support for pdata/legacy boot can be removed.Add TODO comment to the header file that all pdata struct can be removed in
the next merge window (after the sub driver updates are in).Signed-off-by: Peter Ujfalusi
Signed-off-by: Lee Jones
Signed-off-by: Samuel Ortiz -
The performance of regmap-irq is improved if the interrupt mask registers
can be cached since it does read/modify/update cycles so start using the
register cache infrastructure for those registers. We should use this more
widely but I don't have a datasheet and this is a nice, conservative
starting point.Signed-off-by: Mark Brown
Signed-off-by: Lee Jones
Signed-off-by: Samuel Ortiz -
DA9055 is a combination of pmic and codec. This patch updates the DA9055 i2c
device id name to match the standard naming convention followed for such chips.Signed-off-by: Ankur Raina
Signed-off-by: Lee Jones
Signed-off-by: Samuel Ortiz
