12 Mar, 2006

25 commits


10 Mar, 2006

1 commit


08 Mar, 2006

1 commit

  • The patch

    [SCSI] SCSI core kmalloc2kzalloc

    Has an incorrect piece in sr_ioctl.c; it changes buffer from kmalloc
    to kzalloc, but then removes the clearing of the stack variable struct
    packet_command. This, in turn leaves rubbish in the sense pointer
    which the sr_do_ioctl() command then happily writes to ... oops.

    Thanks to Mike Christie for spotting this.

    Signed-off-by: James Bottomley

    James Bottomley
     

07 Mar, 2006

2 commits

  • On 02/07/2006 04:12:55 AM, Christoph Hellwig wrote:
    > On Mon, Feb 06, 2006 at 08:02:21PM -0500, Willem Riede wrote:
    >
    > > But I will certainly help retire scsi_request. And anything else that is
    > > needed to keep up with proper kernel style. Let me know what those are, if
    > > you would? I'll start looking at how st has changed, and will be back with
    > > any questions I may have.
    >
    > right now the above is the most urgent bit. What would be nice but not
    > required is a conversion to the sense handling helpers, similar to what
    > st got (aka using the *normalize_sense functions and then dealing with the
    > parsed sense buffer instead of the raw sense data)

    Ok, so here is my first take at satisfying this request.
    Be warned, that beyond compiling, and checking that the new module
    doesn't immediately blow up, there hasn't yet been a lot of testing.

    But this should allow you to comment on the changes, and move forward
    with dropping scsi_request from the kernel code.

    Signed-off-by: Willem Riede
    Signed-off-by: James Bottomley

    Willem Riede
     
  • Stop gcc complaining about undefined variables

    Signed-off-by: James Bottomley

    James Bottomley
     

06 Mar, 2006

9 commits


03 Mar, 2006

2 commits