15 Aug, 2008

1 commit

  • Some devices emit a ACPI_NOTIFY_DEVICE_CHECK while physically unplugging
    even if the software undock has already been done and dock_present() check
    fails. However, the internal flags need to be cleared (complete_undock()).

    Also, even notify userspace if the dock station suddently went away
    without proper software undocking.

    This happens on a Acer TravelMate 3000

    Signed-off-by: Holger Macht
    Signed-off-by: Andi Kleen

    Holger Macht
     

21 Jul, 2008

1 commit

  • commit 816c2eda3ce8fa7eb62f22e01e2ec7a3f7d677c0 ("dock: bay: Don't call
    acpi_walk_namespace() when ACPI is disabled.") was merged between
    2.6.26-rc8 and -rc9)

    Due to rebasing the ACPI tree via quilt the same patch got applied again
    via commit cc7e51666d82aedfd6b9a033ca1a10d71c21f1ca ("dock: bay: Don't
    call acpi_walk_namespace() when ACPI is disabled.")

    Revert it, as it is obviously bogus.

    Signed-off-by: Thomas Gleixner
    Signed-off-by: Linus Torvalds

    Thomas Gleixner
     

17 Jul, 2008

1 commit


26 Jun, 2008

1 commit


12 Jun, 2008

1 commit


18 Mar, 2008

1 commit

  • begin_undock() is only called when triggered via a acpi notify handler
    (pressing the undock button on the dock station), but complete_undock() is
    always called after the eject. So if a undock is triggered through a sysfs
    write, the flag DOCK_UNDOCKING has to be set for the dock station,
    too. Otherwise this will freeze the system hard.

    Signed-off-by: Holger Macht
    Acked-by: Kristen Carlson Accardi
    Signed-off-by: Andrew Morton
    Signed-off-by: Len Brown

    Holger Macht
     

07 Feb, 2008

2 commits

  • Conflicts:

    drivers/acpi/scan.c
    include/linux/acpi.h

    Signed-off-by: Len Brown

    Len Brown
     
  • This patch contains the following possible cleanups:
    - make the following needlessly global code static:
    - drivers/acpi/bay.c:dev_attr_eject
    - drivers/acpi/bay.c:dev_attr_present
    - drivers/acpi/dock.c:dev_attr_docked
    - drivers/acpi/dock.c:dev_attr_flags
    - drivers/acpi/dock.c:dev_attr_uid
    - drivers/acpi/dock.c:dev_attr_undock
    - drivers/acpi/pci_bind.c:acpi_pci_unbind()
    - drivers/acpi/pci_link.c:acpi_link_lock
    - drivers/acpi/sbs.c:acpi_sbs_callback()
    - drivers/acpi/sbshc.c:acpi_smbus_transaction()
    - drivers/acpi/sleep/main.c:acpi_sleep_prepare()
    - #if 0 the following unused global functions:
    - drivers/acpi/numa.c:acpi_unmap_pxm_to_node()
    - remove the following unused EXPORT_SYMBOL's:
    - acpi_register_gsi
    - acpi_unregister_gsi
    - acpi_strict
    - acpi_bus_receive_event
    - register_acpi_bus_type
    - unregister_acpi_bus_type
    - acpi_os_printf
    - acpi_os_sleep
    - acpi_os_stall
    - acpi_os_read_pci_configuration
    - acpi_os_create_semaphore
    - acpi_os_delete_semaphore
    - acpi_os_wait_semaphore
    - acpi_os_signal_semaphore
    - acpi_os_signal
    - acpi_pci_irq_enable
    - acpi_get_pxm

    Signed-off-by: Adrian Bunk
    Acked-by: Alexey Starikovskiy
    Signed-off-by: Len Brown

    Adrian Bunk
     

08 Dec, 2007

1 commit


12 Aug, 2007

1 commit

  • Send key=value pair along with the uevent instead of a plain value so that
    userspace (udev) can handle it like common environment variables.

    Signed-off-by: Holger Macht
    Acked-by: Kristen Carlson Accardi
    Cc: Stephan Berberig
    Signed-off-by: Andrew Morton
    Acked-by: Greg Kroah-Hartman
    Signed-off-by: Len Brown

    Holger Macht
     

19 Jul, 2007

1 commit

  • Data returned by acpi_get_name in acpi_buffer is not acpi_object and
    therefore should not be cast to it, otherwise we'll get an nice oops
    trying to print error message.

    Also print name of the ACPI object corresponding to the docking station
    and elevate severity of the message printed when _DCK fails to KERN_ERR.

    Signed-off-by: Dmitry Torokhov
    Cc: Kristen Carlson Accardi
    Signed-off-by: Len Brown

    Dmitry Torokhov
     

10 May, 2007

6 commits

  • Send an env along with our KOBJ_CHANGE uevent so that user space has
    the option of checking for that to see if a dock or undock has occurred.

    Signed-off-by: Kristen Carlson Accardi
    Signed-off-by: Len Brown

    Kristen Carlson Accardi
     
  • Platform devices may not send uevents by default - override the setting
    so that we can send uevents on dock/undock.

    Signed-off-by: Kristen Carlson Accardi
    Signed-off-by: Len Brown

    Kristen Carlson Accardi
     
  • Allow the driver to be loaded with an option that will allow userspace to
    control whether the laptop is ejected immediately when the user presses the
    button, or only when the syfs undock file is written.

    if immediate_undock == 1, then when the user presses the undock button, the
    laptop will send an event to userspace to notify userspace of the undock, but
    then immediately undock without waiting for userspace. This is the current
    behavior, and I set this to be the default.

    if immediate_undock == 0, then when the user presses the undock button, the
    laptop will send an event to userspace and do nothing. User space can query
    the "flags" sysfs entry to determine if an undock request has been made by
    the user (if bit 1 is set). User space will then need to write the undock
    sysfs entry to complete the undocking process.

    Signed-off-by: Kristen Carlson Accardi
    Signed-off-by: Len Brown

    Kristen Carlson Accardi
     
  • Get rid of no release function warnings by switching to dynamically
    allocating the platform_device and using the platform device release
    routine in the base driver.

    Signed-off-by: Kristen Carlson Accardi
    Signed-off-by: Len Brown

    Kristen Carlson Accardi
     
  • The driver tests the dock_station pointer for nonnull
    to check whether it has initialized properly. But in
    some cases dock_station will be non-null after being
    freed when driver init fails. Fix by zeroing the
    pointer after freeing.

    Signed-off-by: Chuck Ebbert
    Signed-off-by: Kristen Carlson Accardi
    Signed-off-by: Len Brown

    Chuck Ebbert
     
  • Make uid sysfs file error path free memory, and cleanup sysfs file
    when removing driver. Also fix CodingStyle violations.

    Signed-off-by: Kristen Carlson Accardi
    Cc: Illya A. Volynets-Evenbakh
    Signed-off-by: Len Brown

    Kristen Carlson Accardi
     

29 Mar, 2007

1 commit


10 Mar, 2007

1 commit


13 Feb, 2007

2 commits


03 Feb, 2007

1 commit


16 Dec, 2006

2 commits


15 Dec, 2006

1 commit


07 Dec, 2006

4 commits


04 Dec, 2006

1 commit


31 Oct, 2006

1 commit


14 Oct, 2006

1 commit


04 Aug, 2006

1 commit

  • Remove uevent dock notifications. There are no consumers
    of these events at present, and uevents are likely not the
    correct way to send this type of event anyway.

    Until I get some kind of idea if anyone in userspace cares
    about dock events, I will just not send any.

    Signed-off-by: Kristen Carlson Accardi
    Signed-off-by: Greg Kroah-Hartman

    Kristen Carlson Accardi
     

11 Jul, 2006

1 commit


10 Jul, 2006

1 commit


09 Jul, 2006

1 commit


28 Jun, 2006

1 commit

  • Create a driver which lives in the acpi subsystem to handle dock events.
    This driver is not an "ACPI" driver, because acpi drivers require that the
    object be present when the driver is loaded.

    Signed-off-by: Kristen Carlson Accardi
    Cc: Dave Hansen
    Signed-off-by: Andrew Morton
    Signed-off-by: Len Brown

    Kristen Accardi