23 Sep, 2008

1 commit

  • The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /
    (d)) but is perhaps more readable.

    In the case of the file drivers/atm/eni.c, I am a little bit suspicious of
    the -1 at the end of the affected expression. Please check that that is
    what is wanted.

    An extract of the semantic patch that makes this change is as follows:
    (http://www.emn.fr/x-info/coccinelle/)

    //
    @haskernel@
    @@

    #include

    @depends on haskernel@
    expression n,d;
    @@

    (
    - (n + d - 1) / d
    + DIV_ROUND_UP(n,d)
    |
    - (n + (d - 1)) / d
    + DIV_ROUND_UP(n,d)
    )

    @depends on haskernel@
    expression n,d;
    @@

    - DIV_ROUND_UP((n),d)
    + DIV_ROUND_UP(n,d)

    @depends on haskernel@
    expression n,d;
    @@

    - DIV_ROUND_UP(n,(d))
    + DIV_ROUND_UP(n,d)
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: Andrew Morton
    Signed-off-by: David S. Miller

    Julia Lawall
     

22 Sep, 2008

1 commit


24 Aug, 2008

1 commit


31 Jul, 2008

1 commit


24 Jul, 2008

1 commit


18 Jul, 2008

1 commit


10 Jul, 2008

1 commit


18 Jun, 2008

5 commits


17 Jun, 2008

5 commits


11 Jun, 2008

1 commit


21 May, 2008

1 commit


15 May, 2008

1 commit

  • Time is unsigned long (except when you are in a hurry) so we need to
    store rx_tmp_jif in the right sized object.

    Signed-off-by: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: David S. Miller

    Alan Cox
     

30 Apr, 2008

1 commit

  • * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6: (53 commits)
    tcp: Overflow bug in Vegas
    [IPv4] UFO: prevent generation of chained skb destined to UFO device
    iwlwifi: move the selects to the tristate drivers
    ipv4: annotate a few functions __init in ipconfig.c
    atm: ambassador: vcc_sf semaphore to mutex
    MAINTAINERS: The socketcan-core list is subscribers-only.
    netfilter: nf_conntrack: padding breaks conntrack hash on ARM
    ipv4: Update MTU to all related cache entries in ip_rt_frag_needed()
    sch_sfq: use del_timer_sync() in sfq_destroy()
    net: Add compat support for getsockopt (MCAST_MSFILTER)
    net: Several cleanups for the setsockopt compat support.
    ipvs: fix oops in backup for fwmark conn templates
    bridge: kernel panic when unloading bridge module
    bridge: fix error handling in br_add_if()
    netfilter: {nfnetlink,ip,ip6}_queue: fix skb_over_panic when enlarging packets
    netfilter: x_tables: fix net namespace leak when reading /proc/net/xxx_tables_names
    netfilter: xt_TCPOPTSTRIP: signed tcphoff for ipv6_skip_exthdr() retval
    tcp: Limit cwnd growth when deferring for GSO
    tcp: Allow send-limited cwnd to grow up to max_burst when gso disabled
    [netdrvr] gianfar: Determine TBIPA value dynamically
    ...

    Linus Torvalds
     

29 Apr, 2008

2 commits


20 Apr, 2008

2 commits

  • The functions time_before, time_before_eq, time_after, and time_after_eq
    are more robust for comparing jiffies against other values.

    A simplified version of the semantic patch making this change is as follows:
    (http://www.emn.fr/x-info/coccinelle/)

    //
    @ change_compare_np @
    expression E;
    @@

    (
    - jiffies = E
    + time_after_eq(jiffies,E)
    |
    - jiffies < E
    + time_before(jiffies,E)
    |
    - jiffies > E
    + time_after(jiffies,E)
    )

    @ include depends on change_compare_np @
    @@

    #include

    @ no_include depends on !include && change_compare_np @
    @@

    #include
    + #include
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: Andrew Morton
    Signed-off-by: David S. Miller

    Julia Lawall
     
  • Code within NS_DEBUG_SPINLOCKS contained deprecated cli()/sti()
    function calls. NS_DEBUG_SPINLOCKS and the associated code seems to
    be of little use these days so the strategy of removing this code
    rather then updating it to use spinlocks has been taken.

    Signed-off-by: Mark Asselstine
    Reviewed-by: Matthew Wilcox
    Signed-off-by: David S. Miller

    Mark Asselstine
     

14 Apr, 2008

1 commit

  • drivers/atm/horizon.c has unusually large number
    of static inline functions - 36.

    I looked through them. Most of them seems to be small enough,
    but a few are big, others are using udelay or busy loop,
    and as such are better not be inlined.

    This patch removes "inline" from these static functions
    (regardless of number of callsites - gcc nowadays auto-inlines
    statics with one callsite).

    Size difference for 32bit x86:
    text data bss dec hex filename
    8201 180 6 8387 20c3 linux-2.6-ALLYES/drivers/atm/horizon.o
    7840 180 6 8026 1f5a linux-2.6.inline-ALLYES/drivers/atm/horizon.o

    Signed-off-by: Denys Vlasenko
    Signed-off-by: David S. Miller

    Denys Vlasenko
     

04 Apr, 2008

1 commit

  • drivers/atm/ambassador.c has unusually large number
    of static inline functions - 22.

    I looked through them and half of them seem to be too big
    to warrant inlining.

    This patch removes "inline" from these static functions
    (regardless of number of callsites - gcc nowadays auto-inlines
    statics with one callsite).

    Size difference for 32bit x86:
    text data bss dec hex filename
    10209 8488 4 18701 490d linux-2.6-ALLYES/drivers/atm/ambassador.o
    9462 8488 4 17954 4622 linux-2.6.inline-ALLYES/drivers/atm/ambassador.o

    Signed-off-by: Denys Vlasenko
    Signed-off-by: David S. Miller

    Denys Vlasenko
     

02 Apr, 2008

1 commit


01 Apr, 2008

2 commits


29 Mar, 2008

1 commit


17 Mar, 2008

1 commit


06 Mar, 2008

1 commit


29 Jan, 2008

3 commits


21 Jan, 2008

2 commits


09 Jan, 2008

1 commit


21 Dec, 2007

1 commit