23 Jul, 2008
1 commit
-
Some hardware needs to do break handling itself and may have partial
support only. Make break_ctl return an error code. Add a tty driver flag
so you can indicate driver hardware side break support.Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds
21 Jul, 2008
2 commits
-
Move more bits into the tty_port structure
Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds -
Switch MOXA to use the new tty_port structure
Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds
10 Jul, 2008
1 commit
-
Fix an assignment of a const pointer to a non-const pointer in moxa_load_fw().
Signed-off-by: David Howells
Signed-off-by: David Woodhouse
30 Apr, 2008
23 commits
-
Simple search/replace except for synclink.c where I noticed a real bug and
fixed it too. It was doing NULL + offset, then checking for NULL if the remap
failed.Signed-off-by: Alan Cox
Cc: Paul Fulghum
Acked-by: Jiri Slaby
Cc: Ingo Molnar
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
- Stop drivers calling their own flush method indirectly, it obfuscates code
and it will change soon anyway- A few more lock_kernel paths temporarily needed in some driver internal
waiting code- Remove private put_char method that does a write call for one char - we
have that anyway- Most but not yet all of the termios copy under lock fixing (some has other
dependencies to follow)- Note a few locking bugs in drivers found in the process
- Kill remaining [ab]users of TIOCG/SSOFTCAR in the driver, these must go to
fix the termios lockingSigned-off-by: Alan Cox
Cc: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Be more verbose on fw load fail as noted by Oyvind.
Signed-off-by: Jiri Slaby
Cc: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
- update version
- update maintainers
- copyright the stuffSigned-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Drop a message to dmesg about card being ready.
Signed-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
It allows to simplify the code, especially MoxaPortSetBaud.
Signed-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
- moxa_flush_chars -- no code; ldics handle this well
- moxa_put_char -- only wrapper to moxa_write (same code), tty does this
the same way if tty->driver->put_char is NULLSigned-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Cleanup of
- whitespace
- macros
- useless casts
- return (sth); -> return sth;
- types
- superfluous parenthesis and braces
- init tmp directly in moxa_get_serial_info
- commented defunct code
- commented prototypes
- MOXA/moxa printk caseSigned-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
- add locking to open/close/hangup and ioctl (tiocm)
- add pci hot-un-plug support (hangup on board remove, wait for openers)
- cleanup block_till_ready
- move close code common to close/hangup into separate function to be
able to call it from open when hangup occurs while block_till_ready
- let ldisc flush on tty layer, it will do it after we returnSigned-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
- del timer after we are sure it won't be fired again
- make timer scheduling atomic
- don't reschedule timer when all cards have goneSigned-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
- cleanup types
- use tty_prepare_flip_string and io memcpysSigned-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
- merge 2 timers into one -- one can handle the emptywait as good as the other
- merge 2 separated poll functions into one, this allows handle the actions
directly and simplifies the codeSigned-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
- allow stats only for sys_admin
- move TCSBRK* processing to .break_ctl tty op
- let TIOCGSOFTCAR and TIOCSSOFTCAR be processed by ldisc
- remove MOXA_GET_MAJOR, MOXA_GET_CUMAJOR
- fix jiffies subtraction by time_after
- move moxa ioctl numbers into the header; still not exported to userspace,
needs _IOC and 32/64 compat cleanup anywaysSigned-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
- schedule timer even after some card is installed, not after insmod
- cleanup timer functionsSigned-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
The only relevant sign of port being ready is its board->ready since now.
Remove all other flags for this purpose which are set almost on the same
place. Move ports inside the board to be sure that nobody will grab reference
to the port without being sure that it exists.[jirislaby@gmail.com: fix unused var warning]
Signed-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Signed-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
We don't need to hold a reference to port index. In most cases we need port
structure anyway and index is available in port->tty->index.Signed-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Signed-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Substitute ioctl load firmware interface by kernel firmware api.
Signed-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
according to ioctl_list, both have int * as a param, not ulong *.
Signed-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
- request region before remapping pci io space
- use ioremap, iounmap istead of iomap interface, because we use
readX/writeX for accessing this space because of isa supportSigned-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Make the code more readable, remap the base address directly. Describe module
parameters.Signed-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Static ISA field is empty and probably will never be filled in, remove it.
The driver still supports ISA cards passed through module parameter. This
actually fixes one bug inside the initialization of module-param passed cards
initialization.Signed-off-by: Jiri Slaby
Tested-by: Oyvind Aabling
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
09 Feb, 2008
1 commit
-
Signed-off-by: Alan Cox
Cc: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
19 Oct, 2007
4 commits
-
interruptible_sleep_on is deprecated, use completion instead
Signed-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
prepend moxa_ to all moxa functions which laxes this
Signed-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
- use dev_* where pdev is available (probe function)
- add some printks on fail paths
- add KERN_ macros otherwise
- remove useless verbose variable
- wrap lines to 80 cols at mostSigned-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
moxa, fix and optimise empty timer
don't wait and delete empty timer in empty timer function. Also fire next
empty timer at rounded jiffies to save power.Signed-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
18 Jul, 2007
1 commit
-
blah, moxa delays 250+ ms in busy waiting, use msleep instead.
Signed-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
09 May, 2007
1 commit
-
I noticed that the moxa input checking security bug described by
CVE-2005-0504 appears to remain unfixed upstream.The issue is described here:
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2005-0504Debian has been shipping the following patch from Andres Salomon.
(akpm: it's a privileged operation)
Signed-off-by: dann frazier
Signed-off-by: Andres Salomon
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
12 Feb, 2007
6 commits
-
Alter the driver to use the pci probing.
Signed-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
- change pci conf prototype and rename it to moxa_pci_probe
- move some code to moxa_pci_probe
- create moxa_pci_removeSigned-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Remove temporary or once used variables, that can be defined locally to
save some bytes.Signed-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
- rename moxaChannels to moxa_port
- rename moxa_str to moxa_ports
- move board global variables into moxa_board
- move port global variables into moxa_portSigned-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Nothing is used from this struct but *pdev. Remove it and store only pdev.
Signed-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Use del_timer_sync in most timer deletions, we don't want to oops in the timer
function.Signed-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds