Eric Lee / smarc-fsl-linux-kernel

31 Jul, 2008

1 commit

26 Jul, 2008

5 commits

  • ace7dd966   Char: mxser, various cleanups ... Browse Code »

    - remove unused macro
    - some whitespace cleanup
    - useless debug prints removal

    Signed-off-by: Jiri Slaby
    Acked-by: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jiri Slaby
     
  • 1df009247   Char: mxser, remove predefined isa support ... Browse Code »

    Remove a support of ISA addresses predefined at compile time. It is
    unused (filled by zeroes) and prolongs the code. Don't initialize global
    array and add `ioaddr' module param description.

    Signed-off-by: Jiri Slaby
    Acked-by: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jiri Slaby
     
  • 83766bc63   Char: mxser, prints cleanup ... Browse Code »

    - use dev_* for printing in pci probe function
    - move ISA p[rints directly into isa find function, do not postpone it.
    Remove macros bound to it then.
    - prepend some prints by "mxser: " to know what it belongs to

    Signed-off-by: Jiri Slaby
    Acked-by: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jiri Slaby
     
  • 72800df9b   Char: mxser, globals cleanup ... Browse Code »

    - remove unused mxvar_diagflag
    - move mxser_msr into the only user/function
    - GMStatus, hmm, fix race-prone access to it. We need only one instance for
    real, not MXSER_PORTS. Move it to MOXA_GETMSTATUS ioctl.
    - mxser_mon_ext, almost the same, but alloc it on heap, since it has more than
    2 kilos.
    - fix indexing, `i' is not the index value, `i * MXSER_PORTS_PER_BOARD + j' is

    Signed-off-by: Jiri Slaby
    Acked-by: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jiri Slaby
     
  • 41aee9a12   Char: mxser, ioctl cleanup ... Browse Code »

    - remove break ctl from ioctl handler, it's never reached, since
    tty_ops->break_ctl is defined (mxser break handling is done in software)
    - mark MOXA_GET_MAJOR as deprecated
    - fix TIOCGICOUNT (some retval non-checks of put_user). Use copy_to_user
    to whole structure instead.

    Signed-off-by: Jiri Slaby
    Acked-by: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jiri Slaby
     

23 Jul, 2008

3 commits

  • e129deff3   Char: mxser, add CP-102UF support ... Browse Code »

    Add support for CP-102UF moxa card (update to 1.12 original driver) and
    increment this driver version.

    (Somewhat reworked by alan@redhat.com to merge in with other patches)

    Signed-off-by: Alan Cox
    Signed-off-by: Linus Torvalds

    Jiri Slaby
     
  • 9e98966c7   tty: rework break handling ... Browse Code »

    Some hardware needs to do break handling itself and may have partial
    support only. Make break_ctl return an error code. Add a tty driver flag
    so you can indicate driver hardware side break support.

    Signed-off-by: Alan Cox
    Signed-off-by: Linus Torvalds

    Alan Cox
     
  • 8ca8b9005   mxser: remove dead code ... Browse Code »

    Old style ioctl break code can go

    Signed-off-by: Alan Cox
    Signed-off-by: Linus Torvalds

    Alan Cox
     

21 Jul, 2008

2 commits

30 Apr, 2008

4 commits

  • 148ff86b1   mxser: convert large macros to functions ... Browse Code »

    Signed-off-by: Christoph Hellwig
    Signed-off-by: Jiri Slaby
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christoph Hellwig
     
  • 0be2eadee   mxser: switch to put_char being int ... Browse Code »

    Signed-off-by: Alan Cox
    Cc: Jiri Slaby
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Cox
     
  • 978e595f8   tty/serial: lay the foundations for the next set of reworks ... Browse Code »

    - Stop drivers calling their own flush method indirectly, it obfuscates code
    and it will change soon anyway

    - A few more lock_kernel paths temporarily needed in some driver internal
    waiting code

    - Remove private put_char method that does a write call for one char - we
    have that anyway

    - Most but not yet all of the termios copy under lock fixing (some has other
    dependencies to follow)

    - Note a few locking bugs in drivers found in the process

    - Kill remaining [ab]users of TIOCG/SSOFTCAR in the driver, these must go to
    fix the termios locking

    Signed-off-by: Alan Cox
    Cc: Jiri Slaby
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Cox
     
  • 9d6d162d4   mxser: prepare for BKL pushdown ... Browse Code »

    Push the BKL down into various internal routines in the driver ready to
    remove it from the break, ioctl and other call points.

    Signed-off-by: Alan Cox
    Cc: Jiri Slaby
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Cox
     

08 Feb, 2008

4 commits

07 Feb, 2008

1 commit

20 Oct, 2007

1 commit

  • 1977f0327   remove asm/bitops.h includes ... Browse Code »

    remove asm/bitops.h includes

    including asm/bitops directly may cause compile errors. don't include it
    and include linux/bitops instead. next patch will deny including asm header
    directly.

    Cc: Adrian Bunk
    Signed-off-by: Jiri Slaby
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jiri Slaby
     

19 Oct, 2007

2 commits

  • b8cc55493   mxser: fix compiler warning when building without CONFIG_PCI ... Browse Code »

    drivers/char/mxser.c:386: warning: 'mxser_get_PCI_conf' declared 'static' but never defined

    when building without CONFIG_PCI.

    [jesper.juhl@gmail.com: Fix warning: 'CheckIsMoxaMust' defined but not used]
    Signed-off-by: Jesper Juhl
    Signed-off-by: Jesper Juhl
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jesper Juhl
     
  • 0678c5b67   mxser: remove commented crap ... Browse Code »

    This is years dead code and it keeps turning up in confusing ways when
    grepping for stuff.

    Signed-off-by: Alan Cox
    Cc: Jiri Slaby
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Cox
     

17 Jul, 2007

1 commit

09 May, 2007

1 commit

24 Apr, 2007

1 commit

  • fc83815c3   Char: mxser, fix TIOCMIWAIT ... Browse Code »

    There was schedule() missing in the TIOCMIWAIT ioctl. Solve it by moving
    the code to the wait_event_interruptible.

    Signed-off-by: Jiri Slaby
    Cc: Jan Yenya Kasprzak
    Cc: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jiri Slaby
     

12 Feb, 2007

2 commits

  • 8cddd7076   [PATCH] mxser: remove useless fields ... Browse Code »

    the session and pgrp fields in mxser_struct are unused.

    Signed-off-by: Cedric Le Goater
    Cc: Jiri Slaby
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Cedric Le Goater
     
  • b963a8441   [PATCH] Char: tty_wakeup cleanup ... Browse Code »

    tty_wakeup cleanup

    - remove wake_up_interruptible(&tty->write_wait) surrounding
    tty_wakup(tty);
    - substitute tty->ldisc.write_wakeup(tty) + wake_up() by tty_wakeup(tty);

    Signed-off-by: Jiri Slaby
    Cc: Alan Cox
    Acked-by: Tilman Schmidt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jiri Slaby
     

31 Dec, 2006

1 commit

09 Dec, 2006

4 commits

  • 606d099cd   [PATCH] tty: switch to ktermios ... Browse Code »

    This is the grungy swap all the occurrences in the right places patch that
    goes with the updates. At this point we have the same functionality as
    before (except that sgttyb() returns speeds not zero) and are ready to
    begin turning new stuff on providing nobody reports lots of bugs

    If you are a tty driver author converting an out of tree driver the only
    impact should be termios->ktermios name changes for the speed/property
    setting functions from your upper layers.

    If you are implementing your own TCGETS function before then your driver
    was broken already and its about to get a whole lot more painful for you so
    please fix it 8)

    Also fill in c_ispeed/ospeed on init for most devices, although the current
    code will do this for you anyway but I'd like eventually to lose that extra
    paranoia

    [akpm@osdl.org: bluetooth fix]
    [mp3@de.ibm.com: sclp fix]
    [mp3@de.ibm.com: warning fix for tty3270]
    [hugh@veritas.com: fix tty_ioctl powerpc build]
    [jdike@addtoit.com: uml: fix ->set_termios declaration]
    Signed-off-by: Alan Cox
    Signed-off-by: Martin Peschke
    Acked-by: Peter Oberparleiter
    Cc: Cornelia Huck
    Signed-off-by: Hugh Dickins
    Signed-off-by: Jeff Dike
    Cc: Paolo 'Blaisorblade' Giarrusso
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Cox
     
  • 1187ece3d   [PATCH] mxser: PCI refcounts ... Browse Code »

    Switch to pci ref counts for mxser when handling PCI devices. Use
    pci_get_device and drop the reference when we finish and unload.

    Signed-off-by: Alan Cox
    Cc: Greg KH
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Cox
     
  • ae25f8ecd   [PATCH] mxser: correct tty driver name ... Browse Code »

    Mxser tty driver name should be ttyMI, not ttyM. Correct this in mxser to
    avoid conflicts with isicom driver, which is ttyM.

    Acked-by: Alan Cox
    Signed-off-by: Jiri Slaby
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jiri Slaby
     
  • 937949d9e   [PATCH] add process_session() helper routine ... Browse Code »

    Replace occurences of task->signal->session by a new process_session() helper
    routine.

    It will be useful for pid namespaces to abstract the session pid number.

    Signed-off-by: Cedric Le Goater
    Cc: Kirill Korotaev
    Cc: Eric W. Biederman
    Cc: Herbert Poetzl
    Cc: Sukadev Bhattiprolu
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Cedric Le Goater
     

22 Nov, 2006

1 commit

05 Oct, 2006

1 commit

  • 7d12e780e   IRQ: Maintain regs pointer globally rather than passing to IRQ handlers ... Browse Code »

    Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

02 Oct, 2006

1 commit

  • b68e31d0e   [PATCH] const struct tty_operations ... Browse Code »

    As part of an SMP cleanliness pass over UML, I consted a bunch of
    structures in order to not have to document their locking. One of these
    structures was a struct tty_operations. In order to const it in UML
    without introducing compiler complaints, the declaration of
    tty_set_operations needs to be changed, and then all of its callers need to
    be fixed.

    This patch declares all struct tty_operations in the tree as const. In all
    cases, they are static and used only as input to tty_set_operations. As an
    extra check, I ran an i386 allyesconfig build which produced no extra
    warnings.

    53 drivers are affected. I checked the history of a bunch of them, and in
    most cases, there have been only a handful of maintenance changes in the
    last six months. serial_core.c was the busiest one that I looked at.

    Signed-off-by: Jeff Dike
    Acked-by: Alan Cox
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jeff Dike
     

01 Oct, 2006

1 commit

03 Jul, 2006

1 commit

01 Jul, 2006

1 commit

29 Jun, 2006

1 commit

  • 817d6d3bc   [PATCH] remove TTY_DONT_FLIP ... Browse Code »

    Remove TTY_DONT_FLIP tty flag. This flag was introduced in 2.1.X kernels
    to prevent the N_TTY line discipline functions read_chan() and
    n_tty_receive_buf() from running at the same time. 2.2.15 introduced
    tty->read_lock to protect access to the N_TTY read buffer, which is the
    only state requiring protection between these two functions.

    The current TTY_DONT_FLIP implementation is broken for SMP, and is not
    universally honored by drivers that send data directly to the line
    discipline receive_buf function.

    Because TTY_DONT_FLIP is not necessary, is broken in implementation, and is
    not universally honored, it is removed.

    Signed-off-by: Paul Fulghum
    Cc: Alan Cox
    Cc: Theodore Ts'o
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Paul Fulghum