06 Oct, 2008
1 commit
-
Found during the (partial) unregister_netdevice audit that we didn't
have to have :)It looks like a couple of Sun NIC drivers had unregister_netdevice
when they really meant unregister_netdev.Signed-off-by: Herbert Xu
Signed-off-by: David S. Miller
01 Oct, 2008
17 commits
-
Conflicts:
drivers/net/wireless/ath9k/core.c
drivers/net/wireless/ath9k/main.c
net/core/dev.c -
This gives a nice increase in the maximum loss-free packet forwarding
rate in routing workloads.Signed-off-by: Lennert Buytenhek
Signed-off-by: David S. Miller -
* Add support for AR2417 (include pci id) since my previous patch doesn't sit on top of base.c/ath5k.h anymore.
* Update module version to 0.6.0Changes-Licensed-under: ISC
Signed-Off-by: Nick Kossifidis
Signed-off-by: John W. Linville -
* Fix srev reporting during attach
Changes-Licensed-under: ISC
Signed-Off-by: Nick Kossifidis
Signed-off-by: John W. Linville -
* Use QUIET mechanism to drain tx buffer on PCU for newer chips
* Make sure that INTPEND is really 1 and not 0xffffffff while checking for pending interruptsChanges-Licensed-under: ISC
Signed-Off-by: Nick Kossifidis
Signed-off-by: John W. Linville -
* Use new SREV values and PHY srevs to identify radio type durring attach
Changes-Licensed-under: ISC
Signed-Off-by: Nick Kossifidis
Signed-off-by: John W. Linville -
One of the spin-on-condition loops in routine do_dummy_tx always exits before
the condition is satisfied. The hardware might be left in an inconsistent
state that might be the cause of the PHY transmission errors seen by some
users.Signed-off-by: Larry Finger
Signed-off-by: Michael Buesch
Signed-off-by: John W. Linville -
* Update registers
* Update SREV values and add some PHY srevs
* Prepare ath5k.h for newer radios etcThanks to Atheros 's HAL source we now know for sure how many parts we have
and what their SREV values are. We also have some updates on registers. Prepare
ath5k for some major updates ;-)My previous mail had 2 more patches following (git log misusage), sorry for double
posting ;-(Changes-Licensed-under: ISC
Signed-Off-by: Nick Kossifidis
Signed-off-by: John W. Linville -
According to the newly-released Atheros HAL code, asserting the
TSF reset bit will toggle a hardware internal state, resulting in a
spurious reset on the next chip reset. Whenever we force a TSF bit,
write the bit twice to clear the internal signal.Signed-off-by: Bob Copeland
Acked-by: Nick Kossifidis
Signed-off-by: John W. Linville -
Fix by disabling rt2x00 rfkill support when rt2x00 is built-in and rfkill has been modularized, and
a similar scheme for the relationship between leds_class and rt2x00..
Also, give a warning to the end-user when rfkill-/leds-support is disabled this way, so that the
end-user has at least some clues on what is going on.Proper fixing required some general updates of the Kconfig-structure for the rt2x00 driver, whereby
internal configuration symbols had to be moved to after the user-visible configuration symbols.Signed-off-by: Gertjan van Wingerde
Signed-off-by: Ivo van Doorn
Signed-off-by: John W. Linville -
This patch addresses comments from Dan Williams about the patch
committed as "libertas: Improvements on automatic tx power control via
SIOCSIWTXPOW."Signed-off-by: Anna Neal
Signed-off-by: Javier Cardona
Signed-off-by: Dan Williams
Signed-off-by: John W. Linville -
Yet another BCM4306 card with the Bluetooth Coexistence SPROM programming
error has been found.Signed-off-by: Larry Finger
Signed-off-by: John W. Linville -
Use correct DMA_MASK: 4964 and 5000 support 36 bit addresses for
pci express memory access.Signed-off-by: Tomas Winkler
Signed-off-by: Zhu Yi
Signed-off-by: John W. Linville -
This patch enables power save setting from config (iwconfig power)
The sysfs power_level interface is still preserved as it has
mac80211 power implementation is not yet rich enough.Signed-off-by: Ester Kummer
Reviewed-by: Tomas Winkler
Signed-off-by: Zhu Yi
Signed-off-by: John W. Linville -
The patch adds HW bug W/A FH_RCSR_CHNL0_RX_IGNORE_RXF_EMPTY so that we
can enable again interrupt coalescing. It also uses named constants for
open code.Signed-off-by: Tomas Winkler
Signed-off-by: Zhu Yi
Signed-off-by: John W. Linville -
The command
make C=2 CF="-D__CHECK_ENDIAN__" drivers/net/wireless/p54/
generates the following warnings:
.../p54common.c:152:38: warning: incorrect type in argument 1 (different base types)
.../p54common.c:152:38: expected restricted __be32 const [usertype] *p
.../p54common.c:152:38: got unsigned int *
.../p54common.c:184:15: warning: restricted __le32 degrades to integer
.../p54common.c:185:29: warning: cast to restricted __le16
.../p54common.c:309:11: warning: symbol 'p54_rf_chips' was not declared.
Should it be static?
.../p54common.c:313:5: warning: symbol 'p54_parse_eeprom' was not declared.
Should it be static?
.../p54common.c:620:43: warning: incorrect type in argument 3 (different base types)
.../p54common.c:620:43: expected unsigned long [unsigned] [usertype] len
.../p54common.c:620:43: got restricted __le16 [usertype] len
.../p54common.c:780:41: warning: restricted __le16 degrades to integer
.../p54common.c:781:32: warning: restricted __le16 degrades to integer
.../p54common.c:1250:28: warning: incorrect type in argument 2 (different base types)
.../p54common.c:1250:28: expected unsigned short [unsigned] [usertype] filter_type
.../p54common.c:1250:28: got restricted __le16 [usertype] filter_type
.../p54common.c:1252:28: warning: incorrect type in argument 2 (different base types)
.../p54common.c:1252:28: expected unsigned short [unsigned] [usertype] filter_type
.../p54common.c:1252:28: got restricted __le16 [usertype] filter_type
.../p54common.c:1257:42: warning: incorrect type in argument 2 (different base types)
.../p54common.c:1257:42: expected unsigned short [unsigned] [usertype] filter_type
.../p54common.c:1257:42: got restricted __le16
.../p54common.c:1260:42: warning: incorrect type in argument 2 (different base types)
.../p54common.c:1260:42: expected unsigned short [unsigned] [usertype] filter_type
.../p54common.c:1260:42: got restricted __le16
.../p54usb.c:228:10: warning: restricted __le32 degrades to integer
.../p54usb.c:228:23: warning: restricted __le32 degrades to integer
.../p54usb.c:228:7: warning: incorrect type in assignment (different base types)
.../p54usb.c:228:7: expected restricted __le32 [assigned] [usertype] chk
.../p54usb.c:228:7: got unsigned int
.../p54usb.c:221:8: warning: symbol 'p54u_lm87_chksum' was not declared.
Should it be static?All of the above have been fixed. One question, however, remains: In struct
bootrec, the array "data" is treated in many places as native CPU order, but
it may be little-endian everywhere. As far as I can tell, this driver has only
been used with little-endian hardware.Signed-off-by: Larry Finger
Signed-off-by: John W. Linville -
An additional BCM4306 has been found with the Bluetooth coexistence
SPROM coding error.Signed-off-by: Larry Finger
Signed-off-by: John W. Linville
26 Sep, 2008
2 commits
-
This reverts commit 2eefbd63d0c85daa1317636474c226e236beba81.
On request by driver author and Jeff Garzik.
Signed-off-by: David S. Miller
25 Sep, 2008
20 commits
-
Since the e1000/e1000e split, no hardware supported by e1000
supports packet split, just remove the Kconfig option and associated
code from the driver.Signed-off-by: Jesse Brandeburg
Signed-off-by: Jeff Garzik -
The following sparse warnings are being generated
because bonding.h is missing definitons for items
declared in bond_main.c but also used in bond_sysfs.hAlso export bond_dev_list as this is also declared
in bond_main but used elsewhere in drivers/net/bonding.bond_main.c:105:20: warning: symbol 'bonding_defaults' was not declared. Should it be static?
bond_main.c:148:1: warning: symbol 'bond_dev_list' was not declared. Should it be static?
bond_main.c:162:22: warning: symbol 'bond_lacp_tbl' was not declared. Should it be static?
bond_main.c:168:22: warning: symbol 'bond_mode_tbl' was not declared. Should it be static?
bond_main.c:179:22: warning: symbol 'xmit_hashtype_tbl' was not declared. Should it be static?
bond_main.c:186:22: warning: symbol 'arp_validate_tbl' was not declared. Should it be static?
bond_main.c:194:22: warning: symbol 'fail_over_mac_tbl' was not declared. Should it be static?Signed-off-by: Ben Dooks
Signed-off-by: Jeff Garzik -
Netpoll will call the interrupt handler with interrupts
disabled when using kgdboe, so spin_lock_irqsave() should
be used instead of spin_lock_irq() to prevent interrupts
from being incorrectly enabled.Signed-off-by: Weiwei Wang
Signed-off-by: Jeff Garzik -
Now that arch/ppc is gone we don't need CONFIG_PPC_MERGE anymore remove
the dead code associated with !CONFIG_PPC_MERGE.With this change the pre_request_irq() and post_free_irq() calls became
nops so they have been removed. Also removed fs_request_irq() and
fs_free_irq() and just called request_irq() and free_irq().Signed-off-by: Kumar Gala
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: Jeff Garzik
Cc: Scott Wood
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik -
Now that arch/ppc is dead CONFIG_PPC_MERGE is always defined for all
powerpc platforms so we don't need to depend on it.Signed-off-by: Kumar Gala
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: Josh Boyer
Cc: David Gibson
Cc: Jeff Garzik
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik -
Signed-off-by: Jay Cliburn
Signed-off-by: Jeff Garzik -
This patch will add the phy reset bit into the power up mask which is
used during power up. Certain BIOSes will place the phy in reset and
therefore the driver must take the phy out of reset when it loads.Signed-off-by: Ayaz Abdulla
Signed-off-by: Jeff Garzik -
With 2.6.27-rc3 I noticed the following messages in my boot log:
0000:01:00.0: 0000:01:00.0: Warning: detected DSPD enabled in EEPROM
0000:01:00.0: eth0: (PCI Express:2.5GB/s:Width x1) 00:16:76:04:ff:09The second seems correct, but the first has a silly repetition of the
PCI device before the actual message. The message originates from
e1000_eeprom_checks in e1000e/netdev.c.With this patch below the first message becomes
e1000e 0000:01:00.0: Warning: detected DSPD enabled in EEPROM
which makes it similar to directly preceding messages.
Use dev_warn instead of e_warn in e1000_eeprom_checks() as the interface
name has not yet been assigned at that point.[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Frans Pop
Signed-off-by: Jeff Kirsher
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik -
Remove the unneeded (struct atl1e_adapter *) casts, for hw->adapter
already has type atl1e_adapter *.Signed-off-by: Jie Yang
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik -
Recent changes to MII bus initialization code added exit points which
didn't free or iounmap the bus before returning.Addresses http://bugzilla.kernel.org/show_bug.cgi?id=11372.
Signed-off-by: Andy Fleming
Reported-by: Daniel Marjamki
Cc: Jeff Garzik
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik -
Removing the module would cause a kernel oops as platform_driver_probe
failed to detect a device and unregistered the platform driver on module
init, and cleanup_module would unregister the already unregistered driver.
The suspend and resume functions weren't being called.platform_driver support was added earlier, but without any
platform_device_register* calls I don't think it was being used. Now all
devices are registered using platform_device_register_simple and pointers
are kept to unregister the ones that the probe failed for or unregister
all devices on module shutdown. init_module no longer calls ne_init to
reduce confusion (and multiple unregister paths that caused the rmmod
oops). With the devices now registered they are added to the platform
driver and get suspend and resume events.netif_device_detach(dev) was added before unregister_netdev(dev) when
removing the region as occationally I would see a race condition where the
device was still being used in unregister_netdev.Signed-off-by: David Fries
Cc: Atsushi Nemoto
Cc: Paul Gortmaker
Cc: Alan Cox
Cc: Jeff Garzik
Signed-off-by: Andrew Morton
Signed-off-by: Jeff Garzik -
The loop with the timeout used "while (... && timeout--)", which means
than when the timeout occurs, "timeout" will be -1 after the loop has
exited. The code that checks if the looped exited because of a timeout
used "if (timeout
Acked-by: Andy Fleming
Signed-off-by: Jeff Garzik -
When the driver fails to acquire the control flag used to serialize
NVM and PHY accesses between the driver, firmware and hardware, remove the
request for the flag otherwise the hardware might grant the flag when it
becomes available but the driver will not release the flag. This could
cause the firmware to prevent the driver getting the flag for all future
attempts.Signed-off-by: Bruce Allan
Signed-off-by: Jeff Kirsher
Signed-off-by: Jeff Garzik -
Bug fix: don't set netdev->name early before netdev registration. Setting
netdev->name early with dev_alloc_name() would occasionally cause netdev
registration to fail returning error that device was already registered.
Since we're using netdev->name to name MSI-X vectors, we now need to
move the request_irq after netdev registartion, so move it to ->open.Signed-off-by: Scott Feldman
Signed-off-by: Jeff Garzik -
Bug fix: Free MSI intr with correct data handle
Use davem proposed naming for MSI-X tx/rx vectors (ethX-tx-0, ethX-rx-0)Signed-off-by: Scott Feldman
Signed-off-by: Jeff Garzik -
Fixes for review items from Ben Hutchings:
- use netdev->net_stats rather than private net_stats
- use ethtool op .get_sset_count rather than .get_stats_count
- err out if setting Tx/Rx csum or TSO using ethtool and setting is
not enabled for device.
- pass in jiffies + constant to round_jiffies
- return err if new MTU is out-of-boundsSigned-off-by: Scott Feldman
Signed-off-by: Jeff Garzik -
LRO is only applied to IPv4 pkts, so don't use the LRO indication functions
for anything other IPv4 pkts. Every non-IPv4 pkt is indicated using non-
LRO functions.Signed-off-by: Scott Feldman
Signed-off-by: Jeff Garzik -
This patch fixes a wrong assignment in r6040_free_txbufs
on a receive skb pointer while we should actually do this
on the transmit skb pointer.Signed-off-by: Florian Fainelli
Signed-off-by: Jeff Garzik -
This patch allows reporting the link, checksum, and feature settings
of bonded device by using generic hooks.Signed-off-by: Stephen Hemminger
Acked-by: Jay Vosburgh
Signed-off-by: Jeff Garzik
