Eric Lee / smarc-fsl-linux-kernel

15 Jul, 2008

1 commit

30 Jun, 2008

1 commit

24 Jun, 2008

2 commits

06 Feb, 2008

1 commit

  • 5a1c3e1aa   drivers/pcmcia: Add missing iounmap ... Browse Code »

    of_iomap calls ioremap, and so should be matched with an iounmap. At the
    two error returns, the result of calling of_iomap is only stored in a local
    variable, so these error paths need to call iounmap. Furthermore, this
    function ultimately stores the result of of_iomap in an array that is local
    to the file. These values should be iounmapped at some point. I have
    added a corresponding call to iounmap at the end of the function
    m8xx_remove.

    The problem was found using the following semantic match.
    (http://www.emn.fr/x-info/coccinelle/)

    //
    @@
    type T,T1,T2;
    identifier E;
    statement S;
    expression x1,x2,x3;
    int ret;
    @@

    T E;
    ...
    * E = of_iomap(...);
    if (E == NULL) S
    ... when != iounmap(...,(T1)E,...)
    when != if (E != NULL) { ... iounmap(...,(T1)E,...); ...}
    when != x1 = (T1)E
    when != E = x3;
    when any
    if (...) {
    ... when != iounmap(...,(T2)E,...)
    when != if (E != NULL) { ... iounmap(...,(T2)E,...); ...}
    when != x2 = (T2)E
    (
    * return;
    |
    * return ret;
    )
    }
    //

    Signed-off-by: Julia Lawall
    Vitaly Bordug
    Cc: Arnd Bergmann
    Cc: Olof Johansson
    Cc: Dominik Brodowski
    Cc: Paul Mackerras
    Cc: Benjamin Herrenschmidt
    Cc: Kumar Gala
    Cc: Stephen Rothwell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Julia Lawall
     

03 Feb, 2008

1 commit

20 Oct, 2007

1 commit

  • 1977f0327   remove asm/bitops.h includes ... Browse Code »

    remove asm/bitops.h includes

    including asm/bitops directly may cause compile errors. don't include it
    and include linux/bitops instead. next patch will deny including asm header
    directly.

    Cc: Adrian Bunk
    Signed-off-by: Jiri Slaby
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jiri Slaby
     

22 Jul, 2007

1 commit

18 Jul, 2007

1 commit

  • 99121c0da   powerpc: 8xx: fix whitespace and indentation ... Browse Code »

    Rolling forward PCMCIA driver, it was discovered that the indentation in
    existing one, as well as in BSP side are very odd. This patch is just result
    of Lindent run ontop of culprit files.

    Signed-off-by: Vitaly Bordug
    Cc: Arnd Bergmann
    Cc: Olof Johansson
    Cc: Dominik Brodowski
    Cc: Paul Mackerras
    Cc: Benjamin Herrenschmidt
    Cc: Kumar Gala
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Vitaly Bordug
     

10 Jul, 2007

1 commit

  • 80128ff79   [POWERPC] 8xx: mpc885ads pcmcia support ... Browse Code »

    Adds support for PowerQuicc on-chip PCMCIA. The driver is implemented as
    of_device, so only arch/powerpc stuff is capable to use it, which now implies
    only mpc885ads reference board.

    To cope with the code that should be hooked inside driver, but is really board
    specific (like set_voltage), global structure mpc8xx_pcmcia_ops holds
    necessary function pointers that are filled in the BSP code.

    [akpm@linux-foundation.org: whitespace diddles]
    Signed-off-by: Vitaly Bordug
    Acked-by: Arnd Bergmann
    Acked-by: Olof Johansson
    Cc: Dominik Brodowski
    Cc: Paul Mackerras
    Cc: Benjamin Herrenschmidt
    Signed-off-by: Andrew Morton
    Signed-off-by: Kumar Gala

    Vitaly Bordug
     

24 Feb, 2007

1 commit

15 Feb, 2007

1 commit

  • cd354f1ae   [PATCH] remove many unneeded #includes of sched.h ... Browse Code »

    After Al Viro (finally) succeeded in removing the sched.h #include in module.h
    recently, it makes sense again to remove other superfluous sched.h includes.
    There are quite a lot of files which include it but don't actually need
    anything defined in there. Presumably these includes were once needed for
    macros that used to live in sched.h, but moved to other header files in the
    course of cleaning it up.

    To ease the pain, this time I did not fiddle with any header files and only
    removed #includes from .c-files, which tend to cause less trouble.

    Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
    arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
    allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
    configs in arch/arm/configs on arm. I also checked that no new warnings were
    introduced by the patch (actually, some warnings are removed that were emitted
    by unnecessarily included header files).

    Signed-off-by: Tim Schmielau
    Acked-by: Russell King
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tim Schmielau
     

26 Oct, 2006

1 commit

05 Oct, 2006

1 commit

  • 7d12e780e   IRQ: Maintain regs pointer globally rather than passing to IRQ handlers ... Browse Code »

    Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

28 Jun, 2006

1 commit

  • 34af946a2   [PATCH] spin/rwlock init cleanups ... Browse Code »

    locking init cleanups:

    - convert " = SPIN_LOCK_UNLOCKED" to spin_lock_init() or DEFINE_SPINLOCK()
    - convert rwlocks in a similar manner

    this patch was generated automatically.

    Motivation:

    - cleanliness
    - lockdep needs control of lock initialization, which the open-coded
    variants do not give
    - it's also useful for -rt and for lock debugging in general

    Signed-off-by: Ingo Molnar
    Signed-off-by: Arjan van de Ven
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ingo Molnar
     

06 Jan, 2006

4 commits

10 Nov, 2005

1 commit

  • e34631508   [PCMCIA] MPC8xx PCMCIA update ... Browse Code »

    Kconfig entry: dependency on 8xx
    Makefile: fix whitespace breakage
    m8xx_pcmcia.c:
    - asm/segment.h is gone
    - use generic PCMCIA suspend/resume methods

    Signed-off-by: Marcelo Tosatti
    Signed-off-by: Dominik Brodowski

    Marcelo Tosatti
     

29 Oct, 2005

1 commit

  • de957c89b   [PATCH] MPC8xx PCMCIA driver ... Browse Code »

    Here is an uptodated version of the MPC8xx PCMCIA driver for v2.6,
    addressing comments by Jeff and Dominik:

    - use IO accessors instead of direct device memory referencing
    - avoid usage of non-standard "uint/uchar" data types
    - kill struct typedef's

    Will submit it for inclusion once v2.6.14 is out.

    Testing on 8xx platforms is more than welcome! Works like a charm
    on our custom hardware (CONFIG_PRxK).

    Cc: Dominik Brodowski
    Signed-off-by: Andrew Morton
    Signed-off-by: Paul Mackerras

    Marcelo Tosatti