Eric Lee / smarc-fsl-linux-kernel

25 Jul, 2008

1 commit

  • 27ac792ca   PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures ... Browse Code »

    On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit
    boundary. For example:

    u64 val = PAGE_ALIGN(size);

    always returns a value < 4GB even if size is greater than 4GB.

    The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for
    example):

    #define PAGE_SHIFT 12
    #define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT)
    #define PAGE_MASK (~(PAGE_SIZE-1))
    ...
    #define PAGE_ALIGN(addr) (((addr)+PAGE_SIZE-1)&PAGE_MASK)

    The "~" is performed on a 32-bit value, so everything in "and" with
    PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary.
    Using the ALIGN() macro seems to be the right way, because it uses
    typeof(addr) for the mask.

    Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in
    include/linux/mm.h.

    See also lkml discussion: http://lkml.org/lkml/2008/6/11/237

    [akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c]
    [akpm@linux-foundation.org: fix v850]
    [akpm@linux-foundation.org: fix powerpc]
    [akpm@linux-foundation.org: fix arm]
    [akpm@linux-foundation.org: fix mips]
    [akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c]
    [akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c]
    [akpm@linux-foundation.org: fix powerpc]
    Signed-off-by: Andrea Righi
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrea Righi
     

01 Jun, 2007

1 commit

07 May, 2007

1 commit

27 Apr, 2007

1 commit

  • cd9ad58d4   [SCSI] SUNESP: Complete driver rewrite to version 2.0 ... Browse Code »

    Major features:

    1) Tagged queuing support.
    2) Will properly negotiate for synchronous transfers even on
    devices that reject the wide negotiation message, such as
    CDROMs
    3) Significantly lower kernel stack usage in interrupt
    handler path by elimination of function vector arrays,
    replaced by a top-level switch statement state machine.
    4) Uses generic scsi infrastructure as much as possible to
    avoid code duplication.
    5) Automatic request of sense data in response to CHECK_CONDITION
    6) Portable to other platforms using ESP such as DEC and Sun3
    systems.

    Signed-off-by: David S. Miller

    David S. Miller