07 Feb, 2008

1 commit

  • pci_get_device does a pci_dev_get, so pci_dev_put needs to be called in an
    error case

    The problem was fixed using the following semantic patch.
    (http://www.emn.fr/x-info/coccinelle/)

    //
    @exists@
    type T1,T2;
    identifier E;
    statement S,S1;
    expression x1,x2,x3;
    expression test;
    int ret != 0;
    @@

    struct pci_dev *E;
    ...
    (
    E = \(pci_get_slot\|pci_get_device\|pci_get_bus_and_slot\)(...);
    if (E == NULL) S
    |
    if ((E = \(pci_get_slot\|pci_get_device\|pci_get_bus_and_slot\)(...)) == NULL) S
    )
    ... when != pci_dev_put(...,(T1)E,...)
    when != if (E != NULL) { ... pci_dev_put(...,(T1)E,...); ...}
    when != x1 = (T1)E
    when != E = x3;
    when any
    (
    if (E == NULL) S1
    |
    if (test)
    + {
    (
    + pci_dev_put(E);
    return;
    |
    + pci_dev_put(E);
    return ret;
    )
    + }
    |
    if (test) {
    ... when != pci_dev_put(...,(T2)E,...)
    when != if (E != NULL) { ... pci_dev_put(...,(T2)E,...); ...}
    when != x2 = (T2)E
    (
    + pci_dev_put(E);
    return;
    |
    + pci_dev_put(E);
    return ret;
    )
    }
    )
    //

    Signed-off-by: Julia Lawall
    Cc: "David S. Miller"
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Julia Lawall
     

21 Jul, 2007

1 commit

  • The current scheme works on static interpretation of text names, which
    is wrong.

    The output-device setting, for example, must be resolved via an alias
    or similar to a full path name to the console device.

    Paths also contain an optional set of 'options', which starts with a
    colon at the end of the path. The option area is used to specify
    which of two serial ports ('a' or 'b') the path refers to when a
    device node drives multiple ports. 'a' is assumed if the option
    specification is missing.

    This was caught by the UltraSPARC-T1 simulator. The 'output-device'
    property was set to 'ttya' and we didn't pick upon the fact that this
    is an OBP alias set to '/virtual-devices/console'. Instead we saw it
    as the first serial console device, instead of the hypervisor console.

    The infrastructure is now there to take advantage of this to resolve
    the console correctly even in multi-head situations in fbcon too.

    Thanks to Greg Onufer for the bug report.

    Signed-off-by: David S. Miller

    David S. Miller
     

26 Apr, 2007

1 commit


13 Feb, 2007

2 commits


09 Dec, 2006

1 commit


18 Oct, 2006

1 commit


11 Jul, 2006

1 commit

  • MAX_NR_CONSOLES, fg_console, want_console and last_console are more of a
    function of the VT layer than the TTY one. Moving these to vt.h and vt_kern.h
    allows all of the framebuffer and VT console drivers to remove their
    dependency on tty.h.

    [akpm@osdl.org: fix alpha build]
    Signed-off-by: Jon Smirl
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jon Smirl
     

26 Jun, 2006

1 commit

  • Remove VM_LOCKED before remap_pfn range from device drivers and get rid of
    VM_SHM.

    remap_pfn_range() already sets VM_IO. There is no need to set VM_SHM since
    it does nothing. VM_LOCKED is of no use since the remap_pfn_range does not
    place pages on the LRU. The pages are therefore never subject to swap
    anyways. Remove all the vm_flags settings before calling remap_pfn_range.

    After removing all the vm_flag settings no use of VM_SHM is left. Drop it.

    Signed-off-by: Christoph Lameter
    Acked-by: Hugh Dickins
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christoph Lameter
     

15 Jan, 2006

1 commit

  • No need for a file argument. If we'd really need it it's in vma->vm_file
    already. gbefb and sgivwfb used to set vma->vm_file to the file argument, but
    the kernel alrady did that.

    Signed-off-by: Christoph Hellwig
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christoph Hellwig
     

17 Apr, 2005

1 commit

  • Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds