29 Sep, 2008
2 commits
-
Conversion to new-style i2c driver missed the error path of the
probe function. Fix it.Signed-off-by: Jean Delvare
Cc: Timur Tabi
Signed-off-by: Takashi Iwai -
Update the CS4270 ALSA device driver to use the new-style I2C interface.
Starting with the 2.6.27 PowerPC kernel, I2C devices that have entries in the
device trees can no longer be probed by old-style I2C drivers. The device
tree for Freescale MPC8610 HPCD has included an entry for the CS4270 since
2.6.25, but that entry was previously ignored by the PowerPC I2C subsystem.
Since that's no longer the case, the best solution is to update the CS4270
driver to a new-style interface, rather than try to revert the behavior of
new PowerPC I2C subsystem.Signed-off-by: Timur Tabi
Signed-off-by: Takashi Iwai
25 Sep, 2008
2 commits
-
The power_mutex lock in snd_pcm_drop may cause a possible deadlock
chain, and above all, it's unneeded. Let's get rid of it.Signed-off-by: Takashi Iwai
-
The PCM and rawmidi open callbacks have a lock against card->controls_list
but it takes a wrong one, card->controls_rwsem, instead of a right one
card->ctl_files_rwlock. This patch fixes them.This change also fixes automatically the potential deadlocks due to
mm->mmap_sem in munmap and copy_from/to_user, reported by Sitsofe
Wheeler:A: snd_ctl_elem_user_tlv(): card->controls_rwsem => mm->mmap_sem
B: snd_pcm_open(): card->open_mutex => card->controls_rwsem
C: munmap: mm->mmap_sem => snd_pcm_release(): card->open_mutexThe patch breaks the chain.
Signed-off-by: Takashi Iwai
22 Sep, 2008
1 commit
-
s/PDC_PTCR/ATMEL_PDC_PTCR/
Signed-off-by: Haavard Skinnemoen
Acked-by: Mark Brown
Signed-off-by: Takashi Iwai
06 Sep, 2008
1 commit
-
CONFIG_AC97_BUS is used from both sound and ucb1400 drivers.
The recent change in Kconfig introduced the exclusive dependency on
CONFIG_SOUND, and disabled the ucb1400 build without sound.
This patch makes CONFIG_AC97_BUS independent.Signed-off-by: Takashi Iwai
Tested-by: Randy Dunlap
02 Sep, 2008
2 commits
-
Signed-off-by: Takashi Iwai
-
Fix the wrong DAC assignment for NID 0x17 mono-pin on ALC663.
Signed-off-by: Takashi Iwai
01 Sep, 2008
2 commits
-
pxa2xx-i2s: probe actual device and use it for clk_get call
thus fixing error during startup hookSigned-off-by: Dmitry Baryshkov
Acked-by: Mark Brown
Signed-off-by: Takashi Iwai -
Added the EQ distortion fix to the dell_m6_core_init.
Signed-off-by: Matthew Ranostay
Signed-off-by: Takashi Iwai
29 Aug, 2008
1 commit
-
When changing the sample rate, the CMI8788's master clock output becomes
unstable for a short time. The AK4396 needs the master clock to do SPI
writes, so writing to an AK4396 control register directly after a sample
rate change will garble the value. In our case, this leads to the DACs
being misconfigured to I2S sample format, which results in a wrong
output level and horrible distortions on samples louder than -6 dB.To fix this, we need to wait until the new master clock signal has
become stable before doing SPI writes.Signed-off-by: Clemens Ladisch
Signed-off-by: Takashi Iwai
27 Aug, 2008
1 commit
-
This reverts commit 3e0e469fa216ec70c93b1593821b759d19ee2e6b.
The patch introduced a wrong detection of other intel Macs with
ALC88* codec because they share the same PCI SSID (but have different
codec subsystem-IDs). See http://lkml.org/lkml/2008/8/24/143Reported-and-tested-by: Guillaume Chazarain
Signed-off-by: Takashi Iwai
26 Aug, 2008
4 commits
-
Thanks to Felipe Balbi by noticing that if clk_get
to sys_clkout2_src fails, then n810_snd_device is never released.Add also sys_clkout2_src release into error path, error code return and
release the clocks at exit.Signed-off-by: Jarkko Nikula
Acked-by: Mark Brown
Signed-off-by: Takashi Iwai -
The Xonar DX does not have CD Capture controls, so we have to check that
a control actually exists before muting it.Signed-off-by: Clemens Ladisch
Cc:
Signed-off-by: Takashi Iwai -
Signed-off-by: Stephen Rothwell
Signed-off-by: Linus Torvalds -
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6:
ALSA: ASoC: Fix double free and memory leak in many codec drivers
ALSA: CA0106 on MSI K8N Diamond PLUS Motherboard
25 Aug, 2008
2 commits
-
Many SoC audio codec drivers have improper freeing of memory in error
paths.* codec is allocated in the platform device probe function, but is not
freed there in case of error. Instead it is freed in the i2c device
probe function's error path. However the success or failure of both
functions is not linked, so this could result in a double free (if
the platform device is successfully probed, the i2c device probing
fails and then the platform driver is unregistered.)* codec->private_data is allocated in many platform device probe
functions but not freed in their error paths.This patch hopefully solves all these problems.
Signed-off-by: Jean Delvare
Signed-off-by: Mark Brown
Signed-off-by: Takashi Iwai -
Correct a previous patch for the ca0106 onboard the MSI K8N Diamond PLUS
motherboard. Confirmed to have Line/Mic/Aux working for input, and sound
output working as expected.Signed-off-by: Travis Place
Signed-off-by: Takashi Iwai
24 Aug, 2008
1 commit
-
This patch lets the files using linux/version.h match the files that
#include it.Signed-off-by: Adrian Bunk
Signed-off-by: Linus Torvalds
22 Aug, 2008
1 commit
-
Using init_hook to call alc888_coef_init() is problematic for configurations
that already set another init_hook. Better to put it in alc_init() as is
(although it looks a bit hackish).Signed-off-by: Takashi Iwai
21 Aug, 2008
1 commit
-
Enable the snoop for nvidia hda controller to avoid data coherence issue.
Signed-off-by: Peer Chen
Signed-off-by: Andrew Morton
Signed-off-by: Takashi Iwai
17 Aug, 2008
1 commit
-
On some Realtek codecs like ALC882 or ALC883, the capture source is
no mux but sum widget. We have to initialize all channels properly
for this type, otherwise noises may come in from the unused route.The patch assures to mute unused routes, and unmute the currently
selected route.Signed-off-by: Takashi Iwai
Tested-by: Daniel J Blueman
15 Aug, 2008
2 commits
-
The latest revisions of the WM8990 provide a programmable gain amplifier
for the speaker - configure the register cache and implement controls
for this. Older revisions of the device ignore writes to these controls.Signed-off-by: Mark Brown
Signed-off-by: Takashi Iwai -
Signed-off-by: Mark Brown
Signed-off-by: Takashi Iwai
14 Aug, 2008
1 commit
-
Add support for the Asus Xonar D1. It is the same as the DX, but
without the external power detection.Signed-off-by: Clemens Ladisch
Signed-off-by: Takashi Iwai
12 Aug, 2008
4 commits
-
Signed-off-by: Libin Yang
Signed-off-by: Takashi Iwai -
This patch adds the Intel Ibex Peak (PCH) HD Audio Controller DeviceIDs.
Signed-off by: Seth Heasley
Signed-off-by: Takashi Iwai -
Add missing output VREF. After a65f0568f6cc8433877fb71dd7d36b551854b0bc
it's critical, since it makes chip routing initialisation to fail.Signed-off-by: Dmitry Baryshkov
Acked-by: Mark Brown
Signed-off-by: Takashi Iwai -
Correct route name to be MONO1 instead of MONO to follow
recent fix in wm8750.Signed-off-by: Dmitry Baryshkov
Acked-by: Mark Brown
Signed-off-by: Takashi Iwai
11 Aug, 2008
1 commit
-
Since first commit wm8750 contained output named MONO, but
all routes mentioned MONO1. Correct MONO to be MONO1.Signed-off-by: Dmitry Baryshkov
Acked-by: Mark Brown
Signed-off-by: Takashi Iwai
09 Aug, 2008
1 commit
-
Conflicts:
drivers/watchdog/at91rm9200_wdt.c
drivers/watchdog/davinci_wdt.c
drivers/watchdog/ep93xx_wdt.c
drivers/watchdog/ixp2000_wdt.c
drivers/watchdog/ixp4xx_wdt.c
drivers/watchdog/ks8695_wdt.c
drivers/watchdog/omap_wdt.c
drivers/watchdog/pnx4008_wdt.c
drivers/watchdog/sa1100_wdt.c
drivers/watchdog/wdt285.c
08 Aug, 2008
1 commit
-
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6:
ALSA: ASoC: fix SNDCTL_DSP_SYNC support in Freescale 8610 sound drivers
07 Aug, 2008
6 commits
-
This just leaves include/asm-arm/plat-* to deal with.
Signed-off-by: Russell King
-
Remove includes of asm/hardware.h in addition to asm/arch/hardware.h.
Then, since asm/hardware.h only exists to include asm/arch/hardware.h,
update everything to directly include asm/arch/hardware.h and remove
asm/hardware.h.Signed-off-by: Russell King
-
There are 43 includes of asm/mach-types.h by files that don't
reference anything from that file. Remove these unnecessary
includes.Signed-off-by: Russell King
-
This reverts commit 680db0136e0778a0d7e025af7572c6a8d82279e2. The label
is actually used, but hidden behind CONFIG_SND_DEBUG and the horrible
snd_assert() macro.That macro could probably be improved to be along the lines of
#define snd_assert(expr, args...) do { if ((void)(expr),0) { args; } } while (0)
or similar to make sure that we always both evaluate 'expr' and parse
'args', but while gcc should optimize it all away, I'm too lazy to
really verify that. So I'll just admit defeat and will continue to live
with the annoying warning.Noted-by: Robert P. J. Day
Signed-off-by: Linus "Grr.." Torvalds -
This fixes the warning
sound/core/pcm_native.c: In function 'snd_pcm_fasync':
sound/core/pcm_native.c:3262: warning: label 'out' defined but not usedSigned-off-by: Linus Torvalds
05 Aug, 2008
1 commit
-
snd_seq_oss_synth_make_info() incorrectly reports information
to userspace without first checking for the validity of the
device number, leading to possible information leak (CVE-2008-3272).Reported-By: Tobias Klein
Acked-and-tested-by: Takashi Iwai
Cc: stable@kernel.org
Signed-off-by: Willy Tarreau
Signed-off-by: Linus Torvalds
04 Aug, 2008
1 commit
-
If an OSS application calls SNDCTL_DSP_SYNC, then ALSA will call the driver's
_hw_params and _prepare functions again. On the Freescale MPC8610 DMA ASoC
driver, this caused the DMA controller to be unneccessarily re-programmed, and
apparently it doesn't like that. The DMA will then not operate when
instructed. This patch relocates much of the DMA programming to
fsl_dma_open(), which is called only once.Signed-off-by: Timur Tabi
Signed-off-by: Takashi Iwai