13 Oct, 2007
1 commit
-
The Coverity checker spotted that we have already oops'ed if "us"
was NULL.Since "us" can't be NULL in the only caller this patch removes the
NULL check.Signed-off-by: Adrian Bunk
Signed-off-by: Matthew Dharm
Signed-off-by: Greg Kroah-Hartman
15 Feb, 2007
1 commit
-
After Al Viro (finally) succeeded in removing the sched.h #include in module.h
recently, it makes sense again to remove other superfluous sched.h includes.
There are quite a lot of files which include it but don't actually need
anything defined in there. Presumably these includes were once needed for
macros that used to live in sched.h, but moved to other header files in the
course of cleaning it up.To ease the pain, this time I did not fiddle with any header files and only
removed #includes from .c-files, which tend to cause less trouble.Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
configs in arch/arm/configs on arm. I also checked that no new warnings were
introduced by the patch (actually, some warnings are removed that were emitted
by unnecessarily included header files).Signed-off-by: Tim Schmielau
Acked-by: Russell King
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
22 Jun, 2006
2 commits
-
Use USB vendor and product IDs to determine whether the attached
device is a CDROM or a Flash device. Daniel Drake says that the
*same* vendor and product IDs for non-HP vendor ID could be either
flash or cdrom, so try to probe for them.Signed-off-by: Peter Chubb
Signed-off-by: Daniel Drake
Signed-off-by: Greg Kroah-Hartman -
I've worked out what's going wrong. The scsi layer is now much
more likely to pass down scatterlists instead of plain buffers. So
you have to make sure that they're handled correctly. In one of the
changes along the way, usbat_write_block and friends stopped obeying
the srb->use_sg flag.Anyway, with the appended patch, and the one I'm putting in the next email, it
all seems to work for the HP cd4e. Of course, someone's going to have
to test it with the flash drives as well....This patch teaches the usbat_{read,write}_block functions to
obey the use_sg flag in the scsi-request.Signed-off-by: Peter Chubb
Signed-off-by: Daniel Drake
Signed-off-by: Greg Kroah-Hartman
21 Mar, 2006
1 commit
-
another one for kzalloc. This covers the storage subdirectory.
Signed-off-by: Oliver Neukum
Signed-off-by: Greg Kroah-Hartman
18 Nov, 2005
1 commit
-
Peter Favrholdt reported that his Kodak flash device was getting
detected as a CDROM, and he helped me track this down to the fact that
the device takes a long time (approx 440ms!) to reset.This patch increases the delay to 500ms, which solves the problem.
Signed-off-by: Daniel Drake
Signed-off-by: Greg Kroah-Hartman
Signed-off-by: Linus Torvalds
29 Oct, 2005
2 commits
-
A while ago, Matthew Dharm wrote:
> Looks good. Tho, I would like to see a future patch to do two things:
> 1) Change comments from C++ style to C-style
> 2) Make sure we're naming consistently everywhere SCM, USBAT,
> USBAT-02 (most noticably needing fixing is the string used at
> transport-selection time, but a sweep of all uses to be consistent
> would be in order).Sorry for the long delay, here is a patch to address this. I also clarified
some ATA/ATAPI wording + function names.Signed-off-by: Daniel Drake
Signed-off-by: Greg Kroah-Hartmandrivers/usb/storage/shuttle_usbat.c | 306 ++++++++++++++++++++----------------
drivers/usb/storage/shuttle_usbat.h | 66 +++----
drivers/usb/storage/transport.h | 2
drivers/usb/storage/unusual_devs.h | 10 -
drivers/usb/storage/usb.c | 4
5 files changed, 213 insertions(+), 175 deletions(-) -
There appears to be one more case where the HP8200 CD writer devices are
detected as flash readers - when the USB cable is replugged after use, with
the power cable still connected.Oddly enough, the identify device command appears to 'fall through' when the
devices are in this state, the status register reading exactly the same opcode
as the command (0xA1) that was just executed.I think it's safe to label this behaviour as specific to HP8200 devices, I
can't get the flash devices to respond like this.This patch should solve the last of the HP8200 issues which have cropped up
recently.Signed-off-by: Daniel Drake
Signed-off-by: Greg Kroah-Hartmandrivers/usb/storage/shuttle_usbat.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
09 Sep, 2005
1 commit
-
Adding flash-device support to the shuttle_usbat driver in 2.6.11
introduced the need to detect which type of device we are dealing with:
CDRW drive, or flash media reader.The detection routine used turned out to not work for HP8200 CDRW users,
who saw their devices being detected as a flash disk.This patch (which has been tested on both flash and cdrom) removes some
unnecessary code, moves device detection to much later during
initialization, and introduces a new detection routine which appears to
work.Signed-off-by: Daniel Drake
Signed-off-by: Greg Kroah-Hartman
04 May, 2005
1 commit
-
Here are some spelling corrections for drivers/usb.
cancelation -> cancellation
succesful -> successful
cancelation -> cancellation
decriptor -> descriptor
Initalize -> Initialize
wierd -> weird
Protocoll -> Protocol
occured -> occurred
successfull -> successful
Procesing -> Processing
devide -> divide
Isochronuous -> Isochronous
noticable -> noticeable
Basicly -> Basically
transfering -> transferring
intialize -> initialize
Incomming -> Incoming
additionnal -> additional
asume -> assume
Unfortunatly -> Unfortunately
retreive -> retrieve
tranceiver -> transceiver
Compatiblity -> Compatibility
Incorprated -> Incorporated
existance -> existence
Ununsual -> UnusualSigned-off-by: Steven Cole
Signed-off-by: Greg Kroah-Hartman
17 Apr, 2005
1 commit
-
Initial git repository build. I'm not bothering with the full history,
even though we have it. We can create a separate "historical" git
archive of that later if we want to, and in the meantime it's about
3.2GB when imported into git - space that would just make the early
git days unnecessarily complicated, when we don't have a lot of good
infrastructure for it.Let it rip!
