01 May, 2008

1 commit

  • x86.git randconfig testing found the following build error in latest
    -git:

    CC [M] drivers/isdn/hysdn/hysdn_procconf.o
    CC [M] drivers/isdn/hysdn/hysdn_init.o
    drivers/isdn/hysdn/hysdn_procconf.c: In function 'hysdn_procconf_init':
    drivers/isdn/hysdn/hysdn_procconf.c:408: error: too few arguments to function 'proc_create'

    with the following config:

    http://redhat.com/~mingo/misc/config-Wed_Apr_30_15_12_48_CEST_2008.bad

    Signed-off-by: Ingo Molnar
    Cc: "Denis V. Lunev"
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ingo Molnar
     

30 Apr, 2008

4 commits

  • - Operations are now a shared const function block as with most other Linux
    objects

    - Introduce wrappers for some optional functions to get consistent behaviour

    - Wrap put_char which used to be patched by the tty layer

    - Document which functions are needed/optional

    - Make put_char report success/fail

    - Cache the driver->ops pointer in the tty as tty->ops

    - Remove various surplus lock calls we no longer need

    - Remove proc_write method as noted by Alexey Dobriyan

    - Introduce some missing sanity checks where certain driver/ldisc
    combinations would oops as they didn't check needed methods were present

    [akpm@linux-foundation.org: fix fs/compat_ioctl.c build]
    [akpm@linux-foundation.org: fix isicom]
    [akpm@linux-foundation.org: fix arch/ia64/hp/sim/simserial.c build]
    [akpm@linux-foundation.org: fix kgdb]
    Signed-off-by: Alan Cox
    Acked-by: Greg Kroah-Hartman
    Cc: Jason Wessel
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Cox
     
  • Signed-off-by: Alan Cox
    Acked-by: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Cox
     
  • - Stop drivers calling their own flush method indirectly, it obfuscates code
    and it will change soon anyway

    - A few more lock_kernel paths temporarily needed in some driver internal
    waiting code

    - Remove private put_char method that does a write call for one char - we
    have that anyway

    - Most but not yet all of the termios copy under lock fixing (some has other
    dependencies to follow)

    - Note a few locking bugs in drivers found in the process

    - Kill remaining [ab]users of TIOCG/SSOFTCAR in the driver, these must go to
    fix the termios locking

    Signed-off-by: Alan Cox
    Cc: Jiri Slaby
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Cox
     
  • Three things here
    - Remove softcar handler
    - Correct termios change detection logic
    - Wrap break/ioctl in lock_kernel ready to drop it in the caller

    Signed-off-by: Alan Cox
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alan Cox
     

29 Apr, 2008

1 commit

  • Use proc_create()/proc_create_data() to make sure that ->proc_fops and ->data
    be setup before gluing PDE to main tree.

    Add correct ->owner to proc_fops to fix reading/module unloading race.

    Signed-off-by: Denis V. Lunev
    Acked-by: Karsten Keil
    Cc: Alexey Dobriyan
    Cc: "Eric W. Biederman"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Denis V. Lunev
     

28 Apr, 2008

8 commits

  • Since CONFIG_AVMB1_COMPAT is not a Kconfig variable, move it out of the
    Kconfig namespace.

    Signed-off-by: Robert P. J. Day
    Acked-by: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Robert P. J. Day
     
  • capifs_remount may reach 'return' statement without freeing of memory
    allocated by kstrdup call

    Signed-off-by: Cyrill Gorcunov
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Cyrill Gorcunov
     
  • The PNP driver interfaces depend on CONFIG_PNP, so test that rather than
    __ISAPNP__.

    Signed-off-by: Bjorn Helgaas
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Bjorn Helgaas
     
  • Fix a rather obvious cut-and-paste error, where earlier code for the
    controller URB got somehow mixed in with code for the interrupt URB.

    Signed-off-by: Robert P. J. Day
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Robert P. J. Day
     
  • __FUNCTION__ is gcc-specific, use __func__

    Signed-off-by: Harvey Harrison
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Harvey Harrison
     
  • drivers/isdn/hardware/eicon/message.c:745:47: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/eicon/message.c:761:45: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/eicon/message.c:9122:16: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/eicon/message.c:9147:16: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/eicon/message.c:9173:14: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/eicon/divasmain.c:396:23: warning: Using plain integer as NULL pointer

    Signed-off-by: Harvey Harrison
    Cc: Karsten Keil
    Cc: Jeff Garzik
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Harvey Harrison
     
  • drivers/isdn/hardware/avm/b1isa.c:206:37: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/b1isa.c:208:33: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/b1.c:664:42: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/b1.c:666:44: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/b1.c:668:42: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/b1.c:791:37: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/b1.c:793:33: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/b1pci.c:385:37: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/b1pci.c:387:33: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/b1dma.c:886:42: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/b1dma.c:888:44: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/b1dma.c:890:42: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/b1dma.c:973:37: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/b1dma.c:975:33: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/b1pcmcia.c:204:37: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/b1pcmcia.c:206:33: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/t1isa.c:554:37: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/t1isa.c:556:33: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/t1pci.c:236:37: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/t1pci.c:238:33: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/c4.c:1091:42: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/c4.c:1093:44: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/c4.c:1095:42: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/c4.c:1170:21: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/c4.c:1294:37: warning: Using plain integer as NULL pointer
    drivers/isdn/hardware/avm/c4.c:1296:33: warning: Using plain integer as NULL pointer

    Signed-off-by: Harvey Harrison
    Cc: Karsten Keil
    Cc: Jeff Garzik
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Harvey Harrison
     
  • drivers/isdn/capi/kcapi.c:829:30: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/kcapi.c:838:27: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/kcapi.c:954:17: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/kcapi.c:1007:37: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/kcapi.c:1009:33: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capiutil.c:453:24: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capilib.c:47:30: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capi.c:353:29: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capi.c:369:15: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capi.c:486:48: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capi.c:515:46: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capi.c:541:47: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capi.c:692:47: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capi.c:699:49: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capi.c:704:14: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capi.c:943:53: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capi.c:948:32: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capi.c:969:42: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capi.c:989:48: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capi.c:1026:69: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capi.c:1028:19: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capi.c:1061:20: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capi.c:1529:37: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capi.c:1531:33: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capidrv.c:338:15: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capidrv.c:758:32: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capidrv.c:880:40: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capidrv.c:407:15: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capidrv.c:429:49: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capidrv.c:407:15: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capidrv.c:444:49: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capidrv.c:429:49: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capidrv.c:429:49: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capidrv.c:429:49: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capidrv.c:429:49: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capidrv.c:429:49: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capidrv.c:1664:61: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capidrv.c:1969:37: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capidrv.c:2294:37: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capidrv.c:2297:33: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capidrv.c:2338:37: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capidrv.c:2341:33: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capifs.c:192:37: warning: Using plain integer as NULL pointer
    drivers/isdn/capi/capifs.c:194:33: warning: Using plain integer as NULL pointer

    Signed-off-by: Harvey Harrison
    Cc: Karsten Keil
    Cc: Jeff Garzik
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Harvey Harrison
     

22 Apr, 2008

1 commit


21 Apr, 2008

3 commits

  • - reference irq number in CardState structure

    - remove now-unused 'intno' argument from rs_interrupt_elsa()

    - cs->irq_func() should be defined using standard irq_handler_t

    - add KERN_DEBUG to printk() where appropriate

    Signed-off-by: Jeff Garzik

    Jeff Garzik
     
  • For the vast majority of CardType[card->typ] uses (but not all!),
    the string is constant for each driver. Therefore, we may replace
    CardType[card->typ] with the actual string describing the driver, making
    each printk() a bit more simple.

    This also has the nice, intended side effect of greatly reducing
    external references to hisax global CardType[]. This will be of value
    once the ISDN drivers are converted to the ISA/PCI/PNP hotplug APIs.

    Signed-off-by: Jeff Garzik

    Jeff Garzik
     
  • Pass a function pointer into the core HiSax probe function checkcard(),
    in order to facilitate modular drivers passing in their own setup
    routines.

    Signed-off-by: Jeff Garzik

    Jeff Garzik
     

14 Apr, 2008

1 commit


13 Mar, 2008

1 commit

  • * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6: (47 commits)
    [SCTP]: Fix local_addr deletions during list traversals.
    net: fix build with CONFIG_NET=n
    [TCP]: Prevent sending past receiver window with TSO (at last skb)
    rt2x00: Add new D-Link USB ID
    rt2x00: never disable multicast because it disables broadcast too
    libertas: fix the 'compare command with itself' properly
    drivers/net/Kconfig: fix whitespace for GELIC_WIRELESS entry
    [NETFILTER]: nf_queue: don't return error when unregistering a non-existant handler
    [NETFILTER]: nfnetlink_queue: fix EPERM when binding/unbinding and instance 0 exists
    [NETFILTER]: nfnetlink_log: fix EPERM when binding/unbinding and instance 0 exists
    [NETFILTER]: nf_conntrack: replace horrible hack with ksize()
    [NETFILTER]: nf_conntrack: add \n to "expectation table full" message
    [NETFILTER]: xt_time: fix failure to match on Sundays
    [NETFILTER]: nfnetlink_log: fix computation of netlink skb size
    [NETFILTER]: nfnetlink_queue: fix computation of allocated size for netlink skb.
    [NETFILTER]: nfnetlink: fix ifdef in nfnetlink_compat.h
    [NET]: include into linux/ethtool.h for __u* typedef
    [NET]: Make /proc/net a symlink on /proc/self/net (v3)
    RxRPC: fix rxrpc_recvmsg()'s returning of msg_name
    net/enc28j60: oops fix
    ...

    Linus Torvalds
     

08 Mar, 2008

1 commit

  • The card state mutex was only initialized when a device was connected,
    but used during unload unconditionally, leading to an Oops if a driver
    was loaded and unloaded again without ever connecting a device.

    Fix this by initializing the mutex as soon as the structure is allocated.
    Also add a missing mutex unlock revealed in the same execution path.

    This fixes a possible Oops in 2.6.25-rc that was introduced by commit
    e468c04894f36045cf93d1384183a461014b6840 ("Gigaset: permit module
    unload").

    Thanks to Roland Kletzing for reporting this problem.

    Signed-off-by: Tilman Schmidt
    Tested-by: Roland Kletzing
    Cc: Hansjoerg Lipp
    Cc: Karsten Keil
    Signed-off-by: Linus Torvalds

    Tilman Schmidt
     

06 Mar, 2008

1 commit


05 Mar, 2008

2 commits

  • After a quick glance at the code, we're getting the DEBUG_SHIRQ spurious
    interrupt before we have the adapter template filled in. Real interrupts
    appear to be turned on by fcpci*_init(), so move request_irq until just before
    that.

    Signed-off-by: Kyle McMartin
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Kyle McMartin
     
  • In commit e6bafba5b4765a5a252f1b8d31cbf6d2459da337 ("wmi: (!x & y)
    strikes again"), a bug was fixed that involved converting !x & y to !(x
    & y). The code below shows the same pattern, and thus should perhaps be
    fixed in the same way.

    This is not tested and clearly changes the semantics, so it is only
    something to consider.

    The semantic patch that makes this change is as follows:
    (http://www.emn.fr/x-info/coccinelle/)

    //
    @@ expression E1,E2; @@
    (
    !E1 & !E2
    |
    - !E1 & E2
    + !(E1 & E2)
    )
    //

    Signed-off-by: Julia Lawall
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Julia Lawall
     

10 Feb, 2008

4 commits

  • Fix following warnings:
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x19723): Section mismatch in reference from the function ISACVersion() to the variable .devinit.data:ISACVer
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x2005b): Section mismatch in reference from the function setup_avm_a1_pcmcia() to the function .devinit.text:setup_isac()

    ISACVer were only used from function annotated __devinit
    so add same annotation to ISACVer.
    One af the fererencing functions missed __devinit so add it
    and kill an additional warning.

    Signed-off-by: Sam Ravnborg
    Acked-by: Karsten Keil
    Cc: Jeff Garzik
    Signed-off-by: David S. Miller

    Sam Ravnborg
     
  • Fix the following warnings:
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x722): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_teles3()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x72c): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_s0box()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x736): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_telespci()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x747): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_avm_pcipnp()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x74e): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_elsa()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x755): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_diva()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x75c): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_sedlbauer()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x763): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_netjet_s()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x76a): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_hfcpci()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x771): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_hfcsx()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x778): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_niccy()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x77f): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_bkm_a4t()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x786): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_sct_quadro()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x78d): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_gazel()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x794): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_w6692()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x79b): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_netjet_u()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x7a2): Section mismatch in reference from the function hisax_cs_setup_card() to the function .devinit.text:setup_enternow_pci()

    checkcard() are the only user of hisax_cs_setup_card().
    And checkcard is only used during init or when hot plugging
    ISDN devices. So annotate hisax_cs_setup_card() with __devinit.
    checkcard() is used by exported functions so it cannot be
    annotated __devinit. Annotate it with __ref so modpost
    ignore references to _devinit section.

    Signed-off-by: Sam Ravnborg
    Acked-by: Karsten Keil
    Cc: Jeff Garzik
    Signed-off-by: David S. Miller

    Sam Ravnborg
     
  • Fix the following warnings:
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x1b276): Section mismatch in reference from the function inithscxisac() to the function .devinit.text:clear_pending_isac_ints()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x1b286): Section mismatch in reference from the function inithscxisac() to the function .devinit.text:initisac()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x1fec7): Section mismatch in reference from the function AVM_card_msg() to the function .devinit.text:clear_pending_isac_ints()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x21669): Section mismatch in reference from the function AVM_card_msg() to the function .devinit.text:clear_pending_isac_ints()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x21671): Section mismatch in reference from the function AVM_card_msg() to the function .devinit.text:initisac()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x2991e): Section mismatch in reference from the function Sedl_card_msg() to the function .devinit.text:clear_pending_isac_ints()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x29936): Section mismatch in reference from the function Sedl_card_msg() to the function .devinit.text:initisac()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x2993e): Section mismatch in reference from the function Sedl_card_msg() to the function .devinit.text:initisar()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x2e026): Section mismatch in reference from the function NETjet_S_card_msg() to the function .devinit.text:clear_pending_isac_ints()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x2e02e): Section mismatch in reference from the function NETjet_S_card_msg() to the function .devinit.text:initisac()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x37813): Section mismatch in reference from the function BKM_card_msg() to the function .devinit.text:clear_pending_isac_ints()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x37823): Section mismatch in reference from the function BKM_card_msg() to the function .devinit.text:initisac()

    initisar(), initisac() and clear_pending_isac_ints()
    were all used via a cardmsg fnction - which may be called
    ouside __devinit context.
    So remove the bogus __devinit annotation of the
    above three functions to fix the warnings.

    Signed-off-by: Sam Ravnborg
    Acked-by: Karsten Keil
    Cc: Jeff Garzik
    Signed-off-by: David S. Miller

    Sam Ravnborg
     
  • Fix the following warning:
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x35818): Section mismatch in reference from the function hfcsx_card_msg() to the function .devinit.text:inithfcsx()

    hfcsx_card_msg() may be called outside __devinit context.
    Following the program logic is looks like the CARD_INIT branch
    will only be taken under __devinit context but to be consistent
    remove the __devinit annotation of inithfcsx() so we
    do not mix non-__devinit and __devinit code.

    Signed-off-by: Sam Ravnborg
    Acked-by: Karsten Keil
    Cc: Jeff Garzik
    Signed-off-by: David S. Miller

    Sam Ravnborg
     

09 Feb, 2008

2 commits

  • * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6: (21 commits)
    [IPSEC] flow: reorder "struct flow_cache_entry" and remove SLAB_HWCACHE_ALIGN
    [DECNET] ROUTE: remove unecessary alignment
    [IPSEC]: Add support for aes-ctr.
    [ISDN]: fix section mismatch warning in enpci_card_msg
    [TIPC]: declare proto_ops structures as 'const'.
    [TIPC]: Kill unused static inline (x5)
    [TC]: oops in em_meta
    [IPV6] Minor cleanup: remove unused definitions in net/ip6_fib.h
    [IPV6] Minor clenup: remove two unused definitions in net/ip6_route.h
    [AF_IUCV]: defensive programming of iucv_callback_txdone
    [AF_IUCV]: broken send_skb_q results in endless loop
    [IUCV]: wrong irq-disabling locking at module load time
    [CAN]: Minor clean-ups
    [CAN]: Move proto_{,un}register() out of spin-locked region
    [CAN]: Clean up module auto loading
    [IPSEC] flow: Remove an unnecessary ____cacheline_aligned
    [IPV4]: route: fix crash ip_route_input
    [NETFILTER]: xt_iprange: add missing #include
    [NETFILTER]: xt_iprange: fix typo in address family
    [NETFILTER]: nf_conntrack: fix ct_extend ->move operation
    ...

    Linus Torvalds
     
  • Add a .show_options super operation to capifs.

    Use generic_show_options() and save the complete option string in
    capifs_remount().

    Signed-off-by: Miklos Szeredi
    Acked-by: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Miklos Szeredi
     

08 Feb, 2008

1 commit

  • Fix following warnings:
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x3cf50): Section mismatch in reference from the function enpci_card_msg() to the function .devinit.text:Amd7930_init()
    WARNING: drivers/isdn/hisax/built-in.o(.text+0x3cf85): Section mismatch in reference from the function enpci_card_msg() to the function .devinit.text:Amd7930_init()

    enpci_card_msg() can be called outside __devinit context
    referenced function should not be annotated __devinit.

    Remove annotation of Amd7930_init to fix this.

    Signed-off-by: Sam Ravnborg
    Signed-off-by: David S. Miller

    Sam Ravnborg
     

07 Feb, 2008

9 commits

  • drivers/isdn/hardware/eicon/debug.c: In function 'SuperTraceASSIGN':
    drivers/isdn/hardware/eicon/debug.c:1191: warning: 'rx_dma_magic' may be used uninitialized in this function

    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     
  • '!' has a higher priority than '&'.

    Signed-off-by: Roel Kluin
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Roel Kluin
     
  • The ser_gigaset ISDN driver was using a mutex in its close() method for
    waiting for other running ldisc methods to finish. That's what completions
    are for. Incidentally, this also avoids a spurious "BUG: lock held at task
    exit time" message when the driver's userspace daemon daemonizes itself.

    Signed-off-by: Tilman Schmidt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tilman Schmidt
     
  • Fix the initialization and reference counting of the Gigaset driver modules
    so that they can be unloaded when they are not actually in use.

    Signed-off-by: Tilman Schmidt
    Cc: Hansjoerg Lipp
    Cc: Greg KH
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tilman Schmidt
     
  • Convert atomic_t variables that don't actually use atomic_t functionality
    to int.

    Signed-off-by: Tilman Schmidt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tilman Schmidt
     
  • Add basic suspend/resume support to the usb_gigaset driver for the Siemens
    Gigaset M105 USB DECT adapter.

    Only the USB aspects are handled so far; the ISDN subsystem is not notified in
    any way, for lack of information about how to do that. The driver does not
    check for active connections before suspending. They will be dropped when the
    device loses USB power.

    Signed-off-by: Tilman Schmidt
    Cc: Greg KH
    Cc: Hansjoerg Lipp
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tilman Schmidt
     
  • Add basic suspend/resume support to the bas_gigaset ISDN driver for the
    Siemens Gigaset SX255 series of ISDN DECT bases.

    Only the USB aspects are handled so far; the ISDN subsystem is not notified in
    any way, for lack of information about how to do that. The driver will refuse
    to suspend if a connection is active.

    Signed-off-by: Tilman Schmidt
    Cc: Greg KH
    Cc: Hansjoerg Lipp
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tilman Schmidt
     
  • Some cleanups to the bas-gigaset and usb-gigaset USB ISDN drivers:
    - simplified error handling
    - improved debug messages
    - readability improvements
    - removal of obsolete defines and comments

    Signed-off-by: Tilman Schmidt
    Cc: Greg KH
    Cc: Hansjoerg Lipp
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tilman Schmidt
     
  • Make there only be one reference to urb->status per URB callback, and none
    outside, in preparation for removal of that field.

    Signed-off-by: Tilman Schmidt
    Cc: Greg KH
    Cc: Hansjoerg Lipp
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tilman Schmidt