13 Jun, 2009

1 commit


27 May, 2009

1 commit


27 Feb, 2009

1 commit


22 Jan, 2009

1 commit


11 Jan, 2009

1 commit

  • Since dev->power.should_wakeup bit is used by the PCI core to
    decide whether the device should wake up the system from sleep
    states, set this bit by calling device_set_wakeup_enable().

    This restores proper WOL for the 3c59x driver.

    Reported-and-tested-by: Graeme Wilford
    Reported-by: Gunnar Degnbol
    Signed-off-by: Steffen Klassert
    Signed-off-by: David S. Miller

    Steffen Klassert
     

13 Nov, 2008

1 commit

  • We have some reasons to kill netdev->priv:
    1. netdev->priv is equal to netdev_priv().
    2. netdev_priv() wraps the calculation of netdev->priv's offset, obviously
    netdev_priv() is more flexible than netdev->priv.
    But we cann't kill netdev->priv, because so many drivers reference to it
    directly.

    This patch is a safe convert for netdev->priv to netdev_priv(netdev).
    Since all of the netdev->priv is only for read.
    But it is too big to be sent in one mail.
    I split it to 4 parts and make every part smaller than 100,000 bytes,
    which is max size allowed by vger.

    Signed-off-by: Wang Chen
    Signed-off-by: David S. Miller

    Wang Chen
     

11 Nov, 2008

1 commit


04 Nov, 2008

1 commit


28 Oct, 2008

1 commit

  • This converts pretty much everything to print_mac. There were
    a few things that had conflicts which I have just dropped for
    now, no harm done.

    I've built an allyesconfig with this and looked at the files
    that weren't built very carefully, but it's a huge patch.

    Signed-off-by: Johannes Berg
    Signed-off-by: David S. Miller

    Johannes Berg
     

16 Oct, 2008

1 commit


07 Aug, 2008

1 commit

  • Fix possible bug where end of receive buffer could be overwritten.
    The allocation needs to allow for the reserved space. This would only happen
    if device received packet greater than Ethernet standard MTU.

    Change this driver to use netdev_alloc_skb rather than setting skb->dev
    directly. For the initial allocation it doesn't need to be GFP_ATOMIC.

    Signed-off-by: Stephen Hemminger
    Signed-off-by: Jeff Garzik

    Stephen Hemminger
     

22 Jul, 2008

1 commit


27 Jun, 2008

1 commit

  • Original Author: Michael Buesch

    net, vortex: fix lockup

    Ingo Molnar reported:

    -tip testing found that Johannes Berg's "softirq: remove irqs_disabled
    warning from local_bh_enable" enhancement to lockdep triggers a new
    warning on an old testbox that uses 3c59x vortex and netlogging:

    ----->
    calling vortex_init+0x0/0xb0
    PCI: Found IRQ 10 for device 0000:00:0b.0
    PCI: Sharing IRQ 10 with 0000:00:0a.0
    PCI: Sharing IRQ 10 with 0000:00:0b.1
    3c59x: Donald Becker and others.
    0000:00:0b.0: 3Com PCI 3c556 Laptop Tornado at e0800400.
    PCI: Enabling bus mastering for device 0000:00:0b.0
    initcall vortex_init+0x0/0xb0 returned 0 after 47 msecs
    ...
    calling init_netconsole+0x0/0x1b0
    netconsole: local port 4444
    netconsole: local IP 10.0.1.9
    netconsole: interface eth0
    netconsole: remote port 4444
    netconsole: remote IP 10.0.1.16
    netconsole: remote ethernet address 00:19:xx:xx:xx:xx
    netconsole: device eth0 not up yet, forcing it
    eth0: setting half-duplex.
    eth0: setting full-duplex.
    ------------[ cut here ]------------
    WARNING: at kernel/softirq.c:137 local_bh_enable_ip+0xd1/0xe0()
    Pid: 1, comm: swapper Not tainted 2.6.26-rc6-tip #2091
    [] warn_on_slowpath+0x4f/0x70
    [] ? release_console_sem+0x1b4/0x1d0
    [] ? vprintk+0x2a0/0x450
    [] ? __mod_timer+0xa5/0xc0
    [] ? mdio_sync+0x3d/0x50
    [] ? marker_probe_cb+0x46/0xa0
    [] ? printk+0x27/0x50
    [] ? vortex_set_duplex+0x43/0xc0
    [] ? vortex_set_duplex+0xa1/0xc0
    [] ? vortex_timer+0xe2/0x3e0
    [] local_bh_enable_ip+0xd1/0xe0
    [] _spin_unlock_bh+0x2f/0x40
    [] vortex_timer+0xe2/0x3e0
    [] ? trace_hardirqs_on+0xb/0x10
    [] ? trace_hardirqs_on_caller+0x88/0x160
    [] run_timer_softirq+0x162/0x1c0
    [] ? vortex_timer+0x0/0x3e0
    [] local_bh_enable_ip+0xd1/0xe0
    [] _spin_unlock_bh+0x2f/0x40
    [] vortex_timer+0xe2/0x3e0
    [] ? trace_hardirqs_on+0xb/0x10
    [] ? trace_hardirqs_on_caller+0x88/0x160
    [] run_timer_softirq+0x162/0x1c0
    [] ? vortex_timer+0x0/0x3e0
    [] ? vortex_timer+0x0/0x3e0
    [] __do_softirq+0x9a/0x160
    [] ? __do_softirq+0x0/0x160
    [] call_on_stack+0x15/0x30
    [] ? irq_exit+0x55/0x60
    [] ? do_IRQ+0x85/0xd0
    [] ? trace_hardirqs_on_caller+0xc1/0x160
    [] ? common_interrupt+0x28/0x30
    [] ? mutex_unlock+0x8/0x10
    [] ? _cond_resched+0x10/0x30
    [] ? netpoll_setup+0x117/0x390
    [] ? init_netconsole+0x14e/0x1b0
    [] ? ktime_get+0x19/0x40
    [] ? kernel_init+0x1b2/0x2c0
    [] ? init_netconsole+0x0/0x1b0
    [] ? trace_hardirqs_on_thunk+0xc/0x10
    [] ? restore_nocheck_notrace+0x0/0xe
    [] ? kernel_init+0x0/0x2c0
    [] ? kernel_init+0x0/0x2c0
    [] ? kernel_thread_helper+0x7/0x10
    =======================
    ---[ end trace 37f9c502aff112e0 ]---
    console [netcon0] enabled
    netconsole: network logging started
    initcall init_netconsole+0x0/0x1b0 returned 0 after 2914 msecs

    looking at the driver I think the bug is real and the fix actually
    is trivial.

    vp->lock is also taken in hardware IRQ context, so we _have_ to always
    use irqsafe locking. As we run in a timer with IRQs disabled,
    we can simply use spin_lock.

    Cc:
    Signed-off-by: Ingo Molnar
    Signed-off-by: Jeff Garzik

    Ingo Molnar
     

07 May, 2008

2 commits


18 Oct, 2007

1 commit

  • Simple compile warning fix. (against 2.6.23-git12)

    Thanks,
    Badari

    vortex_up() should initialize 'err' for a successful return.

    drivers/net/3c59x.c: In function `vortex_up':
    drivers/net/3c59x.c:1494: warning: `err' might be used uninitialized in this function

    Signed-off-by: Badari Pulavarty
    Signed-off-by: Jeff Garzik

    Badari Pulavarty
     

17 Oct, 2007

1 commit

  • Some NICs (3c905B) can not generate PME in power state PCI_D0, while others
    like 3c905C can. Call pci_enable_wake() with PCI_D3hot should give proper
    WOL for 3c905B.

    Signed-off-by: Steffen Klassert
    Tested-by: Harry Coin
    Signed-off-by: Andrew Morton
    Signed-off-by: Jeff Garzik

    Steffen Klassert
     

11 Oct, 2007

5 commits


14 Aug, 2007

1 commit

  • A special sequence of ifconfig up/down and plug/unplug the cable can break
    the duplex configuration of the driver.

    Setting
    vp->mii.full_duplex = vp->full_duplex
    in vortex_up should fix this.

    Addresses Bug 8575 3c59x duplex configuration broken
    http://bugzilla.kernel.org/show_bug.cgi?id=8575

    Cc: Martin Buck
    Signed-off-by: Steffen Klassert
    Cc: Natalie Protasevich
    Signed-off-by: Andrew Morton
    Signed-off-by: Jeff Garzik

    Steffen Klassert
     

01 Aug, 2007

1 commit


11 Jul, 2007

1 commit

  • The 3cSOHO100-TX needs a mdio_sync() before mdio_read() to read the MII
    transceiver registers properly. Adding EXTRA_PREAMBLE to drv_flags of the
    3cSOHO100-TX will force this.

    This problem exists already for years (I checked back to 2.6.8).
    Setting duplex for the 3cSOHO100-TX was more or less a random process.
    Till 2.6.15 it was more likely that the diver ends up in half
    duplex mode, after the code change in 2.6.16 it was more likely
    to end up in full duplex mode. I wonder why nobody noticed this earier.

    Hopefully addresses

    Bug 7454 3c59x (3cSOHO100-TX Hurricane) slow network bug
    http://bugzilla.kernel.org/show_bug.cgi?id=7454

    and

    Bug 3654 3cSOHO100-TX: No MII transceiver present
    http://bugzilla.kernel.org/show_bug.cgi?id=3654

    Cc: Jonas Sandberg
    Cc: Jon Sanchez
    Signed-off-by: Steffen Klassert
    Signed-off-by: Andrew Morton
    Signed-off-by: Jeff Garzik

    Steffen Klassert
     

09 May, 2007

1 commit


26 Apr, 2007

1 commit


10 Mar, 2007

1 commit

  • WARNING: drivers/net/3c59x.o - Section mismatch: reference to .init.text: from .text between 'vortex_eisa_probe' (at offset 0x4580) and 'vortex_eisa_remove'
    WARNING: drivers/net/3c59x.o - Section mismatch: reference to .init.text: from .text between 'vortex_eisa_probe' (at offset 0x4584) and 'vortex_eisa_remove'
    WARNING: drivers/net/3c59x.o - Section mismatch: reference to .init.text: from .text between 'vortex_eisa_probe' (at offset 0x4588) and 'vortex_eisa_remove'
    WARNING: drivers/net/3c59x.o - Section mismatch: reference to .init.text: from .text between 'vortex_eisa_probe' (at offset 0x458c) and 'vortex_eisa_remove'

    Fixed by:

    o move definition of vortex_eisa_driver below the functions it references.
    o remove now unnecessary prototypes for vortex_eisa_probe and
    vortex_eisa_remove.
    o Make vortex_eisa_probe an __init function.
    o Make vortex_eisa_remove a __devexit function.
    o Wrap vortex_eisa_driver reference to vortex_eisa_remove with
    __devexit_p().

    Signed-off-by: Ralf Baechle

    drivers/net/3c59x.c | 28 +++++++++++++---------------
    1 file changed, 13 insertions(+), 15 deletions(-)
    Signed-off-by: Jeff Garzik

    Ralf Baechle
     

06 Mar, 2007

1 commit


07 Feb, 2007

1 commit


05 Oct, 2006

1 commit

  • Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

27 Sep, 2006

1 commit

  • Add modalias attribute support for the almost forgotten now EISA bus and
    (at least some) EISA-aware modules.

    The modalias entry looks like (for an 3c509 NIC):

    eisa:sTCM5093

    and the in-module alias like:

    eisa:sTCM5093*

    The patch moves struct eisa_device_id declaration from include/linux/eisa.h
    to include/linux/mod_devicetable.h (so that the former now #includes the
    latter), adds proper MODULE_DEVICE_TABLE(eisa, ...) statements for all
    drivers with EISA IDs I found (some drivers already have that DEVICE_TABLE
    declared), and adds recognision of __mod_eisa_device_table to
    scripts/mod/file2alias.c so that proper modules.alias will be generated.

    There's no support for /lib/modules/$kver/modules.eisamap, as it's not used
    by any existing tools, and because with in-kernel modalias mechanism those
    maps are obsolete anyway.

    The rationale for this patch is:

    a) to make EISA bus to act as other busses with modalias
    support, to unify driver loading

    b) to foget about EISA finally - with this patch, kernel
    (who still supports EISA) will be the only one who knows
    how to choose the necessary drivers for this bus ;)

    [akpm@osdl.org: fix the kbuild bit]
    Signed-off-by: Michael Tokarev
    Cc: Rusty Russell
    Cc: Randy Dunlap
    Acked-the-net-bits-by: Jeff Garzik
    Acked-the-tulip-bit-by: Valerie Henson
    Cc: James Bottomley
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Michael Tokarev
     

25 Sep, 2006

1 commit

  • * 'upstream-linus' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6: (217 commits)
    net/ieee80211: fix more crypto-related build breakage
    [PATCH] Spidernet: add ethtool -S (show statistics)
    [NET] GT96100: Delete bitrotting ethernet driver
    [PATCH] mv643xx_eth: restrict to 32-bit PPC_MULTIPLATFORM
    [PATCH] Cirrus Logic ep93xx ethernet driver
    r8169: the MMIO region of the 8167 stands behin BAR#1
    e1000, ixgb: Remove pointless wrappers
    [PATCH] Remove powerpc specific parts of 3c509 driver
    [PATCH] s2io: Switch to pci_get_device
    [PATCH] gt96100: move to pci_get_device API
    [PATCH] ehea: bugfix for register access functions
    [PATCH] e1000 disable device on PCI error
    drivers/net/phy/fixed: #if 0 some incomplete code
    drivers/net: const-ify ethtool_ops declarations
    [PATCH] ethtool: allow const ethtool_ops
    [PATCH] sky2: big endian
    [PATCH] sky2: fiber support
    [PATCH] sky2: tx pause bug fix
    drivers/net: Trim trailing whitespace
    [PATCH] ehea: IBM eHEA Ethernet Device Driver
    ...

    Manually resolved conflicts in drivers/net/ixgb/ixgb_main.c and
    drivers/net/sky2.c related to CHECKSUM_HW/CHECKSUM_PARTIAL changes by
    commit 84fa7933a33f806bbbaae6775e87459b1ec584c0 that just happened to be
    next to unrelated changes in this update.

    Linus Torvalds
     

23 Sep, 2006

1 commit


14 Sep, 2006

2 commits


12 Sep, 2006

2 commits


20 Aug, 2006

1 commit


06 Jul, 2006

1 commit