13 Aug, 2011
2 commits
-
sound/soc/codecs/wm8750.c:784:2: warning: missing braces around initializer
sound/soc/codecs/wm8750.c:784:2: warning: (near initialization for ‘wm8750_spi_ids[2].name’)It's because struct spi_device_id.name is a char array, not a pointer,
while the driver initializes explicitly with 0.Signed-off-by: Takashi Iwai
12 Aug, 2011
2 commits
-
My gmail account got disabled and I'm not going to reopen it.
Signed-off-by: Jarkko Nikula
Acked-by: Liam Girdwood
Signed-off-by: Mark Brown -
I2S in Exynos4 and S5PC110(S5PV210) has a internal dma.
It can be used low power audio mode and 2nd channel transfer.
This patch can support idma.[Reapplied after dependencies propagated through in 3.1-rc1. --broonie]
Signed-off-by: Sangbeom Kim
Acked-by: Jassi Brar
Acked-by: Liam Girdwood
Acked-by: Jassi Brar
Signed-off-by: Mark Brown
11 Aug, 2011
3 commits
-
Signed-off-by: Mark Brown
Reported-by: Stephen Rothwell -
This error would have no effect on current silicon revisions, the fall
through case has the same behaviour.Signed-off-by: Mark Brown
Acked-by: Liam Girdwood -
This fixes faulty outbount packets in case the inbound packets
received from the hardware are fragmented and contain bogus input
iso frames. The bug has been there for ages, but for some strange
reasons, it was only triggered by newer machines in 64bit mode.Signed-off-by: Daniel Mack
Reported-and-tested-by: William Light
Reported-by: Pedro Ribeiro
Cc: stable@kernel.org
Signed-off-by: Takashi Iwai
10 Aug, 2011
4 commits
-
snd_azf3328_dbgcallenter is called at the very beginning of the function,
so it could be useful to call snd_azf3328_dbgcallleave at all exit points.Signed-off-by: Julia Lawall
Signed-off-by: Takashi Iwai -
In commit 45eebda7, it add new function stac_vrefout_set, but it
is only used in code between CONFIG_SND_HDA_POWER_SAVE macro, so
add the macro to avoid such warning:sound/pci/hda/patch_sigmatel.c:676:12: warning: 'stac_vrefout_set' defined but not used
Signed-off-by: Wang Shaoyan
Signed-off-by: Takashi Iwai -
Signed-off-by: Kazutomo Yoshii
Signed-off-by: Takashi Iwai -
Signed-off-by: Mark Brown
Reported-by: Stephen Rothwell
09 Aug, 2011
6 commits
-
Signed-off-by: Mark Brown
Acked-by: Liam Girdwood -
As we had no id_table only the driver name would be matched against
meaning that WM8987 devices wouldn't be bound.Signed-off-by: Mark Brown
Acked-by: Liam Girdwood -
The I2C address is misformatted and would never match.
Signed-off-by: Mark Brown
Acked-by: Liam Girdwood
Cc: stable@kernel.org -
Without this, request_irq on subsequent device initialization fails, and
the codec cannot be used.Signed-off-by: Stephen Warren
Acked-by: Liam Girdwood
Signed-off-by: Mark Brown -
Two issues were preventing module snd-soc-tegra-wm8903.ko from being
removed and re-inserted:a) The speaker-enable GPIO is hosted by the WM8903 chip. This GPIO must
be freed before snd_soc_unregister_card() is called, because that
triggers wm8903.c:wm8903_remove(), which calls gpiochip_remove(), which
then fails if any of the GPIOs are in use. To solve this, free all GPIOs
first, so the code doesn't care where they come from.b) We need to call snd_soc_jack_free_gpios() to match the call to
snd_soc_jack_add_gpios() during initialization. Without this, the
call to snd_soc_jack_add_gpios() fails during any subsequent modprobe
and initialization, since the GPIO and IRQ are already registered. In
turn, this causes the headphone state not to be monitored, so the
headphone is assumed not to be plugged in, and the audio path to it is
never enabled.Signed-off-by: Stephen Warren
Cc: stable@kernel.org
Signed-off-by: Mark Brown -
Not all PCM devices have all sub-streams. Specifically, the SPDIF driver
only supports playback and hence has no capture substream. Check whether
a substream exists before dereferencing it, when de-allocating DMA
buffers in tegra_pcm_deallocate_dma_buffer.Signed-off-by: Stephen Warren
Acked-by: Liam Girdwood
Signed-off-by: Mark Brown
Cc: stable@kernel.org
08 Aug, 2011
8 commits
-
sound/oss/pss.c: In function 'configure_nonsound_components':
sound/oss/pss.c:676: warning: 'check_region' is deprecated (declared at include/linux/ioport.h:201)Signed-off-by: Wang Shaoyan
Signed-off-by: Takashi Iwai -
Just to be sure.
Signed-off-by: Takashi Iwai
-
A slave-timer instance has no timer reference, and this results in
NULL-dereference at stopping the timer, typically called at closing
the device.Reference: https://bugzilla.kernel.org/show_bug.cgi?id=40682
Cc:
Signed-off-by: Takashi Iwai -
…oonie/sound-2.6 into fix/asoc
-
This closes the small race between a status being read in response to an
interrupt and clearing the interrupt, meaning that if the status changes
between those periods we might not get a reassertion of the interrupt.Signed-off-by: Mark Brown
-
For marketing reasons the part will be called WM8996. In order to avoid
user confusion rename the driver to reflect this.Signed-off-by: Mark Brown
Acked-by: Kukjin Kim
Acked-by: Liam Girdwood
07 Aug, 2011
2 commits
-
CONFIG_SND_TEA575X is enabled by RADIO_SF16FMR2, but the latter one is
no PCI device. Since tea575x-tuner itself is independent from the board
bus type, the config should be moved out of SND_PCI dependency.Reported-by: Randy Dunlap
Acked-by: Randy Dunlap
Signed-off-by: Takashi Iwai -
Use kzalloc rather than kmalloc followed by memset with 0
This considers some simple cases that are common and easy to validate
Note in particular that there are no ...s in the rule, so all of the
matched code has to be contiguousThe semantic patch that makes this output is available
in scripts/coccinelle/api/alloc/kzalloc-simple.cocci.More information about semantic patching is available at
http://coccinelle.lip6.fr/Signed-off-by: Thomas Meyer
Signed-off-by: Takashi Iwai
06 Aug, 2011
2 commits
-
Signed-off-by: Daniel Mack
Reported-by: Renato
Cc: stable@kernel.org
Signed-off-by: Takashi Iwai -
Purely cosmetic, but fixes the following build warning.
CC [M] sound/usb/quirks.o
sound/usb/quirks.c: In function ‘snd_usb_apply_boot_quirk’:
sound/usb/quirks.c:429:6: warning: ‘err’ may be used uninitialized in this function [-Wuninitialized]Signed-off-by: Daniel Mack
Signed-off-by: Takashi Iwai
05 Aug, 2011
3 commits
-
sound/pci/hda/patch_via.c:2087: warning: 'dac' may be used uninitialized in this function
Signed-off-by: Wang Shaoyan
Signed-off-by: Takashi Iwai -
Put the exception checks for io_type switch() for possible mistakes in
future. Also this shuts up annoying compile warnings.Signed-off-by: Takashi Iwai
-
Signed-off-by: Miller Puckette
Signed-off-by: Takashi Iwai
04 Aug, 2011
6 commits
-
When creating the mixers for an USB audio device, the current code looks
at the host interface stored in mixer->chip->ctrl_if. Change this and
rather keep a local pointer to the interface that was given when
snd_usb_create_mixer() was called.Signed-off-by: Daniel Mack
Reported-by: Nicolai Krakowiak
Reported-by: Lean-Yves LENHOF
Acked-by: Clemens Ladisch
Cc: stable@kernel.org
Signed-off-by: Takashi Iwai -
Signed-off-by: Nicolai Krakowiak
Acked-by: Daniel Mack
Acked-by: Clemens Ladisch
Cc: stable@kernel.org
Signed-off-by: Takashi Iwai -
The Focusrite Scarlett 18i6 USB has them that way, which is probably a
bug. Anyway, the driver should simply ignore this fact.Signed-off-by: Daniel Mack
Reported-by: Nicolai Krakowiak
Cc: stable@kernel.org
Signed-off-by: Clemens Ladisch
Signed-off-by: Takashi Iwai -
Update the PAS16 driver to use PIT_TICK_RATE instead
of the more generic CLOCK_TICK_RATE as the two are
equivalent on X86 and we want to depecrate the later.Signed-off-by: Deepak Saxena
Signed-off-by: Takashi Iwai -
It works fine with auto-parser and now the digital mic workaround was
implemented in auto-parser fixup, let's drop the static model quirks for
these models.Signed-off-by: Takashi Iwai
-
The digital-mic unit on ASUS Eee PC gives PDM signals instead of the
normal stereo PCM, thus you can't record a mono stream from the stereo
stream as is; the summed stereo signal results in almost zero level, and
you'll hear only soft noise.As a workaround, use ALC269-specific COEF to manipulate the dmic route
for mono, like used for ALC271x. This is implemented as a fix-up, thus
it works only with model=auto or without REALTEK_QUIRKS Kconfig.Reported-and-tested-by: Pavel Roskin
Signed-off-by: Takashi Iwai
03 Aug, 2011
2 commits
-
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6:
ALSA: asihpi - Clarify adapter index validity check
ALSA: asihpi - Don't leak firmware if mem alloc fails
ALSA: rtctimer.c needs module.h
ASoC: Fix txx9aclc.c build
ALSA: hdspm - Add firmware revision 0xcc for RME MADI
ALSA: hdspm - Fix reported external sample rate on RME MADI and MADIface
ALSA: hdspm - Provide MADI speed mode selector on RME MADI and MADIface
ALSA: sound/core/pcm_compat.c: adjust array index -
Cache handling in this driver is broken. The chip has 16-bit registers, yet the
register numbers also increase by 2 per register, i.e. there are only
even-numbered registers. The cache in this driver, though, simply increments
register numbers, so it does need some mapping as seen in
sgtl5000_restore_regs(), note the '>> 1':snd_soc_write(codec, SGTL5000_CHIP_LINREG_CTRL,
cache[SGTL5000_CHIP_LINREG_CTRL >> 1]);That, of course, won't work with snd_soc_update_bits(). (Thus, we won't even
notice the missing register 0x1c in the default regs which shifted all follwing
registers to wrong values.) Noticed on the MX28EVK where enabling the regulators
simply locked up the chip.Refactor the routines and use a properly sized default_regs array which matches
the register layout of the underlying chip, i.e. create a truly flat cache.
This also saves some code which should make up for the bigger array a little.
When soc-core will somewhen have another cache type which handles a step size,
this conversion will also ease the transition.Signed-off-by: Wolfram Sang
Tested-by: Dong Aisheng
Tested-by: Shawn Guo
Acked-by: Liam Girdwood
Signed-off-by: Mark Brown
Cc: stable@kernel.org
