26 Oct, 2010
13 commits
-
Add __rcu annotations to :
(struct netdev_rx_queue)->rps_map
(struct netdev_rx_queue)->rps_flow_table
struct rps_sock_flow_table *rps_sock_flow_table;And use appropriate rcu primitives.
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller -
One of the previous tproxy related patches split IPv6 defragmentation and
connection tracking, but did not correctly add Kconfig stanzas to handle the
new dependencies correctly. This patch fixes that by making the config options
mirror the setup we have for IPv4: a distinct config option for defragmentation
that is automatically selected by both connection tracking and
xt_TPROXY/xt_socket.The patch also changes the #ifdefs enclosing IPv6 specific code in xt_socket
and xt_TPROXY: we only compile these in case we have ip6tables support enabled.Signed-off-by: KOVACS Krisztian
Signed-off-by: David S. Miller -
(struct ip6_tnl)->next is rcu protected :
(struct ip_tunnel)->next is rcu protected :
(struct xfrm6_tunnel)->next is rcu protected :add __rcu annotation and proper rcu primitives.
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller -
(struct net_device)->garp_port is rcu protected :
(struct garp_port)->applicants is rcu protected :add __rcu annotation and proper rcu primitives.
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller -
(struct net_device)->ip6_ptr is rcu protected :
add __rcu annotation and proper rcu primitives.
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller -
(struct net_device)->vlgrp is rcu protected :
add __rcu annotation and proper rcu primitives.
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller -
This driver tries to do up to half-second udelay()
calls, which overflows on x86-64.Reported-by: Andi Kleen
Signed-off-by: David S. Miller -
Three is definitely too low, and we know from reports that GRE tunnels
stacked as deeply as 37 levels cause stack overflows, so pick some
reasonable value between those two.Signed-off-by: David S. Miller
-
When searching for a free entry in either mlx4_register_vlan() or
mlx4_register_mac(), and there is no free entry, the loop terminates without
updating the local variable free thus causing out of array bounds access. Fix
this by adding a proper check outside the loop.Signed-off-by: Eli Cohen
Signed-off-by: David S. Miller -
On a busy network, the macb driver could get stuck in the interrupt
handler, quickly triggering the watchdog, due to a confluence of
factors:1. macb_poll re-enables interrupts unconditionally, even when it will
be called again because it exhausted its rx budget2. macb_interrupt only disables interrupts after scheduling
macb_poll, but scheduling fails when macb_poll is already scheduled
because it didn't call napi_complete3. macb_interrupt loops until the interrupt status register is clear,
which will never happen in this case if the driver doesn't disable
the RX interruptSince macb_interrupt runs in interrupt context, this effectively locks
up the machine, triggering the hardware watchdog.This issue was readily reproducible on a flooded network with a
modified 2.6.27.48 kernel. The same problem appears to still be in the
2.6.36-rc8 driver code, so I am submitting this patch against that
version. I have not tested this version of the patch except to make
sure the kernel compiles.Signed-off-by: Joshua Hoke
Signed-off-by: David S. Miller -
We're setting skb->ip_summed to CHECKSUM_NONE for all non-TCP pkts, making the stack
recompute checksum.This is a bug for UDP pkts for which cso must be used.Signed-off-by: Somnath Kotur
Signed-off-by: David S. Miller -
Calling netif_carrier_off before register_netdev was causing the network interface
to miss a linkwatch pending event leading to an inconsistent state if the link
is not up when interface is initialized.This is now invoked after register_netdev.Signed-off-by: Somnath Kotur
Signed-off-by: David S. Miller -
Only negative return from bind_qsets() should be considered an error and
propagated.
It fixes an issue reported by IBM on P Series platform.Signed-off-by: Divy Le Ray
Tested-by: Nishanth Aravamudan
Signed-off-by: David S. Miller
25 Oct, 2010
27 commits
-
Causes these build failures on PowerPC:
net/l2tp/l2tp_core.c:1228: error: __ksymtab_l2tp_tunnel_closeall causes a section type conflict
net/l2tp/l2tp_core.c:1228: error: __ksymtab_l2tp_tunnel_closeall causes a section type conflict
net/l2tp/l2tp_core.c:1006: error: __ksymtab_l2tp_xmit_core causes a section type conflict
net/l2tp/l2tp_core.c:1006: error: __ksymtab_l2tp_xmit_core causes a section type conflict
net/l2tp/l2tp_core.c:847: error: __ksymtab_l2tp_udp_recv_core causes a section type conflict
net/l2tp/l2tp_core.c:847: error: __ksymtab_l2tp_udp_recv_core causes a section type conflictSigned-off-by: Stephen Rothwell
Signed-off-by: David S. Miller -
Also correct the byteswapping as we keep the TCI in host order.
Signed-off-by: David Dillow
Signed-off-by: David S. Miller -
When adding VLAN devices, we can get several calls to
typhoon_set_rx_mode() in quick succession. Because we didn't wait for
the commands to complete, we could run out of command descriptors and
fail to set the RX mode.Signed-off-by: David Dillow
Signed-off-by: David S. Miller -
commit 6c04bb18ddd633 (netlink: use call_rcu for netlink_change_ngroups)
used a somewhat convoluted and racy way to perform call_rcu().The old block of memory is freed after a grace period, but the rcu_head
used to track it is located in new block.This can clash if we call two times or more netlink_change_ngroups(),
and a block is freed before another. call_rcu() called on different cpus
makes no guarantee in order of callbacks.Fix this using a more standard way of handling this : Each block of
memory contains its own rcu_head, so that no 'use after free' can
happens.Signed-off-by: Eric Dumazet
CC: Johannes Berg
CC: Paul E. McKenney
Signed-off-by: David S. Miller -
Don't export symbols twice.
Signed-off-by: Denis Kirjanov
Signed-off-by: David S. Miller -
Adding shutdown function that setup wake if wol is enabled.
Add jme_phy_on in jme_set_100m_half in case it is shutting down
or suspending when interface is down(phy_off by default).v2 updates:
Removed CONFIG_PM ifdef for jme_set_100m_half and jme_wait_link.
It would be nice if it can be applied to net-2.6 along with other patches
sent few days ago. If it is not appropriate, please ignore the net-2.6
request, and apply it to net-next-2.6 as previous patch. :)Reported-and-helped-by: Сtac
Signed-off-by: Guo-Fu Tseng
Signed-off-by: David S. Miller -
IP_TRANSPARENT requires root (more precisely CAP_NET_ADMIN privielges)
for IPV6.However as I see right now this check was missed from the IPv6
implementation.Acked-by: YOSHIFUJI Hideaki
Signed-off-by: David S. Miller
-
It's a le64, not a le32, typo in one place only.
Noticed by sparse:
drivers/net/vmxnet3/vmxnet3_drv.c:2668:52: warning: incorrect type in assignment (different base types)
drivers/net/vmxnet3/vmxnet3_drv.c:2668:52: expected restricted __le64 [usertype] confPA
drivers/net/vmxnet3/vmxnet3_drv.c:2668:52: got restricted __le32 [usertype]Signed-off-by: Harvey Harrison
Signed-off-by: Shreyas Bhatewara
Signed-off-by: David S. Miller -
Signed-off-by: Harvey Harrison
Signed-off-by: Shreyas Bhatewara
Signed-off-by: David S. Miller -
It's easier to just annotate the constants as little endian types and set/clear
the flags directly.Signed-off-by: Harvey Harrison
Signed-off-by: Shreyas Bhatewara
Signed-off-by: David S. Miller -
Signed-off-by: Dimitris Michailidis
Signed-off-by: David S. Miller -
Before commit "net: allocate tx queues in register_netdevice"
netif_tx_stop_all_queues and related functions could be used between
device allocation and registration but now only after registration.
cxgb4 has such a call before registration and crashes now. Move it
after register_netdev.Signed-off-by: Dimitris Michailidis
Signed-off-by: David S. Miller -
Add driver for Technologic Systems TS-CAN1 PC104 peripheral boards.
Signed-off-by: Andre B. Oliveira
Acked-by: Wolfgang Grandegger
Reviewed-by: Wolfram Sang
Signed-off-by: David S. Miller -
The ip6_tunnel device did not unset the flag,
IFF_XMIT_DST_RELEASE. This will make the dev layer
to release the dst before calling the tunnel.
The tunnel will not update any mtu/pmtu info, since
it does not have a dst on the skb.
Acked-by: Eric DumazetSigned-off-by: David S. Miller
-
The temporary variable "i" is needlessly initialized to zero
in two distinct cases in this file:1) where it is set to zero and then used as an argument in an addition
before being assigned a non-zero value.2) where it is only used in a standard/typical loop counter
For (1), simply delete assignment to zero and usages while still
zero; for (2) simply make the loop start at zero as per standard
practice as seen everywhere else in the same file.Signed-off-by: Paul Gortmaker
Signed-off-by: David S. Miller -
Signed-off-by: Stephen Hemminger
Acked-by: Jesse Brandeburg
Signed-off-by: David S. Miller -
Make many functions that are only used in one file static.
Remove dead code for override_led_value.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
The driver has lots of unused code to dump data structures to
console. Use existing simple way to remove the code with ifdef.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Use results of make namespacecheck to make functions local and
remove code that is not used.Also rename initialize_ethtool_ops to vxge_initialize_ethtool_ops.
Compile tested only.
Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
The following functions are not used directly by any drivers:
phy_attach_direct
phy_device_create
phy_prepare_link
genphy_config_advert
genphy_setup_forced
phy_config_interrupt
phy_clear_interrypt
phy_sanitize_settings
phy_enable_interrupts
phy_disable_interruptsSigned-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
The up/down are only used in this file.
Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Only used in one file.
Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
The following code and data are defined but never used in current
driver.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
Also moved the refcound inlines from l2tp_core.h to l2tp_core.c
since only used in that one file.Signed-off-by: Stephen Hemminger
Acked-by: James Chapman
Signed-off-by: David S. Miller -
Make the following function static: mlx4_UNMAP_ICM
Remove the following unused function: mlx4_MAP_ICM_pageSigned-off-by: Stephen Hemminger
Signed-off-by: David S. Miller
