Eric Lee / smarc-fsl-linux-kernel

04 Sep, 2019

1 commit

06 Jul, 2019

1 commit

  • 82b7d8566   Bluetooth: Cleanup formatting and coding style ... Browse Code »

    Fix some warnings and one error reported by checkpatch.pl:
    - lines longer than 80 characters are wrapped
    - empty lines inserted to separate variable declarations from the actual
    code
    - line break inserted after if (...)

    Co-developed-by: Thomas Röthenbacher
    Signed-off-by: Thomas Röthenbacher
    Signed-off-by: Fabian Schindlatz
    Cc: linux-kernel@i4.cs.fau.de
    Signed-off-by: Marcel Holtmann

    Fabian Schindlatz
     

31 May, 2019

1 commit

  • 1a59d1b8e   treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 ... Browse Code »

    Based on 1 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license as published by
    the free software foundation either version 2 of the license or at
    your option any later version this program is distributed in the
    hope that it will be useful but without any warranty without even
    the implied warranty of merchantability or fitness for a particular
    purpose see the gnu general public license for more details you
    should have received a copy of the gnu general public license along
    with this program if not write to the free software foundation inc
    59 temple place suite 330 boston ma 02111 1307 usa

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-or-later

    has been chosen to replace the boilerplate/reference in 1334 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Allison Randal
    Reviewed-by: Richard Fontana
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190527070033.113240726@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

24 Jul, 2018

1 commit

  • 478113e43   bluetooth: bpa10x: Replace GFP_ATOMIC with GFP_KERNEL in bpa10x_send_frame() ... Browse Code »

    bpa10x_send_frame() is only set to hdev->send, and hdev->send() is never
    called in atomic context.

    bpa10x_send_frame() calls usb_alloc_urb(), kmalloc() and usb_submit_urb()
    with GFP_ATOMIC, which is not necessary.
    GFP_ATOMIC can be replaced with GFP_KERNEL.

    This is found by a static analysis tool named DCNS written by myself.
    I also manually check the kernel code before reporting it.

    Signed-off-by: Jia-Ju Bai
    Signed-off-by: Marcel Holtmann

    Jia-Ju Bai
     

01 Apr, 2018

1 commit

  • 07eb96a5a   Bluetooth: bpa10x: Use separate h4_recv_buf helper ... Browse Code »

    When adding the alignment and padding support for H:4 packet processing
    for the Nokia driver, it broke the h4_recv_buf usage within bpa10x
    driver. To fix this use a separate helper function and placing it into a
    dedicated h4_recv.h header file.

    Signed-off-by: Marcel Holtmann
    Signed-off-by: Johan Hedberg

    Marcel Holtmann
     

09 Jan, 2018

1 commit

  • cca32837f   Bluetooth: bpa10x: make array 'req' static, shrinks object size ... Browse Code »

    Don't populate the const read-only array 'req' on the stack but instead
    make it static. Makes the object code smaller by over 40 bytes:

    Before:
    text data bss dec hex filename
    8497 3408 128 12033 2f01 linux/drivers/bluetooth/bpa10x.o

    After:
    text data bss dec hex filename
    8366 3496 128 11990 2ed6 linux/drivers/bluetooth/bpa10x.o

    (gcc version 7.2.0 x86_64)

    Signed-off-by: Colin Ian King
    Signed-off-by: Marcel Holtmann

    Colin Ian King
     

30 Oct, 2017

1 commit

16 Jun, 2017

1 commit

  • d58ff3512   networking: make skb_push & __skb_push return void pointers ... Browse Code »

    It seems like a historic accident that these return unsigned char *,
    and in many places that means casts are required, more often than not.

    Make these functions return void * and remove all the casts across
    the tree, adding a (u8 *) cast only where the unsigned char pointer
    was used directly, all done with the following spatch:

    @@
    expression SKB, LEN;
    typedef u8;
    identifier fn = { skb_push, __skb_push, skb_push_rcsum };
    @@
    - *(fn(SKB, LEN))
    + *(u8 *)fn(SKB, LEN)

    @@
    expression E, SKB, LEN;
    identifier fn = { skb_push, __skb_push, skb_push_rcsum };
    type T;
    @@
    - E = ((T *)(fn(SKB, LEN)))
    + E = fn(SKB, LEN)

    @@
    expression SKB, LEN;
    identifier fn = { skb_push, __skb_push, skb_push_rcsum };
    @@
    - fn(SKB, LEN)[0]
    + *(u8 *)fn(SKB, LEN)

    Note that the last part there converts from push(...)[0] to the
    more idiomatic *(u8 *)push(...).

    Signed-off-by: Johannes Berg
    Signed-off-by: David S. Miller

    Johannes Berg
     

18 Jul, 2016

1 commit

  • b2999c195   Bluetooth: bpa10x: Add support for hci_set_fw_info ... Browse Code »

    The Digianswer sniffer devices allow for reading a firmware specific
    information string. If it is available, then inform the Bluetooth core
    about it via hci_set_fw_info. That exposes it via debugfs like this:

    # cat /sys/kernel/debug/bluetooth/hci0/firmware_info
    SNIF_102,BB930,02/01/18,10:37:56

    Signed-off-by: Marcel Holtmann
    Signed-off-by: Johan Hedberg

    Marcel Holtmann
     

20 Nov, 2015

1 commit

08 Oct, 2015

3 commits

  • 943cc5921   Bluetooth: bpa10x: Use h4_recv_buf helper for frame reassembly ... Browse Code »

    The manually coded frame reassembly is actually broken. The h4_recv_buf
    helper from the UART driver is a perfect fit for frame reassembly for
    this driver. So just export that function and use it here as well.

    Signed-off-by: Marcel Holtmann
    Signed-off-by: Johan Hedberg

    Marcel Holtmann
     
  • 881f7e86a   Bluetooth: bpa10x: Add support for set_diag driver callback ... Browse Code »

    The BPA-10x devices support tracing operation. Use the set_diag driver
    callback to allow enabling and disabling that functionality.

    Signed-off-by: Marcel Holtmann
    Signed-off-by: Johan Hedberg

    Marcel Holtmann
     
  • ddd68ec8f   Bluetooth: bpa10x: Read revision information in setup stage ... Browse Code »

    For debugging pruposes, read the revision string of the BPA-10x devices
    and print it. For example one of the latest devices respond with the
    string SNIF_102,BB930,02/01/18,10:37:56.

    < HCI Command: Vendor (0x3f|0x000e) plen 1
    07 .
    > HCI Event: Command Complete (0x0e) plen 49
    Vendor (0x3f|0x000e) ncmd 1
    Status: Success (0x00)
    53 4e 49 46 5f 31 30 32 2c 42 42 39 33 30 2c 30 SNIF_102,BB930,0
    32 2f 30 31 2f 31 38 2c 31 30 3a 33 37 3a 35 36 2/01/18,10:37:56
    00 00 00 00 00 00 00 00 00 00 00 00 00 .............

    Signed-off-by: Marcel Holtmann
    Signed-off-by: Johan Hedberg

    Marcel Holtmann
     

05 Oct, 2015

2 commits

11 Oct, 2013

3 commits

07 Aug, 2012

1 commit

05 Jun, 2012

1 commit

19 May, 2012

1 commit

  • e1f12eb6b   USB: Disable hub-initiated LPM for comms devices. ... Browse Code »

    Hub-initiated LPM is not good for USB communications devices. Comms
    devices should be able to tell when their link can go into a lower power
    state, because they know when an incoming transmission is finished.
    Ideally, these devices would slam their links into a lower power state,
    using the device-initiated LPM, after finishing the last packet of their
    data transfer.

    If we enable the idle timeouts for the parent hubs to enable
    hub-initiated LPM, we will get a lot of useless LPM packets on the bus
    as the devices reject LPM transitions when they're in the middle of
    receiving data. Worse, some devices might blindly accept the
    hub-initiated LPM and power down their radios while they're in the
    middle of receiving a transmission.

    The Intel Windows folks are disabling hub-initiated LPM for all USB
    communications devices under a xHCI USB 3.0 host. In order to keep
    the Linux behavior as close as possible to Windows, we need to do the
    same in Linux.

    Set the disable_hub_initiated_lpm flag for for all USB communications
    drivers. I know there aren't currently any USB 3.0 devices that
    implement these class specifications, but we should be ready if they do.

    Signed-off-by: Sarah Sharp
    Cc: Marcel Holtmann
    Cc: Gustavo Padovan
    Cc: Johan Hedberg
    Cc: Hansjoerg Lipp
    Cc: Tilman Schmidt
    Cc: Karsten Keil
    Cc: Peter Korsgaard
    Cc: Jan Dumon
    Cc: Petko Manolov
    Cc: Steve Glendinning
    Cc: "John W. Linville"
    Cc: Kalle Valo
    Cc: "Luis R. Rodriguez"
    Cc: Jouni Malinen
    Cc: Vasanthakumar Thiagarajan
    Cc: Senthil Balasubramanian
    Cc: Christian Lamparter
    Cc: Brett Rudley
    Cc: Roland Vossen
    Cc: Arend van Spriel
    Cc: "Franky (Zhenhui) Lin"
    Cc: Kan Yan
    Cc: Dan Williams
    Cc: Jussi Kivilinna
    Cc: Ivo van Doorn
    Cc: Gertjan van Wingerde
    Cc: Helmut Schaa
    Cc: Herton Ronaldo Krzesinski
    Cc: Hin-Tak Leung
    Cc: Larry Finger
    Cc: Chaoming Li
    Cc: Daniel Drake
    Cc: Ulrich Kunitz
    Signed-off-by: Sarah Sharp

    Sarah Sharp
     

13 Feb, 2012

3 commits

  • 155961e80   Bluetooth: Remove hci_dev->driver_data ... Browse Code »

    The linux device model provides dev_set/get_drvdata so we can use this
    to save private driver data.
    This also removes several unnecessary casts.

    Signed-off-by: David Herrmann
    Acked-by: Marcel Holtmann
    Signed-off-by: Johan Hedberg

    David Herrmann
     
  • e9b9cfa15   Bluetooth: Remove HCI-owner field ... Browse Code »

    After unregistering an hci_dev object a bluetooth driver does not have
    any callbacks in the hci_dev structure left over. Therefore, there is no
    need to keep a reference to the module.

    Previously, we needed this to protect the hci-destruct callback.
    However, this callback is no longer available so we do not need this
    owner field, anymore. Drivers now call hci_unregister_dev() and they
    are done with the object.

    Signed-off-by: David Herrmann
    Acked-by: Marcel Holtmann
    Signed-off-by: Johan Hedberg

    David Herrmann
     
  • d25442ba4   Bluetooth: bpa10x: Free private driver data on usb shutdown ... Browse Code »

    Instead of waiting for the hci-device to be destroyed we now free the
    private driver data on driver shutdown right away. We call
    hci_unregister_dev() on driver shutdown, that means, the hci-core will
    never ever call our callbacks again except the destruct callback. It
    also does not access hdev->driver_data so there is no reason to keep
    that alive. We simply set the destruct cb to NULL to avoid getting
    called again.

    Signed-off-by: David Herrmann
    Acked-by: Marcel Holtmann
    Signed-off-by: Johan Hedberg

    David Herrmann
     

19 Nov, 2011

1 commit

22 Jul, 2010

1 commit

27 Feb, 2010

1 commit

30 Nov, 2008

2 commits

  • a418b893a   Bluetooth: Enable per-module dynamic debug messages ... Browse Code »

    With the introduction of CONFIG_DYNAMIC_PRINTK_DEBUG it is possible to
    allow debugging without having to recompile the kernel. This patch turns
    all BT_DBG() calls into pr_debug() to support dynamic debug messages.

    As a side effect all CONFIG_BT_*_DEBUG statements are now removed and
    some broken debug entries have been fixed.

    Signed-off-by: Marcel Holtmann

    Marcel Holtmann
     
  • 7a9d40205   Bluetooth: Send HCI Reset command by default on device initialization ... Browse Code »

    The Bluetooth subsystem was not using the HCI Reset command when doing
    device initialization. The Bluetooth 1.0b specification was ambiguous
    on how the device firmware was suppose to handle it. Almost every device
    was triggering a transport reset at the same time. In case of USB this
    ended up in disconnects from the bus.

    All modern Bluetooth dongles handle this perfectly fine and a lot of
    them actually require that HCI Reset is sent. If not then they are
    either stuck in their HID Proxy mode or their internal structures for
    inquiry and paging are not correctly setup.

    To handle old and new devices smoothly the Bluetooth subsystem contains
    a quirk to force the HCI Reset on initialization. However maintaining
    such a quirk becomes more and more complicated. This patch turns the
    logic around and lets the old devices disable the HCI Reset command.

    The only device where the HCI_QUIRK_NO_RESET is still needed are the
    original Digianswer devices and dongles with an early CSR firmware.

    CSR reported that they fixed this for version 12 firmware. The last
    official release of version 11 firmware is build ID 115. The first
    version 12 candidate was build ID 117.

    Signed-off-by: Marcel Holtmann

    Marcel Holtmann
     

31 Oct, 2008

1 commit

06 Oct, 2008

1 commit

08 Aug, 2008

1 commit

05 Feb, 2008

1 commit

22 Oct, 2007

1 commit

26 Apr, 2007

1 commit

05 Oct, 2006

1 commit

  • 7d12e780e   IRQ: Maintain regs pointer globally rather than passing to IRQ handlers ... Browse Code »

    Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

01 Jul, 2006

1 commit

05 Jan, 2006

1 commit

09 Nov, 2005

1 commit

07 Nov, 2005

1 commit