08 Aug, 2019

1 commit

  • In function cm_osc_setup, variable parent takes the value returned by
    of_get_parent, which gets a node but does not put it. If parent is not
    put before it goes out of scope, it may cause a memory leak.
    Hence put parent before the function terminates.
    Issue found with Coccinelle.

    Signed-off-by: Nishka Dasgupta
    Link: https://lkml.kernel.org/r/20190804163445.6862-1-nishkadg.linux@gmail.com
    Reviewed-by: Linus Walleij
    Signed-off-by: Stephen Boyd

    Nishka Dasgupta
     

19 Jun, 2019

1 commit

  • Based on 2 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license version 2 as
    published by the free software foundation

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license version 2 as
    published by the free software foundation #

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-only

    has been chosen to replace the boilerplate/reference in 4122 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Enrico Weigelt
    Reviewed-by: Kate Stewart
    Reviewed-by: Allison Randal
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

31 May, 2019

1 commit

  • Based on 1 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license version 2 as
    published by the free software foundation this program is
    distributed in the hope that it will be useful but without any
    warranty without even the implied warranty of merchantability or
    fitness for a particular purpose see the gnu general public license
    for more details

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-only

    has been chosen to replace the boilerplate/reference in 655 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Allison Randal
    Reviewed-by: Kate Stewart
    Reviewed-by: Richard Fontana
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190527070034.575739538@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

21 May, 2019

1 commit


16 May, 2019

1 commit

  • Now that we've gotten rid of clk_readl() we can remove io.h from the
    clk-provider header and push out the io.h include to any code that isn't
    already including the io.h header but using things like readl/writel,
    etc.

    Found with this grep:

    git grep -l clk-provider.h | grep '.c$' | xargs git grep -L 'linux/io.h' | \
    xargs git grep -l \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\' --or \
    -e '\'

    I also reordered a couple includes when they weren't alphabetical and
    removed clk.h from kona, replacing it with clk-provider.h because
    that driver doesn't use clk consumer APIs.

    Acked-by: Geert Uytterhoeven
    Cc: Chen-Yu Tsai
    Acked-by: Maxime Ripard
    Acked-by: Tero Kristo
    Acked-by: Sekhar Nori
    Cc: Krzysztof Kozlowski
    Acked-by: Mark Brown
    Cc: Chris Zankel
    Acked-by: Max Filippov
    Acked-by: John Crispin
    Acked-by: Heiko Stuebner
    Signed-off-by: Stephen Boyd

    Stephen Boyd
     

11 Dec, 2018

1 commit


17 Mar, 2018

2 commits

  • clk_round_rate() is intended to be used to round a given clock rate to
    the closest one achievable by the actual clock. This implies that the
    input to clk_round_rate() is expected to be unachievable - and such
    cases shouldn't be treated as exceptional.

    To reflect this, remove the WARN_ONs which trigger when an unachievable
    clock rate is passed to vexpress_osc_round_rate().

    Reported-by: Vladimir Murzin
    Signed-off-by: Brian Starkey
    Acked-by: Sudeep Holla
    Signed-off-by: Stephen Boyd

    Brian Starkey
     
  • Clock framework has a provider API(clk_hw_set_rate_range) to set the
    min/max rate of a clock. Use the same to set the boundaries for the
    vexpress osc clock.

    Cc: Michael Turquette
    Cc: Stephen Boyd
    Cc: linux-clk@vger.kernel.org
    Signed-off-by: Sudeep Holla
    Signed-off-by: Stephen Boyd

    Sudeep Holla
     

18 Nov, 2017

1 commit

  • Pull clk updates from Stephen Boyd:
    "We have two changes to the core framework this time around.

    The first being a large change that introduces runtime PM support to
    the clk framework. Now we properly call runtime PM operations on the
    device providing a clk when the clk is in use. This helps on SoCs
    where the clks provided by a device need something to be powered on
    before using the clks, like power domains or regulators. It also helps
    power those things down when clks aren't in use.

    The other core change is a devm API addition for clk providers so we
    can get rid of a bunch of clk driver remove functions that are just
    doing of_clk_del_provider().

    Outside of the core, we have the usual addition of clk drivers and
    smattering of non-critical fixes to existing drivers. The biggest diff
    is support for Mediatek MT2712 and MT7622 SoCs, but those patches
    really just add a bunch of data.

    By the way, we're trying something new here where we build the tree up
    with topic branches. We plan to work this into our workflow so that we
    don't step on each other's toes, and so the fixes branch can be merged
    on an as-needed basis.

    Summary:

    Core:
    - runtime PM support for clk providers
    - devm API for of_clk_add_hw_provider()

    New Drivers:
    - Mediatek MT2712 and MT7622
    - Renesas R-Car V3M SoC

    Updates:
    - runtime PM support for Samsung exynos5433/exynos4412 providers
    - removal of clkdev aliases on Samsung SoCs
    - convert clk-gpio to use gpio descriptors
    - various driver cleanups to match kernel coding style
    - Amlogic Video Processing Unit VPU and VAPB clks
    - sigma-delta modulation for Allwinner audio PLLs
    - Allwinner A83t Display clks
    - support for the second display unit clock on Renesas RZ/G1E
    - suspend/resume support for Renesas R-Car Gen3 CPG/MSSR
    - new clock ids for Rockchip rk3188 and rk3368 SoCs
    - various 'const' markings on clk_ops structures
    - RPM clk support on Qualcomm MSM8996/MSM8660 SoCs"

    * tag 'clk-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux: (137 commits)
    clk: stm32h7: fix test of clock config
    clk: pxa: fix building on older compilers
    clk: sunxi-ng: a83t: Fix i2c buses bits
    clk: ti: dra7-atl-clock: fix child-node lookups
    clk: qcom: common: fix legacy board-clock registration
    clk: uniphier: fix DAPLL2 clock rate of Pro5
    clk: uniphier: fix parent of miodmac clock data
    clk: hi3798cv200: correct parent mux clock for 'clk_sdio0_ciu'
    clk: hisilicon: Delete an error message for a failed memory allocation in hisi_register_clkgate_sep()
    clk: hi3660: fix incorrect uart3 clock freqency
    clk: kona-setup: Delete error messages for failed memory allocations
    ARC: clk: fix spelling mistake: "configurarion" -> "configuration"
    clk: cdce925: remove redundant check for non-null parent_name
    clk: versatile: Improve sizeof() usage
    clk: versatile: Delete error messages for failed memory allocations
    clk: ux500: Improve sizeof() usage
    clk: ux500: Delete error messages for failed memory allocations
    clk: spear: Delete error messages for failed memory allocations
    clk: ti: Delete error messages for failed memory allocations
    clk: mmp: Adjust checks for NULL pointers
    ...

    Linus Torvalds
     

14 Nov, 2017

2 commits


02 Nov, 2017

1 commit

  • Many source files in the tree are missing licensing information, which
    makes it harder for compliance tools to determine the correct license.

    By default all files without license information are under the default
    license of the kernel, which is GPL version 2.

    Update the files which contain no license information with the 'GPL-2.0'
    SPDX license identifier. The SPDX identifier is a legally binding
    shorthand, which can be used instead of the full boiler plate text.

    This patch is based on work done by Thomas Gleixner and Kate Stewart and
    Philippe Ombredanne.

    How this work was done:

    Patches were generated and checked against linux-4.14-rc6 for a subset of
    the use cases:
    - file had no licensing information it it.
    - file was a */uapi/* one with no licensing information in it,
    - file was a */uapi/* one with existing licensing information,

    Further patches will be generated in subsequent months to fix up cases
    where non-standard license headers were used, and references to license
    had to be inferred by heuristics based on keywords.

    The analysis to determine which SPDX License Identifier to be applied to
    a file was done in a spreadsheet of side by side results from of the
    output of two independent scanners (ScanCode & Windriver) producing SPDX
    tag:value files created by Philippe Ombredanne. Philippe prepared the
    base worksheet, and did an initial spot review of a few 1000 files.

    The 4.13 kernel was the starting point of the analysis with 60,537 files
    assessed. Kate Stewart did a file by file comparison of the scanner
    results in the spreadsheet to determine which SPDX license identifier(s)
    to be applied to the file. She confirmed any determination that was not
    immediately clear with lawyers working with the Linux Foundation.

    Criteria used to select files for SPDX license identifier tagging was:
    - Files considered eligible had to be source code files.
    - Make and config files were included as candidates if they contained >5
    lines of source
    - File already had some variant of a license header in it (even if
    Reviewed-by: Philippe Ombredanne
    Reviewed-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

31 Aug, 2017

1 commit


03 Jun, 2017

1 commit


07 Apr, 2017

1 commit

  • This moves the ICST clock divider helper library from
    arch/arm/common to drivers/clk/versatile so it is maintained
    with the other clock drivers.

    We keep the structure as a helper library intact and do not
    fuse it with the clk-icst.c Versatile ICST clock driver: there
    may be other users out there that need to use this library for
    their clocking, and then it will be helpful to keep the
    library contained. (The icst.[c|h] files could just be moved
    to drivers/clk/lib or a similar location to share the library.)

    Acked-by: Stephen Boyd
    Signed-off-by: Linus Walleij

    Linus Walleij
     

30 Aug, 2016

1 commit

  • This adds support for the two ICST525-based clocks on the
    Integrator/AP baseboard, as documented in the board manual
    "Integrator/AP ASIC Development Motherboard", ARM DUI0098 B,
    pages 3-15 thru 3-18.

    Cc: Russell King
    Signed-off-by: Linus Walleij
    [sboyd@codeaurora.org: fixed uninitialized val warning]
    Signed-off-by: Stephen Boyd

    Linus Walleij
     

26 Aug, 2016

1 commit

  • The Integrator/AP and Integrator/CP have special derivatives
    of the ICST525 control registers, where some bits have been
    hardwired but others are possible to adjust, resulting in a
    control register that makes it possible to set an even,
    desired megahertz value.

    The Integrator/AP and Integrator/CP have slightly different
    layout so we support them using different compatible
    strings.

    After adding these clocks, the Integrator-specific cpufreq
    driver can be switched over to use the generic operating
    point device tree cpufreq driver.

    Instead of simply writing a value to the oscillator control
    register we switch to the more elaborate method of providing
    a bitmask and use regmap_update_bits() to poke the right bits
    for the desired frequency, this is needed since these control
    registers sometimes control more than one clock.

    Cc: Russell King
    Signed-off-by: Linus Walleij
    Signed-off-by: Stephen Boyd

    Linus Walleij
     

16 Mar, 2016

1 commit


26 Feb, 2016

1 commit

  • Despite care take to allocate clocks state containers the
    SP810 driver actually just supports creating one instance:
    all clocks registered for every instance will end up with the
    exact same name and __clk_init() will fail.

    Rename the timclken .. timclken to sp810__
    so every clock on every instance gets a unique name.

    This is necessary for the RealView PBA8 which has two SP810
    blocks: the second block will not register its clocks unless
    every clock on every instance is unique and results in boot
    logs like this:

    ------------[ cut here ]------------
    WARNING: CPU: 0 PID: 0 at ../drivers/clk/versatile/clk-sp810.c:137
    clk_sp810_of_setup+0x110/0x154()
    Modules linked in:
    CPU: 0 PID: 0 Comm: swapper/0 Not tainted
    4.5.0-rc2-00030-g352718fc39f6-dirty #225
    Hardware name: ARM RealView Machine (Device Tree Support)
    [] (unwind_backtrace) from []
    (show_stack+0x10/0x14)
    [] (show_stack) from []
    (dump_stack+0x84/0x9c)
    [] (dump_stack) from []
    (warn_slowpath_common+0x74/0xb0)
    [] (warn_slowpath_common) from []
    (warn_slowpath_null+0x1c/0x24)
    [] (warn_slowpath_null) from []
    (clk_sp810_of_setup+0x110/0x154)
    [] (clk_sp810_of_setup) from []
    (of_clk_init+0x12c/0x1c8)
    [] (of_clk_init) from []
    (time_init+0x20/0x2c)
    [] (time_init) from []
    (start_kernel+0x244/0x3c4)
    [] (start_kernel) from [] (0x7000807c)
    ---[ end trace cb88537fdc8fa200 ]---

    Cc: Michael Turquette
    Cc: Pawel Moll
    Fixes: 6e973d2c4385 "clk: vexpress: Add separate SP810 driver"
    Signed-off-by: Linus Walleij
    Signed-off-by: Stephen Boyd

    Linus Walleij
     

11 Feb, 2016

1 commit

  • The Versatile syscon ICST driver OR:s the bits into place but
    forgets to mask the previous value, making the code only work
    if the register is zero or giving haphazard results. Mask the
    19 bits used by the Versatile syscon interface register.

    Regression caused and now fixed by yours truly.

    Cc: Michael Turquette
    Cc: Stephen Boyd
    Cc: linux-clk@vger.kernel.org
    Fixes: 179c8fb3c2a6 ("clk: versatile-icst: convert to use regmap")
    Signed-off-by: Linus Walleij
    Signed-off-by: Stephen Boyd

    Linus Walleij
     

21 Jan, 2016

1 commit

  • Pull ARM SoC multiplatform code updates from Arnd Bergmann:
    "This branch is the culmination of 5 years of effort to bring the ARMv6
    and ARMv7 platforms together such that they can all be enabled and
    boot the same kernel. It has been a tremendous amount of cleanup and
    refactoring by a huge number of people, and creation of several new
    (and major) subsystems to better abstract out all the platform details
    in an appropriate manner.

    The bulk of this branch is a large patchset from Arnd that brings
    several of the more minor and older platforms we have closer to
    multiplatform support. Among these are MMP, S3C64xx, Orion5x, mv78xx0
    and realview Much of this is moving around header files from old mach
    directories, but there are also some cleanup patches of debug_ll
    (lowlevel debug per-platform options) and other parts.

    Linus Walleij also has some patchs to clean up the older ARM Realview
    platforms by finally introducing DT support, and Rob Herring has some
    for ARM Versatile which is now DT-only. Both of these platforms are
    now multiplatform.

    Finally, a couple of patches from Russell for Dove PMU, and a fix from
    Valentin Rothberg for Exynos ADC, which were rebased on top of the
    series to avoid conflicts"

    * tag 'armsoc-multiplatform' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc: (75 commits)
    ARM: realview: don't select SMP_ON_UP for UP builds
    ARM: s3c: simplify s3c_irqwake_{e,}intallow definition
    ARM: s3c64xx: fix pm-debug compilation
    iio: exynos-adc: fix irqf_oneshot.cocci warnings
    ARM: realview: build realview-dt SMP support only when used
    ARM: realview: select apropriate targets
    ARM: realview: clean up header files
    ARM: realview: make all header files local
    ARM: no longer make CPU targets visible separately
    ARM: integrator: use explicit core module options
    ARM: realview: enable multiplatform
    ARM: make default platform work for NOMMU
    ARM: debug-ll: move DEBUG_LL_UART_EFM32 to correct Kconfig location
    ARM: defconfig: use correct debug_ll settings
    ARM: versatile: convert to multi-platform
    ARM: versatile: merge mach code into a single file
    ARM: versatile: switch to DT only booting and remove legacy code
    ARM: versatile: add DT based PCI detection
    ARM: pxa: mark ezx structures as __maybe_unused
    ARM: pxa: mark raumfeld init functions as __maybe_unused
    ...

    Linus Torvalds
     

16 Dec, 2015

2 commits

  • …nel/git/linusw/linux-integrator into next/multiplatform

    Merge "Realview multiplatform support" from Linus Walleij:

    The board and infrastructure changes for RealView
    multiplatform and extended DT support.

    * tag 'realview-base-armsoc-1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-integrator:
    ARM: realview: add an DT SMP boot method
    ARM: realview: select SP810 and ICST for the DT variant
    soc: versatile: add support for the PB11MPCore
    clk: versatile-icst: add device tree support
    clk: versatile-icst: refactor to allocate regmap separately
    clk: versatile-icst: convert to use regmap
    ARM: realview: remove private barrier implementation
    ARM: no longer force unbuffered DMA for realview
    clk/realview: stop using machine headers
    ARM: realview: don't map undefined PCI registers
    ARM: realview: remove sparsemem hack

    Conflicts:
    drivers/clk/versatile/Kconfig

    Arnd Bergmann
     
  • With DT support for clocks, irqchips, timers, and PCI now in place, DT
    based booting has feature parity with non-DT legacy boot. The final
    piece is actually enabling common clock support on Versatile. Enabling
    full DT support requires either removing the old Versatile clock code,
    updating the legacy boot to use the common clock code, or making DT and
    legacy boot mutually exclusive. Given that removing legacy boot code is
    the goal anyway, I am going with the 1st option.

    Signed-off-by: Rob Herring
    Cc: Russell King
    Cc: Linus Walleij
    Cc: Mike Turquette
    Signed-off-by: Arnd Bergmann

    Rob Herring
     

15 Dec, 2015

4 commits

  • This adds support for the ARM syscon ICST clocks to initialized
    directly from the device tree syscon node on ARM Integrator,
    Versatile and RealView reference designs.

    Cc: Michael Turquette
    Cc: Stephen Boyd
    Cc: linux-clk@vger.kernel.org
    Signed-off-by: Linus Walleij

    Linus Walleij
     
  • Break out the registration function so it creates a regmap and
    pass to the setup function, so the latter can be shared with
    a device tree probe function that already has a regmap.

    Cc: Michael Turquette
    Cc: Stephen Boyd
    Cc: linux-clk@vger.kernel.org
    Signed-off-by: Linus Walleij

    Linus Walleij
     
  • Instead of passing around register bases, pass around a regmap
    in this driver. This refactoring make things so much easier when
    we later want to manage an ICST that is part of a syscon.

    Cc: Michael Turquette
    Cc: Stephen Boyd
    Cc: linux-clk@vger.kernel.org
    Signed-off-by: Linus Walleij

    Linus Walleij
     
  • In order to move realview into multiplatform, we have to prevent device
    drivers from accessing the machine header files.

    In case of the clk driver, this is very simple, we just copy the
    small set of register definitions into the driver that needs them.

    Signed-off-by: Arnd Bergmann
    Signed-off-by: Linus Walleij

    Arnd Bergmann
     

21 Nov, 2015

1 commit


19 Nov, 2015

1 commit


24 Oct, 2015

1 commit

  • A static code checker found a memory leak in the Versatile
    ICST code. Fix it.

    Fixes: a183da637c52 "clk: versatile: respect parent rate in ICST clock"
    Reported-by: Stephen Boyd
    Signed-off-by: Linus Walleij
    Signed-off-by: Stephen Boyd

    Linus Walleij
     

17 Oct, 2015

1 commit

  • These drivers only have runtime but no build time dependencies so can be
    built for testing purposes if the Kconfig COMPILE_TEST option is enabled.

    This is useful to have more build coverage and make sure that drivers are
    not affected by changes that could cause build regressions.

    Signed-off-by: Javier Martinez Canillas
    Acked-by: Scott Branden
    Signed-off-by: Stephen Boyd

    Javier Martinez Canillas
     

25 Aug, 2015

2 commits

  • Init data marked const should be annotated with __initconst for
    correctness and not __initdata. This also fixes LTO builds that
    otherwise fail with section mismatch errors.

    Signed-off-by: Nicolas Pitre
    Signed-off-by: Michael Turquette
    [sboyd@codeaurora.org: Dropped hunks that moved const char *
    arrays to const char * const]
    Signed-off-by: Stephen Boyd

    Nicolas Pitre
     
  • We're removing struct clk from the clk provider API. This code is
    calling the consumer APIs to change the parent to a 1 MHz fixed
    rate clock for each of the clocks that the driver provides. Move
    to using the assigned-clock-parents DT property for this instead.
    Because this is an ABI break, detect if the property is missing
    and fall back to setting the parent explicitly before the clocks
    are registered.

    Acked-by: Pawel Moll
    Cc: Linus Walleij
    Tested-by: Sudeep Holla
    Signed-off-by: Stephen Boyd

    Stephen Boyd
     

30 Jul, 2015

1 commit


21 Jul, 2015

1 commit

  • Clock provider drivers generally shouldn't include clk.h because
    it's the consumer API. Remove the include here because this is a
    provider driver. Also remove clkdev.h in files that aren't using
    it and replace them with slab.h in files that were relying on the
    implicit include of slab.h in clkdev.h.

    Reviewed-by: Linus Walleij
    Signed-off-by: Stephen Boyd

    Stephen Boyd
     

15 May, 2015

1 commit

  • drivers/clk/versatile/clk-sp810.c:159:29: error: incompatible types for operation (
    drivers/clk/versatile/clk-sp810.c:159:29: right side has type int
    drivers/clk/versatile/clk-sp810.c:159:53: error: incompatible types for operation (
    drivers/clk/versatile/clk-sp810.c:159:53: right side has type int
    drivers/clk/versatile/clk-sp810.c:138:13: warning: symbol 'clk_sp810_of_setup' was not declared. Should it be static?

    Acked: Pawel Moll
    Signed-off-by: Stephen Boyd

    Stephen Boyd
     

09 Apr, 2015

1 commit

  • Put NULL test on the result of the previous call instead on one of its
    arguments. A simplified version of the semantic match that finds this
    problem is as follows (http://coccinelle.lip6.fr/):

    //
    r@
    expression *e1;
    expression *e2;
    identifier f;
    statement S1,S2;
    @@

    e1 = f(...,e2,...);
    (
    if (e1 == NULL || ...) S1 else S2
    |
    *if (e2 == NULL || ...) S1 else S2
    )
    //

    Signed-off-by: Julia Lawall
    Acked-by: Linus Walleij
    Signed-off-by: Stephen Boyd

    Julia Lawall
     

02 Apr, 2015

1 commit

  • of_device_id is always used as const.
    (See driver.of_match_table and open firmware functions)

    __initdata updated to __initconst for
    static const struct of_device_id ti_clkdm_match_table[]

    Signed-off-by: Fabian Frederick
    Signed-off-by: Stephen Boyd

    Fabian Frederick
     

28 Nov, 2014

1 commit

  • Now, with the CLCD DT support available, there is no
    more reason to keep the non-DT support for V2P-CA9.

    Removed, together with "some" supporting code. It was
    necessary to make PLAT_VERSATILE_SCHED_CLOCK optional
    and selected by the machines still interested in it.

    Acked-by: Mike Turquette
    Signed-off-by: Pawel Moll
    Signed-off-by: Arnd Bergmann

    Pawel Moll
     

25 Jun, 2014

1 commit

  • Versatile platforms share the same OSC programming model as Integrator
    platforms. Add the necessary parameters and init functions for Versatile.

    Renaming the file to clk-versatile.c as versatile is used as the family
    name for ARM, Ltd. boards.

    Signed-off-by: Rob Herring
    Acked-by: Mike Turquette
    Acked-by: Arnd Bergmann
    Reviewed-by: Linus Walleij

    Rob Herring