16 May, 2019

1 commit

• 22c58fd70   Merge tag 'armsoc-soc' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc ... Browse Code »

  Pull ARM SoC platform updates from Olof Johansson:
  "SoC updates, mostly refactorings and cleanups of old legacy platforms.

  Major themes this release:

  - Conversion of ixp4xx to a modern platform (drivers, DT, bindings)

  - Moving some of the ep93xx headers around to get it closer to
  multiplatform enabled.

  - Cleanups of Davinci

  This also contains a few patches that were queued up as fixes before
  5.1 but I didn't get sent in before release"

  * tag 'armsoc-soc' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc: (123 commits)
  ARM: debug-ll: add default address for digicolor
  ARM: u300: regulator: add MODULE_LICENSE()
  ARM: ep93xx: move private headers out of mach/*
  ARM: ep93xx: move pinctrl interfaces into include/linux/soc
  ARM: ep93xx: keypad: stop using mach/platform.h
  ARM: ep93xx: move network platform data to separate header
  ARM: stm32: add AMBA support for stm32 family
  MAINTAINERS: update arch/arm/mach-davinci
  ARM: rockchip: add missing of_node_put in rockchip_smp_prepare_pmu
  ARM: dts: Add queue manager and NPE to the IXP4xx DTSI
  soc: ixp4xx: qmgr: Add DT probe code
  soc: ixp4xx: qmgr: Add DT bindings for IXP4xx qmgr
  soc: ixp4xx: npe: Add DT probe code
  soc: ixp4xx: Add DT bindings for IXP4xx NPE
  soc: ixp4xx: qmgr: Pass resources
  soc: ixp4xx: Remove unused functions
  soc: ixp4xx: Uninline several functions
  soc: ixp4xx: npe: Pass addresses as resources
  ARM: ixp4xx: Turn the QMGR into a platform device
  ARM: ixp4xx: Turn the NPE into a platform device
  ...

  Linus Torvalds

  2019-05-16 23:31:32 +0800  

06 May, 2019

1 commit

• c5bf68fe0   *: convert stream-like files from nonseekable_open -> stream_open ... Browse Code »

  Using scripts/coccinelle/api/stream_open.cocci added in 10dce8af3422
  ("fs: stream_open - opener for stream-like files so that read and write
  can run simultaneously without deadlock"), search and convert to
  stream_open all in-kernel nonseekable_open users for which read and
  write actually do not depend on ppos and where there is no other methods
  in file_operations which assume @offset access.

  I've verified each generated change manually - that it is correct to convert -
  and each other nonseekable_open instance left - that it is either not correct
  to convert there, or that it is not converted due to current stream_open.cocci
  limitations. The script also does not convert files that should be valid to
  convert, but that currently have .llseek = noop_llseek or generic_file_llseek
  for unknown reason despite file being opened with nonseekable_open (e.g.
  drivers/input/mousedev.c)

  Among cases converted 14 were potentially vulnerable to read vs write deadlock
  (see details in 10dce8af3422):

  drivers/char/pcmcia/cm4000_cs.c:1685:7-23: ERROR: cm4000_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/gnss/core.c:45:1-17: ERROR: gnss_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/hid/uhid.c:635:1-17: ERROR: uhid_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/infiniband/core/user_mad.c:988:1-17: ERROR: umad_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/input/evdev.c:527:1-17: ERROR: evdev_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/input/misc/uinput.c:401:1-17: ERROR: uinput_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/isdn/capi/capi.c:963:8-24: ERROR: capi_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/leds/uleds.c:77:1-17: ERROR: uleds_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/media/rc/lirc_dev.c:198:1-17: ERROR: lirc_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/s390/char/fs3270.c:488:1-17: ERROR: fs3270_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/usb/misc/ldusb.c:310:1-17: ERROR: ld_usb_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  drivers/xen/evtchn.c:667:8-24: ERROR: evtchn_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  net/batman-adv/icmp_socket.c:80:1-17: ERROR: batadv_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
  net/rfkill/core.c:1146:8-24: ERROR: rfkill_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.

  and the rest were just safe to convert to stream_open because their read and
  write do not use ppos at all and corresponding file_operations do not
  have methods that assume @offset file access(*):

  arch/powerpc/platforms/52xx/mpc52xx_gpt.c:631:8-24: WARNING: mpc52xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_ibox_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_ibox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_mbox_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_mbox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_wbox_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_wbox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/um/drivers/harddog_kern.c:88:8-24: WARNING: harddog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  arch/x86/kernel/cpu/microcode/core.c:430:33-49: WARNING: microcode_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/char/ds1620.c:215:8-24: WARNING: ds1620_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/char/dtlk.c:301:1-17: WARNING: dtlk_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/char/ipmi/ipmi_watchdog.c:840:9-25: WARNING: ipmi_wdog_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/char/pcmcia/scr24x_cs.c:95:8-24: WARNING: scr24x_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/char/tb0219.c:246:9-25: WARNING: tb0219_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/firewire/nosy.c:306:8-24: WARNING: nosy_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/hwmon/fschmd.c:840:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/hwmon/w83793.c:1344:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/infiniband/core/ucma.c:1747:8-24: WARNING: ucma_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/infiniband/core/ucm.c:1178:8-24: WARNING: ucm_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/infiniband/core/uverbs_main.c:1086:8-24: WARNING: uverbs_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/input/joydev.c:282:1-17: WARNING: joydev_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/pci/switch/switchtec.c:393:1-17: WARNING: switchtec_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/platform/chrome/cros_ec_debugfs.c:135:8-24: WARNING: cros_ec_console_log_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/rtc/rtc-ds1374.c:470:9-25: WARNING: ds1374_wdt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/rtc/rtc-m41t80.c:805:9-25: WARNING: wdt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/s390/char/tape_char.c:293:2-18: WARNING: tape_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/s390/char/zcore.c:194:8-24: WARNING: zcore_reipl_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/s390/crypto/zcrypt_api.c:528:8-24: WARNING: zcrypt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/spi/spidev.c:594:1-17: WARNING: spidev_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/staging/pi433/pi433_if.c:974:1-17: WARNING: pi433_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/acquirewdt.c:203:8-24: WARNING: acq_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/advantechwdt.c:202:8-24: WARNING: advwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/alim1535_wdt.c:252:8-24: WARNING: ali_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/alim7101_wdt.c:217:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/ar7_wdt.c:166:8-24: WARNING: ar7_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/at91rm9200_wdt.c:113:8-24: WARNING: at91wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/ath79_wdt.c:135:8-24: WARNING: ath79_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/bcm63xx_wdt.c:119:8-24: WARNING: bcm63xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/cpu5wdt.c:143:8-24: WARNING: cpu5wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/cpwd.c:397:8-24: WARNING: cpwd_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/eurotechwdt.c:319:8-24: WARNING: eurwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/f71808e_wdt.c:528:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/gef_wdt.c:232:8-24: WARNING: gef_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/geodewdt.c:95:8-24: WARNING: geodewdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/ib700wdt.c:241:8-24: WARNING: ibwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/ibmasr.c:326:8-24: WARNING: asr_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/indydog.c:80:8-24: WARNING: indydog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/intel_scu_watchdog.c:307:8-24: WARNING: intel_scu_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/iop_wdt.c:104:8-24: WARNING: iop_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/it8712f_wdt.c:330:8-24: WARNING: it8712f_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/ixp4xx_wdt.c:68:8-24: WARNING: ixp4xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/ks8695_wdt.c:145:8-24: WARNING: ks8695wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/m54xx_wdt.c:88:8-24: WARNING: m54xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/machzwd.c:336:8-24: WARNING: zf_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/mixcomwd.c:153:8-24: WARNING: mixcomwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/mtx-1_wdt.c:121:8-24: WARNING: mtx1_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/mv64x60_wdt.c:136:8-24: WARNING: mv64x60_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/nuc900_wdt.c:134:8-24: WARNING: nuc900wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/nv_tco.c:164:8-24: WARNING: nv_tco_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pc87413_wdt.c:289:8-24: WARNING: pc87413_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pcwd.c:698:8-24: WARNING: pcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pcwd.c:737:8-24: WARNING: pcwd_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pcwd_pci.c:581:8-24: WARNING: pcipcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pcwd_pci.c:623:8-24: WARNING: pcipcwd_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pcwd_usb.c:488:8-24: WARNING: usb_pcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pcwd_usb.c:527:8-24: WARNING: usb_pcwd_temperature_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pika_wdt.c:121:8-24: WARNING: pikawdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/pnx833x_wdt.c:119:8-24: WARNING: pnx833x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/rc32434_wdt.c:153:8-24: WARNING: rc32434_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/rdc321x_wdt.c:145:8-24: WARNING: rdc321x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/riowd.c:79:1-17: WARNING: riowd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sa1100_wdt.c:62:8-24: WARNING: sa1100dog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sbc60xxwdt.c:211:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sbc7240_wdt.c:139:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sbc8360.c:274:8-24: WARNING: sbc8360_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sbc_epx_c3.c:81:8-24: WARNING: epx_c3_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sbc_fitpc2_wdt.c:78:8-24: WARNING: fitpc2_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sb_wdog.c:108:1-17: WARNING: sbwdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sc1200wdt.c:181:8-24: WARNING: sc1200wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sc520_wdt.c:261:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/sch311x_wdt.c:319:8-24: WARNING: sch311x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/scx200_wdt.c:105:8-24: WARNING: scx200_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/smsc37b787_wdt.c:369:8-24: WARNING: wb_smsc_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/w83877f_wdt.c:227:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/w83977f_wdt.c:301:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wafer5823wdt.c:200:8-24: WARNING: wafwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/watchdog_dev.c:828:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdrtas.c:379:8-24: WARNING: wdrtas_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdrtas.c:445:8-24: WARNING: wdrtas_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdt285.c:104:1-17: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdt977.c:276:8-24: WARNING: wdt977_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdt.c:424:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdt.c:484:8-24: WARNING: wdt_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdt_pci.c:464:8-24: WARNING: wdtpci_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open.
  drivers/watchdog/wdt_pci.c:527:8-24: WARNING: wdtpci_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  net/batman-adv/log.c:105:1-17: WARNING: batadv_log_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  sound/core/control.c:57:7-23: WARNING: snd_ctl_f_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
  sound/core/rawmidi.c:385:7-23: WARNING: snd_rawmidi_f_ops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  sound/core/seq/seq_clientmgr.c:310:7-23: WARNING: snd_seq_f_ops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
  sound/core/timer.c:1428:7-23: WARNING: snd_timer_f_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.

  One can also recheck/review the patch via generating it with explanation comments included via

  $ make coccicheck MODE=patch COCCI=scripts/coccinelle/api/stream_open.cocci SPFLAGS="-D explain"

  (*) This second group also contains cases with read/write deadlocks that
  stream_open.cocci don't yet detect, but which are still valid to convert to
  stream_open since ppos is not used. For example drivers/pci/switch/switchtec.c
  calls wait_for_completion_interruptible() in its .read, but stream_open.cocci
  currently detects only "wait_event*" as blocking.

  Cc: Michael Kerrisk
  Cc: Yongzhi Pan
  Cc: Jonathan Corbet
  Cc: David Vrabel
  Cc: Juergen Gross
  Cc: Miklos Szeredi
  Cc: Tejun Heo
  Cc: Kirill Tkhai
  Cc: Arnd Bergmann
  Cc: Christoph Hellwig
  Cc: Greg Kroah-Hartman
  Cc: Julia Lawall
  Cc: Nikolaus Rath
  Cc: Han-Wen Nienhuys
  Cc: Anatolij Gustschin
  Cc: Jeff Dike
  Cc: Richard Weinberger
  Cc: Anton Ivanov
  Cc: Borislav Petkov
  Cc: Thomas Gleixner
  Cc: Ingo Molnar
  Cc: "James R. Van Zandt"
  Cc: Corey Minyard
  Cc: Harald Welte
  Acked-by: Lubomir Rintel [scr24x_cs]
  Cc: Stefan Richter
  Cc: Johan Hovold
  Cc: David Herrmann
  Cc: Jiri Kosina
  Cc: Benjamin Tissoires
  Cc: Jean Delvare
  Acked-by: Guenter Roeck [watchdog/* hwmon/*]
  Cc: Rudolf Marek
  Cc: Dmitry Torokhov
  Cc: Karsten Keil
  Cc: Jacek Anaszewski
  Cc: Pavel Machek
  Cc: Mauro Carvalho Chehab
  Cc: Kurt Schwemmer
  Acked-by: Logan Gunthorpe [drivers/pci/switch/switchtec]
  Acked-by: Bjorn Helgaas [drivers/pci/switch/switchtec]
  Cc: Benson Leung
  Acked-by: Enric Balletbo i Serra [platform/chrome]
  Cc: Alessandro Zummo
  Acked-by: Alexandre Belloni [rtc/*]
  Cc: Mark Brown
  Cc: Wim Van Sebroeck
  Cc: Florian Fainelli
  Cc: bcm-kernel-feedback-list@broadcom.com
  Cc: Wan ZongShun
  Cc: Zwane Mwaikambo
  Cc: Marek Lindner
  Cc: Simon Wunderlich
  Cc: Antonio Quartulli
  Cc: "David S. Miller"
  Cc: Johannes Berg
  Cc: Jaroslav Kysela
  Cc: Takashi Iwai
  Signed-off-by: Kirill Smelkov

  Kirill Smelkov

  2019-05-06 22:46:41 +0800  

23 Apr, 2019

1 commit

• 9540724ca   ARM: ixp4xx: Add device tree boot support ... Browse Code »

  This adds a minimal support for booting IXP4xx systems
  from device tree.

  We have to add hacks to the QMGR, NPE and notably also
  ethernet and watchdog drivers so that they don't crash
  the platform: these drivers are unconditionally starting
  to grab regions of statically remapped IO space with no
  concern of the device model or other platforms.

  We will go in and properly fix these drivers as we go
  along but for now this hack gets us to a place where we
  can start working on proper device tree support for these
  platforms.

  Signed-off-by: Linus Walleij

  Linus Walleij

  2019-04-23 22:02:15 +0800  

18 Nov, 2013

1 commit

• 487722cf2   watchdog: Get rid of MODULE_ALIAS_MISCDEV statements ... Browse Code »

  I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR)
  and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements.

  Either the device is enumerated and the driver already has a module
  alias (e.g. PCI, USB etc.) that will get the right driver loaded
  automatically.

  Or the device is not enumerated and loading its driver will lead to
  more or less intrusive hardware poking. Such hardware poking should be
  limited to a bare minimum, so the user should really decide which
  drivers should be tried and in what order. Trying them all in
  arbitrary order can't do any good.

  On top of that, loading that many drivers at once bloats the kernel
  log. Also many drivers will stay loaded afterward, bloating the output
  of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets
  loaded as a dependency) can't even be unloaded!

  If defining char-major-10-130 is needed then it should happen in
  user-space.

  Signed-off-by: Jean Delvare
  Acked-by: Guenter Roeck
  Signed-off-by: Wim Van Sebroeck
  Cc: Stephen Warren
  Cc: Mike Frysinger
  Cc: Wan ZongShun
  Cc: Ben Dooks
  Cc: Kukjin Kim
  Cc: Zwane Mwaikambo
  Cc: Jim Cromie

  Jean Delvare

  2013-11-18 02:38:13 +0800  

28 Mar, 2012

2 commits

• 86a1e1896   watchdog: nowayout is bool ... Browse Code »

  nowayout is actually a boolean value.
  So make it bool for all watchdog device drivers.

  Signed-off-by: Wim Van Sebroeck

  Wim Van Sebroeck

  2012-03-28 02:06:02 +0800  
• 27c766aaa   watchdog: Use pr_<fmt> and pr_<level> ... Browse Code »

  Use the current logging styles.

  Make sure all output has a prefix.
  Add missing newlines.
  Remove now unnecessary PFX, NAME, and miscellaneous other #defines.
  Coalesce formats.

  Signed-off-by: Joe Perches
  Signed-off-by: Wim Van Sebroeck

  Joe Perches

  2012-03-28 01:59:26 +0800  

06 Jan, 2012

1 commit

• 1334f3293   watchdog: Use DEFINE_SPINLOCK() for static spinlocks ... Browse Code »

  Rather than just defining static spinlock_t variables and then
  initializing them later in init functions, simply define them with
  DEFINE_SPINLOCK() and remove the calls to spin_lock_init().

  Signed-off-by: Axel Lin
  Cc: Nicolas Thill
  Cc: Heiko Ronsdorf
  Cc: Rodolfo Giometti
  Cc: Andrey Panin
  Cc: Guido Guenther
  Cc: Curt E Bruns
  Cc: Deepak Saxena
  Cc: Andrew Victor
  Cc: George G. Davis
  Cc: Sylver Bruneau
  Signed-off-by: Wim Van Sebroeck

  Axel Lin

  2012-01-06 22:17:17 +0800  

07 Mar, 2010

1 commit

• 42747d712   [WATCHDOG] watchdog_info constify ... Browse Code »

  make the watchdog_info struct const where possible.

  Signed-off-by: Wim Van Sebroeck

  Wim Van Sebroeck

  2010-03-07 18:30:57 +0800  

01 Sep, 2008

1 commit

• 0ba8b9b27   [ARM] cputype: separate definitions, use them ... Browse Code »

  Add asm/cputype.h, moving functions and definitions from asm/system.h
  there. Convert all users of 'processor_id' to the more efficient
  read_cpuid_id() function.

  Signed-off-by: Russell King

  Russell King

  2008-09-01 19:06:23 +0800  

11 Aug, 2008

1 commit

• 9229376e9   [WATCHDOG] fix watchdog/ixp4xx_wdt.c compilation ... Browse Code »

  This patch fixes the following compile error caused by
  commit 20d35f3e50ea7e573f9568b9fce4e98523aaee5d
  ([WATCHDOG 22/57] ixp4xx_wdt: unlocked_ioctl):

  ...
  CC drivers/watchdog/ixp4xx_wdt.o
  ixp4xx_wdt.c:32: error: expected '=', ',', ';', 'asm' or '__attribute__'
  ixp4xx_wdt.c: In function 'wdt_enable':
  ixp4xx_wdt.c:41: error: 'wdt_lock' undeclared (first use in this
  ixp4xx_wdt.c:41: error: (Each undeclared identifier is reported only
  ixp4xx_wdt.c:41: error: for each function it appears in.)
  ixp4xx_wdt.c: In function 'wdt_disable':
  ixp4xx_wdt.c:52: error: 'wdt_lock' undeclared (first use in this
  ixp4xx_wdt.c: In function 'ixp4xx_wdt_init':
  ixp4xx_wdt.c:186: error: 'wdt_lock' undeclared (first use in this
  make[3]: *** [drivers/watchdog/ixp4xx_wdt.o] Error 1

  Reported-by: Adrian Bunk
  Signed-off-by: Adrian Bunk
  Signed-off-by: Wim Van Sebroeck

  Adrian Bunk

  2008-08-11 04:23:29 +0800  

09 Aug, 2008

1 commit

• 097d9eb53   Merge Linus' latest into master ... Browse Code »

  Conflicts:

  drivers/watchdog/at91rm9200_wdt.c
  drivers/watchdog/davinci_wdt.c
  drivers/watchdog/ep93xx_wdt.c
  drivers/watchdog/ixp2000_wdt.c
  drivers/watchdog/ixp4xx_wdt.c
  drivers/watchdog/ks8695_wdt.c
  drivers/watchdog/omap_wdt.c
  drivers/watchdog/pnx4008_wdt.c
  drivers/watchdog/sa1100_wdt.c
  drivers/watchdog/wdt285.c

  Russell King

  2008-08-09 02:18:18 +0800  

07 Aug, 2008

3 commits

• a09e64fbc   [ARM] Move include/asm-arm/arch-* to arch/arm/*/include/mach ... Browse Code »

  This just leaves include/asm-arm/plat-* to deal with.

  Signed-off-by: Russell King

  Russell King

  2008-08-07 16:55:48 +0800  
• be5097293   [ARM] Remove asm/hardware.h, use asm/arch/hardware.h instead ... Browse Code »

  Remove includes of asm/hardware.h in addition to asm/arch/hardware.h.
  Then, since asm/hardware.h only exists to include asm/arch/hardware.h,
  update everything to directly include asm/arch/hardware.h and remove
  asm/hardware.h.

  Signed-off-by: Russell King

  Russell King

  2008-08-07 16:40:08 +0800  
• 7944d3a5a   [WATCHDOG] more coding style clean-up's ... Browse Code »

  More coding style clean-up's.

  Signed-off-by: Wim Van Sebroeck

  Wim Van Sebroeck

  2008-08-07 04:19:41 +0800  

06 Aug, 2008

2 commits

• 0c06090c9   [WATCHDOG] Coding style - Indentation - part 2 ... Browse Code »

  This brings the watchdog drivers into line with coding style.
  This patch takes cares of the indentation as described in chapter 1.
  Main changes:
  * Re-structure the ioctl switch call for all drivers as follows:
  switch (cmd) {
  case WDIOC_GETSUPPORT:
  case WDIOC_GETSTATUS:
  case WDIOC_GETBOOTSTATUS:
  case WDIOC_GETTEMP:
  case WDIOC_SETOPTIONS:
  case WDIOC_KEEPALIVE:
  case WDIOC_SETTIMEOUT:
  case WDIOC_GETTIMEOUT:
  case WDIOC_GETTIMELEFT:
  default:
  }

  This to make the migration from the drivers to the uniform watchdog
  device driver easier in the future.

  Signed-off-by: Wim Van Sebroeck

  Wim Van Sebroeck

  2008-08-06 21:21:09 +0800  
• 089ab0791   [WATCHDOG] Clean-up includes ... Browse Code »

  Use #include instead of
  Use #include instead of
  Clean-up includes.

  Signed-off-by: Wim Van Sebroeck

  Wim Van Sebroeck

  2008-08-06 21:02:16 +0800  

14 Jun, 2008

1 commit

• 20d35f3e5   [WATCHDOG 22/57] ixp4xx_wdt: unlocked_ioctl ... Browse Code »

  Review and switch to unlocked_ioctl

  Signed-off-by: Alan Cox
  Signed-off-by: Wim Van Sebroeck

  Alan Cox

  2008-06-14 03:09:26 +0800  

18 Oct, 2007

1 commit

• b7e04f8c6   mv watchdog tree under drivers ... Browse Code »

  move watchdog tree from drivers/char/watchdog to drivers/watchdog.

  Signed-off-by: Wim Van Sebroeck

  Wim Van Sebroeck

  2007-10-18 18:39:03 +0800