20 Oct, 2017

1 commit

  • Since this driver checks if the return value of dma_map_sg() is minus
    or not and keeps to enable the DMAC, it may cause kernel panic when
    the dma_map_sg() returns 0. So, this patch fixes the issue.

    Reported-by: Dirk Behme
    Fixes: 2a68ea7896e3 ("mmc: renesas-sdhi: add support for R-Car Gen3 SDHI DMAC")
    Signed-off-by: Yoshihiro Shimoda
    Reviewed-by: Geert Uytterhoeven
    Acked-by: Wolfram Sang
    Signed-off-by: Ulf Hansson

    Yoshihiro Shimoda
     

30 Aug, 2017

4 commits

  • There is one SDHI instance on Gen2 which does not have the CBSY bit.
    So, turn CBSY usage into an extra flag and set it accordingly. This has
    the additional advantage that we can also set it for other incarnations
    later.

    Signed-off-by: Wolfram Sang
    Tested-by: Chris Brandt
    Reviewed-by: Simon Horman
    Signed-off-by: Ulf Hansson

    Wolfram Sang
     
  • The structure renesas_sdhi_internal_dmac_dma_ops is only passed as
    the second argument to renesas_sdhi_probe, which is const, so
    renesas_sdhi_internal_dmac_dma_ops can be const too.

    Done with the help of Coccinelle.

    Signed-off-by: Julia Lawall
    Signed-off-by: Ulf Hansson

    Julia Lawall
     
  • Provide a whitelist for Gen3 SoC ES versions for both the SYS DMAC and
    internal DMAC variants of the SDHI driver. This is to allow drivers to
    only initialise for Gen3 SoC ES versions for which they are the appropriate
    DMAC implementation. Currently internal DMAC is the appropriate
    implementation for all supported Gen3 SoC ES versions.

    Signed-off-by: Simon Horman
    Reviewed-by: Wolfram Sang
    Signed-off-by: Ulf Hansson

    Simon Horman
     
  • Add a new variant of the SDHI driver to support R-Car Gen3 with DMA via
    on-chip bus mastering. Since the DMAC is in a part of the SDHI module it
    is not suitable to be used via DMA Engine.

    Clearing of DM_CM_INFO1 after DMA thanks to Dirk Behme

    Cc: Dirk Behme
    Signed-off-by: Yoshihiro Shimoda
    Signed-off-by: Ai Kyuse
    Signed-off-by: Simon Horman
    Reviewed-by: Wolfram Sang
    Signed-off-by: Ulf Hansson

    Simon Horman