Eric Lee / smarc-fsl-linux-kernel

13 Oct, 2007

5 commits

31 Aug, 2007

1 commit

10 Jul, 2007

2 commits

12 May, 2007

2 commits

  • 1626aeb88   libata: clean up SFF init mess ... Browse Code »

    The intention of using port_mask in SFF init helpers was to eventually
    support exoctic configurations such as combination of legacy and
    native port on the same controller. This never became actually
    necessary and the related code always has been subtly broken one way
    or the other. Now that new init model is in place, there is no reason
    to make common helpers capable of handling all corner cases. Exotic
    cases can simply dealt within LLDs as necessary.

    This patch removes port_mask handling in SFF init helpers. SFF init
    helpers don't take n_ports argument and interpret it into port_mask
    anymore. All information is carried via port_info. n_ports argument
    is dropped and always two ports are allocated. LLD can tell SFF to
    skip certain port by marking it dummy. Note that SFF code has been
    treating unuvailable ports this way for a long time until recent
    breakage fix from Linus and is consistent with how other drivers
    handle with unavailable ports.

    This fixes 1-port legacy host handling still broken after the recent
    native mode fix and simplifies SFF init logic. The following changes
    are made...

    * ata_pci_init_native_host() and ata_init_legacy_host() both now try
    to initialized whatever they can and mark failed ports dummy. They
    return 0 if any port is successfully initialized.

    * ata_pci_prepare_native_host() and ata_pci_init_one() now doesn't
    take n_ports argument. All info should be specified via port_info
    array. Always two ports are allocated.

    * ata_pci_init_bmdma() exported to be used by LLDs in exotic cases.

    * port_info handling in all LLDs are standardized - all port_info
    arrays are const stack variable named ppi. Unless the second port
    is different from the first, its port_info is specified as NULL
    (tells libata that it's identical to the last non-NULL port_info).

    * pata_hpt37x/hpt3x2n: don't modify static variable directly. Make an
    on-stack copy instead as ata_piix does.

    * pata_uli: It has 4 ports instead of 2. Don't use
    ata_pci_prepare_native_host(). Allocate the host explicitly and use
    init helpers. It's simple enough.

    Signed-off-by: Tejun Heo
    Signed-off-by: Jeff Garzik

    Tejun Heo
     
  • 9666f4009   libata: reimplement suspend/resume support using sdev->manage_start_stop ... Browse Code »

    Reimplement suspend/resume support using sdev->manage_start_stop.

    * Device suspend/resume is now SCSI layer's responsibility and the
    code is simplified a lot.

    * DPM is dropped. This also simplifies code a lot. Suspend/resume
    status is port-wide now.

    * ata_scsi_device_suspend/resume() and ata_dev_ready() removed.

    * Resume now has to wait for disk to spin up before proceeding. I
    couldn't find easy way out as libata is in EH waiting for the
    disk to be ready and sd is waiting for EH to complete to issue
    START_STOP.

    * sdev->manage_start_stop is set to 1 in ata_scsi_slave_config().
    This fixes spindown on shutdown and suspend-to-disk.

    Signed-off-by: Tejun Heo
    Signed-off-by: Jeff Garzik

    Tejun Heo
     

01 May, 2007

1 commit

  • d4b2bab4f   libata: add deadline support to prereset and reset methods ... Browse Code »

    Add @deadline to prereset and reset methods and make them honor it.
    ata_wait_ready() which directly takes @deadline is implemented to be
    used as the wait function. This patch is in preparation for EH timing
    improvements.

    * ata_wait_ready() never does busy sleep. It's only used from EH and
    no wait in EH is that urgent. This function also prints 'be
    patient' message automatically after 5 secs of waiting if more than
    3 secs is remaining till deadline.

    * ata_bus_post_reset() now fails with error code if any of its wait
    fails. This is important because earlier reset tries will have
    shorter timeout than the spec requires. If a device fails to
    respond before the short timeout, reset should be retried with
    longer timeout rather than silently ignoring the device.

    There are three behavior differences.

    1. Timeout is applied to both devices at once, not separately. This
    is more consistent with what the spec says.

    2. When a device passes devchk but fails to become ready before
    deadline. Previouly, post_reset would just succeed and let
    device classification remove the device. New code fails the
    reset thus causing reset retry. After a few times, EH will give
    up disabling the port.

    3. When slave device passes devchk but fails to become accessible
    (TF-wise) after reset. Original code disables dev1 after 30s
    timeout and continues as if the device doesn't exist, while the
    patched code fails reset. When this happens, new code fails
    reset on whole port rather than proceeding with only the primary
    device.

    If the failing device is suffering transient problems, new code
    retries reset which is a better behavior. If the failing device is
    actually broken, the net effect is identical to it, but not to the
    other device sharing the channel. In the previous code, reset would
    have succeeded after 30s thus detecting the working one. In the new
    code, reset fails and whole port gets disabled. IMO, it's a
    pathological case anyway (broken device sharing bus with working
    one) and doesn't really matter.

    * ata_bus_softreset() is changed to return error code from
    ata_bus_post_reset(). It used to return 0 unconditionally.

    * Spin up waiting is to be removed and not converted to honor
    deadline.

    * To be on the safe side, deadline is set to 40s for the time being.

    Signed-off-by: Tejun Heo
    Signed-off-by: Jeff Garzik

    Tejun Heo
     

29 Apr, 2007

1 commit

03 Mar, 2007

1 commit

10 Feb, 2007

3 commits

  • 246ce3b67   libata: add another IRQ calls (libata drivers) ... Browse Code »

    This patch is against each libata driver.

    Two IRQ calls are added in ata_port_operations.
    - irq_on() is used to enable interrupts.
    - irq_ack() is used to acknowledge a device interrupt.

    In most drivers, ata_irq_on() and ata_irq_ack() are used for
    irq_on and irq_ack respectively.

    In some drivers (ex: ahci, sata_sil24) which cannot use them
    as is, ata_dummy_irq_on() and ata_dummy_irq_ack() are used.

    Signed-off-by: Kou Ishizaki
    Signed-off-by: Akira Iguchi
    Signed-off-by: Jeff Garzik

    Akira Iguchi
     
  • 0d5ff5667   libata: convert to iomap ... Browse Code »

    Convert libata core layer and LLDs to use iomap.

    * managed iomap is used. Pointer to pcim_iomap_table() is cached at
    host->iomap and used through out LLDs. This basically replaces
    host->mmio_base.

    * if possible, pcim_iomap_regions() is used

    Most iomap operation conversions are taken from Jeff Garzik
    's iomap branch.

    Signed-off-by: Tejun Heo
    Signed-off-by: Jeff Garzik

    Tejun Heo
     
  • 24dc5f33e   libata: update libata LLDs to use devres ... Browse Code »

    Update libata LLDs to use devres. Core layer is already converted to
    support managed LLDs. This patch simplifies initialization and fixes
    many resource related bugs in init failure and detach path. For
    example, all converted drivers now handle ata_device_add() failure
    gracefully without excessive resource rollback code.

    As most resources are released automatically on driver detach, many
    drivers don't need or can do with much simpler ->{port|host}_stop().
    In general, stop callbacks are need iff port or host needs to be given
    commands to shut it down. Note that freezing is enough in many cases
    and ports are automatically frozen before being detached.

    Signed-off-by: Tejun Heo
    Signed-off-by: Jeff Garzik

    Tejun Heo
     

03 Feb, 2007

1 commit

03 Dec, 2006

1 commit

02 Dec, 2006

1 commit

  • 30ced0f0d   [PATCH] PATA libata: suspend/resume simple cases ... Browse Code »

    This patch adds the suspend/resume callbacks for drivers which don't need
    any additional help (beyond the pci resume quirk patch I posted earlier
    anyway). Also bring version numbers back inline with master copies.

    Signed-off-by: Alan Cox
    Signed-off-by: Jeff Garzik

    Alan
     

29 Nov, 2006

1 commit

29 Sep, 2006

1 commit

27 Sep, 2006

2 commits

30 Aug, 2006

1 commit