Eric Lee / smarc-fsl-linux-kernel

11 Oct, 2007

1 commit

18 Jul, 2007

1 commit

  • 75a69ac6d   [IrDA]: Fix IrDA build failure ... Browse Code »

    When having built-in IrDA, we hit the following error:

    `irda_sysctl_unregister' referenced in section `.init.text' of
    net/built-in.o: defined in discarded section `.exit.text' of
    net/built-in.o
    `irda_proc_unregister' referenced in section `.init.text' of
    net/built-in.o: defined in discarded section `.exit.text' of
    net/built-in.o
    `irsock_cleanup' referenced in section `.init.text' of net/built-in.o:
    defined in discarded section `.exit.text' of net/built-in.o
    `irttp_cleanup' referenced in section `.init.text' of net/built-in.o:
    defined in discarded section `.exit.text' of net/built-in.o
    `iriap_cleanup' referenced in section `.init.text' of net/built-in.o:
    defined in discarded section `.exit.text' of net/built-in.o
    `irda_device_cleanup' referenced in section `.init.text' of
    net/built-in.o: defined in discarded section `.exit.text' of
    net/built-in.o
    `irlap_cleanup' referenced in section `.init.text' of net/built-in.o:
    defined in discarded section `.exit.text' of net/built-in.o
    `irlmp_cleanup' referenced in section `.init.text' of net/built-in.o:
    defined in discarded section `.exit.text' of net/built-in.o
    make[1]: *** [.tmp_vmlinux1] Error 1
    make: *** [_all] Error 2

    This is due to the irda_init fix recently added, where we call __exit
    routines from an __init one. It is a build failure that I didn't catch
    because it doesn't show up when building IrDA as a module. My apologies
    for that.
    The following patch fixes that failure and is against your net-2.6
    tree. I hope it can make it to the merge window, and stable@kernel.org
    is CCed on this mail.

    Signed-off-by: Samuel Ortiz
    Signed-off-by: David S. Miller

    Samuel Ortiz
     

11 Jul, 2007

1 commit

13 Feb, 2007

1 commit

  • da7071d7e   [PATCH] mark struct file_operations const 8 ... Browse Code »

    Many struct file_operations in the kernel can be "const". Marking them const
    moves these to the .rodata section, which avoids false sharing with potential
    dirty data. In addition it'll catch accidental writes at compile time to
    these shared resources.

    Signed-off-by: Arjan van de Ven
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arjan van de Ven
     

11 Feb, 2007

1 commit

03 Dec, 2006

1 commit

22 Nov, 2006

1 commit

  • 700f9672c   [IRDA]: Lockdep fix. ... Browse Code »

    On Sat, 2006-11-18 at 16:12 +0300, Andrey Borzenkov wrote:

    > =============================================
    > [ INFO: possible recursive locking detected ]
    > 2.6.19-rc5-2avb #2
    > - ---------------------------------------------
    > pppd/26425 is trying to acquire lock:
    > (&hashbin->hb_spinlock){....}, at: [] irlmp_slsap_inuse+0x5a/0x170
    > [irda]
    >
    > but task is already holding lock:
    > (&hashbin->hb_spinlock){....}, at: [] irlmp_slsap_inuse+0x37/0x170
    > [irda]
    >
    > other info that might help us debug this:
    > 1 lock held by pppd/26425:
    > #0: (&hashbin->hb_spinlock){....}, at: []
    > irlmp_slsap_inuse+0x37/0x170 [irda]
    >
    > stack backtrace:
    > [] dump_trace+0x1cc/0x200
    > [] show_trace_log_lvl+0x1a/0x30
    > [] show_trace+0x12/0x20
    > [] dump_stack+0x19/0x20
    > [] __lock_acquire+0x8fa/0xc20
    > [] lock_acquire+0x5d/0x80
    > [] _spin_lock+0x2c/0x40
    > [] irlmp_slsap_inuse+0x5a/0x170 [irda]
    > [] irlmp_open_lsap+0x62/0x180 [irda]
    > [] irttp_open_tsap+0x181/0x230 [irda]
    > [] ircomm_open_tsap+0x5d/0xa0 [ircomm]
    > [] ircomm_open+0xb8/0xd0 [ircomm]
    > [] ircomm_tty_open+0x4f7/0x570 [ircomm_tty]
    > [] tty_open+0x174/0x340
    > [] chrdev_open+0x89/0x170
    > [] __dentry_open+0xa6/0x1d0
    > [] nameidata_to_filp+0x35/0x40
    > [] do_filp_open+0x49/0x50
    > [] do_sys_open+0x47/0xd0
    > [] sys_open+0x1c/0x20
    > [] sysenter_past_esp+0x56/0x8d
    > [] 0xb7f86410
    > =======================

    The comment at the nesting lock says:

    /* Careful for priority inversions here !
    * irlmp->links is never taken while another IrDA
    * spinlock is held, so we are safe. Jean II */

    So, under the assumption the author was right, it just needs a lockdep
    annotation.

    Signed-off-by: Peter Zijlstra
    Acked-by: Ingo Molnar
    Signed-off-by: Andrew Morton
    Signed-off-by: David S. Miller

    Peter Zijlstra
     

29 Sep, 2006

1 commit

22 Jul, 2006

2 commits

01 Jul, 2006

1 commit

18 Jun, 2006

1 commit

30 Aug, 2005

1 commit

  • bf73d1c5d   [IRDA]: Possible cleanups. ... Browse Code »

    This patch contains the following possible cleanups:

    - make the following needlessly global function static:
    - irnet/irnet_ppp.c: irnet_init

    - remove the following unneeded EXPORT_SYMBOL's:
    - irlmp.c: sysctl_discovery_timeout
    - irlmp.c: irlmp_reasons
    - irlmp.c: irlmp_dup
    - irqueue.c: hashbin_find_next

    Signed-off-by: Adrian Bunk
    Signed-off-by: Andrew Morton
    Signed-off-by: David S. Miller

    Adrian Bunk
     

17 Apr, 2005

1 commit

  • 1da177e4c   Linux-2.6.12-rc2 ... Browse Code »

    Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds