21 Sep, 2015
1 commit
-
When a read delegation is being recalled, and we're reclaiming the
cached opens, we need to make sure that we only reclaim read-only
modes.
A previous attempt to do this, relied on retrieving the delegation
type from the nfs4_opendata structure. Unfortunately, as Kinglong
pointed out, this field can only be set when performing reboot recovery.Furthermore, if we call nfs4_open_recover(), then we end up clobbering
the state->flags for all modes that we're not recovering...The fix is to have the delegation recall code pass this information
to the recovery call, and then refactor the recovery code so that
nfs4_open_delegation_recall() does not need to call nfs4_open_recover().Reported-by: Kinglong Mee
Fixes: 39f897fdbd46 ("NFSv4: When returning a delegation, don't...")
Tested-by: Kinglong Mee
Cc: NeilBrown
Cc: stable@vger.kernel.org # v4.2+
Signed-off-by: Trond Myklebust
08 Sep, 2015
2 commits
-
The NFSv4 delegation spec allows the server to tell a client to limit how
much data it cache after the file is closed. In return, the server
guarantees enough free space to avoid ENOSPC situations, etc.
Prior to this patch, we assumed we could always cache aggressively after
close. Unfortunately, this causes problems with servers that set the
limit to 0 and therefore do not offer any ENOSPC guarantees.Signed-off-by: Trond Myklebust
-
Since we're tracking modifications to the page cache on a per-page
basis, it makes sense to express the limit to how much we may cache
in units of pages.Signed-off-by: Trond Myklebust
13 Nov, 2014
1 commit
-
Any attempt to call nfs_remove_bad_delegation() while a delegation is being
returned is currently a no-op. This means that we can end up looping
forever in nfs_end_delegation_return() if something causes the delegation
to be revoked.
This patch adds a mechanism whereby the state recovery code can communicate
to the delegation return code that the delegation is no longer valid and
that it should not be used when reclaiming state.
It also changes the return value for nfs4_handle_delegation_recall_error()
to ensure that nfs_end_delegation_return() does not reattempt the lock
reclaim before state recovery is done.http://lkml.kernel.org/r/CAN-5tyHwG=Cn2Q9KsHWadewjpTTy_K26ee+UnSvHvG4192p-Xw@mail.gmail.com
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust
13 Jul, 2014
1 commit
-
Signed-off-by: Peng Tao
Signed-off-by: Trond Myklebust
06 Apr, 2013
3 commits
-
Signed-off-by: Trond Myklebust
-
Currently, if the application that holds the file open isn't doing
I/O, we may end up returning the delegation. This means that we can
no longer cache the file as aggressively, and often also that we
multiply the state that both the server and the client needs to track.This patch adds a check for open files to the routine that scans
for delegations that are unreferenced.Signed-off-by: Trond Myklebust
-
Unify the error handling in nfs4_open_delegation_recall and
nfs4_lock_delegation_recall.Signed-off-by: Trond Myklebust
12 Feb, 2013
1 commit
-
If the server reboots while we are converting a delegation into
OPEN/LOCK stateids as part of a delegation return, the current code
will simply exit with an error. This causes us to lose both
delegation state and locking state (i.e. locking atomicity).Deal with this by exposing the delegation stateid during delegation
return, so that we can recover the delegation, and then resume
open/lock recovery.Note that not having to hold the nfs_inode->rwsem across the
calls to nfs_delegation_claim_opens() also fixes a deadlock against
the NFSv4.1 reboot recovery code.Signed-off-by: Trond Myklebust
31 Jul, 2012
1 commit
-
This patch exports symbols needed by the v4 module. In addition, I also
switch over to using IS_ENABLED() to check if CONFIG_NFS_V4 or
CONFIG_NFS_V4_MODULE are set.The module (nfs4.ko) will be created in the same directory as nfs.ko and
will be automatically loaded the first time you try to mount over NFS v4.Signed-off-by: Bryan Schumaker
Signed-off-by: Trond Myklebust
29 Jun, 2012
3 commits
-
Delegations are a v4 feature, so push return_delegation out of the
generic client by creating a new rpc_op and renaming the old function to
be in the nfs v4 "namespace"Signed-off-by: Bryan Schumaker
Signed-off-by: Trond Myklebust -
Delegations are a v4 feature, so push them out of the generic code.
Signed-off-by: Bryan Schumaker
Signed-off-by: Trond Myklebust -
I can use this function to return delegations and unset the pnfs layout
driver rather than continuing to do these things in the generic client.
With this change, we no longer need an nfs4_kill_super().Signed-off-by: Bryan Schumaker
Signed-off-by: Trond Myklebust
09 May, 2012
1 commit
-
The assumption is that if you are in a situation where you need to
return the delegation, then you should probably stop caching the
data anyway.Signed-off-by: Trond Myklebust
11 Mar, 2012
1 commit
-
When the NFSv4.0 server tells us that it can no-longer talk to us
on the callback channel, we should attempt a new SETCLIENTID in
order to re-transmit the callback channel information.Note that as long as we do not change the boot verifier, this is
a safe procedure; the server is required to keep our state.Also move the function nfs_handle_cb_pathdown to fs/nfs/nfs4state.c,
and change the name in order to mark it as being specific to NFSv4.0.Signed-off-by: Trond Myklebust
09 Mar, 2012
1 commit
-
The server will just return an NFS4ERR_OPENMODE anyway.
Signed-off-by: Trond Myklebust
06 Mar, 2012
1 commit
-
If we know that the delegation stateid is bad or revoked, we need to
remove that delegation as soon as possible, and then mark all the
stateids that relied on that delegation for recovery. We cannot use
the delegation as part of the recovery process.Also note that NFSv4.1 uses a different error code (NFS4ERR_DELEG_REVOKED)
to indicate that the delegation was revoked.Finally, ensure that setlk() and setattr() can both recover safely from
a revoked delegation.Signed-off-by: Trond Myklebust
Cc: stable@vger.kernel.org
07 Jan, 2011
1 commit
-
Delegations are per-inode, not per-nfs_client. When a server file
system is migrated, delegations on the client must be moved from the
source to the destination nfs_server. Make it easier to manage a
mount point's delegation list across a migration event by moving the
list to the nfs_server struct.Clean up: I added documenting comments to public functions I changed
in this patch. For consistency I added comments to all the other
public functions in fs/nfs/delegation.c.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust
23 Jun, 2010
1 commit
-
Signed-off-by: Trond Myklebust
11 Mar, 2010
1 commit
-
If the NFS_INO_REVAL_FORCED flag is set, that means that we don't yet have
an up to date attribute cache. Even if we hold a delegation, we must
put a GETATTR on the wire.Signed-off-by: Trond Myklebust
Cc: stable@kernel.org
06 Dec, 2009
2 commits
-
in NFSv4.1 the seqid part of a stateid in CB_RECALL must be 0
Signed-off-by: Alexandros Batsakis
Signed-off-by: Trond Myklebust -
For now the clients returns _all_ the delegations of the specificed type
it holdsSigned-off-by: Alexandros Batsakis
Signed-off-by: Trond Myklebust
03 Dec, 2009
1 commit
-
The nfsv4 state manager could potentially deadlock inside
__nfs_inode_return_delegation() if the server reboots, so that the calls to
nfs_msync_inode() end up waiting on state recovery to complete.Also ensure that if a server reboot or network partition causes us to have
to stop returning delegations, that NFS4CLNT_DELEGRETURN is set so that
the state manager can resume any outstanding delegation returns after it
has dealt with the state recovery situation.Finally, ensure that the state manager doesn't wait for the DELEGRETURN
call to complete. It doesn't need to, and that too can cause a deadlock.Signed-off-by: Trond Myklebust
24 Dec, 2008
6 commits
-
Signed-off-by: Trond Myklebust
-
If the client is not using a delegation, the right thing to do is to return
it as soon as possible. This helps reduce the amount of state the server
has to track, as well as reducing the potential for conflicts with other
clients.Signed-off-by: Trond Myklebust
-
Add a delegation cleanup phase to the state management loop, and do the
NFS4ERR_CB_PATH_DOWN recovery there.Signed-off-by: Trond Myklebust
-
Add a flag to mark delegations as requiring return, then run a garbage
collector. In the future, this will allow for more flexible delegation
management, where delegations may be marked for return if it turns out
that they are not being referenced.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
When we can update_open_stateid(), we need to be certain that we don't
race with a delegation return. While we could do this by grabbing the
nfs_client->cl_lock, a dedicated spin lock in the delegation structure
will scale better.Signed-off-by: Trond Myklebust
30 Jan, 2008
1 commit
-
Otherwise, there is a potential deadlock if the last dput() from an NFSv4
close() or other asynchronous operation leads to nfs_clear_inode calling
the synchronous delegreturn.Signed-off-by: Trond Myklebust
11 Jul, 2007
4 commits
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
There appear to be some rogue servers out there that issue multiple
delegations with different stateids for the same file. Ensure that when we
return delegations, we do so on a per-stateid basis rather than a per-file
basis.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
23 Sep, 2006
1 commit
-
Rename struct nfs4_client to struct nfs_client so that it can become the basis
for a general client record for NFS2 and NFS3 in addition to NFS4.Signed-Off-By: David Howells
Signed-off-by: Trond Myklebust
21 Mar, 2006
1 commit
-
In the case where we hold a delegation stateid, use that in for inside
SETATTR calls.Signed-off-by: Trond Myklebust
07 Jan, 2006
2 commits
-
According to RFC3530 we're supposed to cache the change attribute
at the time the client receives a write delegation.
If the inode is clean, a CB_GETATTR callback by the server to the
client is supposed to return the cached change attribute.
If, OTOH, the inode is dirty, the client should bump the cached
change attribute by 1.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
05 Nov, 2005
1 commit
-
Delegations allow us to cache posix and BSD locks, however when the
delegation is recalled, we need to "flush the cache" and send
the cached LOCK requests to the server.This patch sets up the mechanism for doing so.
Signed-off-by: Trond Myklebust
19 Oct, 2005
1 commit
-
Signed-off-by: Trond Myklebust