25 Jan, 2016
1 commit
-
Hook the callback channel into the same session management machinery
as we use for the forward channel.Signed-off-by: Trond Myklebust
19 Feb, 2015
1 commit
-
If the server doesn't agree to out backchannel setup request, then
don't set one up.Signed-off-by: Trond Myklebust
02 Feb, 2014
1 commit
-
There may still be timers active on the session waitqueues. Make sure
that we kill them before freeing the memory.Cc: stable@vger.kernel.org # 3.12+
Signed-off-by: Trond Myklebust
05 Sep, 2013
1 commit
-
linux/fs/nfs/nfs4session.c:337:6: warning:
symbol 'nfs41_set_target_slotid' was not declared. Should it be static?Move nfs41_set_target_slotid() and nfs41_update_target_slotid() back
behind CONFIG_NFS_V4_1, since, in the final revision of this work,
they are used only in NFSv4.1 and later.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust
04 Sep, 2013
4 commits
-
The nfs4_destroy_slot_tables() function is renamed to avoid
confusion with the new helper.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
I'd like to re-use NFSv4.1's slot table machinery for NFSv4.0
transport blocking. Re-organize some of nfs4session.c so the slot
table code is built even when NFS_V4_1 is disabled.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust -
Clean up, since slot and sequence numbers are all unsigned anyway.
Among other things, squelch compiler warnings:
linux/fs/nfs/nfs4proc.c: In function ‘nfs4_setup_sequence’:
linux/fs/nfs/nfs4proc.c:703:2: warning: signed and unsigned type in
conditional expression [-Wsign-compare]and
linux/fs/nfs/nfs4session.c: In function ‘nfs4_alloc_slot’:
linux/fs/nfs/nfs4session.c:151:31: warning: signed and unsigned type in
conditional expression [-Wsign-compare]Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust
08 Aug, 2013
1 commit
-
Never try to use a non-UID 0 user credential for lease management,
as that credential can change out from under us. The server will
block NFSv4 lease recovery with NFS4ERR_CLID_INUSE.Since the mechanism to acquire a credential for lease management
is now the same for all minor versions, replace the minor version-
specific callout with a single function.Signed-off-by: Chuck Lever
Signed-off-by: Trond Myklebust
29 Jun, 2013
1 commit
-
nfs4_init_session was originally written to be called prior to
nfs4_init_channel_attrs, setting the session target_max response and request
sizes that nfs4_init_channel_attrs would pay attention to.In the current code flow, nfs4_init_session, just like nfs4_init_ds_session
for the data server case, is called after the session is all negotiated, and
is actually used in a RECLAIM COMPLETE call to the server.Remove the un-needed fc_target_max response and request fields from
nfs4_session and just set the max_resp_sz and max_rqst_sz in
nfs4_init_channel_attrs.Signed-off-by: Andy Adamson
Signed-off-by: Trond Myklebust
21 May, 2013
1 commit
-
On a CB_RECALL the callback service thread flushes the inode using
filemap_flush prior to scheduling the state manager thread to return the
delegation. When pNFS is used and I/O has not yet gone to the data server
servicing the inode, a LAYOUTGET can preceed the I/O. Unlike the async
filemap_flush call, the LAYOUTGET must proceed to completion.If the state manager starts to recover data while the inode flush is sending
the LAYOUTGET, a deadlock occurs as the callback service thread holds the
single callback session slot until the flushing is done which blocks the state
manager thread, and the state manager thread has set the session draining bit
which puts the inode flush LAYOUTGET RPC to sleep on the forechannel slot
table waitq.Separate the draining of the back channel from the draining of the fore channel
by moving the NFS4_SESSION_DRAINING bit from session scope into the fore
and back slot tables. Drain the back channel first allowing the LAYOUTGET
call to proceed (and fail) so the callback service thread frees the callback
slot. Then proceed with draining the forechannel.Signed-off-by: Andy Adamson
Signed-off-by: Trond Myklebust
16 Dec, 2012
2 commits
-
If an RPC call is interrupted, assume that the server hasn't processed
the RPC call so that the next time we use the slot, we know that if we
get a NFS4ERR_SEQ_MISORDERED or NFS4ERR_SEQ_FALSE_RETRY, we just have
to bump the sequence number.Signed-off-by: Trond Myklebust
-
Shave a few bytes off the slot table size by moving the RPC timestamp
into the sequence results.Signed-off-by: Trond Myklebust
12 Dec, 2012
1 commit
-
If the server sends us a target that looks like an outlier, but
is lower than the existing target, then respect it anyway.
However defer actually updating the generation counter until
we get a target that doesn't look like an outlier.Signed-off-by: Trond Myklebust
06 Dec, 2012
3 commits
-
Look for sudden changes in the first and second derivatives in order
to eliminate outlier changes to target_highest_slotid (which are
due to out-of-order RPC replies).Signed-off-by: Trond Myklebust
-
Currently, we see a lot of bouncing for the value of highest_used_slotid
due to the fact that slots are getting freed, instead of getting instantly
transmitted to the next waiting task.Signed-off-by: Trond Myklebust
-
NFSv4.1 session management is getting complex enough to deserve
a separate file.Signed-off-by: Trond Myklebust