26 Mar, 2016
4 commits
-
Error should only be returned if nothing had been read/written.
Otherwise we need to report a short read/write instead.Signed-off-by: Al Viro
Signed-off-by: Mike Marshall -
a) open files can't have NULL inodes
b) it's SEEK_END, not ORANGEFS_SEEK_END; no need to get cute.
c) make_bad_inode() on lseek()?Signed-off-by: Al Viro
Signed-off-by: Mike Marshall -
just have it return the slot number or -E... - the caller checks
the sign anywaySigned-off-by: Al Viro
Signed-off-by: Mike Marshall -
it's always __orangefs_bufmap
Signed-off-by: Al Viro
Signed-off-by: Mike Marshall
24 Mar, 2016
2 commits
-
Signed-off-by: Martin Brandenburg
Signed-off-by: Mike Marshall -
This is motivated by orangefs_inode_old_getattr's habit of writing over
live inodes.Signed-off-by: Martin Brandenburg
Signed-off-by: Mike Marshall
10 Mar, 2016
1 commit
-
Don't return EINTR on interrupted writes if some data has already
been written.Signed-off-by: Mike Marshall
04 Mar, 2016
1 commit
-
Signed-off-by: Mike Marshall
25 Feb, 2016
1 commit
-
I have verified that there is nothing in the userspace daemon version we
are implementing this protocol against that ever looks at this field.Signed-off-by: Martin Brandenburg
Signed-off-by: Mike Marshall
20 Feb, 2016
2 commits
-
shouldn't be needed now
Signed-off-by: Al Viro
Signed-off-by: Mike Marshall -
Make cancels reuse the aborted read/write op, to make sure they do not
fail on lack of memory.Don't issue a cancel unless the daemon has seen our read/write, has not
replied and isn't being shut down.If cancel *is* issued, don't wait for it to complete; stash the slot
in there and just have it freed when cancel is finally replied to or
purged (and delay dropping the reference until then, obviously).Signed-off-by: Al Viro
Signed-off-by: Mike Marshall
13 Feb, 2016
4 commits
-
it's always equal to __orangefs_bufmap and the latter can't change
until we are doneSigned-off-by: Al Viro
Signed-off-by: Mike Marshall -
the second caller never needs to cancel, actually
Signed-off-by: Al Viro
Signed-off-by: Mike Marshall -
Signed-off-by: Al Viro
Signed-off-by: Mike Marshall -
Signed-off-by: Al Viro
Signed-off-by: Mike Marshall
05 Feb, 2016
1 commit
-
Signed-off-by: Mike Marshall
29 Jan, 2016
1 commit
-
Previously, it would update a live inode. This was fixed, but it did not
ever check that the inode attributes in the dcache are correct. This
checks all inode attributes and rejects any that are not correct, which
causes a lookup and thus a new getattr.Perhaps inode_operations->permission should replace or augment some of
this.There is no actual caching, and this does a rather excessive amount of
network operations back to the filesystem server.Signed-off-by: Martin Brandenburg
Signed-off-by: Mike Marshall
24 Jan, 2016
3 commits
-
Signed-off-by: Al Viro
Signed-off-by: Mike Marshall -
Signed-off-by: Al Viro
Signed-off-by: Mike Marshall -
* create with refcount 1
* make op_release() decrement and free if zero (i.e. old put_op()
has become that).
* mark when submitter has given up waiting; from that point nobody
else can move between the lists, change state, etc.
* have daemon read/write_iter grab a reference when picking op
and *always* give it up in the end
* don't put into hash until we know it's been successfully passed to
daemon* move op->lock _lower_ than htab_in_progress_lock (and make sure
to take it in purge_inprogress_ops())Signed-off-by: Al Viro
Signed-off-by: Mike Marshall
05 Dec, 2015
1 commit
-
Also changed references within source files that referred to
header files whose names had changed.Signed-off-by: Mike Marshall
04 Dec, 2015
1 commit
-
OrangeFS was formerly known as PVFS2 and retains the name in many places.
I leave the device /dev/pvfs2-req since this affects userspace.
I leave the filesystem type pvfs2 since this affects userspace. Further
the OrangeFS sysint library reads fstab for an entry of type pvfs2
independently of kernel mounts.I leave extended attribute keys user.pvfs2 and system.pvfs2 as the
sysint library understands these.I leave references to userspace binaries still named pvfs2.
I leave the filenames.
Signed-off-by: Yi Liu
[martin@omnibond.com: clairify above constraints and merge]
Signed-off-by: Martin Brandenburg
Signed-off-by: Mike Marshall
17 Nov, 2015
1 commit
-
On Wed, Nov 11, 2015 at 10:19:48AM +0000, Al Viro wrote:
> I'll cook the minimal fixup for API change after I get some sleep and
> send it your way, unless somebody gets there first...This should do it - switches ->ioctl() to pvfs2_inode_[gs]etxattr() and
converts xattr_handler ->[gs]et() to new API.Signed-off-by: Al Viro
Signed-off-by: Mike Marshall
14 Nov, 2015
7 commits
-
if we are appending, generic_write_checks would have updated
pos to the end of the file...Signed-off-by: Mike Marshall
-
... and make the only caller use page-backed iov_iter,
getting rid of kmap/kunmap *and* of the bug with
attempted use of iovec-backed copy_page_to_iter()
on a kernel pointer.Signed-off-by: Al Viro
Signed-off-by: Mike Marshall -
no need to build a copy of what the caller already has;
what's more, we want the one given to caller properly
advanced *and* we shouldn't depend upon it being an
iovec-backed one.Signed-off-by: Al Viro
Signed-off-by: Mike Marshall -
copy_page_{to,from}_iter() advances it just fine *and* it has no
problem with partially consumed segments.Signed-off-by: Al Viro
Signed-off-by: Mike Marshall -
incidentally, insane or compromised server returning *more* than
requested on read should not oops the kernel - initialize the
iov_iter for read according to the iovec we've got. That's why
pvfs_bufmap_copy_to_iovec() needed a separate size argument - we
shouldn't abuse iov_iter_count(iter) for passing that.Signed-off-by: Al Viro
Signed-off-by: Mike Marshall -
Signed-off-by: Al Viro
Signed-off-by: Mike Marshall -
Signed-off-by: Al Viro
Signed-off-by: Mike Marshall
13 Nov, 2015
1 commit
-
Signed-off-by: Al Viro
Signed-off-by: Mike Marshall
06 Oct, 2015
1 commit
-
Signed-off-by: Mike Marshall
03 Oct, 2015
6 commits
-
Previously the code silently failed to update the disk. Now it will not
allow writable and shared mmaps.Signed-off-by: Martin Brandenburg
Signed-off-by: Mike Marshall -
Signed-off-by: Mike Marshall
-
replace opencoded pvfs_bufmap_copy_to_kernel_iovec,
pvfs_bufmap_copy_to_user_iovec, pvfs_bufmap_copy_iovec_from_kernel,
and pvfs_bufmap_copy_iovec_from_user with pvfs_bufmap_copy_to_iovec
and pvfs_bufmap_copy_from_iovec, which both use the iov_iter
interface.Signed-off-by: Mike Marshall
-
Don't check for negative rc from boolean.
Don't pointlessly initialize variables, it short-circuits
gcc's uninitialized variable warnings. And max_new_nr_segs
can never be zero, so don't check for it.Preserve original kstrdup pointer for freeing later.
Don't check for negative value in unsigned variable.
Signed-off-by: Mike Marshall
-
Signed-off-by: Mike Marshall
-
Signed-off-by: Mike Marshall