22 Feb, 2011
1 commit
-
The current code does not follow Intel documentation: It misses some things
and does other, undocumented things. This causes wrong backlight values in
certain conditions. Instead of adding tricky code handling badly documented
and rare corner cases, don't handle combination mode specially at all. This
way PCI_LBPC is never touched and weird things shouldn't happen.If combination mode is enabled, then the only downside is that changing the
brightness has a greater granularity (the LBPC value), but LBPC is at most
254 and the maximum is in the thousands, so this is no real functional loss.A potential problem with not handling combined mode is that a brightness of
max * PCI_LBPC is not bright enough. However, this is very unlikely because
from the documentation LBPC seems to act as a scaling factor and doesn't look
like it's supposed to be changed after boot. The value at boot should always
result in a bright enough screen.IMPORTANT: However, although usually the above is true, it may not be when
people ran an older (2.6.37) kernel which messed up the LBPC register, and
they are unlucky enough to have a BIOS that saves and restores the LBPC value.
Then a good kernel may seem to not work: Max brightness isn't bright enough.
If this happens people should boot back into the old kernel, set brightness
to the maximum, and then reboot. After that everything should be fine.For more information see the below links. This fixes bugs:
http://bugzilla.kernel.org/show_bug.cgi?id=23472
http://bugzilla.kernel.org/show_bug.cgi?id=25072Signed-off-by: Indan Zupancic
Tested-by: Alex Riesen
Signed-off-by: Linus Torvalds
17 Feb, 2011
10 commits
-
* 'nouveau/drm-nouveau-next' of /ssd/git/drm-nouveau-next:
drm/nouveau: fix suspend/resume on GPUs that don't have PM support
drm/nouveau: flips/flipd need to always set 'evict' for move_accel_cleanup()
drm/nv40: fix tiling-related setup for a number of chipsets
drm/nouveau: fix non-EDIDful native mode selection
drm/nouveau: Fix detection of DDC-based LVDS on DCB15 boards.
drm/nv04-nv40: Fix NULL dereference when we fail to find an LVDS native mode.
drm/nv10: Fix crash when allocating a BO larger than half the available VRAM. -
The fixed ref/post dividers are set by the AdjustPll table
rather than the ss info table on dce4+. Make sure we enable
the fractional feedback dividers when using a fixed post
or ref divider on them as well.Fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=29272Signed-off-by: Alex Deucher
Cc: stable@kernel.org
Signed-off-by: Dave Airlie -
Signed-off-by: Marek Olšák
Signed-off-by: Dave Airlie -
This has been broken since 2.6.37, and fixes resume on a couple of fermi
boards I have access to.Signed-off-by: Ben Skeggs
-
We free the temporary binding before leaving this function, so we also have
to wait for the move to actually complete.Signed-off-by: Ben Skeggs
-
Due to the default case handling the older chipsets, a bunch of the newer
ones ended up having the wrong tiling regs used. This commit switches the
default case to handle the newest chipsets.This also makes nv4e touch the "extra" tiling regs. "nv" doesn't touch
them for C51 but traces of the NVIDIA binary driver show it being done
there.I couldn't find NV41/NV45 traces to confirm the behaviour there, but an
educated guess was taken at each of them.Signed-off-by: Ben Skeggs
-
The DRM core fills this value, but at too late a stage for this to work,
possibly resulting in an undesirable mode being selected.Signed-off-by: Ben Skeggs
-
Signed-off-by: Francisco Jerez
Signed-off-by: Ben Skeggs -
Reported-by: Alex Buell
Signed-off-by: Francisco Jerez
Signed-off-by: Ben Skeggs -
Reported-by: Alex Buell
Signed-off-by: Francisco Jerez
Signed-off-by: Ben Skeggs
15 Feb, 2011
3 commits
-
The problematic boards have a recommended reference divider
to be used when spread spectrum is enabled on the laptop panel.
Enable the use of the recommended reference divider along with
the new pll algo.v2: testing options
v3: When using the fixed reference divider with LVDS, prefer
min m to max p and use fractional feedback dividers.Fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=28852
https://bugzilla.kernel.org/show_bug.cgi?id=24462
https://bugzilla.kernel.org/show_bug.cgi?id=26552
MacbookPro issues reported by Justin MattockSigned-off-by: Alex Deucher
Cc: stable@kernel.org
Signed-off-by: Dave Airlie -
Prevent divider overflow.
Fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=28932Signed-off-by: Alex Deucher
Cc: stable@kernel.org
Signed-off-by: Dave Airlie -
Signed-off-by: Alex Deucher
Signed-off-by: Dave Airlie
14 Feb, 2011
17 commits
-
* 'intel/drm-intel-fixes' of /ssd/git/drm-next:
drm/i915: Fix resume regression from 5d1d0cc
drm/i915/tv: Use polling rather than interrupt-based hotplug
drm/i915: Trigger modesetting if force-audio changes
drm/i915/sdvo: If we have an EDID confirm it matches the mode of the connection
drm/i915: Disable RC6 on Ironlake
drm/i915/lvds: Restore dithering on native modes for gen2/3
drm/i915: Invalidate TLB caches on SNB BLT/BSD rings -
Makes debugging CS rejections much easier.
Signed-off-by: Alex Deucher
Cc: stable@kernel.org
Signed-off-by: Dave Airlie -
This is an important security fix because we allowed arbitrary values
to be passed to AARESOLVE_OFFSET. This also puts the right buffer address
in the register.Signed-off-by: Marek Olšák
Signed-off-by: Dave Airlie -
Also move ZB_DEPTHCLEARVALUE to the list of safe regs.
Signed-off-by: Marek Olšák
Signed-off-by: Dave Airlie -
Not only is linear aligned supposedly more performant,
linear general is only supported by the CB in single
slice mode. The texture hardware doesn't support
linear general, but I think the hw automatically
upgrades it to linear aligned.Signed-off-by: Alex Deucher
Signed-off-by: Dave Airlie -
Not only is linear aligned supposedly more performant,
linear general is only supported by the CB in single
slice mode. The texture hardware doesn't support
linear general, but I think the hw automatically
upgrades it to linear aligned.Signed-off-by: Alex Deucher
Signed-off-by: Dave Airlie -
My evergreen has been in a remote PC for week and reset has never once
saved me from certain doom, I finally relocated to the box with a
serial cable and noticed an oops when the GPU resets, and the TTM
delayed delete thread tries to remove something from the GTT.This stops the delayed delete thread from executing across the GPU
reset handler, and woot I can GPU reset now.Signed-off-by: Dave Airlie
-
Based on 6xx/7xx endian fixes from Cédric Cano.
v2: fix typo in shader
Signed-off-by: Alex Deucher
Signed-off-by: Dave Airlie -
agd5f: minor cleanups
Signed-off-by: Cédric Cano
Signed-off-by: Alex Deucher
Signed-off-by: Dave Airlie -
agd5f: additional cleanups/fixes
Signed-off-by: Cédric Cano
Signed-off-by: Alex Deucher
Signed-off-by: Dave Airlie -
agd5f: minor cleanups
Signed-off-by: Cédric Cano
Signed-off-by: Alex Deucher
Signed-off-by: Dave Airlie -
The colorbuffer, zbuffer, and texture states are checked only once when
they get changed. This improves performance in the apps which emit
lots of draw packets and few state changes.This drops performance in glxgears by a 1% or so, but glxgears is not
a benchmark we care about.
The time spent in the kernel when running Torcs dropped from 33% to 23%
and the frame rate is higher, which is a good thing.r600 might need something like this as well.
Signed-off-by: Marek Olšák
Signed-off-by: Dave Airlie -
In the continuing effort to avoid kernel addresses leaking to unprivileged
users, this patch switches to %pK for /proc/dri/*/vma.Signed-off-by: Kees Cook
Signed-off-by: Dave Airlie -
PPC Mac cards do not provide connector tables in
their vbios. Their connector/encoder configurations
must be hardcoded in the driver.verified by nyef on #radeon
Signed-off-by: Alex Deucher
Cc: stable@kernel.org
Signed-off-by: Dave Airlie -
drivers/gpu/drm/radeon/mkregtable.c:parser_auth() almost always remembers
to fclose(file) before returning, but it misses two spots.This is not really important since the process will exit shortly after and
thus close the file for us, but being explicit prevents static analysis
tools from complaining about leaked memory and missing fclose() calls and
it also seems to be the prefered style of the existing code to explicitly
close the file.So, here's a patch to add the two missing fclose() calls.
Signed-off-by: Jesper Juhl
Signed-off-by: Dave Airlie -
- set scaler table clears the interleave bit, need to
reset it in encoder quirks, this was already done for
pre-dce4.
- remove the interleave settings from set_base() functions
this is now handled in the encoder quirks functions, and
isn't technically part of the display base setup.
- rename evergreen_do_set_base() to dce4_do_set_base() since
it's used on both evergreen and NI asics.Fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=28182Signed-off-by: Alex Deucher
Cc: stable@kernel.org
Signed-off-by: Dave Airlie -
The old code dereferenced a value, the new code just needs to pass
the ptr.fixes an oops looking at files in debugfs.
cc: stable@kernel.org
Signed-off-by: Dave Airlie
11 Feb, 2011
3 commits
-
The irony of the patch to fix the resume regression on PineView causing
a further regression on Ironlake is not lost on me.Reported-by: Jeff Chua
Reported-by: Björn Schließmann
Tested-by: Björn Schließmann
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=28802
Signed-off-by: Chris Wilson -
The documentation recommends that we should use a polling method for TV
detection as this is more power efficient than the interrupt based
mechanism (as the encoder can be completely switched off). A secondary
effect is that leaving the hotplug enabled seems to be causing pipe
underruns as reported by Hugh Dickins on his Crestline.Tested-by: Hugh Dickins
Signed-off-by: Chris Wilson
[This is a candidate for stable, but needs minor porting to 2.6.37] -
If the user changes the force-audio property and it no longer reflects
the current configuration, then we need to trigger a mode set in order
to update the registers.Signed-off-by: Chris Wilson
10 Feb, 2011
2 commits
-
If we have an EDID for a digital panel, but we are probing a non-TMDS
connector then we know that this is a false detection, and vice versa.
This should reduce the number of bogus outputs on multi-function
adapters that report the same output on multiple connectors.Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=34101
Reported-by: Sebastien Caty
Tested-by: Sebastien Caty
Signed-off-by: Chris Wilson
Cc: stable@kernel.org -
The automatic powersaving feature is once again causing havoc, with 100%
reliable hangs on boot and resume on affected machines.Reported-by: Francesco Allertsen
Reported-by: Gui Rui
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=28582
Signed-off-by: Chris Wilson
06 Feb, 2011
1 commit
-
A regression introduced in bee17e5 cleared the dithering bit for native
modes on gen2/3.Bugzilla: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/711568
Signed-off-by: Chris Wilson
05 Feb, 2011
2 commits
-
* 'drm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6: (27 commits)
gpu/stub: fix acpi_video build error, fix stub kconfig dependencies
drm/radeon/kms: dynamically allocate power state space
drm/radeon/kms: fix s/r issues with bios scratch regs
agp: ensure GART has an address before enabling it
Revert "agp: AMD AGP is used on UP1100 & UP1500 alpha boxen"
amd-k7-agp: remove non-x86 code
drm/radeon/kms/evergreen: always set certain VGT regs at CP init
drm/radeon/kms: add updated ib_execute function for evergreen
drm/radeon: remove 0x4243 pci id
drm/radeon/kms: Enable new pll calculation for avivo+ asics
drm/radeon/kms: add new pll algo for avivo asics
drm/radeon/kms: add pll debugging output
drm/radeon/kms: switch back to min->max pll post divider iteration
drm/radeon/kms: rv6xx+ thermal sensor fixes
drm/nv50: fix display on 0x50
drm/nouveau: correctly pair hwmon_init and hwmon_fini
drm/i915: Only bind to function 0 of the PCI device
drm/i915: Suppress spurious vblank interrupts
drm: Avoid leak of adjusted mode along quick set_mode paths
drm: Simplify and defend later checks when disabling a crtc
... -
In drm_crtc_helper_set_config, instead of always forcing all outputs
to DRM_MODE_DPMS_ON, only set them if the CRTC is actually getting a
mode set, as any mode set will turn all outputs on.This fixes https://lkml.org/lkml/2011/1/24/457
Signed-off-by: Keith Packard
Cc: stable@kernel.org (2.6.37)
Reported-and-tested-by: Carlos R. Mafra
Tested-by: Takashi Iwai
Signed-off-by: Linus Torvalds
04 Feb, 2011
1 commit
-
The comments under "config STUB_POULSBO" are close to correct,
but they are not being followed. This patch updates them to reflect
the requirements for THERMAL.This build error is caused by STUB_POULSBO selecting ACPI_VIDEO
when ACPI_VIDEO's config requirements are not met.ERROR: "thermal_cooling_device_register" [drivers/acpi/video.ko] undefined!
ERROR: "thermal_cooling_device_unregister" [drivers/acpi/video.ko] undefined!Signed-off-by: Randy Dunlap
Tested-by: Ingo Molnar
Signed-off-by: Dave Airlie
