04 Apr, 2015
1 commit
-
Looking over the implementation for jhash2 and comparing it to jhash_3words
I realized that the two hashes were in fact very different. Doing a bit of
digging led me to "The new jhash implementation" in which lookup2 was
supposed to have been replaced with lookup3.In reviewing the patch I noticed that jhash2 had originally initialized a
and b to JHASH_GOLDENRATIO and c to initval, but after the patch a, b, and
c were initialized to initval + (length << 2) + JHASH_INITVAL. However the
changes in jhash_3words simply replaced the initialization of a and b with
JHASH_INITVAL.This change corrects what I believe was an oversight so that a, b, and c in
jhash_3words all have the same value added consisting of initval + (length
<< 2) + JHASH_INITVAL so that jhash2 and jhash_3words will now produce the
same hash result given the same inputs.Fixes: 60d509c823cca ("The new jhash implementation")
Signed-off-by: Alexander Duyck
Signed-off-by: David S. Miller
10 Dec, 2010
1 commit
-
The current jhash.h implements the lookup2() hash function by Bob Jenkins.
However, lookup2() is outdated as Bob wrote a new hash function called
lookup3(). The patch replaces the lookup2() implementation of the 'jhash*'
functions with that of lookup3().You can read a longer comparison of the two and other hash functions at
http://burtleburtle.net/bob/hash/doobs.html.Signed-off-by: Jozsef Kadlecsik
Acked-by: Rusty Russell
Signed-off-by: David S. Miller
18 Aug, 2010
1 commit
-
Fix a spelling mistake.
Signed-off-by: Anton Blanchard
Signed-off-by: Jiri Kosina
26 Apr, 2007
1 commit
-
Use const to avoid forcing users to cast const data.
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller
17 Apr, 2005
1 commit
-
Initial git repository build. I'm not bothering with the full history,
even though we have it. We can create a separate "historical" git
archive of that later if we want to, and in the meantime it's about
3.2GB when imported into git - space that would just make the early
git days unnecessarily complicated, when we don't have a lot of good
infrastructure for it.Let it rip!
