31 Dec, 2007

2 commits


14 Nov, 2007

1 commit

  • request

    In SendReceive() function in transport.c - it memcpy's
    message payload into a buffer passed via out_buf param. The function
    assumes that all buffers are of size (CIFSMaxBufSize +
    MAX_CIFS_HDR_SIZE) , unfortunately it is also called with smaller
    (MAX_CIFS_SMALL_BUFFER_SIZE) buffers. There are eight callers
    (SMB worker functions) which are primarily affected by this change:

    TreeDisconnect, uLogoff, Close, findClose, SetFileSize, SetFileTimes,
    Lock and PosixLock

    CC: Dave Kleikamp
    CC: Przemyslaw Wegrzyn
    Acked-by: Jeff Layton
    Signed-off-by: Steve French

    Steve French
     

03 Nov, 2007

1 commit

  • Also, fix the parser to recognize them and set the secType
    accordingly. Make CIFSSMBNegotiate not error out automatically
    after parsing the securityBlob.

    Also thanks to Q (Igor) and Simo for their help on this
    set of kerberos patches (and Dave Howells for help on the
    upcall).

    Signed-off-by: Jeff Layton
    Signed-off-by: Steve French

    Jeff Layton
     

27 Oct, 2007

1 commit


26 Oct, 2007

1 commit


24 Oct, 2007

1 commit


19 Oct, 2007

1 commit


18 Oct, 2007

1 commit


17 Oct, 2007

3 commits


15 Oct, 2007

1 commit


12 Oct, 2007

1 commit


05 Oct, 2007

1 commit

  • Fixes two problems:
    1) we dropped down to negotiating lanman if we did not recognize the
    mechanism (krb5 e.g.)
    2) we did not stop cifsd (thus will fail when doing rmod cifs with
    slab free errors) when we fail tcon but have a bad session (which is
    the case in which signing is required but we don't allow signing on
    the client)

    It also turns on extended security flag in the header when passing
    "sec=krb5" on mount command (although kerberos support is not done of
    course)

    Acked-by: Jeff Layton
    CC: Shaggy
    Signed-off-by: Steve French

    Steve French
     

04 Oct, 2007

1 commit


28 Sep, 2007

1 commit


26 Sep, 2007

1 commit


25 Sep, 2007

1 commit


20 Sep, 2007

1 commit


31 Aug, 2007

2 commits


19 Jul, 2007

1 commit


18 Jul, 2007

1 commit


15 Jul, 2007

1 commit

  • In the cleanup phase of the dbench test, we were noticing sharing
    violation followed by failed directory removals when dbench
    did not close the test files before the cleanup phase started.
    Using the new POSIX unlink, which Samba has supported for a few
    months, avoids this.

    Signed-off-by: Steve French

    Steve French
     

13 Jul, 2007

1 commit

  • This should be the last big batch of whitespace/formatting fixes.
    checkpatch warnings for the cifs directory are down about 90% and
    many of the remaining ones are harder to remove or make the code
    harder to read.

    Signed-off-by: Steve French

    Steve French
     

08 Jul, 2007

1 commit


07 Jul, 2007

1 commit

  • Currently, if mount with a signing-enabled sec= option (e.g.
    sec=ntlmi), the kernel does a warning printk if the server doesn't
    support signing, and then proceeds without signatures.

    This is probably OK for people that think to look at the ring buffer,
    but seems wrong to me. If someone explicitly requests signing, we
    should error out if that request can't be satisfied. They can then
    reattempt the mount without signing if that's ok.

    Signed-off-by: Jeff Layton
    Signed-off-by: Steve French

    Jeff
     

29 Jun, 2007

1 commit


06 Jun, 2007

1 commit


25 Apr, 2007

1 commit


24 Apr, 2007

1 commit


01 Mar, 2007

1 commit

  • In fixing a bug Samba 3.0.26pre allowed some clients (including Linux cifs
    client) to change file size to zero in SET_FILE_UNIX_BASIC (which Linux cifs
    client uses for chmod).

    The server has been "fixed" now but that also fixes the client to net send
    file size zero on chmod.

    Fixes Samba bugzilla bug # 4418.

    Fixed with help from Jeremy Allison

    Signed-off-by: Jeremy Allison
    Signed-off-by: Steve French

    Steve French
     

18 Feb, 2007

1 commit


14 Feb, 2007

1 commit


14 Dec, 2006

1 commit

  • Run this:

    #!/bin/sh
    for f in $(grep -Erl "\([^\)]*\) *k[cmz]alloc" *) ; do
    echo "De-casting $f..."
    perl -pi -e "s/ ?= ?\([^\)]*\) *(k[cmz]alloc) *\(/ = \1\(/" $f
    done

    And then go through and reinstate those cases where code is casting pointers
    to non-pointers.

    And then drop a few hunks which conflicted with outstanding work.

    Cc: Russell King , Ian Molton
    Cc: Mikael Starvik
    Cc: Yoshinori Sato
    Cc: Roman Zippel
    Cc: Geert Uytterhoeven
    Cc: Ralf Baechle
    Cc: Paul Mackerras
    Cc: Kyle McMartin
    Cc: Benjamin Herrenschmidt
    Cc: Martin Schwidefsky
    Cc: "David S. Miller"
    Cc: Jeff Dike
    Cc: Greg KH
    Cc: Jens Axboe
    Cc: Paul Fulghum
    Cc: Alan Cox
    Cc: Karsten Keil
    Cc: Mauro Carvalho Chehab
    Cc: Jeff Garzik
    Cc: James Bottomley
    Cc: Ian Kent
    Cc: Steven French
    Cc: David Woodhouse
    Cc: Neil Brown
    Cc: Jaroslav Kysela
    Cc: Takashi Iwai
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Robert P. J. Day
     

16 Oct, 2006

1 commit

  • * missing cpu_to_le64() for ChangeTime (introduced by
    [CIFS] Legacy time handling for Win9x and OS/2 part 1)
    * missing le16_to_cpu() for DialectIndex (introduced by
    [CIFS] Do not send newer QFSInfo to legacy servers which can not support it)

    Signed-off-by: Al Viro
    Signed-off-by: Linus Torvalds

    Al Viro
     

13 Oct, 2006

1 commit


12 Oct, 2006

1 commit


02 Oct, 2006

1 commit