31 Dec, 2007
2 commits
-
Requires cifsacl mount flag to be on and CIFS_EXPERIMENTAL enabled
CC: Shirish Pargaonkar
Signed-off-by: Steve French -
Thanks to Oleg Gvozdev for noticing the problem.
CC: Andrew Morton
Signed-off-by: Steve French
14 Nov, 2007
1 commit
-
request
In SendReceive() function in transport.c - it memcpy's
message payload into a buffer passed via out_buf param. The function
assumes that all buffers are of size (CIFSMaxBufSize +
MAX_CIFS_HDR_SIZE) , unfortunately it is also called with smaller
(MAX_CIFS_SMALL_BUFFER_SIZE) buffers. There are eight callers
(SMB worker functions) which are primarily affected by this change:TreeDisconnect, uLogoff, Close, findClose, SetFileSize, SetFileTimes,
Lock and PosixLockCC: Dave Kleikamp
CC: Przemyslaw Wegrzyn
Acked-by: Jeff Layton
Signed-off-by: Steve French
03 Nov, 2007
1 commit
-
Also, fix the parser to recognize them and set the secType
accordingly. Make CIFSSMBNegotiate not error out automatically
after parsing the securityBlob.Also thanks to Q (Igor) and Simo for their help on this
set of kerberos patches (and Dave Howells for help on the
upcall).Signed-off-by: Jeff Layton
Signed-off-by: Steve French
27 Oct, 2007
1 commit
-
Now GetACL in getinodeinfo path when cifsacl mount option used, and
ACL is parsed for SIDs. Missing only one piece now to be able
to retrieve the modeSigned-off-by: Steve French
26 Oct, 2007
1 commit
-
Acked-by: Shirish Pargaonkar
CC: Cyrill Gorcunov
Signed-off-by: Steve French
24 Oct, 2007
1 commit
-
get rid of couple of unused function warnings which
show up when CONFIG_CIFS_EXPERIMENTAL is not defined - wrap them in
#ifdef CONFIG_CIFS_EXPERIMENTAL. Patch against current git.Signed-off-by: Parag Warudkar
Signed-off-by: Steve French
19 Oct, 2007
1 commit
-
Also returns more accurate errors to mount for the cases of
account expired and password expiredAcked-by: Jeff Layton
Signed-off-by: Steve French
18 Oct, 2007
1 commit
-
Signed-off-by: Steve French
17 Oct, 2007
3 commits
-
Signed-off-by: Steve French
-
SPNEGO NegProt response also contains a server_GUID. Parse it as we
would for RawNTLMSSP.Signed-off-by: Jeff Layton
Signed-off-by: Steve French -
[CIFS] fix error message about packet signing
When packet signing is disabled and the server requires it, cifs prints
an error message. The current message refers to a file in /proc that no
longer exists. Fix it to refer to the correct file.Signed-off-by: Jeff Layton
Signed-off-by: Steve French
15 Oct, 2007
1 commit
-
Signed-off-by: Cyrill Gorcunov
Signed-off-by: Steve French
12 Oct, 2007
1 commit
-
Signed-off-by: Shirish Pargaonkar
Signed-off-by: Steve French
05 Oct, 2007
1 commit
-
Fixes two problems:
1) we dropped down to negotiating lanman if we did not recognize the
mechanism (krb5 e.g.)
2) we did not stop cifsd (thus will fail when doing rmod cifs with
slab free errors) when we fail tcon but have a bad session (which is
the case in which signing is required but we don't allow signing on
the client)It also turns on extended security flag in the header when passing
"sec=krb5" on mount command (although kerberos support is not done of
course)Acked-by: Jeff Layton
CC: Shaggy
Signed-off-by: Steve French
04 Oct, 2007
1 commit
-
Signed-off-by: Shirish Pargaonkar
Signed-off-by: Steve French
28 Sep, 2007
1 commit
-
We were allocating request buffers twice in the statfs
path when mounted to very old (Windows 9x) servers.Signed-off-by: Steve French
26 Sep, 2007
1 commit
-
Signed-off-by: Steve French
25 Sep, 2007
1 commit
-
Add code to be able to dump CIFS ACL information
when Query Posix ACL with cifsacl mount parm enabled.Signed-off-by: Shirish Pargoankar
Signed-off-by: Steve French
20 Sep, 2007
1 commit
-
Signed-off-by: Steve French
31 Aug, 2007
2 commits
-
Signed-off-by: Steve French
-
Signed-off-by: Andrew Haupt
Signed-off-by: Steve French
19 Jul, 2007
1 commit
-
Previously the only way to do this was to umount all mounts to that server,
turn off a proc setting (/proc/fs/cifs/LinuxExtensionsEnabled).Fixes Samba bugzilla bug number: 4582 (and also 2008)
Signed-off-by: Steve French
18 Jul, 2007
1 commit
-
Signed-off-by: Steve French
15 Jul, 2007
1 commit
-
In the cleanup phase of the dbench test, we were noticing sharing
violation followed by failed directory removals when dbench
did not close the test files before the cleanup phase started.
Using the new POSIX unlink, which Samba has supported for a few
months, avoids this.Signed-off-by: Steve French
13 Jul, 2007
1 commit
-
This should be the last big batch of whitespace/formatting fixes.
checkpatch warnings for the cifs directory are down about 90% and
many of the remaining ones are harder to remove or make the code
harder to read.Signed-off-by: Steve French
08 Jul, 2007
1 commit
-
Signed-off-by: Steve French
07 Jul, 2007
1 commit
-
Currently, if mount with a signing-enabled sec= option (e.g.
sec=ntlmi), the kernel does a warning printk if the server doesn't
support signing, and then proceeds without signatures.This is probably OK for people that think to look at the ring buffer,
but seems wrong to me. If someone explicitly requests signing, we
should error out if that request can't be satisfied. They can then
reattempt the mount without signing if that's ok.Signed-off-by: Jeff Layton
Signed-off-by: Steve French
29 Jun, 2007
1 commit
-
We were checking the wrong (old) global variable to determine
whether to override server and force signing on the SMB
connection.Acked-by: Dave Kleikamp
Signed-off-by: Steve French
06 Jun, 2007
1 commit
-
A related signature issue that I came across.
There's a bug in win2k that when NT error codes are not negotiated, the
server doesn't response that signatures are mandatory. Since there's
(currently) no way turn on signatures in such case, I had to force NT
error codes, so that this bug will not occurSigned-off-by: Yehuda Sadeh Weinraub
Signed-off-by: Steve French
25 Apr, 2007
1 commit
-
Fix incorrect parsing of return data
Signed-off-by: Steve French
24 Apr, 2007
1 commit
-
Signed-off-by: Steve French
01 Mar, 2007
1 commit
-
In fixing a bug Samba 3.0.26pre allowed some clients (including Linux cifs
client) to change file size to zero in SET_FILE_UNIX_BASIC (which Linux cifs
client uses for chmod).The server has been "fixed" now but that also fixes the client to net send
file size zero on chmod.Fixes Samba bugzilla bug # 4418.
Fixed with help from Jeremy Allison
Signed-off-by: Jeremy Allison
Signed-off-by: Steve French
18 Feb, 2007
1 commit
-
The C99 specification states in section 6.11.5:
The placement of a storage-class specifier other than at the
beginning of the declaration specifiers in a declaration is an
obsolescent feature.Signed-off-by: Tobias Klauser
Signed-off-by: Adrian Bunk
14 Feb, 2007
1 commit
-
After temporary server or network failure and reconneciton, we were not
resending the unix capabilities via SetFSInfo - which confused Samba posix
byte range locking code.Discovered by jra
Signed-off-by: Steve French
14 Dec, 2006
1 commit
-
Run this:
#!/bin/sh
for f in $(grep -Erl "\([^\)]*\) *k[cmz]alloc" *) ; do
echo "De-casting $f..."
perl -pi -e "s/ ?= ?\([^\)]*\) *(k[cmz]alloc) *\(/ = \1\(/" $f
doneAnd then go through and reinstate those cases where code is casting pointers
to non-pointers.And then drop a few hunks which conflicted with outstanding work.
Cc: Russell King , Ian Molton
Cc: Mikael Starvik
Cc: Yoshinori Sato
Cc: Roman Zippel
Cc: Geert Uytterhoeven
Cc: Ralf Baechle
Cc: Paul Mackerras
Cc: Kyle McMartin
Cc: Benjamin Herrenschmidt
Cc: Martin Schwidefsky
Cc: "David S. Miller"
Cc: Jeff Dike
Cc: Greg KH
Cc: Jens Axboe
Cc: Paul Fulghum
Cc: Alan Cox
Cc: Karsten Keil
Cc: Mauro Carvalho Chehab
Cc: Jeff Garzik
Cc: James Bottomley
Cc: Ian Kent
Cc: Steven French
Cc: David Woodhouse
Cc: Neil Brown
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
16 Oct, 2006
1 commit
-
* missing cpu_to_le64() for ChangeTime (introduced by
[CIFS] Legacy time handling for Win9x and OS/2 part 1)
* missing le16_to_cpu() for DialectIndex (introduced by
[CIFS] Do not send newer QFSInfo to legacy servers which can not support it)Signed-off-by: Al Viro
Signed-off-by: Linus Torvalds
13 Oct, 2006
1 commit
-
Partly suggested by Igor Mammedov
Signed-off-by: Steve French
12 Oct, 2006
1 commit
-
Signed-off-by: Steve French
02 Oct, 2006
1 commit
-
Signed-off-by: Steve French