16 Mar, 2013

2 commits

  • When warping the clock (from a local time RTC), use
    timekeeping_inject_offset() to atomically add the offset.

    This avoids any minor time error caused by the delay between
    reading the time, and then setting the adjusted time.

    Signed-off-by: John Stultz

    John Stultz
     
  • If the Hardware Clock kept in local time,kernel will adjust the time
    to be UTC time.But if Hardware Clock kept in UTC time,system will make
    a dummy settimeofday call first (sys_tz.tz_minuteswest = 0) to make sure
    the time is not shifted,so at this point I think maybe it is not necessary
    to set the kernel time once the sys_tz.tz_minuteswest is zero.

    Signed-off-by: Dong Zhu
    [jstultz: Updated to merge with conflicting changes ]
    Signed-off-by: John Stultz

    Dong Zhu
     

11 Mar, 2013

17 commits

  • Pull perf fixes from Ingo Molnar:
    "Misc minor fixes mostly related to tracing"

    * 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
    s390: Fix a header dependencies related build error
    tracing: update documentation of snapshot utility
    tracing: Do not return EINVAL in snapshot when not allocated
    tracing: Add help of snapshot feature when snapshot is empty
    ftrace: Update the kconfig for DYNAMIC_FTRACE

    Linus Torvalds
     
  • Pull networking fixes from David Miller:

    1) Missing cancel of work items in mac80211 MLME, from Ben Greear.

    2) Fix DMA mapping handling in iwlwifi by using coherent DMA for
    command headers, from Johannes Berg.

    3) Decrease the amount of pressure on the page allocator by using order
    1 pages less in iwlwifi, from Emmanuel Grumbach.

    4) Fix mesh PS broadcast OOPS in mac80211, from Marco Porsch.

    5) Don't forget to recalculate idle state in mac80211 monitor
    interface, from Felix Fietkau.

    6) Fix varargs in netfilter conntrack handler, from Joe Perches.

    7) Need to reset entire chip when command queue fills up in iwlwifi,
    from Emmanuel Grumbach.

    8) The TX antenna value must be valid when calibrations are performed
    in iwlwifi, fix from Dor Shaish.

    9) Don't generate netfilter audit log entries when audit is disabled,
    from Gao Feng.

    10) Deal with DMA unit hang on e1000e during power state transitions,
    from Bruce Allan.

    11) Remove BUILD_BUG_ON check from igb driver, from Alexander Duyck.

    12) Fix lockdep warning on i2c handling of igb driver, from Carolyn
    Wyborny.

    13) Fix several TTY handling issues in IRDA ircomm tty driver, from
    Peter Hurley.

    14) Several QFQ packet scheduler fixes from Paolo Valente.

    15) When VXLAN encapsulates on transmit, we have to reset the netfilter
    state. From Zang MingJie.

    16) Fix jiffie check in net_rx_action() so that we really cap the
    processing at 2HZ. From Eric Dumazet.

    17) Fix erroneous trigger of IP option space exhaustion, when routers
    are pre-specified and we are looking to see if we can insert a
    timestamp, we will have the space. From David Ward.

    18) Fix various issues in benet driver wrt waiting for firmware to
    finish POST after resets or errors. From Gavin Shan and Sathya
    Perla.

    19) Fix TX locking in SFC driver, from Ben Hutchings.

    20) Like the VXLAN fix above, when we encap in a TUN device we have to
    reset the netfilter state. This should fix several strange crashes
    reported by Dave Jones and others. From Eric Dumazet.

    21) Don't forget to clean up MAC address resources when shutting down a
    port in mlx4 driver, from Yan Burman.

    22) Fix divide by zero in vmxnet3 driver, from Bhavesh Davda.

    23) Fix device statistic regression in tg3 when the driver is using
    phylib, from Nithin Sujir.

    24) Fix info leak in several netlink handlers, from Mathias Krause.

    * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net: (79 commits)
    6lowpan: Fix endianness issue in is_addr_link_local().
    rrunner.c: fix possible memory leak in rr_init_one()
    dcbnl: fix various netlink info leaks
    rtnl: fix info leak on RTM_GETLINK request for VF devices
    bridge: fix mdb info leaks
    tg3: Update link_up flag for phylib devices
    ipv6: stop multicast forwarding to process interface scoped addresses
    bridging: fix rx_handlers return code
    netlabel: fix build problems when CONFIG_IPV6=n
    drivers/isdn: checkng length to be sure not memory overflow
    net/rds: zero last byte for strncpy
    bnx2x: Fix SFP+ misconfiguration in iSCSI boot scenario
    bnx2x: Fix intermittent long KR2 link up time
    macvlan: Set IFF_UNICAST_FLT flag to prevent unnecessary promisc mode.
    team: unsyc the devices addresses when port is removed
    bridge: add missing vid to br_mdb_get()
    Fix: sparse warning in inet_csk_prepare_forced_close
    afkey: fix a typo
    MAINTAINERS: Update qlcnic maintainers list
    netlabel: correctly list all the static label mappings
    ...

    Linus Torvalds
     
  • Pull UML fixes from Richard Weinberger:
    "This update brings various fixes.
    Nothing special...

    In my local queue I have some more fixes which will be sent later to
    you. 3.9 uncovered strange UML issues. :("

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml:
    um: Use tty_port in SIGWINCH handler
    um: Use tty_port_operations->destruct
    um: fix build failure due to mess-up of sig_info protorype
    um: add missing declaration of 'getrlimit()' and friends
    net : enable tx time stamping in the vde driver.
    hostfs: fix a not needed double check

    Linus Torvalds
     
  • Pull input updates from Dmitry Torokhov:
    "Except for the largish change to the ALPS driver adding "Dolphin V1"
    support and Wacom getting a new signature of yet another device, the
    rest are straightforward driver fixes."

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input:
    Input: mms114 - Fix regulator enable and disable paths
    Input: ads7864 - check return value of regulator enable
    Input: tc3589x-keypad - fix keymap size
    Input: wacom - add support for 0x10d
    Input: ALPS - update documentation for recent touchpad driver mods
    Input: ALPS - add "Dolphin V1" touchpad support
    Input: ALPS - remove unused argument to alps_enter_command_mode()
    Input: cypress_ps2 - fix trackpadi found in Dell XPS12

    Linus Torvalds
     
  • Commit 877c685607925238e302cd3aa38788dca6c1b226
    ("perf: Remove include of cgroup.h from perf_event.h") caused
    this build failure if PERF_EVENTS is enabled:

    In file included from arch/s390/include/asm/perf_event.h:9:0,
    from include/linux/perf_event.h:24,
    from kernel/events/ring_buffer.c:12:
    arch/s390/include/asm/cpu_mf.h: In function 'qctri':
    arch/s390/include/asm/cpu_mf.h:61:12: error: 'EINVAL' undeclared (first use in this function)

    cpu_mf.h had an implicit errno.h dependency, which was added
    indirectly via cgroups.h but not anymore. Add it explicitly.

    Reported-by: Fengguang Wu
    Tested-by: Fengguang Wu
    Signed-off-by: Li Zefan
    Cc: Martin Schwidefsky
    Cc: Heiko Carstens
    Link: http://lkml.kernel.org/r/51385F79.7000106@huawei.com
    Signed-off-by: Ingo Molnar

    Li Zefan
     
  • The tty below tty_port might get destroyed by the tty layer
    while we hold a reference to it.
    So we have to carry tty_port around...

    Signed-off-by: Richard Weinberger

    Richard Weinberger
     
  • As we setup the SIGWINCH handler in tty_port_operations->activate
    it makes sense to tear down it in ->destruct.

    Signed-off-by: Richard Weinberger

    Richard Weinberger
     
  • arch/um/os-Linux/signal.c:18:8: error: conflicting types for 'sig_info'
    In file included from /home/slyfox/linux-2.6/arch/um/os-Linux/signal.c:12:0:
    arch/um/include/shared/as-layout.h:64:15: note: previous declaration of 'sig_info' was here

    Signed-off-by: Sergei Trofimovich
    CC: Jeff Dike
    CC: Richard Weinberger
    CC: "Martin Pärtel"
    CC: Al Viro
    CC: user-mode-linux-devel@lists.sourceforge.net
    CC: user-mode-linux-user@lists.sourceforge.net
    CC: linux-kernel@vger.kernel.org
    Signed-off-by: Richard Weinberger

    Sergei Trofimovich
     
  • arch/um/os-Linux/start_up.c: In function 'check_coredump_limit':
    arch/um/os-Linux/start_up.c:338:16: error: storage size of 'lim' isn't known
    arch/um/os-Linux/start_up.c:339:2: error: implicit declaration of function 'getrlimit' [-Werror=implicit-function-declaration]

    Signed-off-by: Sergei Trofimovich
    CC: Jeff Dike
    CC: Richard Weinberger
    CC: Al Viro
    CC: user-mode-linux-devel@lists.sourceforge.net
    CC: user-mode-linux-user@lists.sourceforge.net
    CC: linux-kernel@vger.kernel.org
    Signed-off-by: Richard Weinberger

    Sergei Trofimovich
     
  • This new version moves the skb_tx_timestamp in the main uml
    driver. This should avoid the need to call this function in each
    transport (vde, slirp, tuntap, ...). It also add support for ethtool
    get_ts_info.

    Signed-off-by: Paul Chavent
    Acked-by: Richard Cochran
    Signed-off-by: Richard Weinberger

    Paul Chavent
     
  • With the commit 3be2be0a32c18b0fd6d623cda63174a332ca0de1 we removed vmtruncate,
    but actaully there is no need to call inode_newsize_ok() because the checks are
    already done in inode_change_ok() at the begin of the function.

    Signed-off-by: Marco Stornelli
    Signed-off-by: Richard Weinberger

    Marco Stornelli
     
  • When it uses regulators the mms114 driver checks to see if it managed to
    acquire regulators and ignores errors. This is not the intended usage and
    not great style in general.

    Since the driver already refuses to probe if it fails to allocate the
    regulators simply make the enable and disable calls unconditional and
    add appropriate error handling, including adding cleanup of the
    regulators if setup_reg() fails.

    Signed-off-by: Mark Brown
    Acked-by: Joonyoung Shim
    Signed-off-by: Dmitry Torokhov

    Mark Brown
     
  • At least print a warning if we can't power the device up.

    Signed-off-by: Mark Brown
    Signed-off-by: Dmitry Torokhov

    Mark Brown
     
  • The keymap size used by tc3589x is too low, leading to the driver
    overwriting other people's memory. Fix this by making the driver
    use the automatically allocated keymap provided by
    matrix_keypad_build_keymap() instead of allocating one on its own.

    Signed-off-by: Rabin Vincent
    Signed-off-by: Dmitry Torokhov

    Rabin Vincent
     
  • Linus Torvalds
     
  • Signed-off-by: YOSHIFUJI Hideaki
    Signed-off-by: David S. Miller

    YOSHIFUJI Hideaki / 吉藤英明
     
  • In the event that register_netdev() failed, the rrpriv->evt_ring
    allocation would have not been freed.

    Signed-off-by: David Oostdyk
    Signed-off-by: David S. Miller

    David Oostdyk
     

10 Mar, 2013

6 commits

  • The dcb netlink interface leaks stack memory in various places:
    * perm_addr[] buffer is only filled at max with 12 of the 32 bytes but
    copied completely,
    * no in-kernel driver fills all fields of an IEEE 802.1Qaz subcommand,
    so we're leaking up to 58 bytes for ieee_ets structs, up to 136 bytes
    for ieee_pfc structs, etc.,
    * the same is true for CEE -- no in-kernel driver fills the whole
    struct,

    Prevent all of the above stack info leaks by properly initializing the
    buffers/structures involved.

    Signed-off-by: Mathias Krause
    Signed-off-by: David S. Miller

    Mathias Krause
     
  • Initialize the mac address buffer with 0 as the driver specific function
    will probably not fill the whole buffer. In fact, all in-kernel drivers
    fill only ETH_ALEN of the MAX_ADDR_LEN bytes, i.e. 6 of the 32 possible
    bytes. Therefore we currently leak 26 bytes of stack memory to userland
    via the netlink interface.

    Signed-off-by: Mathias Krause
    Signed-off-by: David S. Miller

    Mathias Krause
     
  • The bridging code discloses heap and stack bytes via the RTM_GETMDB
    netlink interface and via the notify messages send to group RTNLGRP_MDB
    afer a successful add/del.

    Fix both cases by initializing all unset members/padding bytes with
    memset(0).

    Cc: Stephen Hemminger
    Signed-off-by: Mathias Krause
    Signed-off-by: David S. Miller

    Mathias Krause
     
  • Pull namespace bugfixes from Eric Biederman:
    "This is three simple fixes against 3.9-rc1. I have tested each of
    these fixes and verified they work correctly.

    The userns oops in key_change_session_keyring and the BUG_ON triggered
    by proc_ns_follow_link were found by Dave Jones.

    I am including the enhancement for mount to only trigger requests of
    filesystem modules here instead of delaying this for the 3.10 merge
    window because it is both trivial and the kind of change that tends to
    bit-rot if left untouched for two months."

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace:
    proc: Use nd_jump_link in proc_ns_follow_link
    fs: Limit sys_mount to only request filesystem modules (Part 2).
    fs: Limit sys_mount to only request filesystem modules.
    userns: Stop oopsing in key_change_session_keyring

    Linus Torvalds
     
  • It is a Wacom device found in Fujitsu Lifebook T902.

    Signed-off-by: Stephan Frank
    Acked-by: Ping Cheng
    Signed-off-by: Dmitry Torokhov

    Stephan Frank
     
  • There is a more complete atmel patch-series out by Nick Dyer that fixes
    this and other things, but in the meantime this is the minimal thing to
    get the touchscreen going on (at least my) Pixel Chromebook.

    Not that I want my dirty fingers near that beautiful screen, but it
    seems that a non-initialized touchscreen will also end up being a
    constant wakeup source, so you have to disable it to go to sleep. And
    it's easier to just fix the initialization sequence.

    Signed-off-by: Linus Torvalds

    Linus Torvalds
     

09 Mar, 2013

15 commits

  • Update proc_ns_follow_link to use nd_jump_link instead of just
    manually updating nd.path.dentry.

    This fixes the BUG_ON(nd->inode != parent->d_inode) reported by Dave
    Jones and reproduced trivially with mkdir /proc/self/ns/uts/a.

    Sigh it looks like the VFS change to require use of nd_jump_link
    happend while proc_ns_follow_link was baking and since the common case
    of proc_ns_follow_link continued to work without problems the need for
    making this change was overlooked.

    Cc: stable@vger.kernel.org
    Signed-off-by: "Eric W. Biederman"

    Eric W. Biederman
     
  • Pull btrfs fixes from Chris Mason:
    "These are scattered fixes and one performance improvement. The
    biggest functional change is in how we throttle metadata changes. The
    new code bumps our average file creation rate up by ~13% in fs_mark,
    and lowers CPU usage.

    Stefan bisected out a regression in our allocation code that made
    balance loop on extents larger than 256MB."

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs:
    Btrfs: improve the delayed inode throttling
    Btrfs: fix a mismerge in btrfs_balance()
    Btrfs: enforce min_bytes parameter during extent allocation
    Btrfs: allow running defrag in parallel to administrative tasks
    Btrfs: avoid deadlock on transaction waiting list
    Btrfs: do not BUG_ON on aborted situation
    Btrfs: do not BUG_ON in prepare_to_reloc
    Btrfs: free all recorded tree blocks on error
    Btrfs: build up error handling for merge_reloc_roots
    Btrfs: check for NULL pointer in updating reloc roots
    Btrfs: fix unclosed transaction handler when the async transaction commitment fails
    Btrfs: fix wrong handle at error path of create_snapshot() when the commit fails
    Btrfs: use set_nlink if our i_nlink is 0

    Linus Torvalds
     
  • Add basic platform data to get the current upstream driver working
    with the 224s touchpad and 1664s touchscreen.
    We will be using NULL config so we will use the settings from the
    devices' NVRAMs.

    Signed-off-by: Benson Leung
    Tested-by: Olof Johansson
    Signed-off-by: Linus Torvalds

    Benson Leung
     
  • This same driver can be used by atmel based touchscreens and touchpads
    (buttonpads). Platform data may specify a device is a touchpad
    using the is_tp flag.

    This will cause the driver to perform some touchpad specific
    initializations, such as:
    * register input device name "Atmel maXTouch Touchpad" instead of
    Touchscreen.
    * register BTN_LEFT & BTN_TOOL_* event types.
    * register axis resolution (as a fixed constant, for now)
    * register BUTTONPAD property
    * process GPIO buttons using reportid T19

    Input event GPIO mapping is done by the platform data key_map array.

    key_map[x] should contain the KEY or BTN code to send when processing
    GPIOx from T19. To specify a GPIO as not an input source, populate
    with KEY_RESERVED, or 0.

    Signed-off-by: Daniel Kurtz
    Signed-off-by: Benson Leung
    Signed-off-by: Nick Dyer
    Tested-by: Olof Johansson
    Signed-off-by: Linus Torvalds

    Daniel Kurtz
     
  • Pull CIFS fixes from Steve French:
    "A small set of cifs fixes which includes one for a recent regression
    in the write path (pointed out by Anton), some fixes for rename
    problems and as promised for 3.9 removing the obsolete sockopt mount
    option (and the accompanying deprecation warning)."

    * 'for-next' of git://git.samba.org/sfrench/cifs-2.6:
    CIFS: Fix missing of oplock_read value in smb30_values structure
    cifs: don't try to unlock pagecache page after releasing it
    cifs: remove the sockopt= mount option
    cifs: Check server capability before attempting silly rename
    cifs: Fix bug when checking error condition in cifs_rename_pending_delete()

    Linus Torvalds
     
  • Merge misc fixes from Andrew Morton.

    * emailed patches from Andrew Morton :
    alpha: boot: fix build breakage introduced by system.h disintegration
    memcg: initialize kmem-cache destroying work earlier
    Randy has moved
    ksm: fix m68k build: only NUMA needs pfn_to_nid
    dmi_scan: fix missing check for _DMI_ signature in smbios_present()
    Revert parts of "hlist: drop the node parameter from iterators"
    idr: remove WARN_ON_ONCE() on negative IDs
    mm/mempolicy.c: fix sp_node_init() argument ordering
    mm/mempolicy.c: fix wrong sp_node insertion
    ipc: don't allocate a copy larger than max
    ipc: fix potential oops when src msg > 4k w/ MSG_COPY

    Linus Torvalds
     
  • Commit ec2212088c42 ("Disintegrate asm/system.h for Alpha") removed the
    system.h include from boot/head.S, which puts the PAL_* asm constants
    out of scope.

    Include so we can get building again.

    Signed-off-by: Will Deacon
    Cc: David Rusling
    Cc: David Howells
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Will Deacon
     
  • Fix a warning from lockdep caused by calling cancel_work_sync() for
    uninitialized struct work. This path has been triggered by destructon
    kmem-cache hierarchy via destroying its root kmem-cache.

    cache ffff88003c072d80
    obj ffff88003b410000 cache ffff88003c072d80
    obj ffff88003b924000 cache ffff88003c20bd40
    INFO: trying to register non-static key.
    the code is fine but needs lockdep annotation.
    turning off the locking correctness validator.
    Pid: 2825, comm: insmod Tainted: G O 3.9.0-rc1-next-20130307+ #611
    Call Trace:
    __lock_acquire+0x16a2/0x1cb0
    lock_acquire+0x8a/0x120
    flush_work+0x38/0x2a0
    __cancel_work_timer+0x89/0xf0
    cancel_work_sync+0xb/0x10
    kmem_cache_destroy_memcg_children+0x81/0xb0
    kmem_cache_destroy+0xf/0xe0
    init_module+0xcb/0x1000 [kmem_test]
    do_one_initcall+0x11a/0x170
    load_module+0x19b0/0x2320
    SyS_init_module+0xc6/0xf0
    system_call_fastpath+0x16/0x1b

    Example module to demonstrate:

    #include
    #include
    #include
    #include

    int __init mod_init(void)
    {
    int size = 256;
    struct kmem_cache *cache;
    void *obj;
    struct page *page;

    cache = kmem_cache_create("kmem_cache_test", size, size, 0, NULL);
    if (!cache)
    return -ENOMEM;

    printk("cache %p\n", cache);

    obj = kmem_cache_alloc(cache, GFP_KERNEL);
    if (obj) {
    page = virt_to_head_page(obj);
    printk("obj %p cache %p\n", obj, page->slab_cache);
    kmem_cache_free(cache, obj);
    }

    flush_scheduled_work();

    obj = kmem_cache_alloc(cache, GFP_KERNEL);
    if (obj) {
    page = virt_to_head_page(obj);
    printk("obj %p cache %p\n", obj, page->slab_cache);
    kmem_cache_free(cache, obj);
    }

    kmem_cache_destroy(cache);

    return -EBUSY;
    }

    module_init(mod_init);
    MODULE_LICENSE("GPL");

    Signed-off-by: Konstantin Khlebnikov
    Cc: Glauber Costa
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Konstantin Khlebnikov
     
  • Update email address and CREDITS info. xenotime.net is defunct.

    Signed-off-by: Randy Dunlap
    Cc: Harry Wei
    Cc: Keiichi KII
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     
  • A CONFIG_DISCONTIGMEM=y m68k config gave

    mm/ksm.c: In function `get_kpfn_nid':
    mm/ksm.c:492: error: implicit declaration of function `pfn_to_nid'

    linux/mmzone.h declares it for CONFIG_SPARSEMEM and CONFIG_FLATMEM, but
    expects the arch's asm/mmzone.h to declare it for CONFIG_DISCONTIGMEM
    (see arch/mips/include/asm/mmzone.h for example).

    Or perhaps it is only expected when CONFIG_NUMA=y: too much of a maze,
    and m68k got away without it so far, so fix the build in mm/ksm.c.

    Signed-off-by: Hugh Dickins
    Reported-by: Geert Uytterhoeven
    Cc: Petr Holasek
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Hugh Dickins
     
  • Commit 9f9c9cbb6057 ("drivers/firmware/dmi_scan.c: fetch dmi version
    from SMBIOS if it exists") hoisted the check for "_DMI_" into
    dmi_scan_machine(), which means that we don't bother to check for
    "_DMI_" at offset 16 in an SMBIOS entry. smbios_present() may also call
    dmi_present() for an address where we found "_SM_", if it failed further
    validation.

    Check for "_DMI_" in smbios_present() before calling dmi_present().

    [akpm@linux-foundation.org: fix build]
    Signed-off-by: Ben Hutchings
    Reported-by: Tim McGrath
    Tested-by: Tim Mcgrath
    Cc: Zhenzhong Duan
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ben Hutchings
     
  • Commit b67bfe0d42ca ("hlist: drop the node parameter from iterators")
    did a lot of nice changes but also contains two small hunks that seem to
    have slipped in accidentally and have no apparent connection to the
    intent of the patch.

    This reverts the two extraneous changes.

    Signed-off-by: Arnd Bergmann
    Cc: Peter Senna Tschudin
    Cc: Paul E. McKenney
    Cc: Sasha Levin
    Cc: Thomas Gleixner
    Cc: Rusty Russell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arnd Bergmann
     
  • idr_find(), idr_remove() and idr_replace() used to silently ignore the
    sign bit and perform lookup with the rest of the bits. The weird behavior
    has been changed such that negative IDs are treated as invalid. As the
    behavior change was subtle, WARN_ON_ONCE() was added in the hope of
    determining who's calling idr functions with negative IDs so that they can
    be examined for problems.

    Up until now, all two reported cases are ID number coming directly from
    userland and getting fed into idr_find() and the warnings seem to cause
    more problems than being helpful. Drop the WARN_ON_ONCE()s.

    Signed-off-by: Tejun Heo
    Reported-by:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tejun Heo
     
  • Currently, n_new is wrongly initialized. start and end parameter are
    inverted. Let's fix it.

    Signed-off-by: KOSAKI Motohiro
    Cc: Hillf Danton
    Cc: Sasha Levin
    Cc: Hugh Dickins
    Cc: Mel Gorman
    Cc: Dave Jones
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    KOSAKI Motohiro
     
  • n->end is accessed in sp_insert(). Thus it should be update
    before calling sp_insert(). This mistake may make kernel panic.

    Signed-off-by: Hillf Danton
    Signed-off-by: KOSAKI Motohiro
    Cc: Sasha Levin
    Cc: Hugh Dickins
    Cc: Mel Gorman
    Cc: Dave Jones
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Hillf Danton