Eric Lee / smarc-fsl-linux-kernel

06 Jan, 2012

1 commit

04 Nov, 2011

3 commits

  • da8ebe4e0   hwmon: (ibmaem) Avoid repeated memory allocations ... Browse Code »

    Preallocate a buffer for the response to sensor reads, and reuse it
    for each read instead of allocating a new one each time. This should
    be faster and should also avoid memory fragmentation.

    Signed-off-by: Jean Delvare
    Acked-by: Darrick J. Wong
    Acked-by: Guenter Roeck

    Jean Delvare
     
  • 9d84c9e8b   hwmon: (ibmaem) Make instance initializations independent ... Browse Code »

    There is no good reason that I can see why the failure to initialize
    one instance should prevent other instances from being initialized.

    Signed-off-by: Jean Delvare
    Acked-by: Darrick J. Wong
    Acked-by: Guenter Roeck

    Jean Delvare
     
  • 547a1c99d   hwmon: (ibmaem) Fix error paths ... Browse Code »

    I am under the impression that error paths in functions
    aem_init_aem1_inst() and aem_init_aem2_inst() are incorrect. In
    several cases, the function returns 0 on error, which I suspect is
    not intended. Fix this by properly tracking error codes.

    Signed-off-by: Jean Delvare
    Acked-by: Darrick J. Wong
    Acked-by: Guenter Roeck

    Jean Delvare
     

01 Nov, 2011

1 commit

12 Aug, 2011

1 commit

  • 66a89b216   hwmon: (ibmaem) add missing kfree ... Browse Code »
    1

    rs_resp is dynamically allocated in aem_read_sensor(), so it should be freed
    before exiting in every case. This collects the kfree and the return at
    the end of the function.

    Signed-off-by: Julia Lawall
    Signed-off-by: Guenter Roeck
    Cc: stable@kernel.org # 2.6.27+

    Julia Lawall
     

18 Jun, 2011

1 commit

26 May, 2011

1 commit

09 Jan, 2011

1 commit

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

16 Jun, 2009

1 commit

13 Nov, 2008

1 commit

  • fe2d5ffc7   Fix platform drivers that crash on suspend/resume ... Browse Code »

    It turns out that if one registers a struct platform_device, the
    platform device code expects that platform_device.device->driver points
    to a struct driver inside a struct platform_driver.

    This is not the case with the ipmi-si, ipmi-msghandler and ibmaem
    drivers, which causes the suspend/resume hook functions to jump off into
    nowhere, causing a crash. Make this assumption hold true for these
    three drivers.

    Signed-off-by: Darrick J. Wong
    Acked-by: Corey Minyard
    Cc: Jean Delvare
    Cc: Kay Sievers
    Cc: Greg KH
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Darrick J. Wong
     

17 Oct, 2008

1 commit

15 Aug, 2008

3 commits

  • bb15e7f28   ibmaem: don't query the entire sensor repository when reading energy meter ... Browse Code »

    Currently, all sensors are read when the energy meter is queried via
    sysfs. This introduces a considerable amount of delay and variation in
    the sysfs reading, which is not desirable when trying to profile energy
    use. Therefore, read only the energy meters when a sysfs query comes in
    for them, and don't cache the results so that we always get the latest
    reading.

    Signed-off-by: Darrick J. Wong
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Darrick J. Wong
     
  • 9c5413eac   ibmaem: prevent infinite probing loop on x3650 M2 systems ... Browse Code »

    On older machines, probing for a nonexistent AEM interface returned an
    IPMI error; when we saw this, we'd stop probing. On the x3650 M2 and
    (presumably) later, we are returned a value indicating success and a
    buffer full of garbage or zeroes. This causes the probe function to run
    in an infinite loop. To fix this, we add one last check--if the
    interface number we're looking for is higher than the number of
    interfaces that AEM claims to have, stop probing.

    Signed-off-by: Darrick J. Wong
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Darrick J. Wong
     
  • eb93b7df7   ibmaem: update the documentation to reflect the current name ... Browse Code »

    Minor documentation update to reflect the current full name of the power
    management hardware interface and reflows the text a bit.

    Signed-off-by: Darrick J. Wong
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Darrick J. Wong
     

04 Jun, 2008

1 commit

25 May, 2008

1 commit